)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"42bf48ed285687773a19128f22607f49875b9d8b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"For the same storage backend, it is compatible with different backup"},{"line_number":10,"context_line":"driver matching methods. For example:"},{"line_number":11,"context_line":"\u0027cinder.backup.drivers.ceph.CephBackupDriver\u0027 and"},{"line_number":12,"context_line":"\u0027cinder.backup.drivers.ceph\u0027 are the same storage backend, and should be"},{"line_number":13,"context_line":"allowed to perform the specified operation regardless of the ``service``"},{"line_number":14,"context_line":"value of the backup file in db."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_f78b2f13","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":28},"updated":"2018-11-02 12:31:27.000000000","message":"This form was deprecated and no longer supported.","commit_id":"5f79f98cc722695b1c2a18eba6735d9c7179ce06"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"0d44ecdd7f35a9602075f17e7c9be8a0cd99a613","unresolved":false,"context_lines":[{"line_number":9,"context_line":"For the same storage backend, it is compatible with different backup"},{"line_number":10,"context_line":"driver matching methods. For example:"},{"line_number":11,"context_line":"\u0027cinder.backup.drivers.ceph.CephBackupDriver\u0027 and"},{"line_number":12,"context_line":"\u0027cinder.backup.drivers.ceph\u0027 are the same storage backend, and should be"},{"line_number":13,"context_line":"allowed to perform the specified operation regardless of the ``service``"},{"line_number":14,"context_line":"value of the backup file in db."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_d1b95cc5","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":28},"in_reply_to":"3f79a3b5_f78b2f13","updated":"2018-11-02 15:20:32.000000000","message":"But this config all exist in sqlarmy/api.py, and it\u0027s also available in cinder.conf of backup_driver.\nAnd I want to know why deprecated this (Forgive me not seeing the change of backup)?","commit_id":"5f79f98cc722695b1c2a18eba6735d9c7179ce06"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"19974340158aa5ef07d758510f6770da986b5611","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The backup_driver name is configured uniformly from the Stein version."},{"line_number":10,"context_line":"For example, support for"},{"line_number":11,"context_line":"\u0027cinder.backup.drivers.service.ServiceBackupDriver\u0027 does not support"},{"line_number":12,"context_line":"\u0027cinder.backup.drivers.service\u0027"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ie97f7cc5f2d8b1059edae1400f615084bb6d48cf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_1584635c","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":31},"updated":"2018-11-06 12:55:21.000000000","message":"You could get more real example from [1]\n[1] https://github.com/openstack/cinder/blob/4afc2eb/cinder/db/sqlalchemy/api.py#L585","commit_id":"0618534e0cbcbab6823c5932dd92d8d662c3f639"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"975e6dd0d41d52c4ceb9d8685c7f58004eb50253","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The backup_driver name is configured uniformly from the Stein version."},{"line_number":10,"context_line":"For example, support for"},{"line_number":11,"context_line":"\u0027cinder.backup.drivers.service.ServiceBackupDriver\u0027 does not support"},{"line_number":12,"context_line":"\u0027cinder.backup.drivers.service\u0027"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ie97f7cc5f2d8b1059edae1400f615084bb6d48cf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_6cdb86ea","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":31},"in_reply_to":"3f79a3b5_1584635c","updated":"2018-11-07 00:30:39.000000000","message":"Yeah, I know this, \u0027service\u0027 is a generalize, I will improve this description.","commit_id":"0618534e0cbcbab6823c5932dd92d8d662c3f639"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"79fb922495426028dd4a6a0189b318e5e509dc6e","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1]"},{"line_number":19,"context_line":"https://github.com/openstack/cinder/blob/4afc2eb/cinder/db/sqlalchemy/api.py#L585"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ie97f7cc5f2d8b1059edae1400f615084bb6d48cf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_1450c5d0","line":20,"updated":"2018-11-07 17:14:20.000000000","message":"Is this patch related to https://bugs.launchpad.net/cinder/+bug//1801316 ?","commit_id":"f5f12ef0b27f2f66fbaab3dcfafebb8490297b73"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3f6f159d1e4a7f8e6fc399e71a4921aae678bef0","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1]"},{"line_number":19,"context_line":"https://github.com/openstack/cinder/blob/4afc2eb/cinder/db/sqlalchemy/api.py#L585"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ie97f7cc5f2d8b1059edae1400f615084bb6d48cf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_ef944f44","line":20,"in_reply_to":"3f79a3b5_1450c5d0","updated":"2018-11-08 01:27:30.000000000","message":"No, this patch is fix the TODO in master, that bug exists in rocky and previous versions, so I have been removed the flag of bug 1801316.","commit_id":"f5f12ef0b27f2f66fbaab3dcfafebb8490297b73"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"76f10efa01fed1ef9561a1eeeba2574df18b44c5","unresolved":false,"context_lines":[{"line_number":16,"context_line":"be found in [1]."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1]"},{"line_number":19,"context_line":"https://github.com/openstack/cinder/blob/4afc2eb/cinder/db/sqlalchemy/api.py#L585"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ie97f7cc5f2d8b1059edae1400f615084bb6d48cf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f79a3b5_58d17255","line":19,"updated":"2018-11-08 21:25:43.000000000","message":"Cinder is not a github-based project -- please avoid using github for commit message documentation.","commit_id":"f95799097d4a9cf7744e4b185167d2acd2f9838a"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"b450365d9d44a46076410f9732ffc2e50c32de68","unresolved":false,"context_lines":[{"line_number":16,"context_line":"be found in [1]."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1]"},{"line_number":19,"context_line":"https://github.com/openstack/cinder/blob/4afc2eb/cinder/db/sqlalchemy/api.py#L585"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ie97f7cc5f2d8b1059edae1400f615084bb6d48cf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f79a3b5_e1268a22","line":19,"in_reply_to":"3f79a3b5_58d17255","updated":"2018-11-09 01:12:26.000000000","message":"Remove this in next patch.","commit_id":"f95799097d4a9cf7744e4b185167d2acd2f9838a"}],"cinder/backup/manager.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"4d22051f3428739445f65a7952faea42275f647f","unresolved":false,"context_lines":[{"line_number":502,"context_line":"        if not backup:"},{"line_number":503,"context_line":"            return True"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"        # The backup_driver name is configured uniformly from"},{"line_number":506,"context_line":"        # the Stein version."},{"line_number":507,"context_line":"        if self.driver_name \u003d\u003d backup:"},{"line_number":508,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_5a3c4a2c","line":505,"updated":"2018-11-06 12:36:47.000000000","message":"This comment is not needed.","commit_id":"d60b8778d86e35d9e1bfdc69b2a239a8ad626dec"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"975e6dd0d41d52c4ceb9d8685c7f58004eb50253","unresolved":false,"context_lines":[{"line_number":502,"context_line":"        if not backup:"},{"line_number":503,"context_line":"            return True"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"        # The backup_driver name is configured uniformly from"},{"line_number":506,"context_line":"        # the Stein version."},{"line_number":507,"context_line":"        if self.driver_name \u003d\u003d backup:"},{"line_number":508,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_8c6aa215","line":505,"in_reply_to":"3f79a3b5_55297b80","updated":"2018-11-07 00:30:39.000000000","message":"Done","commit_id":"d60b8778d86e35d9e1bfdc69b2a239a8ad626dec"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"19974340158aa5ef07d758510f6770da986b5611","unresolved":false,"context_lines":[{"line_number":502,"context_line":"        if not backup:"},{"line_number":503,"context_line":"            return True"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"        # The backup_driver name is configured uniformly from"},{"line_number":506,"context_line":"        # the Stein version."},{"line_number":507,"context_line":"        if self.driver_name \u003d\u003d backup:"},{"line_number":508,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_55297b80","line":505,"in_reply_to":"3f79a3b5_5a3c4a2c","updated":"2018-11-06 12:55:21.000000000","message":"+1, because we already do online migration in [1], let\u0027s user forget the module-style name.\n\n[1] https://github.com/openstack/cinder/blob/4afc2eb/cinder/db/sqlalchemy/api.py#L585","commit_id":"d60b8778d86e35d9e1bfdc69b2a239a8ad626dec"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"975e6dd0d41d52c4ceb9d8685c7f58004eb50253","unresolved":false,"context_lines":[{"line_number":502,"context_line":"        if not backup:"},{"line_number":503,"context_line":"            return True"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"        # The backup_driver name is configured uniformly from"},{"line_number":506,"context_line":"        # the Stein version."},{"line_number":507,"context_line":"        if self.driver_name \u003d\u003d backup:"},{"line_number":508,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_6c6dc62e","line":505,"in_reply_to":"3f79a3b5_5a3c4a2c","updated":"2018-11-07 00:30:39.000000000","message":"Done","commit_id":"d60b8778d86e35d9e1bfdc69b2a239a8ad626dec"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"76f10efa01fed1ef9561a1eeeba2574df18b44c5","unresolved":false,"context_lines":[{"line_number":502,"context_line":"        if not backup:"},{"line_number":503,"context_line":"            return True"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"        if self.driver_name \u003d\u003d backup:"},{"line_number":506,"context_line":"            return True"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"        # We support renaming of drivers, so check old names as well"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_d8d34262","line":505,"updated":"2018-11-08 21:25:43.000000000","message":"This appears that it could cause compatibility issues with consuming backups created a couple of releases ago.  The commit message doesn\u0027t spell out the behavior in this regard.  Why is this safe?","commit_id":"f95799097d4a9cf7744e4b185167d2acd2f9838a"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"b5d014678b2dc7305b08863b92cc1425da170338","unresolved":false,"context_lines":[{"line_number":502,"context_line":"        if not backup:"},{"line_number":503,"context_line":"            return True"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"        if self.driver_name \u003d\u003d backup:"},{"line_number":506,"context_line":"            return True"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"        # We support renaming of drivers, so check old names as well"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_077876f4","line":505,"in_reply_to":"3f79a3b5_a132d20c","updated":"2018-11-09 03:37:42.000000000","message":"Or as the alternative we could keep this, and add a online data migration code in objects.backup._from_db_object, and do something like what we have done in [1].\n\nOtherwise, we will always keep this compatibility code.\n\nFYI, we did this kind of migration in placement [2] , but I\u0027m not sure whether it\u0027s the best practice or not. \n\n[1] https://github.com/openstack/cinder/blob/4afc2eb/cinder/db/sqlalchemy/api.py#L585\n[2] https://github.com/openstack/nova/blob/730936e/nova/api/openstack/placement/objects/resource_provider.py#L1186","commit_id":"f95799097d4a9cf7744e4b185167d2acd2f9838a"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"b450365d9d44a46076410f9732ffc2e50c32de68","unresolved":false,"context_lines":[{"line_number":502,"context_line":"        if not backup:"},{"line_number":503,"context_line":"            return True"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"        if self.driver_name \u003d\u003d backup:"},{"line_number":506,"context_line":"            return True"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"        # We support renaming of drivers, so check old names as well"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_a132d20c","line":505,"in_reply_to":"3f79a3b5_d8d34262","updated":"2018-11-09 01:12:26.000000000","message":"Emm... this is where I didn\u0027t think about it. Considering the compatibility issue, it seems that it cannot be set to equal, if I want to update this as equal, I have to make sure this is a brand new environment. is it?\n\nIf this is the case, I feel that the bug 1801316 still exists in the master branch, so here need to do the following:\n\nIf self.driver_name.startswith(backup) or backup.startswith(\n                 Self.driver_name):\n    Return True","commit_id":"f95799097d4a9cf7744e4b185167d2acd2f9838a"}],"cinder/tests/unit/backup/test_backup.py":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"4809d35d7a9fd83b05557b39b77d8ed4adf99e11","unresolved":false,"context_lines":[{"line_number":1777,"context_line":"        self.assertEqual(100, tpool._nthreads)"},{"line_number":1778,"context_line":"        self.assertListEqual([], tpool._threads)"},{"line_number":1779,"context_line":""},{"line_number":1780,"context_line":"    def test_backup_service_name_equals_driver_name(self):"},{"line_number":1781,"context_line":"        driver_name \u003d \u0027cinder.tests.unit.backup.fake_service\u0027"},{"line_number":1782,"context_line":"        service_name \u003d \u0027cinder.tests.unit.backup.fake_service\u0027"},{"line_number":1783,"context_line":"        self.backup_mgr.driver_name \u003d driver_name"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_eef3079f","line":1780,"updated":"2018-11-07 07:31:25.000000000","message":"Even if we don\u0027t change the code, this test case is also passed, so it would be good if we can also test something like:\n\nservice_name \u003d \u0027cinder.tests.unit.backup.fake_service\u0027\ndriver_name \u003d \u0027cinder.tests.unit.backup.fake_service.FakeBackupService\u0027\n\nself.assertFalse(self.backup_mgr._is_our_backup(backup))\n\nto ensure that only \u0027\u003d\u003d\u0027 can match it rather than \u0027startwith()\u0027 , \u0027in\u0027 or something.","commit_id":"351602b0d0b0d12a179ecbfcad76552451f6b5ea"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"53599a2853b0df6e8c8b2534534ee5f41d20fc09","unresolved":false,"context_lines":[{"line_number":1777,"context_line":"        self.assertEqual(100, tpool._nthreads)"},{"line_number":1778,"context_line":"        self.assertListEqual([], tpool._threads)"},{"line_number":1779,"context_line":""},{"line_number":1780,"context_line":"    def test_backup_service_name_equals_driver_name(self):"},{"line_number":1781,"context_line":"        driver_name \u003d \u0027cinder.tests.unit.backup.fake_service\u0027"},{"line_number":1782,"context_line":"        service_name \u003d \u0027cinder.tests.unit.backup.fake_service\u0027"},{"line_number":1783,"context_line":"        self.backup_mgr.driver_name \u003d driver_name"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_8e305308","line":1780,"in_reply_to":"3f79a3b5_eef3079f","updated":"2018-11-07 07:53:19.000000000","message":"Done","commit_id":"351602b0d0b0d12a179ecbfcad76552451f6b5ea"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"79fb922495426028dd4a6a0189b318e5e509dc6e","unresolved":false,"context_lines":[{"line_number":1778,"context_line":"        self.assertListEqual([], tpool._threads)"},{"line_number":1779,"context_line":""},{"line_number":1780,"context_line":"    def test_backup_service_name_equals_driver_name_is_true(self):"},{"line_number":1781,"context_line":"        driver_name \u003d \u0027cinder.tests.unit.backup.fake_service\u0027"},{"line_number":1782,"context_line":"        service_name \u003d \u0027cinder.tests.unit.backup.fake_service\u0027"},{"line_number":1783,"context_line":"        self.backup_mgr.driver_name \u003d driver_name"},{"line_number":1784,"context_line":"        vol_id \u003d self._create_volume_db_entry(status\u003d\u0027available\u0027, size\u003d1)"},{"line_number":1785,"context_line":"        backup \u003d self._create_backup_db_entry(volume_id\u003dvol_id,"},{"line_number":1786,"context_line":"                                              service\u003dservice_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_b4bc71d5","line":1783,"range":{"start_line":1781,"start_character":0,"end_line":1783,"end_character":49},"updated":"2018-11-07 17:14:20.000000000","message":"I\u0027m not sure, but I think we can use the default driver name as the service name:\n\n`service_name \u003d self.backup_mgr.driver_name`","commit_id":"f5f12ef0b27f2f66fbaab3dcfafebb8490297b73"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3f6f159d1e4a7f8e6fc399e71a4921aae678bef0","unresolved":false,"context_lines":[{"line_number":1778,"context_line":"        self.assertListEqual([], tpool._threads)"},{"line_number":1779,"context_line":""},{"line_number":1780,"context_line":"    def test_backup_service_name_equals_driver_name_is_true(self):"},{"line_number":1781,"context_line":"        driver_name \u003d \u0027cinder.tests.unit.backup.fake_service\u0027"},{"line_number":1782,"context_line":"        service_name \u003d \u0027cinder.tests.unit.backup.fake_service\u0027"},{"line_number":1783,"context_line":"        self.backup_mgr.driver_name \u003d driver_name"},{"line_number":1784,"context_line":"        vol_id \u003d self._create_volume_db_entry(status\u003d\u0027available\u0027, size\u003d1)"},{"line_number":1785,"context_line":"        backup \u003d self._create_backup_db_entry(volume_id\u003dvol_id,"},{"line_number":1786,"context_line":"                                              service\u003dservice_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_ef176f9d","line":1783,"range":{"start_line":1781,"start_character":0,"end_line":1783,"end_character":49},"in_reply_to":"3f79a3b5_b4bc71d5","updated":"2018-11-08 01:27:30.000000000","message":"I think that the implementation is different and the purpose is the same.\nBut use \u0027service_name \u003d self.backup_mgr.driver_name\u0027 looks better, so update this.","commit_id":"f5f12ef0b27f2f66fbaab3dcfafebb8490297b73"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"79fb922495426028dd4a6a0189b318e5e509dc6e","unresolved":false,"context_lines":[{"line_number":1790,"context_line":"    def test_backup_service_name_equals_driver_name_is_false(self):"},{"line_number":1791,"context_line":"        driver_name \u003d \u0027cinder.tests.unit.backup.fake_service.FakeBackupService\u0027"},{"line_number":1792,"context_line":"        service_name \u003d \u0027cinder.tests.unit.backup.fake_service\u0027"},{"line_number":1793,"context_line":"        self.backup_mgr.driver_name \u003d driver_name"},{"line_number":1794,"context_line":"        vol_id \u003d self._create_volume_db_entry(status\u003d\u0027available\u0027, size\u003d1)"},{"line_number":1795,"context_line":"        backup \u003d self._create_backup_db_entry(volume_id\u003dvol_id,"},{"line_number":1796,"context_line":"                                              service\u003dservice_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_147a0526","line":1793,"range":{"start_line":1793,"start_character":0,"end_line":1793,"end_character":49},"updated":"2018-11-07 17:14:20.000000000","message":"I think we don\u0027t need this assignment because the default driver_name already is: `cinder.tests.unit.backup.fake_service.FakeBackupService`","commit_id":"f5f12ef0b27f2f66fbaab3dcfafebb8490297b73"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3f6f159d1e4a7f8e6fc399e71a4921aae678bef0","unresolved":false,"context_lines":[{"line_number":1790,"context_line":"    def test_backup_service_name_equals_driver_name_is_false(self):"},{"line_number":1791,"context_line":"        driver_name \u003d \u0027cinder.tests.unit.backup.fake_service.FakeBackupService\u0027"},{"line_number":1792,"context_line":"        service_name \u003d \u0027cinder.tests.unit.backup.fake_service\u0027"},{"line_number":1793,"context_line":"        self.backup_mgr.driver_name \u003d driver_name"},{"line_number":1794,"context_line":"        vol_id \u003d self._create_volume_db_entry(status\u003d\u0027available\u0027, size\u003d1)"},{"line_number":1795,"context_line":"        backup \u003d self._create_backup_db_entry(volume_id\u003dvol_id,"},{"line_number":1796,"context_line":"                                              service\u003dservice_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_8f9a7b0f","line":1793,"range":{"start_line":1793,"start_character":0,"end_line":1793,"end_character":49},"in_reply_to":"3f79a3b5_147a0526","updated":"2018-11-08 01:27:30.000000000","message":"Yeah, this is not necessary.","commit_id":"f5f12ef0b27f2f66fbaab3dcfafebb8490297b73"}]}