)]}'
{"cinder/backup/manager.py":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"e1e048567a9148f8859352b7996d3ad719e2da58","unresolved":false,"context_lines":[{"line_number":522,"context_line":"            return True"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"        # TODO(tommylikehu): We upgraded the \u0027driver_name\u0027 from module"},{"line_number":525,"context_line":"        # to class name, so we use \u0027in\u0027 here to match two namings,"},{"line_number":526,"context_line":"        # this can be replaced with equal sign during next"},{"line_number":527,"context_line":"        # release (Rocky)."},{"line_number":528,"context_line":"        if self.driver_name.startswith(backup) or backup.startswith("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_eaab2c6e","line":525,"range":{"start_line":525,"start_character":36,"end_line":525,"end_character":38},"updated":"2018-11-05 02:09:12.000000000","message":"nit and note for other reviewer: I think it\u0027s should be \u0027startswith\u0027 in here, see ref[1].\n\n[1] https://review.openstack.org/#/c/566574/2..4/cinder/backup/manager.py@579\n\nAnd this TODO maybe has some problem, we cannot just change this startswith to equal sign.\n\nwe perhaps should also process the old-style backup (change his service field from cinder.backup.drivers.ceph to cinder.backup.drivers.ceph.CephBackupDriver)?","commit_id":"9d6b47f25def05114582edf64adecd4068e2ee7c"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f41d338d56fcc679925b61f76bd803fd06d42773","unresolved":false,"context_lines":[{"line_number":522,"context_line":"            return True"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"        # TODO(tommylikehu): We upgraded the \u0027driver_name\u0027 from module"},{"line_number":525,"context_line":"        # to class name, so we use \u0027in\u0027 here to match two namings,"},{"line_number":526,"context_line":"        # this can be replaced with equal sign during next"},{"line_number":527,"context_line":"        # release (Rocky)."},{"line_number":528,"context_line":"        if self.driver_name.startswith(backup) or backup.startswith("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_3bc174fe","line":525,"range":{"start_line":525,"start_character":36,"end_line":525,"end_character":38},"in_reply_to":"3f79a3b5_a0bf93fb","updated":"2018-11-05 08:27:50.000000000","message":"@Rajat, you can review this patch first https://review.openstack.org/#/c/615117/\n\nLike \u0027cinder.backup.drivers.ceph\u0027 was deprecated and no longer supported after rocky, so it was not fixed in master.","commit_id":"9d6b47f25def05114582edf64adecd4068e2ee7c"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f41d338d56fcc679925b61f76bd803fd06d42773","unresolved":false,"context_lines":[{"line_number":522,"context_line":"            return True"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"        # TODO(tommylikehu): We upgraded the \u0027driver_name\u0027 from module"},{"line_number":525,"context_line":"        # to class name, so we use \u0027in\u0027 here to match two namings,"},{"line_number":526,"context_line":"        # this can be replaced with equal sign during next"},{"line_number":527,"context_line":"        # release (Rocky)."},{"line_number":528,"context_line":"        if self.driver_name.startswith(backup) or backup.startswith("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_1be7d8ad","line":525,"range":{"start_line":525,"start_character":36,"end_line":525,"end_character":38},"in_reply_to":"3f79a3b5_eaab2c6e","updated":"2018-11-05 08:27:50.000000000","message":"Thanks yikun, I will be changes this TODO, and add a new comment here.","commit_id":"9d6b47f25def05114582edf64adecd4068e2ee7c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8914f7373757813c64299e426e54a0365527ea63","unresolved":false,"context_lines":[{"line_number":522,"context_line":"            return True"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"        # TODO(tommylikehu): We upgraded the \u0027driver_name\u0027 from module"},{"line_number":525,"context_line":"        # to class name, so we use \u0027in\u0027 here to match two namings,"},{"line_number":526,"context_line":"        # this can be replaced with equal sign during next"},{"line_number":527,"context_line":"        # release (Rocky)."},{"line_number":528,"context_line":"        if self.driver_name.startswith(backup) or backup.startswith("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a0bf93fb","line":525,"range":{"start_line":525,"start_character":36,"end_line":525,"end_character":38},"in_reply_to":"3f79a3b5_eaab2c6e","updated":"2018-11-05 07:15:54.000000000","message":"the note was directly copied without any modification to the related code.\nit should be \u0027startstwith\u0027\nThis should be fixed in master, no point in doing changes here.","commit_id":"9d6b47f25def05114582edf64adecd4068e2ee7c"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"e1e048567a9148f8859352b7996d3ad719e2da58","unresolved":false,"context_lines":[{"line_number":525,"context_line":"        # to class name, so we use \u0027in\u0027 here to match two namings,"},{"line_number":526,"context_line":"        # this can be replaced with equal sign during next"},{"line_number":527,"context_line":"        # release (Rocky)."},{"line_number":528,"context_line":"        if self.driver_name.startswith(backup) or backup.startswith("},{"line_number":529,"context_line":"                self.driver_name):"},{"line_number":530,"context_line":"            return True"},{"line_number":531,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_cac0b02f","line":528,"updated":"2018-11-05 02:09:12.000000000","message":"-1, we need a test for this.","commit_id":"9d6b47f25def05114582edf64adecd4068e2ee7c"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"25201a68b8b8d0987b8bbe964e3a44bb46d31998","unresolved":false,"context_lines":[{"line_number":525,"context_line":"        # to class name, so we use \u0027in\u0027 here to match two namings,"},{"line_number":526,"context_line":"        # this can be replaced with equal sign during next"},{"line_number":527,"context_line":"        # release (Rocky)."},{"line_number":528,"context_line":"        if self.driver_name.startswith(backup) or backup.startswith("},{"line_number":529,"context_line":"                self.driver_name):"},{"line_number":530,"context_line":"            return True"},{"line_number":531,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_ad79b581","line":528,"in_reply_to":"3f79a3b5_75be14cf","updated":"2018-11-06 01:19:34.000000000","message":"You could get some ref from https://review.openstack.org/#/c/610645","commit_id":"9d6b47f25def05114582edf64adecd4068e2ee7c"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"7e2a6c564232eab467ad4054d3b2224a0a86d948","unresolved":false,"context_lines":[{"line_number":525,"context_line":"        # to class name, so we use \u0027in\u0027 here to match two namings,"},{"line_number":526,"context_line":"        # this can be replaced with equal sign during next"},{"line_number":527,"context_line":"        # release (Rocky)."},{"line_number":528,"context_line":"        if self.driver_name.startswith(backup) or backup.startswith("},{"line_number":529,"context_line":"                self.driver_name):"},{"line_number":530,"context_line":"            return True"},{"line_number":531,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_75be14cf","line":528,"in_reply_to":"3f79a3b5_c0bacf0a","updated":"2018-11-05 12:11:20.000000000","message":"@yikun, @Rajat, I am confusing with the unit test, about call this method\u0027s apis (e.g. restore/delete) all have the test  case with each and contained this. Do I need to add a test case for each method like [1]? :P\n[1] https://github.com/openstack/cinder/blob/stable/rocky/cinder/tests/unit/backup/test_backup.py#L1474-L1492","commit_id":"9d6b47f25def05114582edf64adecd4068e2ee7c"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f41d338d56fcc679925b61f76bd803fd06d42773","unresolved":false,"context_lines":[{"line_number":525,"context_line":"        # to class name, so we use \u0027in\u0027 here to match two namings,"},{"line_number":526,"context_line":"        # this can be replaced with equal sign during next"},{"line_number":527,"context_line":"        # release (Rocky)."},{"line_number":528,"context_line":"        if self.driver_name.startswith(backup) or backup.startswith("},{"line_number":529,"context_line":"                self.driver_name):"},{"line_number":530,"context_line":"            return True"},{"line_number":531,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_dbf8804c","line":528,"in_reply_to":"3f79a3b5_c0bacf0a","updated":"2018-11-05 08:27:50.000000000","message":"Done","commit_id":"9d6b47f25def05114582edf64adecd4068e2ee7c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8914f7373757813c64299e426e54a0365527ea63","unresolved":false,"context_lines":[{"line_number":525,"context_line":"        # to class name, so we use \u0027in\u0027 here to match two namings,"},{"line_number":526,"context_line":"        # this can be replaced with equal sign during next"},{"line_number":527,"context_line":"        # release (Rocky)."},{"line_number":528,"context_line":"        if self.driver_name.startswith(backup) or backup.startswith("},{"line_number":529,"context_line":"                self.driver_name):"},{"line_number":530,"context_line":"            return True"},{"line_number":531,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c0bacf0a","line":528,"in_reply_to":"3f79a3b5_cac0b02f","updated":"2018-11-05 07:15:54.000000000","message":"+1\nsimilar to this\nhttps://github.com/openstack/cinder/blob/master/cinder/tests/unit/backup/test_backup.py#L1461","commit_id":"9d6b47f25def05114582edf64adecd4068e2ee7c"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f41d338d56fcc679925b61f76bd803fd06d42773","unresolved":false,"context_lines":[{"line_number":525,"context_line":"        # to class name, so we use \u0027in\u0027 here to match two namings,"},{"line_number":526,"context_line":"        # this can be replaced with equal sign during next"},{"line_number":527,"context_line":"        # release (Rocky)."},{"line_number":528,"context_line":"        if self.driver_name.startswith(backup) or backup.startswith("},{"line_number":529,"context_line":"                self.driver_name):"},{"line_number":530,"context_line":"            return True"},{"line_number":531,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_7bf7ec5b","line":528,"in_reply_to":"3f79a3b5_cac0b02f","updated":"2018-11-05 08:27:50.000000000","message":"Done","commit_id":"9d6b47f25def05114582edf64adecd4068e2ee7c"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"75ab99c4d52bbac82f8e4e070faec7ca685edc5f","unresolved":false,"context_lines":[{"line_number":524,"context_line":"        # TODO(tommylikehu): We upgraded the \u0027driver_name\u0027 from module to"},{"line_number":525,"context_line":"        # class name, so we use \u0027startswith\u0027 here to match two namings,"},{"line_number":526,"context_line":"        # this can be replaced with equal sign during next release (Rocky)."},{"line_number":527,"context_line":"        # (Brin Zhang): The \u0027driver_name\u0027 varies depending on the user"},{"line_number":528,"context_line":"        # settings, so a two-way judgment is required."},{"line_number":529,"context_line":"        if self.driver_name.startswith(backup) or backup.startswith("},{"line_number":530,"context_line":"                self.driver_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_1a62523e","line":527,"range":{"start_line":527,"start_character":10,"end_line":527,"end_character":22},"updated":"2018-11-06 12:40:23.000000000","message":"Only need to include a name if you are setting a TODO. This leading part can be removed.","commit_id":"2a838b0ec32ea83e64a9d8d2390f2d6bc0378509"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"1bcbb2c2042990c3a2c15d72b88173189cbb5fc6","unresolved":false,"context_lines":[{"line_number":524,"context_line":"        # TODO(tommylikehu): We upgraded the \u0027driver_name\u0027 from module to"},{"line_number":525,"context_line":"        # class name, so we use \u0027startswith\u0027 here to match two namings,"},{"line_number":526,"context_line":"        # this can be replaced with equal sign during next release (Rocky)."},{"line_number":527,"context_line":"        # (Brin Zhang): The \u0027driver_name\u0027 varies depending on the user"},{"line_number":528,"context_line":"        # settings, so a two-way judgment is required."},{"line_number":529,"context_line":"        if self.driver_name.startswith(backup) or backup.startswith("},{"line_number":530,"context_line":"                self.driver_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_ac08be2d","line":527,"range":{"start_line":527,"start_character":10,"end_line":527,"end_character":22},"in_reply_to":"3f79a3b5_1a62523e","updated":"2018-11-07 00:42:12.000000000","message":"Done","commit_id":"2a838b0ec32ea83e64a9d8d2390f2d6bc0378509"}],"cinder/tests/unit/backup/test_backup.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"81a83681cc193ade7be6d4dd162a2c49c9400d0f","unresolved":false,"context_lines":[{"line_number":1791,"context_line":""},{"line_number":1792,"context_line":"    def test_backup_service_name_startswith_driver_name(self):"},{"line_number":1793,"context_line":"        driver_name \u003d \u0027cinder.tests.unit.backup.fake_service\u0027"},{"line_number":1794,"context_line":"        service_name \u003d \\"},{"line_number":1795,"context_line":"            \u0027cinder.tests.unit.backup.fake_service.FakeBackupService\u0027"},{"line_number":1796,"context_line":"        self.override_config(\u0027backup_driver\u0027, driver_name)"},{"line_number":1797,"context_line":"        vol_id \u003d self._create_volume_db_entry(status\u003d\u0027available\u0027, size\u003d1)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_de3135bd","line":1794,"range":{"start_line":1794,"start_character":23,"end_line":1794,"end_character":24},"updated":"2018-11-06 06:18:01.000000000","message":"please use paranthesis () to wrap this","commit_id":"b2a742beac3602690862568fd59ca447108776b6"}]}