)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"9f381ce0102b7457409e5d1539e5b35a7d5675f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"52b56519_3d397681","updated":"2024-05-21 04:01:09.000000000","message":"We need to be ruthless here. If someone wants to work on this, they should do it. Otherwise, force-abandon it.","commit_id":"8abd68cd61c5c540634492dd6f23f91450acbc88"}],"cinder/message/message_field.py":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"d84b470416182412d10c7ccd1bb9b290e30ba89b","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                       \u0027SnapshotLimitExceeded\u0027],"},{"line_number":129,"context_line":"        NOT_ENOUGH_SPACE_FOR_IMAGE: [\u0027ImageTooBig\u0027],"},{"line_number":130,"context_line":"        UNMANAGE_ENC_NOT_SUPPORTED: [\u0027UnmanageEncVolNotSupported\u0027],"},{"line_number":131,"context_line":"        METADATA_UPDATE_FAIL: [\u0027MetadataUpdateFailure\u0027],"},{"line_number":132,"context_line":"        METADATA_COPY_FAIL: [\u0027MetadataCopyFailure\u0027],"},{"line_number":133,"context_line":"    }"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_3504ca7c","line":132,"range":{"start_line":131,"start_character":0,"end_line":132,"end_character":52},"updated":"2018-11-26 16:45:25.000000000","message":"I\u0027m not sure how EXCEPTION_DETAIL_MAPPINGS works. However, why don\u0027t add METADA_ERROR?","commit_id":"8abd68cd61c5c540634492dd6f23f91450acbc88"}],"cinder/tests/unit/volume/flows/test_create_volume_flow.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"49a64e5eb0ae98436ce33e166d7290cf9921821c","unresolved":false,"context_lines":[{"line_number":1261,"context_line":""},{"line_number":1262,"context_line":"    @mock.patch(\u0027cinder.message.api.API.create\u0027)"},{"line_number":1263,"context_line":"    @mock.patch(\u0027cinder.objects.Snapshot.get_by_id\u0027)"},{"line_number":1264,"context_line":"    def test_create_from_snapshot_drive_error("},{"line_number":1265,"context_line":"            self, mock_get_snapshot, mock_message_create):"},{"line_number":1266,"context_line":"        fake_db \u003d mock.MagicMock()"},{"line_number":1267,"context_line":"        fake_driver \u003d mock.MagicMock()"},{"line_number":1268,"context_line":"        fake_volume_manager \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_1632c6f3","line":1265,"range":{"start_line":1264,"start_character":45,"end_line":1265,"end_character":58},"updated":"2018-11-12 07:17:04.000000000","message":"can you reformat this like other tests? see L#1192","commit_id":"b75c69c88741a9e05cbe4644b0a995c840f763fb"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"35c4d3096975d8e460b31c271de0e0ccff31f46d","unresolved":false,"context_lines":[{"line_number":1261,"context_line":""},{"line_number":1262,"context_line":"    @mock.patch(\u0027cinder.message.api.API.create\u0027)"},{"line_number":1263,"context_line":"    @mock.patch(\u0027cinder.objects.Snapshot.get_by_id\u0027)"},{"line_number":1264,"context_line":"    def test_create_from_snapshot_drive_error("},{"line_number":1265,"context_line":"            self, mock_get_snapshot, mock_message_create):"},{"line_number":1266,"context_line":"        fake_db \u003d mock.MagicMock()"},{"line_number":1267,"context_line":"        fake_driver \u003d mock.MagicMock()"},{"line_number":1268,"context_line":"        fake_volume_manager \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_d14cfc98","line":1265,"range":{"start_line":1264,"start_character":45,"end_line":1265,"end_character":58},"in_reply_to":"3f79a3b5_1632c6f3","updated":"2018-11-19 07:13:05.000000000","message":"May I ask why you prefer to this format? It seems both formats are ok. Sometimes the name of the variable is too long, and we can\u0027t use the style like L#1192.","commit_id":"b75c69c88741a9e05cbe4644b0a995c840f763fb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"14ee5681e232c4ef7deecaca4fdd746bd4345ec8","unresolved":false,"context_lines":[{"line_number":1261,"context_line":""},{"line_number":1262,"context_line":"    @mock.patch(\u0027cinder.message.api.API.create\u0027)"},{"line_number":1263,"context_line":"    @mock.patch(\u0027cinder.objects.Snapshot.get_by_id\u0027)"},{"line_number":1264,"context_line":"    def test_create_from_snapshot_drive_error("},{"line_number":1265,"context_line":"            self, mock_get_snapshot, mock_message_create):"},{"line_number":1266,"context_line":"        fake_db \u003d mock.MagicMock()"},{"line_number":1267,"context_line":"        fake_driver \u003d mock.MagicMock()"},{"line_number":1268,"context_line":"        fake_volume_manager \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_3701a004","line":1265,"range":{"start_line":1264,"start_character":45,"end_line":1265,"end_character":58},"in_reply_to":"3f79a3b5_d14cfc98","updated":"2018-11-19 08:25:55.000000000","message":"Yes i agree but in this case they don\u0027t exceed\n    def test_create_from_snapshot_drive_error(self,\n                                              mock_get_snapshot,\n                                              mock_message_create):\nI preferred this due to format consistency with other tests and better readability but since there isn\u0027t any strict rule, i\u0027ve no issues with the current formatting.","commit_id":"b75c69c88741a9e05cbe4644b0a995c840f763fb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"49a64e5eb0ae98436ce33e166d7290cf9921821c","unresolved":false,"context_lines":[{"line_number":1291,"context_line":"    @mock.patch(\u0027cinder.message.api.API.create\u0027)"},{"line_number":1292,"context_line":"    @mock.patch(\u0027cinder.objects.Volume.get_by_id\u0027)"},{"line_number":1293,"context_line":"    @mock.patch(\u0027cinder.objects.Snapshot.get_by_id\u0027)"},{"line_number":1294,"context_line":"    def test_create_from_snapshot_metadata_error("},{"line_number":1295,"context_line":"            self, mock_get_snapshot, mock_get_volume, mock_message_create):"},{"line_number":1296,"context_line":"        fake_db \u003d mock.MagicMock()"},{"line_number":1297,"context_line":"        fake_driver \u003d mock.MagicMock()"},{"line_number":1298,"context_line":"        fake_volume_manager \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_7648da60","line":1295,"range":{"start_line":1294,"start_character":48,"end_line":1295,"end_character":75},"updated":"2018-11-12 07:17:04.000000000","message":"same","commit_id":"b75c69c88741a9e05cbe4644b0a995c840f763fb"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"d84b470416182412d10c7ccd1bb9b290e30ba89b","unresolved":false,"context_lines":[{"line_number":1291,"context_line":"    @mock.patch(\u0027cinder.message.api.API.create\u0027)"},{"line_number":1292,"context_line":"    @mock.patch(\u0027cinder.objects.Volume.get_by_id\u0027)"},{"line_number":1293,"context_line":"    @mock.patch(\u0027cinder.objects.Snapshot.get_by_id\u0027)"},{"line_number":1294,"context_line":"    def test_create_from_snapshot_metadata_error("},{"line_number":1295,"context_line":"            self, mock_get_snapshot, mock_get_volume, mock_message_create):"},{"line_number":1296,"context_line":"        fake_db \u003d mock.MagicMock()"},{"line_number":1297,"context_line":"        fake_driver \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_60b60229","line":1294,"range":{"start_line":1294,"start_character":0,"end_line":1294,"end_character":49},"updated":"2018-11-26 16:45:25.000000000","message":"I wonder if, in the future, we can add tests for METADATA_UPDATE_FAIL and METADATA_COPY_FAIL, or do you think that is unnecessary?","commit_id":"8abd68cd61c5c540634492dd6f23f91450acbc88"}],"cinder/volume/flows/manager/create_volume.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"49a64e5eb0ae98436ce33e166d7290cf9921821c","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                                                                   snapshot)"},{"line_number":452,"context_line":"        except Exception as ex:"},{"line_number":453,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":454,"context_line":"                message \u003d \\"},{"line_number":455,"context_line":"                    message_field.Detail.DRIVER_FAILED_CREATE_FROM_SNAPSHOT"},{"line_number":456,"context_line":"                self.message.create("},{"line_number":457,"context_line":"                    context,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_364ee26c","line":454,"range":{"start_line":454,"start_character":25,"end_line":454,"end_character":27},"updated":"2018-11-12 07:17:04.000000000","message":"please wrap this using paranthesis ()","commit_id":"b75c69c88741a9e05cbe4644b0a995c840f763fb"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"35c4d3096975d8e460b31c271de0e0ccff31f46d","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                                                                   snapshot)"},{"line_number":452,"context_line":"        except Exception as ex:"},{"line_number":453,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":454,"context_line":"                message \u003d \\"},{"line_number":455,"context_line":"                    message_field.Detail.DRIVER_FAILED_CREATE_FROM_SNAPSHOT"},{"line_number":456,"context_line":"                self.message.create("},{"line_number":457,"context_line":"                    context,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_142fc28a","line":454,"range":{"start_line":454,"start_character":25,"end_line":454,"end_character":27},"in_reply_to":"3f79a3b5_364ee26c","updated":"2018-11-19 07:13:05.000000000","message":"Done","commit_id":"b75c69c88741a9e05cbe4644b0a995c840f763fb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"49a64e5eb0ae98436ce33e166d7290cf9921821c","unresolved":false,"context_lines":[{"line_number":478,"context_line":"                               \u0027snapshot_ref_id\u0027: snapshot.volume_id})"},{"line_number":479,"context_line":"                raise exception.MetadataUpdateFailure(reason\u003dex)"},{"line_number":480,"context_line":"            if make_bootable:"},{"line_number":481,"context_line":"                self._handle_bootable_volume_glance_meta("},{"line_number":482,"context_line":"                    context, volume,"},{"line_number":483,"context_line":"                    snapshot_id\u003dsnapshot_id)"},{"line_number":484,"context_line":"            return model_update"},{"line_number":485,"context_line":"        except Exception as ex:"},{"line_number":486,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_d6aa0ece","line":483,"range":{"start_line":481,"start_character":56,"end_line":483,"end_character":44},"updated":"2018-11-12 07:17:04.000000000","message":"same, see L#357","commit_id":"b75c69c88741a9e05cbe4644b0a995c840f763fb"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"090cc2d856adcba6e8d8fcc678be511524cd2095","unresolved":false,"context_lines":[{"line_number":476,"context_line":"                              \"snapshot %(snapshot_ref_id)s volume reference\","},{"line_number":477,"context_line":"                              {\u0027snapshot_id\u0027: snapshot_id,"},{"line_number":478,"context_line":"                               \u0027snapshot_ref_id\u0027: snapshot.volume_id})"},{"line_number":479,"context_line":"                raise exception.MetadataUpdateFailure(reason\u003dex)"},{"line_number":480,"context_line":"            if make_bootable:"},{"line_number":481,"context_line":"                self._handle_bootable_volume_glance_meta("},{"line_number":482,"context_line":"                    context, volume,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_7070fca4","line":479,"updated":"2019-03-28 20:09:52.000000000","message":"Not your change, but this seems like a weird exception to raise here.","commit_id":"8abd68cd61c5c540634492dd6f23f91450acbc88"}]}