)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"4af82503081afc622be254c912ed239b66ed7d69","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2018-11-05 16:35:29 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Improve transfer records"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I33bd43b2d62b2caec0a579b209dd334e32ac8f04"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_51d0cf2a","line":8,"updated":"2018-11-05 09:50:57.000000000","message":"Lack of the bp index. Such as \u0027Blueprint:improve-volume-transfer-records \u0027","commit_id":"ccc0846563de20e053f8cc07957ef4bf1da57897"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a1059afd2963d80234dddf6d02f15857ff4aac94","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add x_project_id, accepted to transfers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the \u0027original_project_id\u0027, \u0027current_project_id\u0027,"},{"line_number":10,"context_line":"\u0027accepted\u0027 fields to transfers table and model."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Part of blueprint: improve-volume-transfer-records"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_95712516","line":10,"updated":"2018-12-07 18:50:10.000000000","message":"Why wouldn\u0027t we use \"source\" and \"destination\" instead of original/current?  \"current\" is misleading since it will no longer be accurate if two transfers have occurred for the same volume...","commit_id":"43561049fb8be2967dc8e8d586bebbc60609406d"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"ae1ae469f44978fb1e3cc181d361a1086e48cf33","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add x_project_id, accepted to transfers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the \u0027original_project_id\u0027, \u0027current_project_id\u0027,"},{"line_number":10,"context_line":"\u0027accepted\u0027 fields to transfers table and model."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Part of blueprint: improve-volume-transfer-records"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_2d0d5332","line":10,"in_reply_to":"3f79a3b5_95712516","updated":"2018-12-10 08:06:23.000000000","message":"Yes, agree with you, and all words are replaced.\n\nAnd I also added appending change in original spec:\nhttps://review.openstack.org/#/c/624012/","commit_id":"43561049fb8be2967dc8e8d586bebbc60609406d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"607f90798d1f17cc38bb42f9c92c98f99ff02f50","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add x_project_id, accepted to transfers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the \u0027source_project_id\u0027, \u0027destination_project_id\u0027,"},{"line_number":10,"context_line":"\u0027accepted\u0027 fields to transfers table and model."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Part of blueprint: improve-volume-transfer-records"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f79a3b5_3e178645","line":9,"range":{"start_line":9,"start_character":20,"end_line":9,"end_character":65},"updated":"2018-12-12 04:56:58.000000000","message":"So these are good suggestions but different from what was proposed in the spec [1], i think we need to add a follow up patch for the spec so as to keep consistency.\n\n[1] https://review.openstack.org/#/c/612866/4/specs/stein/improve-volume-transfer-records.rst","commit_id":"8f64ee6c2fe431483151f90dce6bd34ae27dee75"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2cbd61aa70ae8f994423b9d48bd650f5fd665bb0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add x_project_id, accepted to transfers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the \u0027source_project_id\u0027, \u0027destination_project_id\u0027,"},{"line_number":10,"context_line":"\u0027accepted\u0027 fields to transfers table and model."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Part of blueprint: improve-volume-transfer-records"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f79a3b5_fe358ed5","line":9,"range":{"start_line":9,"start_character":20,"end_line":9,"end_character":65},"in_reply_to":"3f79a3b5_3e178645","updated":"2018-12-12 05:02:39.000000000","message":"Ignore this comment, addressed by https://review.openstack.org/#/c/624012","commit_id":"8f64ee6c2fe431483151f90dce6bd34ae27dee75"}],"cinder/db/sqlalchemy/migrate_repo/versions/127_add_project_id_and_accepted_to_transfer.py":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"e0986c0ecaf3bc750374f8d30906c0bd9ecb37dc","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"def upgrade(migrate_engine):"},{"line_number":17,"context_line":"    \"\"\"Add the original_project_id, current_project_id, accept column to the"},{"line_number":18,"context_line":"    transfers table."},{"line_number":19,"context_line":"    \"\"\""},{"line_number":20,"context_line":"    meta \u003d MetaData(bind\u003dmigrate_engine)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_3e22a9b8","line":17,"range":{"start_line":17,"start_character":56,"end_line":17,"end_character":62},"updated":"2018-11-06 06:53:49.000000000","message":"accepted","commit_id":"4713f90c6be34adc16f5e23692e0ce89ef11e26f"}],"cinder/db/sqlalchemy/migrate_repo/versions/128_add_project_id_and_accepted_to_transfer.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"10d11b1840f6c936a8c8a4c2246bfaf83ea2bee8","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"def upgrade(migrate_engine):"},{"line_number":17,"context_line":"    meta \u003d MetaData(bind\u003dmigrate_engine)"},{"line_number":18,"context_line":"    transfers \u003d Table(\u0027transfers\u0027, meta, autoload\u003dTrue)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    source_project_id \u003d Column(\u0027source_project_id\u0027, String(255),"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_fb4a80ad","line":17,"updated":"2018-12-12 04:32:27.000000000","message":"can we add a docstring description here like\nhttps://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/migrate_repo/versions/123_add_transfer_no_snapshots.py#L17","commit_id":"8f64ee6c2fe431483151f90dce6bd34ae27dee75"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"6e5e9d929c30f653d74c0b7962292101235d3d13","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"def upgrade(migrate_engine):"},{"line_number":17,"context_line":"    meta \u003d MetaData(bind\u003dmigrate_engine)"},{"line_number":18,"context_line":"    transfers \u003d Table(\u0027transfers\u0027, meta, autoload\u003dTrue)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    source_project_id \u003d Column(\u0027source_project_id\u0027, String(255),"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_bee876a8","line":17,"in_reply_to":"3f79a3b5_fb4a80ad","updated":"2018-12-12 05:59:25.000000000","message":"+1","commit_id":"8f64ee6c2fe431483151f90dce6bd34ae27dee75"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"10d11b1840f6c936a8c8a4c2246bfaf83ea2bee8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    meta \u003d MetaData(bind\u003dmigrate_engine)"},{"line_number":18,"context_line":"    transfers \u003d Table(\u0027transfers\u0027, meta, autoload\u003dTrue)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    source_project_id \u003d Column(\u0027source_project_id\u0027, String(255),"},{"line_number":21,"context_line":"                               nullable\u003dTrue)"},{"line_number":22,"context_line":"    if not hasattr(transfers.c, \u0027source_project_id\u0027):"},{"line_number":23,"context_line":"        transfers.create_column(source_project_id)"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_9b8fccd1","line":21,"range":{"start_line":20,"start_character":0,"end_line":21,"end_character":45},"updated":"2018-12-12 04:32:27.000000000","message":"This variable is unused if the column already exists, can we move this in the if block.","commit_id":"8f64ee6c2fe431483151f90dce6bd34ae27dee75"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"6e5e9d929c30f653d74c0b7962292101235d3d13","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    meta \u003d MetaData(bind\u003dmigrate_engine)"},{"line_number":18,"context_line":"    transfers \u003d Table(\u0027transfers\u0027, meta, autoload\u003dTrue)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    source_project_id \u003d Column(\u0027source_project_id\u0027, String(255),"},{"line_number":21,"context_line":"                               nullable\u003dTrue)"},{"line_number":22,"context_line":"    if not hasattr(transfers.c, \u0027source_project_id\u0027):"},{"line_number":23,"context_line":"        transfers.create_column(source_project_id)"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_dee532d1","line":21,"range":{"start_line":20,"start_character":0,"end_line":21,"end_character":45},"in_reply_to":"3f79a3b5_9b8fccd1","updated":"2018-12-12 05:59:25.000000000","message":"+1","commit_id":"8f64ee6c2fe431483151f90dce6bd34ae27dee75"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"10d11b1840f6c936a8c8a4c2246bfaf83ea2bee8","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    if not hasattr(transfers.c, \u0027source_project_id\u0027):"},{"line_number":23,"context_line":"        transfers.create_column(source_project_id)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    destination_project_id \u003d Column(\u0027destination_project_id\u0027, String(255),"},{"line_number":26,"context_line":"                                    nullable\u003dTrue)"},{"line_number":27,"context_line":"    if not hasattr(transfers.c, \u0027destination_project_id\u0027):"},{"line_number":28,"context_line":"        transfers.create_column(destination_project_id)"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_3b9478e6","line":26,"range":{"start_line":25,"start_character":4,"end_line":26,"end_character":50},"updated":"2018-12-12 04:32:27.000000000","message":"same","commit_id":"8f64ee6c2fe431483151f90dce6bd34ae27dee75"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"10d11b1840f6c936a8c8a4c2246bfaf83ea2bee8","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    if not hasattr(transfers.c, \u0027destination_project_id\u0027):"},{"line_number":28,"context_line":"        transfers.create_column(destination_project_id)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    accepted \u003d Column(\u0027accepted\u0027, Boolean, default\u003dFalse)"},{"line_number":31,"context_line":"    if not hasattr(transfers.c, \u0027accepted\u0027):"},{"line_number":32,"context_line":"        transfers.create_column(accepted)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_5b99341b","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":57},"updated":"2018-12-12 04:32:27.000000000","message":"same","commit_id":"8f64ee6c2fe431483151f90dce6bd34ae27dee75"}],"cinder/tests/unit/db/test_migrations.py":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"e0986c0ecaf3bc750374f8d30906c0bd9ecb37dc","unresolved":false,"context_lines":[{"line_number":409,"context_line":"        volume_transfer \u003d db_utils.get_table(engine, \u0027transfers\u0027)"},{"line_number":410,"context_line":"        self.assertIn(\u0027no_snapshots\u0027, volume_transfer.c)"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"    def _check_123(self, engine, data):"},{"line_number":413,"context_line":"        volume_transfer \u003d db_utils.get_table(engine, \u0027transfers\u0027)"},{"line_number":414,"context_line":"        self.assertIn(\u0027original_project_id\u0027, volume_transfer.c)"},{"line_number":415,"context_line":"        self.assertIn(\u0027current_project_id\u0027, volume_transfer.c)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_9e0add26","line":412,"range":{"start_line":412,"start_character":15,"end_line":412,"end_character":18},"updated":"2018-11-06 06:53:49.000000000","message":"127","commit_id":"4713f90c6be34adc16f5e23692e0ce89ef11e26f"}]}