)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fdeba17b935dc04b1d11445119db9f9c015d2e05","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating QoS specs, convert float type value of QoS specs"},{"line_number":10,"context_line":"to integer, if float type QoS specs passed to driver directly,"},{"line_number":11,"context_line":"unexpected error may happend."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib80c9a469189a34401784041db15f9714b967058"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_9525a518","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":16},"updated":"2018-11-08 07:57:57.000000000","message":"can you please elaborate on this","commit_id":"2d0942bee814df29e438a3520fa13852b37066cc"},{"author":{"_account_id":26114,"name":"Yong Huang","email":"yong.huang@emc.com","username":"yong.huang"},"change_message_id":"02e7fb63f3b908e1f0bd36e2a847dca1ce7cc22b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating QoS specs, convert float type value of QoS specs"},{"line_number":10,"context_line":"to integer, if float type QoS specs passed to driver directly,"},{"line_number":11,"context_line":"unexpected error may happend."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib80c9a469189a34401784041db15f9714b967058"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_d329dc39","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":16},"in_reply_to":"3f79a3b5_9525a518","updated":"2018-11-09 08:20:19.000000000","message":"Done. There are also some discussions in review https://review.openstack.org/#/c/598090/","commit_id":"2d0942bee814df29e438a3520fa13852b37066cc"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4c4de06a0ceac33897751d5853419e6f2375c818","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Convert float type value of QoS specs to interger"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating QoS specs, convert float type value of QoS specs"},{"line_number":10,"context_line":"to integer, if float type QoS specs passed to driver directly,"},{"line_number":11,"context_line":"unexpected error may happened. For example, Dell EMC Unity not"},{"line_number":12,"context_line":"support float type QoS value, it will raise exception if float"},{"line_number":13,"context_line":"passed. Since float type value is not make sense for QoS (iops,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_0d42943d","line":10,"range":{"start_line":10,"start_character":35,"end_line":10,"end_character":42},"updated":"2018-11-14 05:24:48.000000000","message":"values are passed","commit_id":"1b122355122d2380fb38d2b4acd5f0223a0a1829"},{"author":{"_account_id":26114,"name":"Yong Huang","email":"yong.huang@emc.com","username":"yong.huang"},"change_message_id":"a832fd1483f28d1057a23764b211dc1a7c12c60e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Convert float type value of QoS specs to interger"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating QoS specs, convert float type value of QoS specs"},{"line_number":10,"context_line":"to integer, if float type QoS specs passed to driver directly,"},{"line_number":11,"context_line":"unexpected error may happened. For example, Dell EMC Unity not"},{"line_number":12,"context_line":"support float type QoS value, it will raise exception if float"},{"line_number":13,"context_line":"passed. Since float type value is not make sense for QoS (iops,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_56f3c26e","line":10,"range":{"start_line":10,"start_character":35,"end_line":10,"end_character":42},"in_reply_to":"3f79a3b5_0d42943d","updated":"2018-11-22 02:37:11.000000000","message":"Done","commit_id":"1b122355122d2380fb38d2b4acd5f0223a0a1829"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4c4de06a0ceac33897751d5853419e6f2375c818","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating QoS specs, convert float type value of QoS specs"},{"line_number":10,"context_line":"to integer, if float type QoS specs passed to driver directly,"},{"line_number":11,"context_line":"unexpected error may happened. For example, Dell EMC Unity not"},{"line_number":12,"context_line":"support float type QoS value, it will raise exception if float"},{"line_number":13,"context_line":"passed. Since float type value is not make sense for QoS (iops,"},{"line_number":14,"context_line":"bandwidth should be integer), so convert it to integer in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_cd6d7ccf","line":11,"range":{"start_line":11,"start_character":58,"end_line":11,"end_character":62},"updated":"2018-11-14 05:24:48.000000000","message":"does not","commit_id":"1b122355122d2380fb38d2b4acd5f0223a0a1829"},{"author":{"_account_id":26114,"name":"Yong Huang","email":"yong.huang@emc.com","username":"yong.huang"},"change_message_id":"a832fd1483f28d1057a23764b211dc1a7c12c60e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating QoS specs, convert float type value of QoS specs"},{"line_number":10,"context_line":"to integer, if float type QoS specs passed to driver directly,"},{"line_number":11,"context_line":"unexpected error may happened. For example, Dell EMC Unity not"},{"line_number":12,"context_line":"support float type QoS value, it will raise exception if float"},{"line_number":13,"context_line":"passed. Since float type value is not make sense for QoS (iops,"},{"line_number":14,"context_line":"bandwidth should be integer), so convert it to integer in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_76f03e61","line":11,"range":{"start_line":11,"start_character":58,"end_line":11,"end_character":62},"in_reply_to":"3f79a3b5_cd6d7ccf","updated":"2018-11-22 02:37:11.000000000","message":"Done","commit_id":"1b122355122d2380fb38d2b4acd5f0223a0a1829"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4c4de06a0ceac33897751d5853419e6f2375c818","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to integer, if float type QoS specs passed to driver directly,"},{"line_number":11,"context_line":"unexpected error may happened. For example, Dell EMC Unity not"},{"line_number":12,"context_line":"support float type QoS value, it will raise exception if float"},{"line_number":13,"context_line":"passed. Since float type value is not make sense for QoS (iops,"},{"line_number":14,"context_line":"bandwidth should be integer), so convert it to integer in"},{"line_number":15,"context_line":"Cinder API."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_ad6cc0cf","line":13,"range":{"start_line":13,"start_character":31,"end_line":13,"end_character":33},"updated":"2018-11-14 05:24:48.000000000","message":"does","commit_id":"1b122355122d2380fb38d2b4acd5f0223a0a1829"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4c4de06a0ceac33897751d5853419e6f2375c818","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to integer, if float type QoS specs passed to driver directly,"},{"line_number":11,"context_line":"unexpected error may happened. For example, Dell EMC Unity not"},{"line_number":12,"context_line":"support float type QoS value, it will raise exception if float"},{"line_number":13,"context_line":"passed. Since float type value is not make sense for QoS (iops,"},{"line_number":14,"context_line":"bandwidth should be integer), so convert it to integer in"},{"line_number":15,"context_line":"Cinder API."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_8d6784ed","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":6},"updated":"2018-11-14 05:24:48.000000000","message":"type value is passed","commit_id":"1b122355122d2380fb38d2b4acd5f0223a0a1829"},{"author":{"_account_id":26114,"name":"Yong Huang","email":"yong.huang@emc.com","username":"yong.huang"},"change_message_id":"a832fd1483f28d1057a23764b211dc1a7c12c60e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to integer, if float type QoS specs passed to driver directly,"},{"line_number":11,"context_line":"unexpected error may happened. For example, Dell EMC Unity not"},{"line_number":12,"context_line":"support float type QoS value, it will raise exception if float"},{"line_number":13,"context_line":"passed. Since float type value is not make sense for QoS (iops,"},{"line_number":14,"context_line":"bandwidth should be integer), so convert it to integer in"},{"line_number":15,"context_line":"Cinder API."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_168f8ad3","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":6},"in_reply_to":"3f79a3b5_8d6784ed","updated":"2018-11-22 02:37:11.000000000","message":"Done","commit_id":"1b122355122d2380fb38d2b4acd5f0223a0a1829"},{"author":{"_account_id":26114,"name":"Yong Huang","email":"yong.huang@emc.com","username":"yong.huang"},"change_message_id":"a832fd1483f28d1057a23764b211dc1a7c12c60e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to integer, if float type QoS specs passed to driver directly,"},{"line_number":11,"context_line":"unexpected error may happened. For example, Dell EMC Unity not"},{"line_number":12,"context_line":"support float type QoS value, it will raise exception if float"},{"line_number":13,"context_line":"passed. Since float type value is not make sense for QoS (iops,"},{"line_number":14,"context_line":"bandwidth should be integer), so convert it to integer in"},{"line_number":15,"context_line":"Cinder API."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_369406e7","line":13,"range":{"start_line":13,"start_character":31,"end_line":13,"end_character":33},"in_reply_to":"3f79a3b5_ad6cc0cf","updated":"2018-11-22 02:37:11.000000000","message":"Done","commit_id":"1b122355122d2380fb38d2b4acd5f0223a0a1829"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4c4de06a0ceac33897751d5853419e6f2375c818","unresolved":false,"context_lines":[{"line_number":11,"context_line":"unexpected error may happened. For example, Dell EMC Unity not"},{"line_number":12,"context_line":"support float type QoS value, it will raise exception if float"},{"line_number":13,"context_line":"passed. Since float type value is not make sense for QoS (iops,"},{"line_number":14,"context_line":"bandwidth should be integer), so convert it to integer in"},{"line_number":15,"context_line":"Cinder API."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ib80c9a469189a34401784041db15f9714b967058"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_0d5b7423","line":14,"range":{"start_line":14,"start_character":32,"end_line":14,"end_character":40},"updated":"2018-11-14 05:24:48.000000000","message":"we convert","commit_id":"1b122355122d2380fb38d2b4acd5f0223a0a1829"},{"author":{"_account_id":26114,"name":"Yong Huang","email":"yong.huang@emc.com","username":"yong.huang"},"change_message_id":"a832fd1483f28d1057a23764b211dc1a7c12c60e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"unexpected error may happened. For example, Dell EMC Unity not"},{"line_number":12,"context_line":"support float type QoS value, it will raise exception if float"},{"line_number":13,"context_line":"passed. Since float type value is not make sense for QoS (iops,"},{"line_number":14,"context_line":"bandwidth should be integer), so convert it to integer in"},{"line_number":15,"context_line":"Cinder API."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ib80c9a469189a34401784041db15f9714b967058"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_d694b2e8","line":14,"range":{"start_line":14,"start_character":32,"end_line":14,"end_character":40},"in_reply_to":"3f79a3b5_0d5b7423","updated":"2018-11-22 02:37:11.000000000","message":"Done","commit_id":"1b122355122d2380fb38d2b4acd5f0223a0a1829"}],"cinder/tests/unit/test_qos_specs.py":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"2808a232fde6ffa5a6189eb9b4c2f0acc0e8e012","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 eBay Inc."},{"line_number":2,"context_line":"# Copyright (c) 2013 OpenStack Foundation"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_7c69ff20","line":1,"updated":"2018-11-22 07:00:55.000000000","message":"unrelated change","commit_id":"5e6312f52b9cccc8a1f229c6fc7af49a7f6b0ca5"},{"author":{"_account_id":26114,"name":"Yong Huang","email":"yong.huang@emc.com","username":"yong.huang"},"change_message_id":"00e45ed52ae4222043506866cde27b940b7cac89","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 eBay Inc."},{"line_number":2,"context_line":"# Copyright (c) 2013 OpenStack Foundation"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_2e2a5fe4","line":1,"in_reply_to":"3f79a3b5_7c69ff20","updated":"2018-11-23 07:16:44.000000000","message":"Will recover it.","commit_id":"5e6312f52b9cccc8a1f229c6fc7af49a7f6b0ca5"}],"cinder/utils.py":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"dc0df6ef99dc34873e2feccaf9439163b6e93144","unresolved":false,"context_lines":[{"line_number":1163,"context_line":"                                min_length\u003d0, max_length\u003d255)"},{"line_number":1164,"context_line":""},{"line_number":1165,"context_line":""},{"line_number":1166,"context_line":"def validate_dictionary_values(specs):"},{"line_number":1167,"context_line":"    \"\"\"Check value type, translate float type value to integer.\"\"\""},{"line_number":1168,"context_line":"    return {key: str(as_int(value)) for key, value in specs.items()}"},{"line_number":1169,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_d620ceb0","line":1166,"range":{"start_line":1166,"start_character":4,"end_line":1166,"end_character":30},"updated":"2018-11-12 08:34:51.000000000","message":"maybe a better name can be found.\nMore precise for integer value check.","commit_id":"1b122355122d2380fb38d2b4acd5f0223a0a1829"},{"author":{"_account_id":26114,"name":"Yong Huang","email":"yong.huang@emc.com","username":"yong.huang"},"change_message_id":"9d0355ecf1ff604ec0825bf6dccc35e47cfd05e4","unresolved":false,"context_lines":[{"line_number":1163,"context_line":"                                min_length\u003d0, max_length\u003d255)"},{"line_number":1164,"context_line":""},{"line_number":1165,"context_line":""},{"line_number":1166,"context_line":"def validate_dictionary_values(specs):"},{"line_number":1167,"context_line":"    \"\"\"Check value type, translate float type value to integer.\"\"\""},{"line_number":1168,"context_line":"    return {key: str(as_int(value)) for key, value in specs.items()}"},{"line_number":1169,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_d6c6f214","line":1166,"range":{"start_line":1166,"start_character":4,"end_line":1166,"end_character":30},"in_reply_to":"3f79a3b5_d620ceb0","updated":"2018-11-22 02:35:43.000000000","message":"Done","commit_id":"1b122355122d2380fb38d2b4acd5f0223a0a1829"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c0c6dea7649e7a5660bc9a74c89c7fe73c4cc2ea","unresolved":false,"context_lines":[{"line_number":1163,"context_line":"                                min_length\u003d0, max_length\u003d255)"},{"line_number":1164,"context_line":""},{"line_number":1165,"context_line":""},{"line_number":1166,"context_line":"def convert_dictionary_values_if_needed(specs):"},{"line_number":1167,"context_line":"    \"\"\"Check value type, convert float type value to integer.\"\"\""},{"line_number":1168,"context_line":"    return {key: str(as_int(value)) for key, value in specs.items()}"},{"line_number":1169,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_902b1a94","line":1166,"range":{"start_line":1166,"start_character":4,"end_line":1166,"end_character":39},"updated":"2019-03-29 13:42:47.000000000","message":"This should have a more meaningful name, like \"convert_dict_float_values_to_ints()\".","commit_id":"5e6312f52b9cccc8a1f229c6fc7af49a7f6b0ca5"},{"author":{"_account_id":26114,"name":"Yong Huang","email":"yong.huang@emc.com","username":"yong.huang"},"change_message_id":"6d8cc71540cd198bc8030de634fc64b2fc436b41","unresolved":false,"context_lines":[{"line_number":1163,"context_line":"                                min_length\u003d0, max_length\u003d255)"},{"line_number":1164,"context_line":""},{"line_number":1165,"context_line":""},{"line_number":1166,"context_line":"def convert_dictionary_values_if_needed(specs):"},{"line_number":1167,"context_line":"    \"\"\"Check value type, convert float type value to integer.\"\"\""},{"line_number":1168,"context_line":"    return {key: str(as_int(value)) for key, value in specs.items()}"},{"line_number":1169,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_d4bdd202","line":1166,"range":{"start_line":1166,"start_character":4,"end_line":1166,"end_character":39},"in_reply_to":"5fc1f717_902b1a94","updated":"2019-04-03 06:35:33.000000000","message":"Done","commit_id":"5e6312f52b9cccc8a1f229c6fc7af49a7f6b0ca5"}],"cinder/volume/qos_specs.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4c4de06a0ceac33897751d5853419e6f2375c818","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    # Validate the key-value pairs in the qos spec."},{"line_number":53,"context_line":"    utils.validate_dictionary_string_length(specs)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    # Validate the value type in the qos spec."},{"line_number":56,"context_line":"    specs \u003d utils.validate_dictionary_values(specs)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    consumer \u003d specs.get(\u0027consumer\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_ed495865","line":55,"range":{"start_line":55,"start_character":6,"end_line":55,"end_character":14},"updated":"2018-11-14 05:24:48.000000000","message":"This isn\u0027t validating, rather converting values","commit_id":"1b122355122d2380fb38d2b4acd5f0223a0a1829"},{"author":{"_account_id":26114,"name":"Yong Huang","email":"yong.huang@emc.com","username":"yong.huang"},"change_message_id":"a832fd1483f28d1057a23764b211dc1a7c12c60e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    # Validate the key-value pairs in the qos spec."},{"line_number":53,"context_line":"    utils.validate_dictionary_string_length(specs)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    # Validate the value type in the qos spec."},{"line_number":56,"context_line":"    specs \u003d utils.validate_dictionary_values(specs)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    consumer \u003d specs.get(\u0027consumer\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_b6fa5641","line":55,"range":{"start_line":55,"start_character":6,"end_line":55,"end_character":14},"in_reply_to":"3f79a3b5_ed495865","updated":"2018-11-22 02:37:11.000000000","message":"Done","commit_id":"1b122355122d2380fb38d2b4acd5f0223a0a1829"}]}