)]}'
{"cinder/zonemanager/drivers/brocade/brcd_fabric_opts.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"f3404a9f92af1b5b2a5a92f39d2880fde2f9b17e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"brcd_zone_opts \u003d ["},{"line_number":22,"context_line":"    cfg.StrOpt(\u0027fc_southbound_protocol\u0027,"},{"line_number":23,"context_line":"               default\u003d\u0027HTTP\u0027,"},{"line_number":24,"context_line":"               choices\u003d(\u0027SSH\u0027, \u0027HTTP\u0027, \u0027HTTPS\u0027, \u0027REST_HTTP\u0027, \u0027REST_HTTPS\u0027),"},{"line_number":25,"context_line":"               help\u003d\u0027South bound connector for the fabric.\u0027),"},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027fc_fabric_address\u0027,"},{"line_number":27,"context_line":"               default\u003d\u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"9fdfeff1_e80973dc","line":24,"updated":"2019-02-15 23:44:47.000000000","message":"these options seem confusing a bit.  \n\nWhat\u0027s the difference between HTTP and REST_HTTP ?\nShouldn\u0027t we document this in the help or documentation somewhere?","commit_id":"ffa9159401f30042857725bad7d90773340754cb"}],"cinder/zonemanager/drivers/brocade/brcd_fc_zone_driver.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"afe91a93d45321e02306c0cbe2dde420f47d5ab4","unresolved":false,"context_lines":[{"line_number":27,"context_line":":zone_name_prefix: Used by: class: \u0027FCZoneDriver\u0027. Defaults to \u0027openstack\u0027"},{"line_number":28,"context_line":"\"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"import six"},{"line_number":31,"context_line":"import string"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"from oslo_concurrency import lockutils"}],"source_content_type":"text/x-python","patch_set":9,"id":"bfdaf3ff_76c228ec","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":10},"updated":"2019-01-10 20:52:39.000000000","message":"This line should be moved right after oslo imports","commit_id":"e9852e03e0be87f46bfe312ec5136f8ad0fc5f18"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"78b4fd21244430d26153cecd9b5328932714eca5","unresolved":false,"context_lines":[{"line_number":27,"context_line":":zone_name_prefix: Used by: class: \u0027FCZoneDriver\u0027. Defaults to \u0027openstack\u0027"},{"line_number":28,"context_line":"\"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"import six"},{"line_number":31,"context_line":"import string"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"from oslo_concurrency import lockutils"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_1f186fd1","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":10},"in_reply_to":"bfdaf3ff_76c228ec","updated":"2019-02-05 23:22:18.000000000","message":"Done","commit_id":"e9852e03e0be87f46bfe312ec5136f8ad0fc5f18"}],"cinder/zonemanager/drivers/brocade/brcd_rest_fc_zone_client.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"51374ba68a649b80356348ce39b739ed8a85a593","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\"\"\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import json"},{"line_number":22,"context_line":"from oslo_log import log as logging"},{"line_number":23,"context_line":"from oslo_serialization import base64"},{"line_number":24,"context_line":"import requests"},{"line_number":25,"context_line":"import six"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_7502db0f","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":37},"updated":"2018-11-15 04:52:08.000000000","message":"third party imports are defined after standard imports","commit_id":"f87cf84e4c01888c4ac1ca53267dc5206dedaee0"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"d87a014f81bdb33d59d4d33e0be69d03b7c7288a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\"\"\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import json"},{"line_number":22,"context_line":"from oslo_log import log as logging"},{"line_number":23,"context_line":"from oslo_serialization import base64"},{"line_number":24,"context_line":"import requests"},{"line_number":25,"context_line":"import six"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_5bd85450","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":37},"in_reply_to":"3f79a3b5_7502db0f","updated":"2018-11-29 10:33:16.000000000","message":"Done","commit_id":"f87cf84e4c01888c4ac1ca53267dc5206dedaee0"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"afe91a93d45321e02306c0cbe2dde420f47d5ab4","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                active_cfg_name \u003d effective_cfg[rest_constant.CFG_NAME]"},{"line_number":180,"context_line":"                zones \u003d effective_cfg[rest_constant.ENABLED_ZONE]"},{"line_number":181,"context_line":"                if type(zones) is list:"},{"line_number":182,"context_line":"                    i \u003d 0"},{"line_number":183,"context_line":"                    for zone in zones:"},{"line_number":184,"context_line":"                        zones_map.update({zones[i][rest_constant.ZONE_NAME]:"},{"line_number":185,"context_line":"                                          zones[i][rest_constant.MEMBER_ENTRY]"},{"line_number":186,"context_line":"                                                  [rest_constant.ENTRY_NAME]})"},{"line_number":187,"context_line":"                        i \u003d i + 1"},{"line_number":188,"context_line":"                else:"},{"line_number":189,"context_line":"                    zones_map.update({zones[rest_constant.ZONE_NAME]:"},{"line_number":190,"context_line":"                                      zones[rest_constant.MEMBER_ENTRY]"}],"source_content_type":"text/x-python","patch_set":9,"id":"bfdaf3ff_967f8caa","line":187,"range":{"start_line":182,"start_character":19,"end_line":187,"end_character":33},"updated":"2019-01-10 20:52:39.000000000","message":"Please, change it to:\nfor i, zone in enumerate(zones):\n                        zones_map.update({zones[i][rest_constant.ZONE_NAME]:\n                                          zones[i][rest_constant.MEMBER_ENTRY]\n                                                  [rest_constant.ENTRY_NAME]})\n\nI will be more pythonic","commit_id":"e9852e03e0be87f46bfe312ec5136f8ad0fc5f18"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"78b4fd21244430d26153cecd9b5328932714eca5","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                active_cfg_name \u003d effective_cfg[rest_constant.CFG_NAME]"},{"line_number":180,"context_line":"                zones \u003d effective_cfg[rest_constant.ENABLED_ZONE]"},{"line_number":181,"context_line":"                if type(zones) is list:"},{"line_number":182,"context_line":"                    i \u003d 0"},{"line_number":183,"context_line":"                    for zone in zones:"},{"line_number":184,"context_line":"                        zones_map.update({zones[i][rest_constant.ZONE_NAME]:"},{"line_number":185,"context_line":"                                          zones[i][rest_constant.MEMBER_ENTRY]"},{"line_number":186,"context_line":"                                                  [rest_constant.ENTRY_NAME]})"},{"line_number":187,"context_line":"                        i \u003d i + 1"},{"line_number":188,"context_line":"                else:"},{"line_number":189,"context_line":"                    zones_map.update({zones[rest_constant.ZONE_NAME]:"},{"line_number":190,"context_line":"                                      zones[rest_constant.MEMBER_ENTRY]"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_ff124bb4","line":187,"range":{"start_line":182,"start_character":19,"end_line":187,"end_character":33},"in_reply_to":"bfdaf3ff_967f8caa","updated":"2019-02-05 23:22:18.000000000","message":"Done","commit_id":"e9852e03e0be87f46bfe312ec5136f8ad0fc5f18"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"afe91a93d45321e02306c0cbe2dde420f47d5ab4","unresolved":false,"context_lines":[{"line_number":189,"context_line":"                    zones_map.update({zones[rest_constant.ZONE_NAME]:"},{"line_number":190,"context_line":"                                      zones[rest_constant.MEMBER_ENTRY]"},{"line_number":191,"context_line":"                                           [rest_constant.ENTRY_NAME]})"},{"line_number":192,"context_line":"            except Exception:"},{"line_number":193,"context_line":"                active_cfg_name \u003d \u0027\u0027"},{"line_number":194,"context_line":"            LOG.info(\"REST get effective zoneset success: \""},{"line_number":195,"context_line":"                     \"active cfg: %(cfg_name)s, checksum: %(chksum)s\","}],"source_content_type":"text/x-python","patch_set":9,"id":"bfdaf3ff_b67c10b6","line":192,"updated":"2019-01-10 20:52:39.000000000","message":"Can we catch less general exception here? Do we need any logs here?","commit_id":"e9852e03e0be87f46bfe312ec5136f8ad0fc5f18"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"78b4fd21244430d26153cecd9b5328932714eca5","unresolved":false,"context_lines":[{"line_number":189,"context_line":"                    zones_map.update({zones[rest_constant.ZONE_NAME]:"},{"line_number":190,"context_line":"                                      zones[rest_constant.MEMBER_ENTRY]"},{"line_number":191,"context_line":"                                           [rest_constant.ENTRY_NAME]})"},{"line_number":192,"context_line":"            except Exception:"},{"line_number":193,"context_line":"                active_cfg_name \u003d \u0027\u0027"},{"line_number":194,"context_line":"            LOG.info(\"REST get effective zoneset success: \""},{"line_number":195,"context_line":"                     \"active cfg: %(cfg_name)s, checksum: %(chksum)s\","}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_3f4773bf","line":192,"in_reply_to":"bfdaf3ff_b67c10b6","updated":"2019-02-05 23:22:18.000000000","message":"This only happens when trying to parse the JSON response and the active_zone_name is not found because the zone database on the switch is empty.  No logs are needed as this is a valid case in the field.","commit_id":"e9852e03e0be87f46bfe312ec5136f8ad0fc5f18"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ea64799d55f7d6b6009eade75ace998dda68ae32","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\"\"\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import json"},{"line_number":22,"context_line":"import requests"},{"line_number":23,"context_line":"import six"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from oslo_log import log as logging"},{"line_number":26,"context_line":"from oslo_serialization import base64"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_ff600b38","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":10},"updated":"2019-02-05 23:33:36.000000000","message":"These two are third party libs, so technically they should be grouped with the oslo imports.","commit_id":"ce3549bf07e012e367521d897bd69d3f83fd62ce"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"b26d2f96a2064d261d607399ca258b7553c49ceb","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\"\"\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import json"},{"line_number":22,"context_line":"import requests"},{"line_number":23,"context_line":"import six"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from oslo_log import log as logging"},{"line_number":26,"context_line":"from oslo_serialization import base64"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_2c02ae0a","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":10},"in_reply_to":"9fdfeff1_ff600b38","updated":"2019-02-09 09:21:08.000000000","message":"Done","commit_id":"ce3549bf07e012e367521d897bd69d3f83fd62ce"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ea64799d55f7d6b6009eade75ace998dda68ae32","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from cinder import exception"},{"line_number":29,"context_line":"from cinder.i18n import _"},{"line_number":30,"context_line":"import cinder.zonemanager.drivers.brocade.fc_zone_constants as zone_constant"},{"line_number":31,"context_line":"import cinder.zonemanager.drivers.brocade.rest_constants as rest_constant"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_df5f4770","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":56},"updated":"2019-02-05 23:33:36.000000000","message":"from  cinder.zonemanager.drivers.brocade import rest_constants","commit_id":"ce3549bf07e012e367521d897bd69d3f83fd62ce"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"b26d2f96a2064d261d607399ca258b7553c49ceb","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from cinder import exception"},{"line_number":29,"context_line":"from cinder.i18n import _"},{"line_number":30,"context_line":"import cinder.zonemanager.drivers.brocade.fc_zone_constants as zone_constant"},{"line_number":31,"context_line":"import cinder.zonemanager.drivers.brocade.rest_constants as rest_constant"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_cc08c229","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":56},"in_reply_to":"9fdfeff1_df5f4770","updated":"2019-02-09 09:21:08.000000000","message":"Done","commit_id":"ce3549bf07e012e367521d897bd69d3f83fd62ce"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ea64799d55f7d6b6009eade75ace998dda68ae32","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        self._logout()"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def _login(self):"},{"line_number":97,"context_line":"        credentials \u003d base64.encode_as_text(\u0027%s:%s\u0027 % (self.sw_user,"},{"line_number":98,"context_line":"                                            self.sw_pwd)).replace(\u0027\\n\u0027, \u0027\u0027)"},{"line_number":99,"context_line":"        auth_headers \u003d {rest_constant.USER_AGENT: rest_constant.ZONE_DRIVER,"},{"line_number":100,"context_line":"                        rest_constant.ACCEPT: rest_constant.YANG,"},{"line_number":101,"context_line":"                        rest_constant.AUTHORIZATION: \"Basic %s\" % credentials}"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_9fff7f33","line":98,"range":{"start_line":97,"start_character":22,"end_line":98,"end_character":75},"updated":"2019-02-05 23:33:36.000000000","message":"It doesn\u0027t look like you\u0027re actually using self.session, but if you do, this is maybe easier done with:\n\nself.session \u003d requests.Session()\nself.session.auth \u003d (self.sw_user, self.sw_pwd)\n\nIt may simplify other calls by using a session and you could refactor this slightly to get rid of the need to keep self.sw_pwd in memory.","commit_id":"ce3549bf07e012e367521d897bd69d3f83fd62ce"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"b26d2f96a2064d261d607399ca258b7553c49ceb","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        self._logout()"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def _login(self):"},{"line_number":97,"context_line":"        credentials \u003d base64.encode_as_text(\u0027%s:%s\u0027 % (self.sw_user,"},{"line_number":98,"context_line":"                                            self.sw_pwd)).replace(\u0027\\n\u0027, \u0027\u0027)"},{"line_number":99,"context_line":"        auth_headers \u003d {rest_constant.USER_AGENT: rest_constant.ZONE_DRIVER,"},{"line_number":100,"context_line":"                        rest_constant.ACCEPT: rest_constant.YANG,"},{"line_number":101,"context_line":"                        rest_constant.AUTHORIZATION: \"Basic %s\" % credentials}"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_ec0b4621","line":98,"range":{"start_line":97,"start_character":22,"end_line":98,"end_character":75},"in_reply_to":"9fdfeff1_9fff7f33","updated":"2019-02-09 09:21:08.000000000","message":"Done","commit_id":"ce3549bf07e012e367521d897bd69d3f83fd62ce"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ea64799d55f7d6b6009eade75ace998dda68ae32","unresolved":false,"context_lines":[{"line_number":398,"context_line":"            raise exception.BrocadeZoningRestException(reason\u003dmsg)"},{"line_number":399,"context_line":"        return checksum"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    def _buildUrl(self, path):"},{"line_number":402,"context_line":"        protocol \u003d zone_constant.HTTP"},{"line_number":403,"context_line":"        if self.protocol \u003d\u003d zone_constant.PROTOCOL_HTTPS:"},{"line_number":404,"context_line":"            protocol \u003d zone_constant.HTTPS"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_5fa7d750","line":401,"range":{"start_line":401,"start_character":8,"end_line":401,"end_character":17},"updated":"2019-02-05 23:33:36.000000000","message":"_build_url would be a better Pythonic name.","commit_id":"ce3549bf07e012e367521d897bd69d3f83fd62ce"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"b26d2f96a2064d261d607399ca258b7553c49ceb","unresolved":false,"context_lines":[{"line_number":398,"context_line":"            raise exception.BrocadeZoningRestException(reason\u003dmsg)"},{"line_number":399,"context_line":"        return checksum"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    def _buildUrl(self, path):"},{"line_number":402,"context_line":"        protocol \u003d zone_constant.HTTP"},{"line_number":403,"context_line":"        if self.protocol \u003d\u003d zone_constant.PROTOCOL_HTTPS:"},{"line_number":404,"context_line":"            protocol \u003d zone_constant.HTTPS"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_8c12ba57","line":401,"range":{"start_line":401,"start_character":8,"end_line":401,"end_character":17},"in_reply_to":"9fdfeff1_5fa7d750","updated":"2019-02-09 09:21:08.000000000","message":"Done","commit_id":"ce3549bf07e012e367521d897bd69d3f83fd62ce"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ea64799d55f7d6b6009eade75ace998dda68ae32","unresolved":false,"context_lines":[{"line_number":404,"context_line":"            protocol \u003d zone_constant.HTTPS"},{"line_number":405,"context_line":"        url \u003d protocol + \"://\" + self.sw_ip + path"},{"line_number":406,"context_line":"        if self.vfid is not None:"},{"line_number":407,"context_line":"            url \u003d url + \"?vf-id\u003d\" + str(self.vfid)"},{"line_number":408,"context_line":"        return url"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_3f7f73ac","line":407,"range":{"start_line":407,"start_character":36,"end_line":407,"end_character":40},"updated":"2019-02-05 23:33:36.000000000","message":"Instead of string concatenation and needing to explicitly convert to a string, it would be better if you did string formatting for these:\n\nurl \u003d \u0027%s?vf-id\u003d%s\u0027 % (url, self.vfid)\n\nSame above with setting url.","commit_id":"ce3549bf07e012e367521d897bd69d3f83fd62ce"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"b26d2f96a2064d261d607399ca258b7553c49ceb","unresolved":false,"context_lines":[{"line_number":404,"context_line":"            protocol \u003d zone_constant.HTTPS"},{"line_number":405,"context_line":"        url \u003d protocol + \"://\" + self.sw_ip + path"},{"line_number":406,"context_line":"        if self.vfid is not None:"},{"line_number":407,"context_line":"            url \u003d url + \"?vf-id\u003d\" + str(self.vfid)"},{"line_number":408,"context_line":"        return url"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_ac0d3e36","line":407,"range":{"start_line":407,"start_character":36,"end_line":407,"end_character":40},"in_reply_to":"9fdfeff1_3f7f73ac","updated":"2019-02-09 09:21:08.000000000","message":"Done","commit_id":"ce3549bf07e012e367521d897bd69d3f83fd62ce"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b7c75ba7778492984f133d77e8aea4070b10b853","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from cinder import exception"},{"line_number":29,"context_line":"from cinder.i18n import _"},{"line_number":30,"context_line":"from cinder.zonemanager.drivers.brocade import fc_zone_constants"},{"line_number":31,"context_line":"from cinder.zonemanager.drivers.brocade import rest_constants as rest_constant"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_da8922ca","line":31,"range":{"start_line":31,"start_character":61,"end_line":31,"end_character":78},"updated":"2019-02-12 21:10:11.000000000","message":"Why is this being renamed to drop the s? Would be better to just not alias it and use the full name.","commit_id":"7b8773f7982a9812ab39f5f72d1d6153dffe5123"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"4bbe8b17677a70d28229aae3bb4c0c86f73fe2bc","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from cinder import exception"},{"line_number":29,"context_line":"from cinder.i18n import _"},{"line_number":30,"context_line":"from cinder.zonemanager.drivers.brocade import fc_zone_constants"},{"line_number":31,"context_line":"from cinder.zonemanager.drivers.brocade import rest_constants as rest_constant"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_f3da1176","line":31,"range":{"start_line":31,"start_character":61,"end_line":31,"end_character":78},"in_reply_to":"9fdfeff1_da8922ca","updated":"2019-02-12 22:56:07.000000000","message":"Done","commit_id":"7b8773f7982a9812ab39f5f72d1d6153dffe5123"}]}