)]}'
{"cinder/tests/unit/volume/test_volume.py":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"a8bc8c8aec97502584d828969a2a2ba61e5279fc","unresolved":false,"context_lines":[{"line_number":2609,"context_line":"                                               size\u003d3,"},{"line_number":2610,"context_line":"                                               status\u003d\u0027creating\u0027,"},{"line_number":2611,"context_line":"                                               host\u003dCONF.host)"},{"line_number":2612,"context_line":"        self.volume.create_volume(self.context, volume_src)"},{"line_number":2613,"context_line":""},{"line_number":2614,"context_line":"        volume_src \u003d db.volume_get(self.context, volume_src[\u0027id\u0027])"},{"line_number":2615,"context_line":""},{"line_number":2616,"context_line":"        self.assertRaises(exception.InvalidInput,"},{"line_number":2617,"context_line":"                          volume_api.create,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_d32b122f","line":2614,"range":{"start_line":2612,"start_character":7,"end_line":2614,"end_character":66},"updated":"2018-11-27 18:47:14.000000000","message":"I\u0027m not familiar with testing the volume API that\u0027s why my question could be silly.\n\nWhy don\u0027t you just do :\n\n     volume_src \u003d self.volume.create_volume(self.context, volume_src)","commit_id":"05cd766e2fc8fbf5c7de79f54525b4d06a87f823"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"6c3e50cc4e09f2aace4999afa2beb9bd85157fe2","unresolved":false,"context_lines":[{"line_number":2608,"context_line":"                                               status\u003d\u0027available\u0027,"},{"line_number":2609,"context_line":"                                               host\u003dCONF.host)"},{"line_number":2610,"context_line":""},{"line_number":2611,"context_line":"        volume_api \u003d cinder.volume.api.API()"},{"line_number":2612,"context_line":""},{"line_number":2613,"context_line":"        self.assertRaises(exception.InvalidInput,"},{"line_number":2614,"context_line":"                          volume_api.create,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_9a4a6d23","line":2611,"updated":"2018-11-29 02:33:56.000000000","message":"-1 You\u0027d better to use self.volume_api, no need to define.\nhttps://github.com/openstack/cinder/blob/master/cinder/tests/unit/volume/__init__.py#L82","commit_id":"294f5ded037ecc990cb8211833f3be56b6ad38a2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e907dd2468e54f04a59aaa9426550fec67cf8e63","unresolved":false,"context_lines":[{"line_number":2608,"context_line":"                                               status\u003d\u0027available\u0027,"},{"line_number":2609,"context_line":"                                               host\u003dCONF.host)"},{"line_number":2610,"context_line":""},{"line_number":2611,"context_line":"        volume_api \u003d cinder.volume.api.API()"},{"line_number":2612,"context_line":""},{"line_number":2613,"context_line":"        self.assertRaises(exception.InvalidInput,"},{"line_number":2614,"context_line":"                          volume_api.create,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_68430b48","line":2611,"in_reply_to":"3f79a3b5_9a4a6d23","updated":"2018-11-29 06:18:26.000000000","message":"+1.\nThis is a result of taking reference from some of the older tests.\nWe can have another patch to remove these redundancies from other tests too like in L#2563 ...","commit_id":"294f5ded037ecc990cb8211833f3be56b6ad38a2"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"6c3e50cc4e09f2aace4999afa2beb9bd85157fe2","unresolved":false,"context_lines":[{"line_number":2611,"context_line":"        volume_api \u003d cinder.volume.api.API()"},{"line_number":2612,"context_line":""},{"line_number":2613,"context_line":"        self.assertRaises(exception.InvalidInput,"},{"line_number":2614,"context_line":"                          volume_api.create,"},{"line_number":2615,"context_line":"                          self.context,"},{"line_number":2616,"context_line":"                          size\u003d1,"},{"line_number":2617,"context_line":"                          name\u003d\u0027fake_name\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_5a5615d3","line":2614,"updated":"2018-11-29 02:33:56.000000000","message":"self.volume_api.create","commit_id":"294f5ded037ecc990cb8211833f3be56b6ad38a2"}]}