)]}'
{"cinder/image/image_utils.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8a6d7ae82fa961b3d4e874d84a1b9ad4e74af63b","unresolved":false,"context_lines":[{"line_number":247,"context_line":"                conversion_dir \u003d os.path.dirname(conversion_dir)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"            raise exception.InsufficientConversionSpace("},{"line_number":250,"context_line":"                location\u003dconversion_dir)"},{"line_number":251,"context_line":"        raise"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    duration \u003d timeutils.delta_seconds(start_time, timeutils.utcnow())"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_3091e351","line":250,"updated":"2018-12-12 17:04:10.000000000","message":"The directory should just be logged here -- there isn\u0027t a reason to attach it to an exception since this is admin-only info that should only show up in the log file and nowhere else.","commit_id":"6b174b8d30d821d1ab5bb2eae79c6e6bee1be689"},{"author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"change_message_id":"39ffc2e23eb56adb20fbedf0ebd94a95d132cca5","unresolved":false,"context_lines":[{"line_number":247,"context_line":"                conversion_dir \u003d os.path.dirname(conversion_dir)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"            raise exception.InsufficientConversionSpace("},{"line_number":250,"context_line":"                location\u003dconversion_dir)"},{"line_number":251,"context_line":"        raise"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    duration \u003d timeutils.delta_seconds(start_time, timeutils.utcnow())"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_126f0030","line":250,"in_reply_to":"3f79a3b5_3091e351","updated":"2018-12-13 06:46:50.000000000","message":"Agree. And add a new exception seems too heavy here. Code modified!","commit_id":"6b174b8d30d821d1ab5bb2eae79c6e6bee1be689"}],"cinder/tests/unit/test_image_utils.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"fa933002ab94aa360acce0ebdb4f8fe33b38dca9","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        self.assertRaises(processutils.ProcessExecutionError,"},{"line_number":313,"context_line":"                          image_utils.convert_image,"},{"line_number":314,"context_line":"                          source, dest, out_format)"},{"line_number":315,"context_line":"        mock_log.assert_called_with(\u0027Insufficient free space on fakedir for\u0027"},{"line_number":316,"context_line":"                                    \u0027 imageconversion.\u0027)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_489793ea","line":315,"updated":"2018-12-19 16:35:16.000000000","message":"Really not a fan of asserting on logging text in unit tests.","commit_id":"5ca4c3573b1f2020a87530aabe96b0d7307e5038"}]}