)]}'
{"cinder/tests/unit/volume/test_volume_retype.py":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"ddc8951be9592592f62c7fb589071c4cff296809","unresolved":false,"context_lines":[{"line_number":148,"context_line":"             ])"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def test_retype_driver_not_initialized(self):"},{"line_number":151,"context_line":"        volume_types.create(self.context,"},{"line_number":152,"context_line":"                            \"new_vol_type\","},{"line_number":153,"context_line":"                            {},"},{"line_number":154,"context_line":"                            description\u003d\"new_type\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_21d93e26","line":151,"updated":"2018-11-20 19:22:20.000000000","message":"Why do we need to create a new type instead of using \u0027fake_vol_type\u0027?","commit_id":"dafe7b0b7d77659dd355b0dfa2b11b7b1740e1d6"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8ed3387146ea226337f49c5c00beab0a3f0ead4c","unresolved":false,"context_lines":[{"line_number":148,"context_line":"             ])"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def test_retype_driver_not_initialized(self):"},{"line_number":151,"context_line":"        volume_types.create(self.context,"},{"line_number":152,"context_line":"                            \"new_vol_type\","},{"line_number":153,"context_line":"                            {},"},{"line_number":154,"context_line":"                            description\u003d\"new_type\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_8b04c57e","line":151,"in_reply_to":"3f79a3b5_21d93e26","updated":"2018-11-23 04:48:23.000000000","message":"default_vol_type (fake_vol_type) is used to create the volume and this new type is used for the retype operation but agree on the point that code can be reused.\nyou can use multiattach_type or multiattach_type2 instead","commit_id":"dafe7b0b7d77659dd355b0dfa2b11b7b1740e1d6"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8ed3387146ea226337f49c5c00beab0a3f0ead4c","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                          new_vol_type.id, host_obj,"},{"line_number":173,"context_line":"                          migration_policy\u003d\u0027on-demand\u0027)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        volume \u003d objects.Volume.get_by_id(context.get_admin_context(),"},{"line_number":176,"context_line":"                                          volume.id)"},{"line_number":177,"context_line":"        self.assertEqual(\u0027available\u0027, volume.status)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        self.volume.driver._initialized \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_ebf2199c","line":176,"range":{"start_line":175,"start_character":8,"end_line":176,"end_character":52},"updated":"2018-11-23 04:48:23.000000000","message":"volume.refresh()","commit_id":"dafe7b0b7d77659dd355b0dfa2b11b7b1740e1d6"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"ddc8951be9592592f62c7fb589071c4cff296809","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                                          volume.id)"},{"line_number":177,"context_line":"        self.assertEqual(\u0027available\u0027, volume.status)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        self.volume.driver._initialized \u003d True"},{"line_number":180,"context_line":"        self.volume.delete_volume(self.context, volume)"},{"line_number":181,"context_line":"        volume_types.destroy(self.context, new_vol_type.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_61d896ec","line":181,"range":{"start_line":179,"start_character":8,"end_line":181,"end_character":59},"updated":"2018-11-20 19:22:20.000000000","message":"Since this is a test, I think we don\u0027t need this lines. We are not using asserts after the delete.","commit_id":"dafe7b0b7d77659dd355b0dfa2b11b7b1740e1d6"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8ed3387146ea226337f49c5c00beab0a3f0ead4c","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                                          volume.id)"},{"line_number":177,"context_line":"        self.assertEqual(\u0027available\u0027, volume.status)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        self.volume.driver._initialized \u003d True"},{"line_number":180,"context_line":"        self.volume.delete_volume(self.context, volume)"},{"line_number":181,"context_line":"        volume_types.destroy(self.context, new_vol_type.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_cbe5ddd0","line":181,"range":{"start_line":179,"start_character":8,"end_line":181,"end_character":59},"in_reply_to":"3f79a3b5_61d896ec","updated":"2018-11-23 04:48:23.000000000","message":"+1","commit_id":"dafe7b0b7d77659dd355b0dfa2b11b7b1740e1d6"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"dd32dc6f6b78ee8321821613ede451724a2822ac","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            host\u003dCONF.host,"},{"line_number":154,"context_line":"            status\u003d\u0027available\u0027,"},{"line_number":155,"context_line":"            volume_type_id\u003dself.default_vol_type.id)"},{"line_number":156,"context_line":"        volume.previous_status \u003d \u0027available\u0027"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        host_obj \u003d {\u0027host\u0027: CONF.host, \u0027capabilities\u0027: {}}"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_f58a6b10","line":156,"updated":"2018-11-30 19:04:18.000000000","message":"I think you\u0027ve uncovered a bug with this. You previous_status shouldn\u0027t need to have a value set. The code should track the volume\u0027s current status, not its previous status.\n\nIt looks like http://git.openstack.org/cgit/openstack/cinder/tree/cinder/volume/manager.py#n2701 should at least check for both like we do at http://git.openstack.org/cgit/openstack/cinder/tree/cinder/scheduler/manager.py#n308","commit_id":"8427ab8b7ad374a9e4ff51595ac6d7a03fbe67e0"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f08a463f4e8630c032555d937416d616ddcbaa94","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            host\u003dCONF.host,"},{"line_number":154,"context_line":"            status\u003d\u0027available\u0027,"},{"line_number":155,"context_line":"            volume_type_id\u003dself.default_vol_type.id)"},{"line_number":156,"context_line":"        volume.previous_status \u003d \u0027available\u0027"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        host_obj \u003d {\u0027host\u0027: CONF.host, \u0027capabilities\u0027: {}}"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_5a5e8ae2","line":156,"in_reply_to":"3f79a3b5_f58a6b10","updated":"2018-12-18 22:29:28.000000000","message":"Replying to your out of context reply...\n\nThe test should not need to set the previous_status. That is None by default, the code in create_volume should handle that situation.\n\nAdding the check like I referred to above should make that code more robust to actually check what it should be on the volume without needing to artificially set it in the test.","commit_id":"8427ab8b7ad374a9e4ff51595ac6d7a03fbe67e0"}]}