)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"d6fc3925c14f08afe8a2b0963ef4af50b342833c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     whoami-rajat \u003crajatdhasmana@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-11-26 11:46:53 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Automating generation of sample files"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the following functionality:"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_f0afc0de","line":7,"updated":"2018-12-03 11:21:54.000000000","message":"If you need to do an update, please change this to something like \"Automate generation of api-ref samples\". Every time I see this title I wonder what needs to change with our existing automated sample file generation:\n\nhttps://docs.openstack.org/cinder/latest/configuration/block-storage/samples/index.html","commit_id":"654f6a2eac7aab74c8f5bf7d0e977538bc199d6d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2cb65554b780ccad7d65dd34cabbf99edd5ff899","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     whoami-rajat \u003crajatdhasmana@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-11-26 11:46:53 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Automating generation of sample files"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the following functionality:"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_a389f2c8","line":7,"in_reply_to":"3f79a3b5_f0afc0de","updated":"2018-12-04 04:37:42.000000000","message":"Done","commit_id":"654f6a2eac7aab74c8f5bf7d0e977538bc199d6d"}],"api-ref/source/v3/samples/volume-type-create-response.json":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"5efcfda547450ff6318444a9a468980f5a95902e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3f79a3b5_3cdff5d3","line":14,"updated":"2018-11-23 10:05:07.000000000","message":"nit: redundant line","commit_id":"7ce34ba03d39d056e15bb9055448730f5c2d627e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"405e00b5fe3b28f481bb92645ad4175787d6fc3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3f79a3b5_97db821e","line":14,"in_reply_to":"3f79a3b5_3cdff5d3","updated":"2018-11-23 10:39:40.000000000","message":"Removed","commit_id":"7ce34ba03d39d056e15bb9055448730f5c2d627e"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"6c5cd1e511caad21a53cd5ea3b9428ee5422b8f2","unresolved":false,"context_lines":[{"line_number":3,"context_line":"        \"name\": \"vol-type-001\","},{"line_number":4,"context_line":"        \"extra_specs\": {"},{"line_number":5,"context_line":"            \"capabilities\": \"gpu\""},{"line_number":6,"context_line":"            },"},{"line_number":7,"context_line":"        \"os-volume-type-access:is_public\": true,"},{"line_number":8,"context_line":"        \"is_public\": true,"},{"line_number":9,"context_line":"        \"id\": \"6d0ff92a-0007-4780-9ece-acfe5876966a\","}],"source_content_type":"application/json","patch_set":2,"id":"3f79a3b5_74ba59e0","line":6,"range":{"start_line":6,"start_character":8,"end_line":6,"end_character":12},"updated":"2018-11-24 03:46:05.000000000","message":"nit","commit_id":"c7136e52ababefc286e427b3776c50a3d5be929f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a85847090b6efed0aa41065d3c3eb7af8eb9d31e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"        \"name\": \"vol-type-001\","},{"line_number":4,"context_line":"        \"extra_specs\": {"},{"line_number":5,"context_line":"            \"capabilities\": \"gpu\""},{"line_number":6,"context_line":"            },"},{"line_number":7,"context_line":"        \"os-volume-type-access:is_public\": true,"},{"line_number":8,"context_line":"        \"is_public\": true,"},{"line_number":9,"context_line":"        \"id\": \"6d0ff92a-0007-4780-9ece-acfe5876966a\","}],"source_content_type":"application/json","patch_set":2,"id":"3f79a3b5_da2917f1","line":6,"range":{"start_line":6,"start_character":8,"end_line":6,"end_character":12},"in_reply_to":"3f79a3b5_74ba59e0","updated":"2018-11-24 10:26:13.000000000","message":"Done","commit_id":"c7136e52ababefc286e427b3776c50a3d5be929f"}],"api-ref/source/v3/samples/volume-types-list-response.json":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"6c5cd1e511caad21a53cd5ea3b9428ee5422b8f2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"            \"description\": \"volume type 0001\","},{"line_number":5,"context_line":"            \"extra_specs\": {"},{"line_number":6,"context_line":"                \"capabilities\": \"gpu\""},{"line_number":7,"context_line":"                },"},{"line_number":8,"context_line":"            \"id\": \"6685584b-1eac-4da6-b5c3-555430cf68ff\","},{"line_number":9,"context_line":"            \"is_public\": true,"},{"line_number":10,"context_line":"            \"name\": \"vol-type-001\","}],"source_content_type":"application/json","patch_set":2,"id":"3f79a3b5_34b061fc","line":7,"range":{"start_line":7,"start_character":12,"end_line":7,"end_character":16},"updated":"2018-11-24 03:46:05.000000000","message":"nit","commit_id":"c7136e52ababefc286e427b3776c50a3d5be929f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a85847090b6efed0aa41065d3c3eb7af8eb9d31e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"            \"description\": \"volume type 0001\","},{"line_number":5,"context_line":"            \"extra_specs\": {"},{"line_number":6,"context_line":"                \"capabilities\": \"gpu\""},{"line_number":7,"context_line":"                },"},{"line_number":8,"context_line":"            \"id\": \"6685584b-1eac-4da6-b5c3-555430cf68ff\","},{"line_number":9,"context_line":"            \"is_public\": true,"},{"line_number":10,"context_line":"            \"name\": \"vol-type-001\","}],"source_content_type":"application/json","patch_set":2,"id":"3f79a3b5_9a2f1ff3","line":7,"range":{"start_line":7,"start_character":12,"end_line":7,"end_character":16},"in_reply_to":"3f79a3b5_34b061fc","updated":"2018-11-24 10:26:13.000000000","message":"Done","commit_id":"c7136e52ababefc286e427b3776c50a3d5be929f"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"6c5cd1e511caad21a53cd5ea3b9428ee5422b8f2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"            \"description\": \"volume type 0002\","},{"line_number":16,"context_line":"            \"extra_specs\": {"},{"line_number":17,"context_line":"                \"capabilities\": \"gpu\""},{"line_number":18,"context_line":"                },"},{"line_number":19,"context_line":"            \"id\": \"6685584b-1eac-4da6-b5c3-555430cf68ff\","},{"line_number":20,"context_line":"            \"is_public\": true,"},{"line_number":21,"context_line":"            \"name\": \"vol-type-002\","}],"source_content_type":"application/json","patch_set":2,"id":"3f79a3b5_d4c80d77","line":18,"range":{"start_line":18,"start_character":12,"end_line":18,"end_character":16},"updated":"2018-11-24 03:46:05.000000000","message":"nit","commit_id":"c7136e52ababefc286e427b3776c50a3d5be929f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a85847090b6efed0aa41065d3c3eb7af8eb9d31e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"            \"description\": \"volume type 0002\","},{"line_number":16,"context_line":"            \"extra_specs\": {"},{"line_number":17,"context_line":"                \"capabilities\": \"gpu\""},{"line_number":18,"context_line":"                },"},{"line_number":19,"context_line":"            \"id\": \"6685584b-1eac-4da6-b5c3-555430cf68ff\","},{"line_number":20,"context_line":"            \"is_public\": true,"},{"line_number":21,"context_line":"            \"name\": \"vol-type-002\","}],"source_content_type":"application/json","patch_set":2,"id":"3f79a3b5_3a384b3a","line":18,"range":{"start_line":18,"start_character":12,"end_line":18,"end_character":16},"in_reply_to":"3f79a3b5_d4c80d77","updated":"2018-11-24 10:26:13.000000000","message":"Done","commit_id":"c7136e52ababefc286e427b3776c50a3d5be929f"}],"cinder/tests/functional/api_sample_tests/api_sample_base.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4956ff593c01cd873890eafb1197f7b0c14be503","unresolved":false,"context_lines":[{"line_number":21,"context_line":"CONF \u003d cfg.CONF"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class ApiSampleTestBase(api_samples_test_base.ApiSampleTestBase):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def setUp(self):"},{"line_number":27,"context_line":"        super(ApiSampleTestBase, self).setUp()"},{"line_number":28,"context_line":"        self.api_major_version \u003d \u0027v3\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        # this is used to generate sample docs"},{"line_number":31,"context_line":"        self.generate_samples \u003d os.getenv(\u0027GENERATE_SAMPLES\u0027) is not None"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_7eeca8bc","line":31,"range":{"start_line":24,"start_character":0,"end_line":31,"end_character":73},"updated":"2018-12-05 10:29:38.000000000","message":"cinder does not have much versions of endpoints support or nova has this separate base class with legacy reason. We can merge this and api_samples_test_base.ApiSampleTestBase into single class and maintain single base class.","commit_id":"21c4a1d53658fe9e5f9393fb7b1073e5735717e3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"11262e13cb420ee61c2dbcfb0a02f2b147ca0c6a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"CONF \u003d cfg.CONF"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class ApiSampleTestBase(api_samples_test_base.ApiSampleTestBase):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def setUp(self):"},{"line_number":27,"context_line":"        super(ApiSampleTestBase, self).setUp()"},{"line_number":28,"context_line":"        self.api_major_version \u003d \u0027v3\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        # this is used to generate sample docs"},{"line_number":31,"context_line":"        self.generate_samples \u003d os.getenv(\u0027GENERATE_SAMPLES\u0027) is not None"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_4b4477a0","line":31,"range":{"start_line":24,"start_character":0,"end_line":31,"end_character":73},"in_reply_to":"3f79a3b5_7eeca8bc","updated":"2018-12-06 07:05:54.000000000","message":"Done","commit_id":"21c4a1d53658fe9e5f9393fb7b1073e5735717e3"}],"cinder/tests/functional/api_sample_tests/samples/volume-type-create-response.json.tpl":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"5efcfda547450ff6318444a9a468980f5a95902e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"        \"name\": \"vol-type-001\","},{"line_number":4,"context_line":"        \"extra_specs\": {"},{"line_number":5,"context_line":"            \"capabilities\": \"gpu\""},{"line_number":6,"context_line":"            },"},{"line_number":7,"context_line":"        \"os-volume-type-access:is_public\": true,"},{"line_number":8,"context_line":"        \"is_public\": true,"},{"line_number":9,"context_line":"        \"id\": \"%(uuid)s\","}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3f79a3b5_9c772908","line":6,"range":{"start_line":6,"start_character":8,"end_line":6,"end_character":12},"updated":"2018-11-23 10:05:07.000000000","message":"nit: bad indent","commit_id":"7ce34ba03d39d056e15bb9055448730f5c2d627e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"405e00b5fe3b28f481bb92645ad4175787d6fc3a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"        \"name\": \"vol-type-001\","},{"line_number":4,"context_line":"        \"extra_specs\": {"},{"line_number":5,"context_line":"            \"capabilities\": \"gpu\""},{"line_number":6,"context_line":"            },"},{"line_number":7,"context_line":"        \"os-volume-type-access:is_public\": true,"},{"line_number":8,"context_line":"        \"is_public\": true,"},{"line_number":9,"context_line":"        \"id\": \"%(uuid)s\","}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3f79a3b5_57e16acd","line":6,"range":{"start_line":6,"start_character":8,"end_line":6,"end_character":12},"in_reply_to":"3f79a3b5_9c772908","updated":"2018-11-23 10:39:40.000000000","message":"Done","commit_id":"7ce34ba03d39d056e15bb9055448730f5c2d627e"}],"cinder/tests/functional/api_sample_tests/samples/volume-type-default-response.json.tpl":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"6c5cd1e511caad21a53cd5ea3b9428ee5422b8f2","unresolved":false,"context_lines":[{"line_number":3,"context_line":"        \"description\": \"volume type 0001\","},{"line_number":4,"context_line":"        \"extra_specs\": {"},{"line_number":5,"context_line":"            \"capabilities\": \"gpu\""},{"line_number":6,"context_line":"            },"},{"line_number":7,"context_line":"        \"id\": \"%(uuid)s\","},{"line_number":8,"context_line":"        \"is_public\": true,"},{"line_number":9,"context_line":"        \"name\": \"vol-type-001\","}],"source_content_type":"text/x-smarty","patch_set":2,"id":"3f79a3b5_f4c5095e","line":6,"range":{"start_line":6,"start_character":8,"end_line":6,"end_character":12},"updated":"2018-11-24 03:46:05.000000000","message":"nit","commit_id":"c7136e52ababefc286e427b3776c50a3d5be929f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a85847090b6efed0aa41065d3c3eb7af8eb9d31e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"        \"description\": \"volume type 0001\","},{"line_number":4,"context_line":"        \"extra_specs\": {"},{"line_number":5,"context_line":"            \"capabilities\": \"gpu\""},{"line_number":6,"context_line":"            },"},{"line_number":7,"context_line":"        \"id\": \"%(uuid)s\","},{"line_number":8,"context_line":"        \"is_public\": true,"},{"line_number":9,"context_line":"        \"name\": \"vol-type-001\","}],"source_content_type":"text/x-smarty","patch_set":2,"id":"3f79a3b5_5a350742","line":6,"range":{"start_line":6,"start_character":8,"end_line":6,"end_character":12},"in_reply_to":"3f79a3b5_f4c5095e","updated":"2018-11-24 10:26:13.000000000","message":"Done","commit_id":"c7136e52ababefc286e427b3776c50a3d5be929f"}],"cinder/tests/functional/api_sample_tests/samples/volume-type-show-response.json.tpl":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"6c5cd1e511caad21a53cd5ea3b9428ee5422b8f2","unresolved":false,"context_lines":[{"line_number":3,"context_line":"        \"description\": \"volume type 0001\","},{"line_number":4,"context_line":"        \"extra_specs\": {"},{"line_number":5,"context_line":"            \"capabilities\": \"gpu\""},{"line_number":6,"context_line":"            },"},{"line_number":7,"context_line":"        \"id\": \"%(uuid)s\","},{"line_number":8,"context_line":"        \"is_public\": true,"},{"line_number":9,"context_line":"        \"name\": \"vol-type-001\","}],"source_content_type":"text/x-smarty","patch_set":2,"id":"3f79a3b5_94be15cd","line":6,"range":{"start_line":6,"start_character":8,"end_line":6,"end_character":12},"updated":"2018-11-24 03:46:05.000000000","message":"nit","commit_id":"c7136e52ababefc286e427b3776c50a3d5be929f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a85847090b6efed0aa41065d3c3eb7af8eb9d31e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"        \"description\": \"volume type 0001\","},{"line_number":4,"context_line":"        \"extra_specs\": {"},{"line_number":5,"context_line":"            \"capabilities\": \"gpu\""},{"line_number":6,"context_line":"            },"},{"line_number":7,"context_line":"        \"id\": \"%(uuid)s\","},{"line_number":8,"context_line":"        \"is_public\": true,"},{"line_number":9,"context_line":"        \"name\": \"vol-type-001\","}],"source_content_type":"text/x-smarty","patch_set":2,"id":"3f79a3b5_fa3df329","line":6,"range":{"start_line":6,"start_character":8,"end_line":6,"end_character":12},"in_reply_to":"3f79a3b5_94be15cd","updated":"2018-11-24 10:26:13.000000000","message":"Done","commit_id":"c7136e52ababefc286e427b3776c50a3d5be929f"}],"cinder/tests/functional/api_sample_tests/samples/volume-types-list-response.json.tpl":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"6c5cd1e511caad21a53cd5ea3b9428ee5422b8f2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"            \"description\": \"volume type 0001\","},{"line_number":5,"context_line":"            \"extra_specs\": {"},{"line_number":6,"context_line":"                \"capabilities\": \"gpu\""},{"line_number":7,"context_line":"                },"},{"line_number":8,"context_line":"            \"id\": \"%(uuid)s\","},{"line_number":9,"context_line":"            \"is_public\": true,"},{"line_number":10,"context_line":"            \"name\": \"vol-type-001\","}],"source_content_type":"text/x-smarty","patch_set":2,"id":"3f79a3b5_b4bb11dc","line":7,"range":{"start_line":7,"start_character":12,"end_line":7,"end_character":16},"updated":"2018-11-24 03:46:05.000000000","message":"nit","commit_id":"c7136e52ababefc286e427b3776c50a3d5be929f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a85847090b6efed0aa41065d3c3eb7af8eb9d31e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"            \"description\": \"volume type 0001\","},{"line_number":5,"context_line":"            \"extra_specs\": {"},{"line_number":6,"context_line":"                \"capabilities\": \"gpu\""},{"line_number":7,"context_line":"                },"},{"line_number":8,"context_line":"            \"id\": \"%(uuid)s\","},{"line_number":9,"context_line":"            \"is_public\": true,"},{"line_number":10,"context_line":"            \"name\": \"vol-type-001\","}],"source_content_type":"text/x-smarty","patch_set":2,"id":"3f79a3b5_1a3b0f36","line":7,"range":{"start_line":7,"start_character":12,"end_line":7,"end_character":16},"in_reply_to":"3f79a3b5_b4bb11dc","updated":"2018-11-24 10:26:13.000000000","message":"Done","commit_id":"c7136e52ababefc286e427b3776c50a3d5be929f"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"6c5cd1e511caad21a53cd5ea3b9428ee5422b8f2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"            \"description\": \"volume type 0002\","},{"line_number":16,"context_line":"            \"extra_specs\": {"},{"line_number":17,"context_line":"                \"capabilities\": \"gpu\""},{"line_number":18,"context_line":"                },"},{"line_number":19,"context_line":"            \"id\": \"%(uuid)s\","},{"line_number":20,"context_line":"            \"is_public\": true,"},{"line_number":21,"context_line":"            \"name\": \"vol-type-002\","}],"source_content_type":"text/x-smarty","patch_set":2,"id":"3f79a3b5_549abd74","line":18,"range":{"start_line":18,"start_character":12,"end_line":18,"end_character":16},"updated":"2018-11-24 03:46:05.000000000","message":"nit","commit_id":"c7136e52ababefc286e427b3776c50a3d5be929f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a85847090b6efed0aa41065d3c3eb7af8eb9d31e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"            \"description\": \"volume type 0002\","},{"line_number":16,"context_line":"            \"extra_specs\": {"},{"line_number":17,"context_line":"                \"capabilities\": \"gpu\""},{"line_number":18,"context_line":"                },"},{"line_number":19,"context_line":"            \"id\": \"%(uuid)s\","},{"line_number":20,"context_line":"            \"is_public\": true,"},{"line_number":21,"context_line":"            \"name\": \"vol-type-002\","}],"source_content_type":"text/x-smarty","patch_set":2,"id":"3f79a3b5_ba0d3b93","line":18,"range":{"start_line":18,"start_character":12,"end_line":18,"end_character":16},"in_reply_to":"3f79a3b5_549abd74","updated":"2018-11-24 10:26:13.000000000","message":"Done","commit_id":"c7136e52ababefc286e427b3776c50a3d5be929f"}],"cinder/tests/functional/api_sample_tests/test_volume_types.py":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"6c5cd1e511caad21a53cd5ea3b9428ee5422b8f2","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        CONF.set_override(\"default_volume_type\","},{"line_number":32,"context_line":"                          \"vol-type-001\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def _post(self, subs\u003dNone):"},{"line_number":35,"context_line":"        subs \u003d subs if subs is not None else self.subs"},{"line_number":36,"context_line":"        response \u003d self._do_post(\u0027types\u0027,"},{"line_number":37,"context_line":"                                 \u0027volume-type-create-request\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_f41749ee","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":13},"updated":"2018-11-24 03:46:05.000000000","message":"I think this could rename to something like \"_volume_type_create\"","commit_id":"c7136e52ababefc286e427b3776c50a3d5be929f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a85847090b6efed0aa41065d3c3eb7af8eb9d31e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        CONF.set_override(\"default_volume_type\","},{"line_number":32,"context_line":"                          \"vol-type-001\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def _post(self, subs\u003dNone):"},{"line_number":35,"context_line":"        subs \u003d subs if subs is not None else self.subs"},{"line_number":36,"context_line":"        response \u003d self._do_post(\u0027types\u0027,"},{"line_number":37,"context_line":"                                 \u0027volume-type-create-request\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_da1277b3","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":13},"in_reply_to":"3f79a3b5_f41749ee","updated":"2018-11-24 10:26:13.000000000","message":"Done","commit_id":"c7136e52ababefc286e427b3776c50a3d5be929f"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"0a64313e3bfb70d74f8fc6803b5f2ab65bc4eea7","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def test_volume_type_extra_spec_create_update(self):"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        res \u003d self._volume_type_create()"},{"line_number":59,"context_line":"        res \u003d json.loads(res.content)[\u0027volume_type\u0027]"},{"line_number":60,"context_line":"        url \u003d (\"types/%s/extra_specs\" % res[\u0027id\u0027])"},{"line_number":61,"context_line":"        response \u003d self._do_post("},{"line_number":62,"context_line":"            url,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_742a52e5","line":59,"range":{"start_line":59,"start_character":14,"end_line":59,"end_character":18},"updated":"2018-11-26 02:59:52.000000000","message":"from oslo_serialization import jsonutils\n\nWe can use jsonutils.loads which using encodeutils.safe_decode to solve the encode problem.\n\n[1] https://github.com/openstack/oslo.serialization/blob/master/oslo_serialization/jsonutils.py#L255","commit_id":"7a7be856292e2a30028f79d566f785b8f0f7c7ab"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"c57df44e5333a607169299315fb3ef516b94cab3","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def test_volume_type_extra_spec_create_update(self):"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        res \u003d self._volume_type_create()"},{"line_number":59,"context_line":"        res \u003d json.loads(res.content)[\u0027volume_type\u0027]"},{"line_number":60,"context_line":"        url \u003d (\"types/%s/extra_specs\" % res[\u0027id\u0027])"},{"line_number":61,"context_line":"        response \u003d self._do_post("},{"line_number":62,"context_line":"            url,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_143bde35","line":59,"range":{"start_line":59,"start_character":14,"end_line":59,"end_character":18},"in_reply_to":"3f79a3b5_742a52e5","updated":"2018-11-26 03:00:24.000000000","message":"Done","commit_id":"7a7be856292e2a30028f79d566f785b8f0f7c7ab"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"9e6f1a8d8792a4ae641cb96e9a15b6b665cd59b9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import json"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from oslo_config import cfg"},{"line_number":16,"context_line":"from oslo_serialization import jsonutils"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_21357bdc","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":11},"updated":"2018-11-26 06:14:56.000000000","message":"oops","commit_id":"39dc08f72592498eca4e186acde05a99509842fb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0e450139a8ebf3512aa4032bf7fd2fa1c23b8845","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import json"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from oslo_config import cfg"},{"line_number":16,"context_line":"from oslo_serialization import jsonutils"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_01563ffa","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":11},"in_reply_to":"3f79a3b5_21357bdc","updated":"2018-11-26 06:19:49.000000000","message":"Done","commit_id":"39dc08f72592498eca4e186acde05a99509842fb"}],"cinder/tests/functional/api_samples_test_base.py":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"5efcfda547450ff6318444a9a468980f5a95902e","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    def _get_sample(cls, name, api_version\u003dNone):"},{"line_number":105,"context_line":"        dirname \u003d os.path.dirname(os.path.abspath(__file__))"},{"line_number":106,"context_line":"        dirname \u003d os.path.normpath(os.path.join(dirname,"},{"line_number":107,"context_line":"                                                \"../../../api-ref/source/v3\"))"},{"line_number":108,"context_line":"        return cls._get_sample_path(name, dirname, api_version\u003dapi_version)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_9c188983","line":107,"range":{"start_line":107,"start_character":73,"end_line":107,"end_character":75},"updated":"2018-11-23 10:05:07.000000000","message":"Don\u0027t we need mircoversion support on it?\n\nBecause every version has there specific response.","commit_id":"7ce34ba03d39d056e15bb9055448730f5c2d627e"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"6c5cd1e511caad21a53cd5ea3b9428ee5422b8f2","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    def _get_sample(cls, name, api_version\u003dNone):"},{"line_number":105,"context_line":"        dirname \u003d os.path.dirname(os.path.abspath(__file__))"},{"line_number":106,"context_line":"        dirname \u003d os.path.normpath(os.path.join(dirname,"},{"line_number":107,"context_line":"                                                \"../../../api-ref/source/v3\"))"},{"line_number":108,"context_line":"        return cls._get_sample_path(name, dirname, api_version\u003dapi_version)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_d4c9ed51","line":107,"range":{"start_line":107,"start_character":73,"end_line":107,"end_character":75},"in_reply_to":"3f79a3b5_972942f2","updated":"2018-11-24 03:46:05.000000000","message":"OK, just a reminder, because v2 is still support, so I think we should also update it to support v2, otherwise we should also update v2 doc mannully.","commit_id":"7ce34ba03d39d056e15bb9055448730f5c2d627e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"405e00b5fe3b28f481bb92645ad4175787d6fc3a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    def _get_sample(cls, name, api_version\u003dNone):"},{"line_number":105,"context_line":"        dirname \u003d os.path.dirname(os.path.abspath(__file__))"},{"line_number":106,"context_line":"        dirname \u003d os.path.normpath(os.path.join(dirname,"},{"line_number":107,"context_line":"                                                \"../../../api-ref/source/v3\"))"},{"line_number":108,"context_line":"        return cls._get_sample_path(name, dirname, api_version\u003dapi_version)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_972942f2","line":107,"range":{"start_line":107,"start_character":73,"end_line":107,"end_character":75},"in_reply_to":"3f79a3b5_9c188983","updated":"2018-11-23 10:39:40.000000000","message":"Currently i\u0027ve decided to implement the tests for v3, i will generalize them for other mv in the future implementation patches. (also after discussion the same with cinder team)","commit_id":"7ce34ba03d39d056e15bb9055448730f5c2d627e"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"6c5cd1e511caad21a53cd5ea3b9428ee5422b8f2","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    def _get_sample_path(cls, name, dirname, suffix\u003d\u0027\u0027, api_version\u003dNone):"},{"line_number":95,"context_line":"        parts \u003d [dirname]"},{"line_number":96,"context_line":"        parts.append(\u0027samples\u0027)"},{"line_number":97,"context_line":"        #parts.append(cls.sample_dir)"},{"line_number":98,"context_line":"        if api_version:"},{"line_number":99,"context_line":"            parts.append(\u0027v\u0027 + api_version)"},{"line_number":100,"context_line":"        parts.append(name + \".json\" + suffix)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_748d7927","line":97,"updated":"2018-11-24 03:46:05.000000000","message":"remove this","commit_id":"c7136e52ababefc286e427b3776c50a3d5be929f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a85847090b6efed0aa41065d3c3eb7af8eb9d31e","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    def _get_sample_path(cls, name, dirname, suffix\u003d\u0027\u0027, api_version\u003dNone):"},{"line_number":95,"context_line":"        parts \u003d [dirname]"},{"line_number":96,"context_line":"        parts.append(\u0027samples\u0027)"},{"line_number":97,"context_line":"        #parts.append(cls.sample_dir)"},{"line_number":98,"context_line":"        if api_version:"},{"line_number":99,"context_line":"            parts.append(\u0027v\u0027 + api_version)"},{"line_number":100,"context_line":"        parts.append(name + \".json\" + suffix)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_9a087f7f","line":97,"in_reply_to":"3f79a3b5_748d7927","updated":"2018-11-24 10:26:13.000000000","message":"I\u0027m planning to add directories for different tests but for now to satisfy pep8, removed it.","commit_id":"c7136e52ababefc286e427b3776c50a3d5be929f"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"6c5cd1e511caad21a53cd5ea3b9428ee5422b8f2","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        if expected is None:"},{"line_number":138,"context_line":"            if result is None:"},{"line_number":139,"context_line":"                pass"},{"line_number":140,"context_line":"            elif result \u003d\u003d u\u0027\u0027:"},{"line_number":141,"context_line":"                pass"},{"line_number":142,"context_line":"            else:"},{"line_number":143,"context_line":"                raise NoMatch(\u0027%(result_str)s: Expected None, got %(result)s.\u0027"},{"line_number":144,"context_line":"                        % {\u0027result_str\u0027: result_str, \u0027result\u0027: result})"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_b469d15b","line":141,"range":{"start_line":140,"start_character":0,"end_line":141,"end_character":20},"updated":"2018-11-24 03:46:05.000000000","message":"emm, null \u003d\u003d u\u0027\u0027 ? and I found [1] is original reason to add this, but it seems a invalid, so I think we could remove it now.\n\n[1] https://bugs.launchpad.net/nova/+bug/1544720","commit_id":"c7136e52ababefc286e427b3776c50a3d5be929f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a85847090b6efed0aa41065d3c3eb7af8eb9d31e","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        if expected is None:"},{"line_number":138,"context_line":"            if result is None:"},{"line_number":139,"context_line":"                pass"},{"line_number":140,"context_line":"            elif result \u003d\u003d u\u0027\u0027:"},{"line_number":141,"context_line":"                pass"},{"line_number":142,"context_line":"            else:"},{"line_number":143,"context_line":"                raise NoMatch(\u0027%(result_str)s: Expected None, got %(result)s.\u0027"},{"line_number":144,"context_line":"                        % {\u0027result_str\u0027: result_str, \u0027result\u0027: result})"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_fa1653a2","line":141,"range":{"start_line":140,"start_character":0,"end_line":141,"end_character":20},"in_reply_to":"3f79a3b5_b469d15b","updated":"2018-11-24 10:26:13.000000000","message":"until i find any of the test failing due to the above, removing it seems better.","commit_id":"c7136e52ababefc286e427b3776c50a3d5be929f"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"6c5cd1e511caad21a53cd5ea3b9428ee5422b8f2","unresolved":false,"context_lines":[{"line_number":243,"context_line":"                        \u0027result\u0027: result})"},{"line_number":244,"context_line":"            try:"},{"line_number":245,"context_line":"                matched_value \u003d match.group(\u0027id\u0027)"},{"line_number":246,"context_line":"                #matched_value \u003d match.group()"},{"line_number":247,"context_line":"            except IndexError:"},{"line_number":248,"context_line":"                if match.groups():"},{"line_number":249,"context_line":"                    matched_value \u003d match.groups()[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_54d63dfa","line":246,"updated":"2018-11-24 03:46:05.000000000","message":"remove this","commit_id":"c7136e52ababefc286e427b3776c50a3d5be929f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a85847090b6efed0aa41065d3c3eb7af8eb9d31e","unresolved":false,"context_lines":[{"line_number":243,"context_line":"                        \u0027result\u0027: result})"},{"line_number":244,"context_line":"            try:"},{"line_number":245,"context_line":"                matched_value \u003d match.group(\u0027id\u0027)"},{"line_number":246,"context_line":"                #matched_value \u003d match.group()"},{"line_number":247,"context_line":"            except IndexError:"},{"line_number":248,"context_line":"                if match.groups():"},{"line_number":249,"context_line":"                    matched_value \u003d match.groups()[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ba721b17","line":246,"in_reply_to":"3f79a3b5_54d63dfa","updated":"2018-11-24 10:26:13.000000000","message":"missed it during testing, Done","commit_id":"c7136e52ababefc286e427b3776c50a3d5be929f"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"6c5cd1e511caad21a53cd5ea3b9428ee5422b8f2","unresolved":false,"context_lines":[{"line_number":359,"context_line":"            # doc/samples check. Also let the test do some of its"},{"line_number":360,"context_line":"            # own generalization, if necessary"},{"line_number":361,"context_line":"            vanilla_regexes \u003d self._get_regexes()"},{"line_number":362,"context_line":"            subs[\u0027volume_host\u0027] \u003d vanilla_regexes[\u0027host_name\u0027]"},{"line_number":363,"context_line":"            subs[\u0027id\u0027] \u003d vanilla_regexes[\u0027id\u0027]"},{"line_number":364,"context_line":"            subs[\u0027uuid\u0027] \u003d vanilla_regexes[\u0027uuid\u0027]"},{"line_number":365,"context_line":"            subs[\u0027image_id\u0027] \u003d vanilla_regexes[\u0027uuid\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_f498a967","line":362,"range":{"start_line":362,"start_character":18,"end_line":362,"end_character":29},"updated":"2018-11-24 03:46:05.000000000","message":"maybe you mean: os-vol-host-attr:host","commit_id":"c7136e52ababefc286e427b3776c50a3d5be929f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a85847090b6efed0aa41065d3c3eb7af8eb9d31e","unresolved":false,"context_lines":[{"line_number":359,"context_line":"            # doc/samples check. Also let the test do some of its"},{"line_number":360,"context_line":"            # own generalization, if necessary"},{"line_number":361,"context_line":"            vanilla_regexes \u003d self._get_regexes()"},{"line_number":362,"context_line":"            subs[\u0027volume_host\u0027] \u003d vanilla_regexes[\u0027host_name\u0027]"},{"line_number":363,"context_line":"            subs[\u0027id\u0027] \u003d vanilla_regexes[\u0027id\u0027]"},{"line_number":364,"context_line":"            subs[\u0027uuid\u0027] \u003d vanilla_regexes[\u0027uuid\u0027]"},{"line_number":365,"context_line":"            subs[\u0027image_id\u0027] \u003d vanilla_regexes[\u0027uuid\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_da77d706","line":362,"range":{"start_line":362,"start_character":18,"end_line":362,"end_character":29},"in_reply_to":"3f79a3b5_f498a967","updated":"2018-11-24 10:26:13.000000000","message":"Done","commit_id":"c7136e52ababefc286e427b3776c50a3d5be929f"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"6c5cd1e511caad21a53cd5ea3b9428ee5422b8f2","unresolved":false,"context_lines":[{"line_number":406,"context_line":"            \u0027host\u0027: self._get_host(),"},{"line_number":407,"context_line":"            \u0027host_name\u0027: r\u0027\\w+\u0027,"},{"line_number":408,"context_line":"            \u0027glance_host\u0027: self._get_glance_host(),"},{"line_number":409,"context_line":"            \u0027volume_host\u0027: self.volume.host,"},{"line_number":410,"context_line":"            \u0027text\u0027: text,"},{"line_number":411,"context_line":"            \u0027int\u0027: \u0027[0-9]+\u0027,"},{"line_number":412,"context_line":"            \u0027user_id\u0027: text,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_94a13596","line":409,"range":{"start_line":409,"start_character":13,"end_line":409,"end_character":24},"updated":"2018-11-24 03:46:05.000000000","message":"ditto","commit_id":"c7136e52ababefc286e427b3776c50a3d5be929f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a85847090b6efed0aa41065d3c3eb7af8eb9d31e","unresolved":false,"context_lines":[{"line_number":406,"context_line":"            \u0027host\u0027: self._get_host(),"},{"line_number":407,"context_line":"            \u0027host_name\u0027: r\u0027\\w+\u0027,"},{"line_number":408,"context_line":"            \u0027glance_host\u0027: self._get_glance_host(),"},{"line_number":409,"context_line":"            \u0027volume_host\u0027: self.volume.host,"},{"line_number":410,"context_line":"            \u0027text\u0027: text,"},{"line_number":411,"context_line":"            \u0027int\u0027: \u0027[0-9]+\u0027,"},{"line_number":412,"context_line":"            \u0027user_id\u0027: text,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_7a7803f5","line":409,"range":{"start_line":409,"start_character":13,"end_line":409,"end_character":24},"in_reply_to":"3f79a3b5_94a13596","updated":"2018-11-24 10:26:13.000000000","message":"Done","commit_id":"c7136e52ababefc286e427b3776c50a3d5be929f"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"6c5cd1e511caad21a53cd5ea3b9428ee5422b8f2","unresolved":false,"context_lines":[{"line_number":434,"context_line":"        headers \u003d headers or {}"},{"line_number":435,"context_line":"        headers[\u0027Content-Type\u0027] \u003d \u0027application/json\u0027"},{"line_number":436,"context_line":"        headers[\u0027Accept\u0027] \u003d \u0027application/json\u0027"},{"line_number":437,"context_line":"        #return self.api.api_get(url)"},{"line_number":438,"context_line":"        #req \u003d webob.Request.blank(\u0027/volumes/%s\u0027 % fake.VOLUME_ID)"},{"line_number":439,"context_line":"        #req.method \u003d \u0027GET\u0027"},{"line_number":440,"context_line":"        #resp \u003d req.get_response()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_347e211a","line":437,"updated":"2018-11-24 03:46:05.000000000","message":"Remove these lines","commit_id":"c7136e52ababefc286e427b3776c50a3d5be929f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a85847090b6efed0aa41065d3c3eb7af8eb9d31e","unresolved":false,"context_lines":[{"line_number":434,"context_line":"        headers \u003d headers or {}"},{"line_number":435,"context_line":"        headers[\u0027Content-Type\u0027] \u003d \u0027application/json\u0027"},{"line_number":436,"context_line":"        headers[\u0027Accept\u0027] \u003d \u0027application/json\u0027"},{"line_number":437,"context_line":"        #return self.api.api_get(url)"},{"line_number":438,"context_line":"        #req \u003d webob.Request.blank(\u0027/volumes/%s\u0027 % fake.VOLUME_ID)"},{"line_number":439,"context_line":"        #req.method \u003d \u0027GET\u0027"},{"line_number":440,"context_line":"        #resp \u003d req.get_response()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_3a660b58","line":437,"in_reply_to":"3f79a3b5_347e211a","updated":"2018-11-24 10:26:13.000000000","message":"oops, Done","commit_id":"c7136e52ababefc286e427b3776c50a3d5be929f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4956ff593c01cd873890eafb1197f7b0c14be503","unresolved":false,"context_lines":[{"line_number":66,"context_line":"class ApiSampleTestBase(functional_helpers._FunctionalTestBase):"},{"line_number":67,"context_line":"    all_extensions \u003d True"},{"line_number":68,"context_line":"    sample_dir \u003d None"},{"line_number":69,"context_line":"    microversion \u003d None"},{"line_number":70,"context_line":"    _project_id \u003d True"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_0449a62e","line":69,"range":{"start_line":69,"start_character":4,"end_line":69,"end_character":23},"updated":"2018-12-05 10:29:38.000000000","message":"it will be hard to mix the microversion support in initial framework. let\u0027s keep it once we have basic framework up and running.","commit_id":"21c4a1d53658fe9e5f9393fb7b1073e5735717e3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"11262e13cb420ee61c2dbcfb0a02f2b147ca0c6a","unresolved":false,"context_lines":[{"line_number":66,"context_line":"class ApiSampleTestBase(functional_helpers._FunctionalTestBase):"},{"line_number":67,"context_line":"    all_extensions \u003d True"},{"line_number":68,"context_line":"    sample_dir \u003d None"},{"line_number":69,"context_line":"    microversion \u003d None"},{"line_number":70,"context_line":"    _project_id \u003d True"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_0bc0bff8","line":69,"range":{"start_line":69,"start_character":4,"end_line":69,"end_character":23},"in_reply_to":"3f79a3b5_0449a62e","updated":"2018-12-06 07:05:54.000000000","message":"Done","commit_id":"21c4a1d53658fe9e5f9393fb7b1073e5735717e3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4956ff593c01cd873890eafb1197f7b0c14be503","unresolved":false,"context_lines":[{"line_number":340,"context_line":"            template_data \u003d response_data"},{"line_number":341,"context_line":"        else:"},{"line_number":342,"context_line":"            template_data \u003d self._read_template(name)"},{"line_number":343,"context_line":"        if (self.generate_samples and"},{"line_number":344,"context_line":"                not os.path.exists(self._get_sample("},{"line_number":345,"context_line":"                    name, self.microversion))):"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"            self._write_sample(name, response_data)"},{"line_number":348,"context_line":"            sample_data \u003d response_data"},{"line_number":349,"context_line":"        else:"},{"line_number":350,"context_line":"            with open(self._get_sample(name,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_471a4019","line":347,"range":{"start_line":343,"start_character":0,"end_line":347,"end_character":42},"updated":"2018-12-05 10:29:38.000000000","message":"tested this with tox -efunctional  and working fine. it generate the missing sample files.","commit_id":"21c4a1d53658fe9e5f9393fb7b1073e5735717e3"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"5e0150ae6b3879214dd3b02a2567e7f99ef42e04","unresolved":false,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def generalize_subs(self, subs, vanilla_regexes):"},{"line_number":298,"context_line":"        \"\"\"Give the test a chance to modify subs after the server response"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"        was verified, and before the on-disk doc/samples file is checked."},{"line_number":301,"context_line":"        This may be needed by some tests to convert exact matches expected"},{"line_number":302,"context_line":"        from the server into pattern matches to verify what is in the"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_11684df1","line":299,"updated":"2018-12-13 21:05:52.000000000","message":"Nit: extra line here","commit_id":"67150217c94aacce944c20c34ebf8711ebd1db0c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cfc8be85052ee961d77561667f8fdff1616a3d4e","unresolved":false,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def generalize_subs(self, subs, vanilla_regexes):"},{"line_number":298,"context_line":"        \"\"\"Give the test a chance to modify subs after the server response"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"        was verified, and before the on-disk doc/samples file is checked."},{"line_number":301,"context_line":"        This may be needed by some tests to convert exact matches expected"},{"line_number":302,"context_line":"        from the server into pattern matches to verify what is in the"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_7bfaba12","line":299,"in_reply_to":"3f79a3b5_11684df1","updated":"2018-12-14 04:03:58.000000000","message":"There was a pep8 issue that\u0027s why i added this line.","commit_id":"67150217c94aacce944c20c34ebf8711ebd1db0c"}],"tox.ini":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4956ff593c01cd873890eafb1197f7b0c14be503","unresolved":false,"context_lines":[{"line_number":62,"context_line":"setenv \u003d"},{"line_number":63,"context_line":"  {[testenv:functional]setenv}"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"[testenv:api-samples]"},{"line_number":66,"context_line":"envdir \u003d {toxworkdir}/shared"},{"line_number":67,"context_line":"setenv \u003d"},{"line_number":68,"context_line":"  {[testenv]setenv}"}],"source_content_type":"text/x-properties","patch_set":6,"id":"3f79a3b5_0758c823","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":21},"updated":"2018-12-05 10:29:38.000000000","message":"When i used this env, this does not pick up the api_sample_tests tests instead it is running all the cinder tests including unit or functional.","commit_id":"21c4a1d53658fe9e5f9393fb7b1073e5735717e3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"11262e13cb420ee61c2dbcfb0a02f2b147ca0c6a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"setenv \u003d"},{"line_number":63,"context_line":"  {[testenv:functional]setenv}"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"[testenv:api-samples]"},{"line_number":66,"context_line":"envdir \u003d {toxworkdir}/shared"},{"line_number":67,"context_line":"setenv \u003d"},{"line_number":68,"context_line":"  {[testenv]setenv}"}],"source_content_type":"text/x-properties","patch_set":6,"id":"3f79a3b5_4b8797b5","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":21},"in_reply_to":"3f79a3b5_0758c823","updated":"2018-12-06 07:05:54.000000000","message":"This problem occurred because the [testenv]setenv @L#13 includes unit tests in the OS_TEST_PATH\nAlso the [testenv]commands @L#25 runs stestr run (which runs for all the tests unit/functional) which runs before our api-samples stestr\nThese both values doesn\u0027t exist in the [testenv] in nova so it doesn\u0027t cause a problem there.\nFixed it by including the useful commands from the base [testenv] here.","commit_id":"21c4a1d53658fe9e5f9393fb7b1073e5735717e3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"21ce42323bcfce53968ddde3e675ca5ca9a839a8","unresolved":false,"context_lines":[{"line_number":62,"context_line":"setenv \u003d"},{"line_number":63,"context_line":"  {[testenv:functional]setenv}"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"[testenv:api-samples]"},{"line_number":66,"context_line":"envdir \u003d {toxworkdir}/shared"},{"line_number":67,"context_line":"setenv \u003d"},{"line_number":68,"context_line":"  {[testenv]setenv}"}],"source_content_type":"text/x-properties","patch_set":6,"id":"3f79a3b5_824a3b22","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":21},"in_reply_to":"3f79a3b5_4b8797b5","updated":"2018-12-09 14:21:03.000000000","message":"thanks. working now.","commit_id":"21c4a1d53658fe9e5f9393fb7b1073e5735717e3"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1e31d87378c08f29e64aa07ffc7c9e1e5f75716c","unresolved":false,"context_lines":[{"line_number":70,"context_line":"commands \u003d"},{"line_number":71,"context_line":"  find . -ignore_readdir_race -type f -name \"*.pyc\" -delete"},{"line_number":72,"context_line":"  stestr --test-path\u003d./cinder/tests/functional/api_sample_tests run {posargs}"},{"line_number":73,"context_line":"  stestr slowest"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"[testenv:compliance]"},{"line_number":76,"context_line":"basepython \u003d python3"}],"source_content_type":"text/x-properties","patch_set":7,"id":"3f79a3b5_661485ec","line":73,"updated":"2018-12-12 18:31:14.000000000","message":"Not sure we care about outputing slowest tests in this situation.","commit_id":"67150217c94aacce944c20c34ebf8711ebd1db0c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cfc8be85052ee961d77561667f8fdff1616a3d4e","unresolved":false,"context_lines":[{"line_number":70,"context_line":"commands \u003d"},{"line_number":71,"context_line":"  find . -ignore_readdir_race -type f -name \"*.pyc\" -delete"},{"line_number":72,"context_line":"  stestr --test-path\u003d./cinder/tests/functional/api_sample_tests run {posargs}"},{"line_number":73,"context_line":"  stestr slowest"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"[testenv:compliance]"},{"line_number":76,"context_line":"basepython \u003d python3"}],"source_content_type":"text/x-properties","patch_set":7,"id":"3f79a3b5_36fa1710","line":73,"in_reply_to":"3f79a3b5_661485ec","updated":"2018-12-14 04:03:58.000000000","message":"I thought when all the tests get merged then it will be helpful, will remove if it doesn\u0027t serve any purpose then.","commit_id":"67150217c94aacce944c20c34ebf8711ebd1db0c"}]}