)]}'
{"cinder/tests/unit/api/v3/test_volume_metadata.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7962f959e0353a150c06021405bf8d506fede88d","unresolved":false,"context_lines":[{"line_number":162,"context_line":"               \"availability_zone\": \"zone1:host1\","},{"line_number":163,"context_line":"               \"metadata\": {}}"},{"line_number":164,"context_line":"        body \u003d {\"volume\": vol}"},{"line_number":165,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/volumes\u0027)"},{"line_number":166,"context_line":"        self.volume_controller.create(req, body\u003dbody)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def test_index(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_1ad5991a","side":"PARENT","line":165,"updated":"2018-12-04 14:57:22.000000000","message":"This was a good catch!","commit_id":"24ac2f39bab27b537d672d0d3e7bc21634d4c255"}],"cinder/tests/unit/api/v3/test_volume_protection.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7962f959e0353a150c06021405bf8d506fede88d","unresolved":false,"context_lines":[{"line_number":656,"context_line":"        response \u003d self._get_request_response(user_context, path, \u0027DELETE\u0027)"},{"line_number":657,"context_line":"        self.assertEqual(http_client.OK, response.status_int)"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"    def test_owner_cannot_crud_metadata_for_others(self):"},{"line_number":660,"context_line":"        # Make sure volume metadata cannot be crud by other users"},{"line_number":661,"context_line":"        user_context \u003d self.user_context"},{"line_number":662,"context_line":"        non_owner_context \u003d self.other_user_context"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_5afd51b6","line":659,"updated":"2018-12-04 14:57:22.000000000","message":"Since the default policy is unrestricted, the policy is not what\u0027s enforcing a non-admin-non-owner from performing this action (otherwise this test would be failing).  Hopefully this is already being tested somewhere else.  In any case, I don\u0027t think it should be tested here.","commit_id":"bde3bebd7bcc269f5b9f480b7cef713536da9545"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"72a0c85efc48be087a23ed2f1a80772adcbcd373","unresolved":false,"context_lines":[{"line_number":656,"context_line":"        response \u003d self._get_request_response(user_context, path, \u0027DELETE\u0027)"},{"line_number":657,"context_line":"        self.assertEqual(http_client.OK, response.status_int)"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"    def test_owner_cannot_crud_metadata_for_others(self):"},{"line_number":660,"context_line":"        # Make sure volume metadata cannot be crud by other users"},{"line_number":661,"context_line":"        user_context \u003d self.user_context"},{"line_number":662,"context_line":"        non_owner_context \u003d self.other_user_context"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_55fe826d","line":659,"in_reply_to":"3f79a3b5_5afd51b6","updated":"2018-12-04 15:37:12.000000000","message":"I realized in looking at another review that the default for this is actually base.RULE_ADMIN_OR_OWNER.  So I downloaded this patch and changed the defaults to \"\", and the test still passes.  So my overall point that policies aren\u0027t what\u0027s preventing a non-admin-non-owner from doing this is correct, I think.","commit_id":"bde3bebd7bcc269f5b9f480b7cef713536da9545"}]}