)]}'
{"cinder/brick/local_dev/lvm.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"e74d660bfeaaf445141847674ca522f501303f41","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            LOG.error(_(\u0027Unable to locate Volume Group %s\u0027) % vg_name)"},{"line_number":85,"context_line":"            raise exception.VolumeGroupNotFound(vg_name\u003dvg_name)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        # NOTE: we assume that the VG has been activated outside of Cinder"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        if lvm_type \u003d\u003d \u0027thin\u0027:"},{"line_number":90,"context_line":"            pool_name \u003d \"%s-pool\" % self.vg_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9OYU%3D","line":87,"updated":"2013-12-13 20:06:56.000000000","message":"I don\u0027t think this is a safe assumption, particularly as it\u0027s not documented and for example we don\u0027t do it in devstack.\n\nI\u0027d rather we explicitly check/activate here rather than do another patch.","commit_id":"80f547bc5eaac35c9f3cbcbe0203940268492fef"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3cfcafdad6efedfbc3e5ec3601ddd92839385154","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            LOG.error(_(\u0027Unable to locate Volume Group %s\u0027) % vg_name)"},{"line_number":85,"context_line":"            raise exception.VolumeGroupNotFound(vg_name\u003dvg_name)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        # NOTE: we assume that the VG has been activated outside of Cinder"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        if lvm_type \u003d\u003d \u0027thin\u0027:"},{"line_number":90,"context_line":"            pool_name \u003d \"%s-pool\" % self.vg_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F8%2F8I%3D","line":87,"in_reply_to":"AAAATn%2F9OJE%3D","updated":"2013-12-17 21:23:41.000000000","message":"I would rather do another patch if we find a reason to activate the VG.  It doesn\u0027t seem right to me, and is a separate issue IMO.","commit_id":"80f547bc5eaac35c9f3cbcbe0203940268492fef"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e67561c42050be369792dd5b35d50063131a5a95","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            LOG.error(_(\u0027Unable to locate Volume Group %s\u0027) % vg_name)"},{"line_number":85,"context_line":"            raise exception.VolumeGroupNotFound(vg_name\u003dvg_name)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        # NOTE: we assume that the VG has been activated outside of Cinder"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        if lvm_type \u003d\u003d \u0027thin\u0027:"},{"line_number":90,"context_line":"            pool_name \u003d \"%s-pool\" % self.vg_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9OJE%3D","line":87,"in_reply_to":"AAAATn%2F9OYU%3D","updated":"2013-12-13 20:54:00.000000000","message":"?\n\nCinder never activates the VG today.  That is (correctly) left up the storage admin, I think?  Why do we need to?","commit_id":"80f547bc5eaac35c9f3cbcbe0203940268492fef"}]}