)]}'
{"id":"openstack%2Fcinder~62035","triplet_id":"openstack%2Fcinder~master~If48be8516fd71738cb83a91683c33d02f227b9d6","project":"openstack/cinder","branch":"master","topic":"bug/1260786","hashtags":[],"change_id":"If48be8516fd71738cb83a91683c33d02f227b9d6","subject":"LVM: Activate source snap LV when cloning from volume","status":"MERGED","created":"2013-12-13 16:28:43.000000000","updated":"2014-01-30 04:45:40.000000000","submitted":"2014-01-30 04:45:40.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"37995ede53fdfe3a7b8970fed2cdf54a9ad8d43a","_number":62035,"virtual_id_number":62035,"owner":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":7236,"name":"Kiyohiro Adachi","email":"kiy-adachi@vx.jp.nec.com","username":"kadachi"},{"value":0,"_account_id":7223,"name":"Ayal Baron","email":"abaron@redhat.com"},{"value":2,"date":"2014-01-30 04:45:40.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"all":[{"value":2,"date":"2014-01-28 23:35:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":1,"date":"2013-12-17 07:27:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true},{"value":0,"date":"2013-12-16 15:08:46.000000000","permitted_voting_range":{"min":0,"max":2},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":1,"date":"2013-12-18 04:40:51.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7236,"name":"Kiyohiro Adachi","email":"kiy-adachi@vx.jp.nec.com","username":"kadachi"},{"value":0,"date":"2013-12-18 14:54:38.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":7223,"name":"Ayal Baron","email":"abaron@redhat.com"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2014-01-28 14:29:35.000000000","_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"all":[{"value":1,"date":"2014-01-28 23:35:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true},{"value":0,"date":"2013-12-16 15:08:46.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":7236,"name":"Kiyohiro Adachi","email":"kiy-adachi@vx.jp.nec.com","username":"kadachi"},{"value":0,"_account_id":7223,"name":"Ayal Baron","email":"abaron@redhat.com"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2014-01-28 14:29:35.000000000","_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":7236,"name":"Kiyohiro Adachi","email":"kiy-adachi@vx.jp.nec.com","username":"kadachi"},{"value":0,"_account_id":7223,"name":"Ayal Baron","email":"abaron@redhat.com"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"_account_id":7223,"name":"Ayal Baron","email":"abaron@redhat.com"},{"_account_id":7236,"name":"Kiyohiro Adachi","email":"kiy-adachi@vx.jp.nec.com","username":"kadachi"},{"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-12-17 07:27:46.000000000","updated_by":{"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true},"reviewer":{"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true},"state":"REVIEWER"},{"updated":"2013-12-18 04:40:51.000000000","updated_by":{"_account_id":7236,"name":"Kiyohiro Adachi","email":"kiy-adachi@vx.jp.nec.com","username":"kadachi"},"reviewer":{"_account_id":7236,"name":"Kiyohiro Adachi","email":"kiy-adachi@vx.jp.nec.com","username":"kadachi"},"state":"REVIEWER"},{"updated":"2013-12-18 14:54:38.000000000","updated_by":{"_account_id":7223,"name":"Ayal Baron","email":"abaron@redhat.com"},"reviewer":{"_account_id":7223,"name":"Ayal Baron","email":"abaron@redhat.com"},"state":"REVIEWER"},{"updated":"2014-01-28 14:29:35.000000000","updated_by":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"reviewer":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"state":"REVIEWER"},{"updated":"2014-01-28 23:35:16.000000000","updated_by":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"reviewer":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"state":"REVIEWER"},{"updated":"2014-01-30 04:45:40.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e533ac07beb6e7f9c4582aa6d08a41e593c6fc36","author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"date":"2013-12-13 17:01:34.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"409b7625165949fd68d6f58f5e6e2daa1e6cd6a8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-13 17:59:22.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-cinder-pep8 http://logs.openstack.org/35/62035/1/check/gate-cinder-pep8/9fc91c4 : SUCCESS in 2m 41s\n- gate-cinder-docs http://docs-draft.openstack.org/35/62035/1/check/gate-cinder-docs/ecb5bf2/doc/build/html/ : SUCCESS in 14m 10s\n- gate-cinder-python26 http://logs.openstack.org/35/62035/1/check/gate-cinder-python26/d31eaf8 : SUCCESS in 4m 37s\n- gate-cinder-python27 http://logs.openstack.org/35/62035/1/check/gate-cinder-python27/7e72ef9 : SUCCESS in 4m 32s\n- gate-cinder-pylint http://logs.openstack.org/35/62035/1/check/gate-cinder-pylint/9401f0f : SUCCESS in 6m 08s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/35/62035/1/check/check-tempest-dsvm-full/5fe63f8 : FAILURE in 49m 22s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/35/62035/1/check/check-tempest-dsvm-postgres-full/f59a74e : FAILURE in 41m 33s\n- check-tempest-dsvm-neutron http://logs.openstack.org/35/62035/1/check/check-tempest-dsvm-neutron/2f04679 : SUCCESS in 34m 58s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/35/62035/1/check/gate-tempest-dsvm-large-ops/c7e4fed : SUCCESS in 16m 28s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/35/62035/1/check/gate-tempest-dsvm-neutron-large-ops/30dd443 : SUCCESS in 22m 03s\n- check-grenade-dsvm http://logs.openstack.org/35/62035/1/check/check-grenade-dsvm/87b8de7 : SUCCESS in 37m 07s\n","accounts_in_message":[],"_revision_number":1},{"id":"7a5a3ff7229529e3bf67458a44b03d6f9ca3991b","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2013-12-13 18:30:18.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nTempest caught a problem with this patch... needs to only run on thin clones, not thick LVM snaps as well.","accounts_in_message":[],"_revision_number":1},{"id":"d8f0ef1a91825c0d37c6c90393db8492d76b54f9","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2013-12-13 18:30:21.000000000","message":"Patch Set 1: Work In Progress","accounts_in_message":[],"_revision_number":1},{"id":"6c6552e4423b1520fd8484401c3cfd291dc135ae","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2013-12-13 18:47:39.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ee161b9cd81f989b5b6ef33faf9429c4fad3d38d","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2013-12-13 18:48:16.000000000","message":"Patch Set 2:\n\nPrior comment was wrong... thick is fine, problem was that it wasn\u0027t detecting that snap activation wasn\u0027t supported since is_snapshot\u003dTrue was missing from the call.","accounts_in_message":[],"_revision_number":2},{"id":"751f61967402751cf321e5be6578b3b25e5401b9","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2013-12-13 19:45:26.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nhmm.. I either commented on the wrong patch earlier or the crummy wifi I was on cut out at a bad time.\n\nSo this is cool that we\u0027re fixing these up for platforms that need to do the activate.  I was thinking it might be more appropriate to address all of these case in one single patch, and also I think it make more sense to put this in the  localdev/lvm file.  The LVM driver is a bit of a mess again, I\u0027d like to do some logical separation if nobody has any objections.","accounts_in_message":[],"_revision_number":2},{"id":"284df0bbf857a9d5bc7704d8665b4a0f09bd1ff5","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2013-12-13 19:57:10.000000000","message":"Patch Set 2:\n\nI\u0027m not opposed to the idea in general.  My concern is this:\n\nThe simple route is to just call lv_activate as part of create_lv_snapshot, which covers both cases that needed fixes here to activate snapshots.\n\nThe downside of that is you end up activating snapshots when they don\u0027t need to be active.  Is that actually bad?  It\u0027s at least wasteful... and may bump up against the reason that RHEL no longer automatically activates thin snaps, but I\u0027m not sure what that reason is.\n\nThere doesn\u0027t appear to be a better place to put the logic in brick to do activation at time of use.\n\nAt any rate, my argument for this particular patch is that since this is a one-liner that should have been in the original patch (which has already been merged into stable/havana), we should probably keep with the same scheme for the moment.","accounts_in_message":[],"_revision_number":2},{"id":"6cf683dc661cfe2307b24956389f4e847238e7c1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-13 20:15:43.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-cinder-pep8 http://logs.openstack.org/35/62035/2/check/gate-cinder-pep8/25287bc : SUCCESS in 2m 35s\n- gate-cinder-docs http://docs-draft.openstack.org/35/62035/2/check/gate-cinder-docs/e2e8879/doc/build/html/ : SUCCESS in 5m 34s\n- gate-cinder-python26 http://logs.openstack.org/35/62035/2/check/gate-cinder-python26/b481a80 : FAILURE in 5m 33s\n- gate-cinder-python27 http://logs.openstack.org/35/62035/2/check/gate-cinder-python27/bd24eed : FAILURE in 4m 28s\n- gate-cinder-pylint http://logs.openstack.org/35/62035/2/check/gate-cinder-pylint/c700d83 : SUCCESS in 6m 21s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/35/62035/2/check/check-tempest-dsvm-full/e5731a5 : SUCCESS in 46m 08s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/35/62035/2/check/check-tempest-dsvm-postgres-full/21bba05 : SUCCESS in 38m 45s\n- check-tempest-dsvm-neutron http://logs.openstack.org/35/62035/2/check/check-tempest-dsvm-neutron/2c16a20 : FAILURE in 41m 59s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/35/62035/2/check/gate-tempest-dsvm-large-ops/33773c8 : SUCCESS in 15m 09s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/35/62035/2/check/gate-tempest-dsvm-neutron-large-ops/027265b : SUCCESS in 16m 23s\n- check-grenade-dsvm http://logs.openstack.org/35/62035/2/check/check-grenade-dsvm/bcecdef : SUCCESS in 35m 07s\n","accounts_in_message":[],"_revision_number":2},{"id":"ec80a8f17a1f2644a00f9ddae053451787b29316","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2013-12-13 20:50:19.000000000","message":"Patch Set 2:\n\nfake_lvm activate_lv() needs arg added too.","accounts_in_message":[],"_revision_number":2},{"id":"bae72e7799d78293a9166d0148071ecbb6074646","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2013-12-13 20:50:28.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"b51a39ebdd18fc52ae1cd80d243d01065ebf5fb3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-13 22:22:07.000000000","message":"Patch Set 3: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-cinder-pep8 http://logs.openstack.org/35/62035/3/check/gate-cinder-pep8/028854a : SUCCESS in 1m 40s\n- gate-cinder-docs http://docs-draft.openstack.org/35/62035/3/check/gate-cinder-docs/1f2499b/doc/build/html/ : SUCCESS in 5m 20s\n- gate-cinder-python26 http://logs.openstack.org/35/62035/3/check/gate-cinder-python26/7c81de1 : SUCCESS in 5m 58s\n- gate-cinder-python27 http://logs.openstack.org/35/62035/3/check/gate-cinder-python27/9ea808f : SUCCESS in 3m 44s\n- gate-cinder-pylint http://logs.openstack.org/35/62035/3/check/gate-cinder-pylint/c14345b : SUCCESS in 5m 34s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/35/62035/3/check/check-tempest-dsvm-full/243526c : SUCCESS in 47m 30s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/35/62035/3/check/check-tempest-dsvm-postgres-full/6c32d30 : FAILURE in 1h 29m 39s\n- check-tempest-dsvm-neutron http://logs.openstack.org/35/62035/3/check/check-tempest-dsvm-neutron/348e993 : SUCCESS in 40m 05s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/35/62035/3/check/gate-tempest-dsvm-large-ops/ef27287 : SUCCESS in 17m 04s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/35/62035/3/check/gate-tempest-dsvm-neutron-large-ops/b296e13 : SUCCESS in 15m 56s\n- check-grenade-dsvm http://logs.openstack.org/35/62035/3/check/check-grenade-dsvm/c8c2e3c : SUCCESS in 41m 53s\n","accounts_in_message":[],"_revision_number":3},{"id":"632a9bc4814e10b145bf6e863d24780c3c10abef","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2013-12-13 22:25:59.000000000","message":"Patch Set 3:\n\nI noticed tempest failed, I think you hit bug(s):\n\n- https://bugs.launchpad.net/bugs/1218391\n- https://bugs.launchpad.net/bugs/1254872\n\nWe don\u0027t automatically recheck or reverify, so please consider\ndoing that manually if someone hasn\u0027t already. For a code review\nwhich is not yet approved, you can recheck by leaving a code\nreview comment with just the text:\n\n    recheck bug 1218391\n\nFor a code review which has been approved but failed to merge,\nyou can reverify by leaving a comment like this:\n\n    reverify bug 1218391","accounts_in_message":[],"_revision_number":3},{"id":"d9e98da2e5531ebd1d578e8e9938ad1f102906fd","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2013-12-16 15:08:46.000000000","message":"Patch Set 3:\n\nrecheck bug 1218391","accounts_in_message":[],"_revision_number":3},{"id":"53231aa60fd25848201ed1eed03e220ed703144c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-16 16:02:02.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- gate-cinder-pep8 http://logs.openstack.org/35/62035/3/check/gate-cinder-pep8/8c07fe1 : SUCCESS in 2m 52s\n- gate-cinder-docs http://docs-draft.openstack.org/35/62035/3/check/gate-cinder-docs/0c4da67/doc/build/html/ : SUCCESS in 3m 59s\n- gate-cinder-python26 http://logs.openstack.org/35/62035/3/check/gate-cinder-python26/41e20d0 : SUCCESS in 5m 48s\n- gate-cinder-python27 http://logs.openstack.org/35/62035/3/check/gate-cinder-python27/cda1b4c : SUCCESS in 5m 33s\n- gate-cinder-pylint http://logs.openstack.org/35/62035/3/check/gate-cinder-pylint/b9d052f : SUCCESS in 5m 01s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/35/62035/3/check/check-tempest-dsvm-full/ac46af5 : SUCCESS in 52m 46s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/35/62035/3/check/check-tempest-dsvm-postgres-full/a29aa78 : SUCCESS in 53m 04s\n- check-tempest-dsvm-neutron http://logs.openstack.org/35/62035/3/check/check-tempest-dsvm-neutron/0794c09 : SUCCESS in 38m 28s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/35/62035/3/check/gate-tempest-dsvm-large-ops/32cfd1f : SUCCESS in 14m 06s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/35/62035/3/check/gate-tempest-dsvm-neutron-large-ops/9878397 : SUCCESS in 15m 28s\n- check-grenade-dsvm http://logs.openstack.org/35/62035/3/check/check-grenade-dsvm/e4f408b : SUCCESS in 37m 12s\n","accounts_in_message":[],"_revision_number":3},{"id":"d46fb2a09f42389eff201cebd1532eeef2bcb655","author":{"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true},"date":"2013-12-17 07:27:46.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"f44848d79ff702c60cfa4ce3f5f3f16f65a8048d","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2013-12-17 20:37:43.000000000","message":"Patch Set 3:\n\n@jgriffith:  where in local_dev/lvm.py would that go exactly?","accounts_in_message":[],"_revision_number":3},{"id":"616c4edb4abc5f86997b038a5a3684d3b90d4a74","author":{"_account_id":7236,"name":"Kiyohiro Adachi","email":"kiy-adachi@vx.jp.nec.com","username":"kadachi"},"date":"2013-12-18 04:40:51.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"0f3369f30869371de656f73c527f95198fc9aa53","author":{"_account_id":7223,"name":"Ayal Baron","email":"abaron@redhat.com"},"date":"2013-12-18 14:54:38.000000000","message":"Patch Set 3: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"e8048f815dffc1b06155bcf1ca1ba452e291c59f","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2014-01-22 16:36:31.000000000","message":"Patch Set 3: (2 inline comments)\n\nAyal pointed out here that there may be another issue since we assume that LVs (for volumes, rather than snapshots) are active when trying to use them.\n\nWhile we probably should check this and activate them when needed, I don\u0027t think we know of any cases yet where this is likely to come up like it does for snapshot LVs, so that would be better addressed as a separate bug/patch.","accounts_in_message":[],"_revision_number":3},{"id":"cce97983e95e64bc740a728aab7db4ac2c45692b","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2014-01-23 15:30:15.000000000","message":"Patch Set 3:\n\nWrote bug 1271971 to look into the other issues here around (non-snapshot) LV activation.","accounts_in_message":[],"_revision_number":3},{"id":"3cacf7631c22bcfcb14f669b8d411896cd70758b","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2014-01-28 14:29:35.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"8e1c2222fc8d7bc2d9f5450517e5e20d010a952b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-28 23:35:16.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"3f140ae1c4c9bd6c82c8a9134249d5971182e6b0","author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"date":"2014-01-28 23:35:16.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\nIt sounds like the concerns that Eric raises are being addressed with a different bug/patch.  So, +A from me.","accounts_in_message":[],"_revision_number":3},{"id":"96457a8e04310dcf6464d7763228ff89993836eb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-29 15:20:20.000000000","message":"Patch Set 3: Fails\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-cinder-docs http://docs-draft.openstack.org/35/62035/3/gate/gate-cinder-docs/0b0cc22/doc/build/html/ : SUCCESS in 6m 37s\n- gate-cinder-pep8 http://logs.openstack.org/35/62035/3/gate/gate-cinder-pep8/4a9710b : SUCCESS in 3m 51s\n- gate-cinder-python26 http://logs.openstack.org/35/62035/3/gate/gate-cinder-python26/f159d52 : FAILURE in 25s\n- gate-cinder-python27 http://logs.openstack.org/35/62035/3/gate/gate-cinder-python27/c73eaea : SUCCESS in 5m 24s\n- gate-tempest-dsvm-full http://logs.openstack.org/35/62035/3/gate/gate-tempest-dsvm-full/8377ebe : SUCCESS in 50m 29s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/35/62035/3/gate/gate-tempest-dsvm-postgres-full/510bb6d : SUCCESS in 54m 23s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/35/62035/3/gate/gate-tempest-dsvm-neutron/529a887 : SUCCESS in 34m 38s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/35/62035/3/gate/gate-tempest-dsvm-large-ops/bea22c7 : SUCCESS in 14m 23s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/35/62035/3/gate/gate-tempest-dsvm-neutron-large-ops/cecac82 : SUCCESS in 12m 52s\n- gate-grenade-dsvm http://logs.openstack.org/35/62035/3/gate/gate-grenade-dsvm/a3fdf77 : SUCCESS in 28m 51s\n","accounts_in_message":[],"_revision_number":3},{"id":"2a6d2698abdec40cca7211079d68ccf978550671","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2014-01-29 15:29:05.000000000","message":"Patch Set 3:\n\nWait for bug 1274135 to be fixed, then reverify.","accounts_in_message":[],"_revision_number":3},{"id":"1ef6f6843760b7f4b999e39d2dad0d8573bb73e1","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2014-01-29 21:41:32.000000000","message":"Patch Set 3:\n\nreverify bug 1274135","accounts_in_message":[],"_revision_number":3},{"id":"55ef624b8795cfa9bf9336e2da51068ffbfb181e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-29 21:41:33.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"7eabb344ad8744a8aa37f6e30fe67ba1263e9c79","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-30 04:45:40.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3},{"id":"216b72afd5279513c7cc2e3d9fc17b11b925c07e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-30 04:45:40.000000000","message":"Patch Set 3: Verified\n\nBuild succeeded.\n\n- gate-cinder-docs http://docs-draft.openstack.org/35/62035/3/gate/gate-cinder-docs/d0fffcb/doc/build/html/ : SUCCESS in 6m 27s\n- gate-cinder-pep8 http://logs.openstack.org/35/62035/3/gate/gate-cinder-pep8/7c26b96 : SUCCESS in 4m 02s\n- gate-cinder-python26 http://logs.openstack.org/35/62035/3/gate/gate-cinder-python26/e3fa8f8 : SUCCESS in 6m 43s\n- gate-cinder-python27 http://logs.openstack.org/35/62035/3/gate/gate-cinder-python27/ed8a1cc : SUCCESS in 5m 26s\n- gate-tempest-dsvm-full http://logs.openstack.org/35/62035/3/gate/gate-tempest-dsvm-full/b31d97e : SUCCESS in 55m 31s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/35/62035/3/gate/gate-tempest-dsvm-postgres-full/8204c28 : SUCCESS in 59m 10s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/35/62035/3/gate/gate-tempest-dsvm-neutron/88b498b : SUCCESS in 38m 00s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/35/62035/3/gate/gate-tempest-dsvm-large-ops/b6a570a : SUCCESS in 11m 40s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/35/62035/3/gate/gate-tempest-dsvm-neutron-large-ops/fc2462b : SUCCESS in 15m 06s\n- gate-grenade-dsvm http://logs.openstack.org/35/62035/3/gate/gate-grenade-dsvm/11332d2 : SUCCESS in 33m 44s\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"673057320929d33095c998d477c2537567ccf74b","revisions":{"f1ddc9362cf50ecfdd55bf581512813c6af10c6b":{"kind":"REWORK","_number":1,"created":"2013-12-13 16:28:43.000000000","uploader":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"ref":"refs/changes/35/62035/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder","ref":"refs/changes/35/62035/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder refs/changes/35/62035/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder refs/changes/35/62035/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder refs/changes/35/62035/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder refs/changes/35/62035/1"}}},"commit":{"parents":[{"commit":"e3ce1ca32c758f71fb801e605a8ff0326223f69b","subject":"Merge \"Lazy log the fixed_key warnings\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/e3ce1ca32c758f71fb801e605a8ff0326223f69b"}]}],"author":{"name":"Eric Harney","email":"eharney@redhat.com","date":"2013-12-13 16:18:56.000000000","tz":-300},"committer":{"name":"Eric Harney","email":"eharney@redhat.com","date":"2013-12-13 16:28:20.000000000","tz":-300},"subject":"LVM: Activate source snap LV when cloning from volume","message":"LVM: Activate source snap LV when cloning from volume\n\nSimilar to the change made in:\n01a2199 LVM: Activate source LV before cloning from it\n\nPrevious change only fixed this issue for clone-from-snapshot.\n\nThis activates the source snapshot LV when cloning from volume\nas well, fixing the problem where cloning fails due to inability\nto open the source LV device.\n\nChange-Id: If48be8516fd71738cb83a91683c33d02f227b9d6\nRelated-Bug: 1252423\nCloses-Bug: 1260786\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/f1ddc9362cf50ecfdd55bf581512813c6af10c6b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/f1ddc9362cf50ecfdd55bf581512813c6af10c6b"}]},"branch":"refs/heads/master"},"699a44e2aaacde5e9bc0b390841ab2cb112e40e7":{"kind":"REWORK","_number":2,"created":"2013-12-13 18:47:39.000000000","uploader":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"ref":"refs/changes/35/62035/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder","ref":"refs/changes/35/62035/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder refs/changes/35/62035/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder refs/changes/35/62035/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder refs/changes/35/62035/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder refs/changes/35/62035/2"}}},"commit":{"parents":[{"commit":"e3ce1ca32c758f71fb801e605a8ff0326223f69b","subject":"Merge \"Lazy log the fixed_key warnings\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/e3ce1ca32c758f71fb801e605a8ff0326223f69b"}]}],"author":{"name":"Eric Harney","email":"eharney@redhat.com","date":"2013-12-13 16:18:56.000000000","tz":-300},"committer":{"name":"Eric Harney","email":"eharney@redhat.com","date":"2013-12-13 18:47:23.000000000","tz":-300},"subject":"LVM: Activate source snap LV when cloning from volume","message":"LVM: Activate source snap LV when cloning from volume\n\nSimilar to the change made in:\n01a2199 LVM: Activate source LV before cloning from it\n\nPrevious change only fixed this issue for clone-from-snapshot.\n\nThis activates the source snapshot LV when cloning from volume\nas well, fixing the problem where cloning fails due to inability\nto open the source LV device.\n\nChange-Id: If48be8516fd71738cb83a91683c33d02f227b9d6\nRelated-Bug: 1252423\nCloses-Bug: 1260786\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/699a44e2aaacde5e9bc0b390841ab2cb112e40e7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/699a44e2aaacde5e9bc0b390841ab2cb112e40e7"}]},"branch":"refs/heads/master"},"673057320929d33095c998d477c2537567ccf74b":{"kind":"REWORK","_number":3,"created":"2013-12-13 20:50:28.000000000","uploader":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"ref":"refs/changes/35/62035/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder","ref":"refs/changes/35/62035/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder refs/changes/35/62035/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder refs/changes/35/62035/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder refs/changes/35/62035/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder refs/changes/35/62035/3"}}},"commit":{"parents":[{"commit":"e3ce1ca32c758f71fb801e605a8ff0326223f69b","subject":"Merge \"Lazy log the fixed_key warnings\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/e3ce1ca32c758f71fb801e605a8ff0326223f69b"}]}],"author":{"name":"Eric Harney","email":"eharney@redhat.com","date":"2013-12-13 16:18:56.000000000","tz":-300},"committer":{"name":"Eric Harney","email":"eharney@redhat.com","date":"2013-12-13 20:49:59.000000000","tz":-300},"subject":"LVM: Activate source snap LV when cloning from volume","message":"LVM: Activate source snap LV when cloning from volume\n\nSimilar to the change made in:\n01a2199 LVM: Activate source LV before cloning from it\n\nPrevious change only fixed this issue for clone-from-snapshot.\n\nThis activates the source snapshot LV when cloning from volume\nas well, fixing the problem where cloning fails due to inability\nto open the source LV device.\n\nChange-Id: If48be8516fd71738cb83a91683c33d02f227b9d6\nRelated-Bug: 1252423\nCloses-Bug: 1260786\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/673057320929d33095c998d477c2537567ccf74b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/673057320929d33095c998d477c2537567ccf74b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}