)]}'
{"cinder/opts.py":[{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"2aee3dbf11ed98613dd2c4ef59e82fc1a28e6eed","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                cinder_volume_driver.iser_opts,"},{"line_number":278,"context_line":"                cinder_volume_driver.nvmet_opts,"},{"line_number":279,"context_line":"                cinder_volume_drivers_datera_dateraiscsi.d_opts,"},{"line_number":280,"context_line":"                cinder_volume_drivers_dell_emc_powermax_common.vmax_opts,"},{"line_number":281,"context_line":"                cinder_volume_drivers_dell_emc_ps.eqlx_opts,"},{"line_number":282,"context_line":"                cinder_volume_drivers_dell_emc_sc_storagecentercommon."},{"line_number":283,"context_line":"                common_opts,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_9556acd0","line":280,"updated":"2018-11-29 21:02:42.000000000","message":"vmax_opts to powermax_opts?","commit_id":"766d911673b88ca7214f28da0b69abb0a51dd7ae"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"d2d57d3b32846b19866f5e5ac2211a604e7093ee","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                cinder_volume_driver.iser_opts,"},{"line_number":278,"context_line":"                cinder_volume_driver.nvmet_opts,"},{"line_number":279,"context_line":"                cinder_volume_drivers_datera_dateraiscsi.d_opts,"},{"line_number":280,"context_line":"                cinder_volume_drivers_dell_emc_powermax_common.vmax_opts,"},{"line_number":281,"context_line":"                cinder_volume_drivers_dell_emc_ps.eqlx_opts,"},{"line_number":282,"context_line":"                cinder_volume_drivers_dell_emc_sc_storagecentercommon."},{"line_number":283,"context_line":"                common_opts,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_b21bacca","line":280,"in_reply_to":"3f79a3b5_9556acd0","updated":"2018-11-30 16:12:41.000000000","message":"Yes, we can do that.","commit_id":"766d911673b88ca7214f28da0b69abb0a51dd7ae"}],"cinder/tests/unit/volume/drivers/dell_emc/powermax/__init__.py":[{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"2aee3dbf11ed98613dd2c4ef59e82fc1a28e6eed","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from cinder.tests.unit.volume.drivers.dell_emc.vnx import fake_exception"},{"line_number":21,"context_line":"from cinder.tests.unit.volume.drivers.dell_emc.vnx import fake_storops"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"fake_vnx \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_550574bf","line":20,"updated":"2018-11-29 21:02:42.000000000","message":"Its confusing to see the vnx module being imported here. Some refactoring oppurtunity here?","commit_id":"766d911673b88ca7214f28da0b69abb0a51dd7ae"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"d2d57d3b32846b19866f5e5ac2211a604e7093ee","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from cinder.tests.unit.volume.drivers.dell_emc.vnx import fake_exception"},{"line_number":21,"context_line":"from cinder.tests.unit.volume.drivers.dell_emc.vnx import fake_storops"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"fake_vnx \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_f27e04e1","line":20,"in_reply_to":"3f79a3b5_550574bf","updated":"2018-11-30 16:12:41.000000000","message":"That is odd, this should be an empty file. I will remove the contents","commit_id":"766d911673b88ca7214f28da0b69abb0a51dd7ae"}],"cinder/volume/drivers/dell_emc/powermax/common.py":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"a56a545b487adb92bcff2827eed104dc16e53a0a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2018 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_70c2e203","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":19},"updated":"2018-12-13 16:28:53.000000000","message":"maybe we should do 2017-2018","commit_id":"6e48c52fad656d5826db7b15cd1a81b555758ff0"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"5abe1fde1b660c4c412c83b641a6f74c08e1094b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2018 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_946420b6","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":19},"in_reply_to":"3f79a3b5_70c2e203","updated":"2018-12-17 17:05:37.000000000","message":"Sure","commit_id":"6e48c52fad656d5826db7b15cd1a81b555758ff0"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2aa63e91f7478a3d10a44c70caa0f4e98eacb5c2","unresolved":false,"context_lines":[{"line_number":91,"context_line":"               help\u003d\u0027DEPRECATED: vmax_service_level.\u0027,"},{"line_number":92,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":93,"context_line":"               deprecated_reason\u003d\u0027Replaced by powermax_service_level.\u0027),"},{"line_number":94,"context_line":"    cfg.StrOpt(utils.VMAX_WORKLOAD,"},{"line_number":95,"context_line":"               help\u003d\u0027Workload, setting this as an extra spec in \u0027"},{"line_number":96,"context_line":"                    \u0027pool_name is preferable.\u0027),"},{"line_number":97,"context_line":"    cfg.ListOpt(utils.VMAX_PORT_GROUPS,"}],"source_content_type":"text/x-python","patch_set":20,"id":"bfdaf3ff_3d2bd130","line":94,"updated":"2019-01-15 15:29:17.000000000","message":"This one doesn\u0027t need to be deprecated and renamed?","commit_id":"76fd03819c08714660491ed3862ee7d6a2d92403"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"e8efa9011dff38408795c5ed0d57bc97a25a1d76","unresolved":false,"context_lines":[{"line_number":91,"context_line":"               help\u003d\u0027DEPRECATED: vmax_service_level.\u0027,"},{"line_number":92,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":93,"context_line":"               deprecated_reason\u003d\u0027Replaced by powermax_service_level.\u0027),"},{"line_number":94,"context_line":"    cfg.StrOpt(utils.VMAX_WORKLOAD,"},{"line_number":95,"context_line":"               help\u003d\u0027Workload, setting this as an extra spec in \u0027"},{"line_number":96,"context_line":"                    \u0027pool_name is preferable.\u0027),"},{"line_number":97,"context_line":"    cfg.ListOpt(utils.VMAX_PORT_GROUPS,"}],"source_content_type":"text/x-python","patch_set":20,"id":"bfdaf3ff_e07600d9","line":94,"in_reply_to":"bfdaf3ff_3d2bd130","updated":"2019-01-15 16:27:22.000000000","message":"Workload is no longer a concept in the new PowerMax array or VMAX AF (if it is updated to the new PowerMax OS).","commit_id":"76fd03819c08714660491ed3862ee7d6a2d92403"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"e8e53137c8e4c5e1109b725adee05bf675ad46c0","unresolved":false,"context_lines":[{"line_number":1687,"context_line":"        return volume_dict"},{"line_number":1688,"context_line":""},{"line_number":1689,"context_line":"    def _set_vmax_extra_specs(self, extra_specs, pool_record):"},{"line_number":1690,"context_line":"        \"\"\"Set the PowerMax/PowerMax/VMAX extra specs."},{"line_number":1691,"context_line":""},{"line_number":1692,"context_line":"        The pool_name extra spec must be set, otherwise a default slo/workload"},{"line_number":1693,"context_line":"        will be chosen. The portgroup can either be passed as an extra spec"}],"source_content_type":"text/x-python","patch_set":20,"id":"bfdaf3ff_067d2e7e","line":1690,"range":{"start_line":1690,"start_character":28,"end_line":1690,"end_character":35},"updated":"2019-01-17 15:07:24.000000000","message":"Looks like a duplication here.","commit_id":"76fd03819c08714660491ed3862ee7d6a2d92403"}],"cinder/volume/drivers/dell_emc/powermax/fc.py":[{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"2aee3dbf11ed98613dd2c4ef59e82fc1a28e6eed","unresolved":false,"context_lines":[{"line_number":103,"context_line":"              - Fix for HyperMax OS Upgrade Bug (bug #1790141)"},{"line_number":104,"context_line":"              - Support for failover to secondary Unisphere"},{"line_number":105,"context_line":"                (bp/vmax-unisphere-failover)"},{"line_number":106,"context_line":"              - Rebrand from VMAX to PowerMax(bp/vmax-powermax-rebrand)"},{"line_number":107,"context_line":"    \"\"\""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    VERSION \u003d \"3.3.0\""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_15185c1e","line":106,"updated":"2018-11-29 21:02:42.000000000","message":"Could we make a major or atleast version change pl?","commit_id":"766d911673b88ca7214f28da0b69abb0a51dd7ae"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"d2d57d3b32846b19866f5e5ac2211a604e7093ee","unresolved":false,"context_lines":[{"line_number":103,"context_line":"              - Fix for HyperMax OS Upgrade Bug (bug #1790141)"},{"line_number":104,"context_line":"              - Support for failover to secondary Unisphere"},{"line_number":105,"context_line":"                (bp/vmax-unisphere-failover)"},{"line_number":106,"context_line":"              - Rebrand from VMAX to PowerMax(bp/vmax-powermax-rebrand)"},{"line_number":107,"context_line":"    \"\"\""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    VERSION \u003d \"3.3.0\""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_1259408f","line":106,"in_reply_to":"3f79a3b5_15185c1e","updated":"2018-11-30 16:12:41.000000000","message":"3.3.0 is currently Stein. It is not our first release supporting the PowerMax array but perhaps the rebrand warrants a major release change. I will check with our PM. Thanks for bringing it up, leave it with me.","commit_id":"766d911673b88ca7214f28da0b69abb0a51dd7ae"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"1a9559405144c2b86689442536146289c42f07aa","unresolved":false,"context_lines":[{"line_number":98,"context_line":"              - Fix for SSL verification/cert application (bug #1772924)"},{"line_number":99,"context_line":"              - Log VMAX metadata of a volume (bp vmax-metadata)"},{"line_number":100,"context_line":"              - Fix for get-pools command (bug #1784856)"},{"line_number":101,"context_line":"        3.3.0 - Fix for initiator retrieval and short hostname unmapping"},{"line_number":102,"context_line":"                (bugs #1783855 #1783867)"},{"line_number":103,"context_line":"              - Fix for HyperMax OS Upgrade Bug (bug #1790141)"},{"line_number":104,"context_line":"              - Support for failover to secondary Unisphere"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_0f13cbb2","line":101,"range":{"start_line":101,"start_character":8,"end_line":101,"end_character":14},"updated":"2018-12-07 15:34:31.000000000","message":"Do you really want to rebrand your driver and not bump the version number?","commit_id":"9a286221a7e45ae03a29f84c47846441d407a996"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"a56a545b487adb92bcff2827eed104dc16e53a0a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2018 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_3036aa03","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2018-12-13 16:28:53.000000000","message":"ditto","commit_id":"6e48c52fad656d5826db7b15cd1a81b555758ff0"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"192c2e8fcebbd808988bc76f181817a7b7dadc6a","unresolved":false,"context_lines":[{"line_number":103,"context_line":"              - Fix for HyperMax OS Upgrade Bug (bug #1790141)"},{"line_number":104,"context_line":"              - Support for failover to secondary Unisphere"},{"line_number":105,"context_line":"                (bp/vmax-unisphere-failover)"},{"line_number":106,"context_line":"              - Rebrand from VMAX to PowerMax(bp/vmax-powermax-rebrand)"},{"line_number":107,"context_line":"    \"\"\""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    VERSION \u003d \"3.3.0\""}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_f0ecb2be","line":106,"updated":"2018-12-13 16:04:21.000000000","message":"I would really like the version to be updated for rebranding. This helps in several places","commit_id":"6e48c52fad656d5826db7b15cd1a81b555758ff0"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"f7034b0383ea983518662ae68505a8793ad90778","unresolved":false,"context_lines":[{"line_number":103,"context_line":"              - Fix for HyperMax OS Upgrade Bug (bug #1790141)"},{"line_number":104,"context_line":"              - Support for failover to secondary Unisphere"},{"line_number":105,"context_line":"                (bp/vmax-unisphere-failover)"},{"line_number":106,"context_line":"              - Rebrand from VMAX to PowerMax(bp/vmax-powermax-rebrand)"},{"line_number":107,"context_line":"    \"\"\""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    VERSION \u003d \"3.3.0\""}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_f3ecbcbe","line":106,"in_reply_to":"3f79a3b5_300f8a39","updated":"2018-12-13 16:42:09.000000000","message":"Yes 4.0.0","commit_id":"6e48c52fad656d5826db7b15cd1a81b555758ff0"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"a56a545b487adb92bcff2827eed104dc16e53a0a","unresolved":false,"context_lines":[{"line_number":103,"context_line":"              - Fix for HyperMax OS Upgrade Bug (bug #1790141)"},{"line_number":104,"context_line":"              - Support for failover to secondary Unisphere"},{"line_number":105,"context_line":"                (bp/vmax-unisphere-failover)"},{"line_number":106,"context_line":"              - Rebrand from VMAX to PowerMax(bp/vmax-powermax-rebrand)"},{"line_number":107,"context_line":"    \"\"\""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    VERSION \u003d \"3.3.0\""}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_300f8a39","line":106,"in_reply_to":"3f79a3b5_f0ecb2be","updated":"2018-12-13 16:28:53.000000000","message":"Rajini, are you asking for a version fully dedicated to re-branding only?","commit_id":"6e48c52fad656d5826db7b15cd1a81b555758ff0"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"5abe1fde1b660c4c412c83b641a6f74c08e1094b","unresolved":false,"context_lines":[{"line_number":103,"context_line":"              - Fix for HyperMax OS Upgrade Bug (bug #1790141)"},{"line_number":104,"context_line":"              - Support for failover to secondary Unisphere"},{"line_number":105,"context_line":"                (bp/vmax-unisphere-failover)"},{"line_number":106,"context_line":"              - Rebrand from VMAX to PowerMax(bp/vmax-powermax-rebrand)"},{"line_number":107,"context_line":"    \"\"\""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    VERSION \u003d \"3.3.0\""}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_94f980c7","line":106,"in_reply_to":"3f79a3b5_f3ecbcbe","updated":"2018-12-17 17:05:37.000000000","message":"I did bring this up with PM and it was mentioned we will go to 4.0 when we move up to the next version of Unisphere for PowerMax(T release).  I will circle back with them on this.","commit_id":"6e48c52fad656d5826db7b15cd1a81b555758ff0"}],"cinder/volume/drivers/dell_emc/powermax/iscsi.py":[{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"2aee3dbf11ed98613dd2c4ef59e82fc1a28e6eed","unresolved":false,"context_lines":[{"line_number":108,"context_line":"              - Fix for HyperMax OS Upgrade Bug (bug #1790141)"},{"line_number":109,"context_line":"              - Support for failover to secondary Unisphere"},{"line_number":110,"context_line":"                (bp/vmax-unisphere-failover)"},{"line_number":111,"context_line":"              - Rebrand from VMAX to PowerMax(bp/vmax-powermax-rebrand)"},{"line_number":112,"context_line":"    \"\"\""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    VERSION \u003d \"3.3.0\""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_351558e8","line":111,"updated":"2018-11-29 21:02:42.000000000","message":"Could we make a major or atleast version change pl?","commit_id":"766d911673b88ca7214f28da0b69abb0a51dd7ae"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"d2d57d3b32846b19866f5e5ac2211a604e7093ee","unresolved":false,"context_lines":[{"line_number":108,"context_line":"              - Fix for HyperMax OS Upgrade Bug (bug #1790141)"},{"line_number":109,"context_line":"              - Support for failover to secondary Unisphere"},{"line_number":110,"context_line":"                (bp/vmax-unisphere-failover)"},{"line_number":111,"context_line":"              - Rebrand from VMAX to PowerMax(bp/vmax-powermax-rebrand)"},{"line_number":112,"context_line":"    \"\"\""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    VERSION \u003d \"3.3.0\""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_924c70cb","line":111,"in_reply_to":"3f79a3b5_351558e8","updated":"2018-11-30 16:12:41.000000000","message":"3.3.0 is currently Stein. It is not our first release supporting the PowerMax array but perhaps the rebrand warrants a major release change. I will check with our PM. Thanks for bringing it up, leave it with me.","commit_id":"766d911673b88ca7214f28da0b69abb0a51dd7ae"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"a56a545b487adb92bcff2827eed104dc16e53a0a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2018 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_90fd3e0c","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":20},"updated":"2018-12-13 16:28:53.000000000","message":"ditto","commit_id":"6e48c52fad656d5826db7b15cd1a81b555758ff0"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"90c7c0a23ea5c1ce0b1dac82dcfde21cd6412490","unresolved":false,"context_lines":[{"line_number":103,"context_line":"              - Fix for SSL verification/cert application (bug #1772924)"},{"line_number":104,"context_line":"              - Log VMAX metadata of a volume (bp vmax-metadata)"},{"line_number":105,"context_line":"              - Fix for get-pools command (bug #1784856)"},{"line_number":106,"context_line":"        4.0.0 - Fix for initiator retrieval and short hostname unmapping"},{"line_number":107,"context_line":"                (bugs #1783855 #1783867)"},{"line_number":108,"context_line":"              - Fix for HyperMax OS Upgrade Bug (bug #1790141)"},{"line_number":109,"context_line":"              - Support for failover to secondary Unisphere"},{"line_number":110,"context_line":"                (bp/vmax-unisphere-failover)"},{"line_number":111,"context_line":"              - Rebrand from VMAX to PowerMax(bp/vmax-powermax-rebrand)"},{"line_number":112,"context_line":"    \"\"\""},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_b55b4c22","line":110,"range":{"start_line":106,"start_character":16,"end_line":110,"end_character":44},"updated":"2018-12-17 21:33:53.000000000","message":"do you want make these 3.3 and rebranding as 4.0.0?\nOr is too late for it?","commit_id":"f9b26858ad7d29f3ef39a208b656961d8f23d18c"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"87e0362eab39c25ee8437b058b643bbf00a3a52e","unresolved":false,"context_lines":[{"line_number":103,"context_line":"              - Fix for SSL verification/cert application (bug #1772924)"},{"line_number":104,"context_line":"              - Log VMAX metadata of a volume (bp vmax-metadata)"},{"line_number":105,"context_line":"              - Fix for get-pools command (bug #1784856)"},{"line_number":106,"context_line":"        4.0.0 - Fix for initiator retrieval and short hostname unmapping"},{"line_number":107,"context_line":"                (bugs #1783855 #1783867)"},{"line_number":108,"context_line":"              - Fix for HyperMax OS Upgrade Bug (bug #1790141)"},{"line_number":109,"context_line":"              - Support for failover to secondary Unisphere"},{"line_number":110,"context_line":"                (bp/vmax-unisphere-failover)"},{"line_number":111,"context_line":"              - Rebrand from VMAX to PowerMax(bp/vmax-powermax-rebrand)"},{"line_number":112,"context_line":"    \"\"\""},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_b976d390","line":110,"range":{"start_line":106,"start_character":16,"end_line":110,"end_character":44},"in_reply_to":"3f79a3b5_b55b4c22","updated":"2018-12-18 17:12:09.000000000","message":"These are the fixes that have gone in since Rocky went GA so they will release in 4.0.0.  We have a single version per OpenStack release, 4.0.0 \u003d Stein.  Is that ok?","commit_id":"f9b26858ad7d29f3ef39a208b656961d8f23d18c"}],"cinder/volume/drivers/dell_emc/powermax/masking.py":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"a56a545b487adb92bcff2827eed104dc16e53a0a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2018 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_7323ccaa","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2018-12-13 16:28:53.000000000","message":"ditto","commit_id":"6e48c52fad656d5826db7b15cd1a81b555758ff0"}],"cinder/volume/drivers/dell_emc/powermax/provision.py":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"a56a545b487adb92bcff2827eed104dc16e53a0a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2018 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_33523413","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":20},"updated":"2018-12-13 16:28:53.000000000","message":"ditto\nNeed to do be done for all files.","commit_id":"6e48c52fad656d5826db7b15cd1a81b555758ff0"}],"cinder/volume/drivers/dell_emc/powermax/utils.py":[{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"d58796e4b064ceb6cfcf234a87281f197e403a85","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        array \u003d host_list[(len(host_list) - 1)]"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        if device_id:"},{"line_number":352,"context_line":"            if len(device_id) !\u003d 5:"},{"line_number":353,"context_line":"                error_message \u003d (_(\"Device ID: %(device_id)s is invalid. \""},{"line_number":354,"context_line":"                                   \"Device ID should be exactly 5 digits.\") %"},{"line_number":355,"context_line":"                                 {\u0027device_id\u0027: device_id})"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_1465d4e4","line":352,"updated":"2018-12-11 19:19:32.000000000","message":"Looks like unrelated change to rename of product","commit_id":"6e48c52fad656d5826db7b15cd1a81b555758ff0"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"5abe1fde1b660c4c412c83b641a6f74c08e1094b","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        array \u003d host_list[(len(host_list) - 1)]"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        if device_id:"},{"line_number":352,"context_line":"            if len(device_id) !\u003d 5:"},{"line_number":353,"context_line":"                error_message \u003d (_(\"Device ID: %(device_id)s is invalid. \""},{"line_number":354,"context_line":"                                   \"Device ID should be exactly 5 digits.\") %"},{"line_number":355,"context_line":"                                 {\u0027device_id\u0027: device_id})"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_74cdc48f","line":352,"in_reply_to":"3f79a3b5_10ddae11","updated":"2018-12-17 17:05:37.000000000","message":"no worries","commit_id":"6e48c52fad656d5826db7b15cd1a81b555758ff0"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"ee07ff30433b1b9eab62b2d5fe3c5f0bc85cfa1c","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        array \u003d host_list[(len(host_list) - 1)]"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        if device_id:"},{"line_number":352,"context_line":"            if len(device_id) !\u003d 5:"},{"line_number":353,"context_line":"                error_message \u003d (_(\"Device ID: %(device_id)s is invalid. \""},{"line_number":354,"context_line":"                                   \"Device ID should be exactly 5 digits.\") %"},{"line_number":355,"context_line":"                                 {\u0027device_id\u0027: device_id})"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_10ddae11","line":352,"in_reply_to":"3f79a3b5_1465d4e4","updated":"2018-12-13 16:03:05.000000000","message":"I was looking at the diff of the wrong version.","commit_id":"6e48c52fad656d5826db7b15cd1a81b555758ff0"}],"cinder/volume/manager.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"75dbe027d29d0c3303ad88b230a7e136d00367cb","unresolved":false,"context_lines":[{"line_number":154,"context_line":"CONF \u003d cfg.CONF"},{"line_number":155,"context_line":"CONF.register_opts(volume_manager_opts)"},{"line_number":156,"context_line":"CONF.register_opts(volume_backend_opts, group\u003dconfig.SHARED_CONF_GROUP)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"MAPPING \u003d {"},{"line_number":159,"context_line":"    \u0027cinder.volume.drivers.windows.windows.WindowsDriver\u0027:"},{"line_number":160,"context_line":"    \u0027cinder.volume.drivers.windows.iscsi.WindowsISCSIDriver\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_acf862c1","line":157,"updated":"2018-11-28 17:21:40.000000000","message":"Please don\u0027t remove the comment explaining what MAPPING is for.","commit_id":"3fc97683d0be087997f1896dc24601e769e456d9"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"75dbe027d29d0c3303ad88b230a7e136d00367cb","unresolved":false,"context_lines":[{"line_number":156,"context_line":"CONF.register_opts(volume_backend_opts, group\u003dconfig.SHARED_CONF_GROUP)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"MAPPING \u003d {"},{"line_number":159,"context_line":"    \u0027cinder.volume.drivers.windows.windows.WindowsDriver\u0027:"},{"line_number":160,"context_line":"    \u0027cinder.volume.drivers.windows.iscsi.WindowsISCSIDriver\u0027,"},{"line_number":161,"context_line":"    \u0027cinder.volume.drivers.dell_emc.vmax.iscsi.VMAXISCSIDriver\u0027:"},{"line_number":162,"context_line":"    \u0027cinder.volume.drivers.dell_emc.powermax.iscsi.PowerMaxISCSIDriver\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_ccf35ee4","line":159,"range":{"start_line":159,"start_character":5,"end_line":159,"end_character":56},"updated":"2018-11-28 17:21:40.000000000","message":"Why are these being added?","commit_id":"3fc97683d0be087997f1896dc24601e769e456d9"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"75dbe027d29d0c3303ad88b230a7e136d00367cb","unresolved":false,"context_lines":[{"line_number":691,"context_line":"                self._update_allocated_capacity(volume, decrement\u003dTrue,"},{"line_number":692,"context_line":"                                                host\u003doriginal_host)"},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"        shared_targets \u003d ("},{"line_number":695,"context_line":"            1"},{"line_number":696,"context_line":"            if self.driver.capabilities.get(\u0027shared_targets\u0027, True)"},{"line_number":697,"context_line":"            else 0)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_6c280a35","line":694,"updated":"2018-11-28 17:21:40.000000000","message":"This doesn\u0027t look related.","commit_id":"3fc97683d0be087997f1896dc24601e769e456d9"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"bae4bff2e3098d3b8d38deab964a6d9ae0869b43","unresolved":false,"context_lines":[{"line_number":160,"context_line":"# new name (the dict value) for at least a cycle to allow time for deployments"},{"line_number":161,"context_line":"# to transition."},{"line_number":162,"context_line":"MAPPING \u003d {"},{"line_number":163,"context_line":"    \u0027cinder.volume.drivers.windows.windows.WindowsDriver\u0027:"},{"line_number":164,"context_line":"    \u0027cinder.volume.drivers.windows.iscsi.WindowsISCSIDriver\u0027,"},{"line_number":165,"context_line":"    \u0027cinder.volume.drivers.dell_emc.vmax.iscsi.VMAXISCSIDriver\u0027:"},{"line_number":166,"context_line":"    \u0027cinder.volume.drivers.dell_emc.powermax.iscsi.PowerMaxISCSIDriver\u0027,"},{"line_number":167,"context_line":"    \u0027cinder.volume.drivers.dell_emc.vmax.fc.VMAXFCDriver\u0027:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_57c8e34c","line":164,"range":{"start_line":163,"start_character":0,"end_line":164,"end_character":61},"updated":"2018-12-03 18:17:02.000000000","message":"-1: Unrelated change","commit_id":"ace949135e8267de416b7c561a8566575daa455a"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"dd703202fdb6a60c2f3c4c014ddbbce91df53d0e","unresolved":false,"context_lines":[{"line_number":160,"context_line":"# new name (the dict value) for at least a cycle to allow time for deployments"},{"line_number":161,"context_line":"# to transition."},{"line_number":162,"context_line":"MAPPING \u003d {"},{"line_number":163,"context_line":"    \u0027cinder.volume.drivers.windows.windows.WindowsDriver\u0027:"},{"line_number":164,"context_line":"    \u0027cinder.volume.drivers.windows.iscsi.WindowsISCSIDriver\u0027,"},{"line_number":165,"context_line":"    \u0027cinder.volume.drivers.dell_emc.vmax.iscsi.VMAXISCSIDriver\u0027:"},{"line_number":166,"context_line":"    \u0027cinder.volume.drivers.dell_emc.powermax.iscsi.PowerMaxISCSIDriver\u0027,"},{"line_number":167,"context_line":"    \u0027cinder.volume.drivers.dell_emc.vmax.fc.VMAXFCDriver\u0027:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_57d223d2","line":164,"range":{"start_line":163,"start_character":0,"end_line":164,"end_character":61},"in_reply_to":"3f79a3b5_57c8e34c","updated":"2018-12-03 18:20:09.000000000","message":"Sure. I will remove","commit_id":"ace949135e8267de416b7c561a8566575daa455a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0a846b70834fa8e2e0f2fe38443a7eaca8649b4a","unresolved":false,"context_lines":[{"line_number":159,"context_line":"# driver is renamed, add a mapping here from the old name (the dict key) to the"},{"line_number":160,"context_line":"# new name (the dict value) for at least a cycle to allow time for deployments"},{"line_number":161,"context_line":"# to transition."},{"line_number":162,"context_line":"MAPPING \u003d {"},{"line_number":163,"context_line":"}"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_d2f6412d","line":162,"updated":"2018-12-03 18:30:31.000000000","message":"-1: You removed too much, only the windows part should have been removed.","commit_id":"cbc308056520b888f12a31c95e5414cf658cba0d"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"ed9373adce15931c3510c85c11db1504c6e4a07e","unresolved":false,"context_lines":[{"line_number":159,"context_line":"# driver is renamed, add a mapping here from the old name (the dict key) to the"},{"line_number":160,"context_line":"# new name (the dict value) for at least a cycle to allow time for deployments"},{"line_number":161,"context_line":"# to transition."},{"line_number":162,"context_line":"MAPPING \u003d {"},{"line_number":163,"context_line":"}"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_baafccdf","line":162,"in_reply_to":"3f79a3b5_d2f6412d","updated":"2018-12-04 10:19:01.000000000","message":"Apologies, I misread","commit_id":"cbc308056520b888f12a31c95e5414cf658cba0d"}],"doc/source/configuration/block-storage/drivers/dell-emc-powermax-driver.rst":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"a56a545b487adb92bcff2827eed104dc16e53a0a","unresolved":false,"context_lines":[{"line_number":584,"context_line":""},{"line_number":585,"context_line":"   .. code-block:: ini"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"      [PMAX_ISCSI]"},{"line_number":588,"context_line":"      volume_driver \u003d cinder.volume.drivers.dell_emc.powermax.iscsi.PowerMaxISCSIDriver"},{"line_number":589,"context_line":"      volume_backend_name \u003d PMAX_ISCSI"},{"line_number":590,"context_line":"      san_ip \u003d 10.10.10.10"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_3379d480","line":587,"range":{"start_line":587,"start_character":7,"end_line":587,"end_character":11},"updated":"2018-12-13 16:28:53.000000000","message":"DO we really want to use PMAX? We used POWERMAX everywhere else. I think it will be confusing to use PMAX in some places and POWERMAX in others. SUggest use POWERMAX everywhere.","commit_id":"6e48c52fad656d5826db7b15cd1a81b555758ff0"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"5abe1fde1b660c4c412c83b641a6f74c08e1094b","unresolved":false,"context_lines":[{"line_number":584,"context_line":""},{"line_number":585,"context_line":"   .. code-block:: ini"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"      [PMAX_ISCSI]"},{"line_number":588,"context_line":"      volume_driver \u003d cinder.volume.drivers.dell_emc.powermax.iscsi.PowerMaxISCSIDriver"},{"line_number":589,"context_line":"      volume_backend_name \u003d PMAX_ISCSI"},{"line_number":590,"context_line":"      san_ip \u003d 10.10.10.10"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_94c0a04d","line":587,"range":{"start_line":587,"start_character":7,"end_line":587,"end_character":11},"in_reply_to":"3f79a3b5_3379d480","updated":"2018-12-17 17:05:37.000000000","message":"Agreed.  I will change this.","commit_id":"6e48c52fad656d5826db7b15cd1a81b555758ff0"}],"releasenotes/notes/vmax-powermax-rebrand-70569fc8cdf40a8c.yaml":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0a846b70834fa8e2e0f2fe38443a7eaca8649b4a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    PowerMax driver - \u0027PowerMax\u0027 is to replace \u0027VMAX\u0027 in release notes,"},{"line_number":5,"context_line":"    online documentation, directory structure and driver name."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_523311f9","line":2,"updated":"2018-12-03 18:30:31.000000000","message":"This should go in the upgrade section, as this is not a feature, right?","commit_id":"cbc308056520b888f12a31c95e5414cf658cba0d"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"ed9373adce15931c3510c85c11db1504c6e4a07e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    PowerMax driver - \u0027PowerMax\u0027 is to replace \u0027VMAX\u0027 in release notes,"},{"line_number":5,"context_line":"    online documentation, directory structure and driver name."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f79a3b5_5a78f87b","line":2,"in_reply_to":"3f79a3b5_523311f9","updated":"2018-12-04 10:19:01.000000000","message":"Correct, this is better suited to the upgrade section","commit_id":"cbc308056520b888f12a31c95e5414cf658cba0d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2aa63e91f7478a3d10a44c70caa0f4e98eacb5c2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    PowerMax driver - \u0027PowerMax\u0027 is to replace \u0027VMAX\u0027 in release notes,"},{"line_number":5,"context_line":"    online documentation, directory structure and driver name."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"bfdaf3ff_dd7de51c","line":2,"updated":"2019-01-15 15:29:17.000000000","message":"This sounds a little awkward to me and is missing some useful details. Not too important, but if you do an update, what about something like:\n\nDell EMC VMAX has been rebranded to PowerMax. The drivers ``cinder.volume.drivers.dell_emc.vmax.iscsi.VMaxISCSIDriver`` and ``cinder.volume.drivers.dell_emc.vmax.fc.VMaxFCDriver`` should now be updated to ``cinder.volume.drivers.dell_emc.powermax.iscsi.PowerMaxISCSIDriver`` or ``cinder.volume.drivers.dell_emc.powermax.fc.PowerMaxFCDriver`` in cinder.conf. Driver configuration options that start with `vmax` should also be updated to ``powermax``. Existing vmax configuration options will continue to work but will be removed in the Train release.","commit_id":"76fd03819c08714660491ed3862ee7d6a2d92403"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"e8e53137c8e4c5e1109b725adee05bf675ad46c0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    PowerMax driver - \u0027PowerMax\u0027 is to replace \u0027VMAX\u0027 in release notes,"},{"line_number":5,"context_line":"    online documentation, directory structure and driver name."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"bfdaf3ff_66751a64","line":2,"in_reply_to":"bfdaf3ff_2046487e","updated":"2019-01-17 15:07:24.000000000","message":"I agree that this needs to be fixed but we can do this as a follow up.","commit_id":"76fd03819c08714660491ed3862ee7d6a2d92403"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"e8efa9011dff38408795c5ed0d57bc97a25a1d76","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    PowerMax driver - \u0027PowerMax\u0027 is to replace \u0027VMAX\u0027 in release notes,"},{"line_number":5,"context_line":"    online documentation, directory structure and driver name."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"bfdaf3ff_2046487e","line":2,"in_reply_to":"bfdaf3ff_dd7de51c","updated":"2019-01-15 16:27:22.000000000","message":"Thanks Sean, I will certainly update if there is further feedback.","commit_id":"76fd03819c08714660491ed3862ee7d6a2d92403"}]}