)]}'
{"cinder/volume/drivers/netapp/eseries/library.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"2e4af51d1bcdc5e88d829539db9e03a1c23b2d2a","unresolved":false,"context_lines":[{"line_number":1292,"context_line":"                  msg_fmt)"},{"line_number":1293,"context_line":""},{"line_number":1294,"context_line":"        iscsi_details \u003d self._get_iscsi_service_details()"},{"line_number":1295,"context_line":"        iscsi_portals \u003d self._get_iscsi_portals_for_vol(eseries_vol,"},{"line_number":1296,"context_line":"                                                        iscsi_details)"},{"line_number":1297,"context_line":"        LOG.debug(\"Successfully fetched target details for volume %(id)s and \""},{"line_number":1298,"context_line":"                  \"initiator %(initiator_name)s.\", msg_fmt)"},{"line_number":1299,"context_line":"        iqns \u003d [portal[\u0027iqn\u0027] for portal in iscsi_portals]"},{"line_number":1300,"context_line":"        addresses \u003d [portal[\u0027ip\u0027] for portal in iscsi_portals]"},{"line_number":1301,"context_line":"        ports \u003d [portal[\u0027tcp_port\u0027] for portal in iscsi_portals]"},{"line_number":1302,"context_line":"        properties \u003d na_utils.get_iscsi_connection_properties(lun_id, volume,"},{"line_number":1303,"context_line":"                                                              iqns, addresses,"},{"line_number":1304,"context_line":"                                                              ports)"},{"line_number":1305,"context_line":"        if self.configuration.use_chap_auth:"},{"line_number":1306,"context_line":"            if self._client.features.CHAP_AUTHENTICATION:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_a056b32b","line":1303,"range":{"start_line":1295,"start_character":8,"end_line":1303,"end_character":74},"updated":"2018-12-17 17:06:22.000000000","message":"-1: The eseries driver was deprecated in the last release and will be removed in this one, so you shouldn\u0027d need to add this fix here. We will work on the multipath testing for this in the next weeks. Hopefully adding that to our CI.","commit_id":"28be74f6048d0ae0a889c45a9e57dae05a31fb4b"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"cb2072c96deef9457a42c78e15d1e1990013d618","unresolved":false,"context_lines":[{"line_number":1292,"context_line":"                  msg_fmt)"},{"line_number":1293,"context_line":""},{"line_number":1294,"context_line":"        iscsi_details \u003d self._get_iscsi_service_details()"},{"line_number":1295,"context_line":"        iscsi_portals \u003d self._get_iscsi_portals_for_vol(eseries_vol,"},{"line_number":1296,"context_line":"                                                        iscsi_details)"},{"line_number":1297,"context_line":"        LOG.debug(\"Successfully fetched target details for volume %(id)s and \""},{"line_number":1298,"context_line":"                  \"initiator %(initiator_name)s.\", msg_fmt)"},{"line_number":1299,"context_line":"        iqns \u003d [portal[\u0027iqn\u0027] for portal in iscsi_portals]"},{"line_number":1300,"context_line":"        addresses \u003d [portal[\u0027ip\u0027] for portal in iscsi_portals]"},{"line_number":1301,"context_line":"        ports \u003d [portal[\u0027tcp_port\u0027] for portal in iscsi_portals]"},{"line_number":1302,"context_line":"        properties \u003d na_utils.get_iscsi_connection_properties(lun_id, volume,"},{"line_number":1303,"context_line":"                                                              iqns, addresses,"},{"line_number":1304,"context_line":"                                                              ports)"},{"line_number":1305,"context_line":"        if self.configuration.use_chap_auth:"},{"line_number":1306,"context_line":"            if self._client.features.CHAP_AUTHENTICATION:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_f21b1a6b","line":1303,"range":{"start_line":1295,"start_character":8,"end_line":1303,"end_character":74},"in_reply_to":"3f79a3b5_a056b32b","updated":"2018-12-17 20:46:59.000000000","message":"I have to add it here since the code is still in the tree.  Otherwise I start messing the backporting process, because I would have to propose an additional patch to the stable branch, and that patch would not be in master, even though both have the same issue.","commit_id":"28be74f6048d0ae0a889c45a9e57dae05a31fb4b"}],"cinder/volume/drivers/netapp/utils.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3079617e493cc92d74b3a8fc61ebec9b7995b0ed","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    if len(addresses) \u003e 1:"},{"line_number":187,"context_line":"        properties[\u0027target_portals\u0027] \u003d target_portals"},{"line_number":188,"context_line":"        properties[\u0027target_iqns\u0027] \u003d iqns"},{"line_number":189,"context_line":"        properties[\u0027target_luns\u0027] \u003d [lun_id] * len(addresses)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    auth \u003d volume[\u0027provider_auth\u0027]"},{"line_number":192,"context_line":"    if auth:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_ec8e94cf","line":189,"range":{"start_line":189,"start_character":36,"end_line":189,"end_character":61},"updated":"2019-02-14 05:30:16.000000000","message":"so here we\u0027re creating a list of same lun_id for all addresses,\ncan\u0027t we use properties[\u0027target_lun\u0027] for all (address,port) ?","commit_id":"c65869626594522231709d9c90a30524a1f0d18c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9294bdc6a0157a0f78ee812ea2c06ee1f9c9e137","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    if len(addresses) \u003e 1:"},{"line_number":187,"context_line":"        properties[\u0027target_portals\u0027] \u003d target_portals"},{"line_number":188,"context_line":"        properties[\u0027target_iqns\u0027] \u003d iqns"},{"line_number":189,"context_line":"        properties[\u0027target_luns\u0027] \u003d [lun_id] * len(addresses)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    auth \u003d volume[\u0027provider_auth\u0027]"},{"line_number":192,"context_line":"    if auth:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_3e6fc328","line":189,"range":{"start_line":189,"start_character":36,"end_line":189,"end_character":61},"in_reply_to":"9fdfeff1_3607f9cc","updated":"2019-02-15 10:09:56.000000000","message":"Yes, i was referring to the same (with an ambiguous question i guess). Thanks for explaining.","commit_id":"c65869626594522231709d9c90a30524a1f0d18c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9981b156252e69bc251f4b01f809a26809dd9375","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    if len(addresses) \u003e 1:"},{"line_number":187,"context_line":"        properties[\u0027target_portals\u0027] \u003d target_portals"},{"line_number":188,"context_line":"        properties[\u0027target_iqns\u0027] \u003d iqns"},{"line_number":189,"context_line":"        properties[\u0027target_luns\u0027] \u003d [lun_id] * len(addresses)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    auth \u003d volume[\u0027provider_auth\u0027]"},{"line_number":192,"context_line":"    if auth:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_3607f9cc","line":189,"range":{"start_line":189,"start_character":36,"end_line":189,"end_character":61},"in_reply_to":"9fdfeff1_ec8e94cf","updated":"2019-02-14 17:58:21.000000000","message":"\u0027lun_id` and `properties[\u0027target_lun\u0027]` are equal at this point, and `lun_id` is shorter.\n\nIf you are referring to why we have to return `target_luns`, then the answer is because a driver that wants to support multipathing  must return both `target_iqns` and `target_luns` information, otherwise os-brick won\u0027t do a multipath attach:  https://github.com/openstack/os-brick/blob/master/os_brick/initiator/connectors/base_iscsi.py#L33-L38","commit_id":"c65869626594522231709d9c90a30524a1f0d18c"}]}