)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5d4880b65c6702014df36f2c2204198e62990372","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is the basic patch which defines a new exception"},{"line_number":10,"context_line":"to indicate the environment error, with this error it"},{"line_number":11,"context_line":"will not retry initialization."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I71d4965cc9298d7500bee64dd9b5f12f2e04a2e0"},{"line_number":14,"context_line":"Implements: blueprint driver-initialization-after-fail"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_255e0ae8","line":11,"range":{"start_line":11,"start_character":9,"end_line":11,"end_character":30},"updated":"2018-12-06 03:22:49.000000000","message":"retry driver(s) initialization/ reinitialize driver(s)","commit_id":"5b7f8be41092cdbc60e3b2610ef7704327c6642e"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"a6af69b5d3af486918ec2bdebd4d13c81865ebe9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is the basic patch which defines a new exception"},{"line_number":10,"context_line":"to indicate the environment error, with this error it"},{"line_number":11,"context_line":"will not retry initialization."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I71d4965cc9298d7500bee64dd9b5f12f2e04a2e0"},{"line_number":14,"context_line":"Implements: blueprint driver-initialization-after-fail"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_a567654f","line":11,"range":{"start_line":11,"start_character":9,"end_line":11,"end_character":30},"in_reply_to":"3f79a3b5_255e0ae8","updated":"2018-12-07 00:48:57.000000000","message":"Done","commit_id":"5b7f8be41092cdbc60e3b2610ef7704327c6642e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"625b7cdc5b63bb7af598df58cd68f9856614e450","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is the basic patch which defines a new exception"},{"line_number":10,"context_line":"to indicate the environment error, with this error it"},{"line_number":11,"context_line":"will not reinitialize drivers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I71d4965cc9298d7500bee64dd9b5f12f2e04a2e0"},{"line_number":14,"context_line":"Co-authored-by: Ovidiu Poncea \u003covidiu.poncea@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_d7bafe0b","line":11,"updated":"2018-12-11 20:11:32.000000000","message":"I think we may want a config option to govern this behavior.\n\nI have seen cases where complex deployment tools deploy Cinder, which encounters an error while various other parts of the environment are still stabilizing, and the driver/service/etc comes up after the first time around.\n\nFor those cases, drivers being reinitialized upon failure is actually a feature and not a problem...","commit_id":"c9d641824c33834f8ae8a8c864387243d651f004"}],"cinder/exception.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"1f3931cb5d315ccf2d457350c914c909107a14a8","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                \"backend API: %(data)s\")"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"class VolumeDriverEnvException(CinderException):"},{"line_number":145,"context_line":"    message \u003d _(\"Unrecoverable volume driver error: %(message)s\")"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_df928c49","line":144,"updated":"2018-12-05 18:20:33.000000000","message":"This should have a comment explaining what cases this exception class is intended to be raised for.","commit_id":"6a8f4fdc56b57cd203a334ec506f643ecf65cdf1"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"9efa6a582f0f6dc00fb16ea847f9f4a9d67f2b9d","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                \"backend API: %(data)s\")"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"class VolumeDriverEnvException(CinderException):"},{"line_number":145,"context_line":"    message \u003d _(\"Unrecoverable volume driver error: %(message)s\")"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_6ad8517c","line":144,"in_reply_to":"3f79a3b5_df928c49","updated":"2018-12-06 02:00:21.000000000","message":"Done.","commit_id":"6a8f4fdc56b57cd203a334ec506f643ecf65cdf1"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5d4880b65c6702014df36f2c2204198e62990372","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"# The error is raised for environment error in volume drivers,"},{"line_number":149,"context_line":"# like lack of packages etc. With this error volume drivers can"},{"line_number":150,"context_line":"# not be reinitialized."},{"line_number":151,"context_line":"class VolumeDriverEnvException(VolumeDriverException):"},{"line_number":152,"context_line":"    message \u003d _(\"Unrecoverable volume driver error: %(message)s\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_05fe6eb4","line":149,"range":{"start_line":149,"start_character":52,"end_line":149,"end_character":59},"updated":"2018-12-06 03:22:49.000000000","message":"its stated drivers here but the only change i see is in RBD. will this change reflect in other drivers too or the scope of this exception is valid for rbd only?","commit_id":"5b7f8be41092cdbc60e3b2610ef7704327c6642e"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"a6af69b5d3af486918ec2bdebd4d13c81865ebe9","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"# The error is raised for environment error in volume drivers,"},{"line_number":149,"context_line":"# like lack of packages etc. With this error volume drivers can"},{"line_number":150,"context_line":"# not be reinitialized."},{"line_number":151,"context_line":"class VolumeDriverEnvException(VolumeDriverException):"},{"line_number":152,"context_line":"    message \u003d _(\"Unrecoverable volume driver error: %(message)s\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_655f0d74","line":149,"range":{"start_line":149,"start_character":52,"end_line":149,"end_character":59},"in_reply_to":"3f79a3b5_05fe6eb4","updated":"2018-12-07 00:48:57.000000000","message":"The update for other drivers needs to be done later.","commit_id":"5b7f8be41092cdbc60e3b2610ef7704327c6642e"}],"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"2401302dd8c489c8e9ef4b3ad72d8240c71b9e7d","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        \"\"\"Returns an error if prerequisites aren\u0027t met.\"\"\""},{"line_number":285,"context_line":"        if rados is None:"},{"line_number":286,"context_line":"            msg \u003d _(\u0027rados and rbd python libraries not found\u0027)"},{"line_number":287,"context_line":"            raise exception.VolumeDriverEnvException(data\u003dmsg)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        for attr in [\u0027rbd_cluster_name\u0027, \u0027rbd_pool\u0027]:"},{"line_number":290,"context_line":"            val \u003d getattr(self.configuration, attr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_dee05c30","line":287,"range":{"start_line":287,"start_character":53,"end_line":287,"end_character":57},"updated":"2018-12-05 08:55:23.000000000","message":"message","commit_id":"6a8f4fdc56b57cd203a334ec506f643ecf65cdf1"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"9efa6a582f0f6dc00fb16ea847f9f4a9d67f2b9d","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        \"\"\"Returns an error if prerequisites aren\u0027t met.\"\"\""},{"line_number":285,"context_line":"        if rados is None:"},{"line_number":286,"context_line":"            msg \u003d _(\u0027rados and rbd python libraries not found\u0027)"},{"line_number":287,"context_line":"            raise exception.VolumeDriverEnvException(data\u003dmsg)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        for attr in [\u0027rbd_cluster_name\u0027, \u0027rbd_pool\u0027]:"},{"line_number":290,"context_line":"            val \u003d getattr(self.configuration, attr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_aad2e95d","line":287,"range":{"start_line":287,"start_character":53,"end_line":287,"end_character":57},"in_reply_to":"3f79a3b5_dee05c30","updated":"2018-12-06 02:00:21.000000000","message":"Thank you!","commit_id":"6a8f4fdc56b57cd203a334ec506f643ecf65cdf1"}]}
