)]}'
{"cinder/volume/manager.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a70f3e763f499d4a12b6e497187a5bad1cd0c750","unresolved":false,"context_lines":[{"line_number":1623,"context_line":"                    if option_per_gb in specs:"},{"line_number":1624,"context_line":"                        minimum_value \u003d int(specs.pop(option_per_gb_min, 0))"},{"line_number":1625,"context_line":"                        value \u003d int(specs[option_per_gb]) * volume_size"},{"line_number":1626,"context_line":"                        maximum_value \u003d int(specs.pop(option_max, 0))"},{"line_number":1627,"context_line":"                        per_gb_value \u003d max(minimum_value, value)"},{"line_number":1628,"context_line":"                        if maximum_value and per_gb_value \u003e maximum_value:"},{"line_number":1629,"context_line":"                            specs[option] \u003d maximum_value"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_f948cb89","line":1626,"range":{"start_line":1626,"start_character":66,"end_line":1626,"end_character":67},"updated":"2018-12-18 17:44:26.000000000","message":"Change this default to be the value variable.","commit_id":"85cf3ead0f68f7b8c48e1bd9ccc60b7e050ae8fd"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"842fb4d51ad67ade0d991670ac3d6ffe4354267a","unresolved":false,"context_lines":[{"line_number":1625,"context_line":"                        value \u003d int(specs[option_per_gb]) * volume_size"},{"line_number":1626,"context_line":"                        maximum_value \u003d int(specs.pop(option_max, 0))"},{"line_number":1627,"context_line":"                        per_gb_value \u003d max(minimum_value, value)"},{"line_number":1628,"context_line":"                        if maximum_value and per_gb_value \u003e maximum_value:"},{"line_number":1629,"context_line":"                            specs[option] \u003d maximum_value"},{"line_number":1630,"context_line":"                        else:"},{"line_number":1631,"context_line":"                            specs[option] \u003d per_gb_value"},{"line_number":1632,"context_line":"                        specs.pop(option_per_gb)"},{"line_number":1633,"context_line":""},{"line_number":1634,"context_line":"        qos_spec \u003d dict(qos_specs\u003dspecs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_3e40698a","line":1631,"range":{"start_line":1628,"start_character":24,"end_line":1631,"end_character":56},"updated":"2018-12-18 16:53:26.000000000","message":"Change to:\n\n    specs[option] \u003d min(per_gb_value, maximum_value)","commit_id":"85cf3ead0f68f7b8c48e1bd9ccc60b7e050ae8fd"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"ff565acef715e6da118d56b0d279b4c381e9294e","unresolved":false,"context_lines":[{"line_number":1625,"context_line":"                        value \u003d int(specs[option_per_gb]) * volume_size"},{"line_number":1626,"context_line":"                        maximum_value \u003d int(specs.pop(option_max, 0))"},{"line_number":1627,"context_line":"                        per_gb_value \u003d max(minimum_value, value)"},{"line_number":1628,"context_line":"                        if maximum_value and per_gb_value \u003e maximum_value:"},{"line_number":1629,"context_line":"                            specs[option] \u003d maximum_value"},{"line_number":1630,"context_line":"                        else:"},{"line_number":1631,"context_line":"                            specs[option] \u003d per_gb_value"},{"line_number":1632,"context_line":"                        specs.pop(option_per_gb)"},{"line_number":1633,"context_line":""},{"line_number":1634,"context_line":"        qos_spec \u003d dict(qos_specs\u003dspecs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_796b5bed","line":1631,"range":{"start_line":1628,"start_character":24,"end_line":1631,"end_character":56},"in_reply_to":"3f79a3b5_3e40698a","updated":"2018-12-18 17:44:11.000000000","message":"the point is, that when maximum_value is not set (in qos policy), it will be defaulted to 0, which will be the minimum.\nSo only some part of condition may be replaced with min(), however if/else still will be in place, so I\u0027m not sure, whether this has a lot of sense. But if you ok with that - no problem, I\u0027ll update the patch.\nAs an alternative I see only one line condition like:\nspecs[option] \u003d min(per_gb_value, maximum_value) if maximum_value else per_gb_value, but I dunno if it\u0027s acceptable way to write conditions in the project","commit_id":"85cf3ead0f68f7b8c48e1bd9ccc60b7e050ae8fd"}]}