)]}'
{"cinder/volume/drivers/dell_emc/powermax/common.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"e705ddd7d1893b21df00c0e9f5f467c69d8bda2c","unresolved":false,"context_lines":[{"line_number":3720,"context_line":"                    self._add_new_volume_to_volume_group("},{"line_number":3721,"context_line":"                        volume, device_id, volume_name, extra_specs)"},{"line_number":3722,"context_line":""},{"line_number":3723,"context_line":"        except Exception as e:"},{"line_number":3724,"context_line":"            exception_message \u003d (_(\"Error extending volume. \""},{"line_number":3725,"context_line":"                                   \"Error received was %(e)s\") %"},{"line_number":3726,"context_line":"                                 {\u0027e\u0027: e})"}],"source_content_type":"text/x-python","patch_set":7,"id":"bfdaf3ff_36390041","line":3723,"updated":"2019-01-10 20:40:37.000000000","message":"Can we catch more specific exception here?","commit_id":"a1db3e7c8d2973c1f13f21535c6aad8cd780ba0b"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"e705ddd7d1893b21df00c0e9f5f467c69d8bda2c","unresolved":false,"context_lines":[{"line_number":4058,"context_line":"                self.masking.add_volumes_to_storage_group("},{"line_number":4059,"context_line":"                    array, volumes_not_deleted,"},{"line_number":4060,"context_line":"                    vol_grp_name, interval_retries_dict)"},{"line_number":4061,"context_line":"        except Exception as ex:"},{"line_number":4062,"context_line":"            LOG.error(\"Error in rollback - %(ex)s. \""},{"line_number":4063,"context_line":"                      \"Failed to add back volumes to sg %(sg_name)s\","},{"line_number":4064,"context_line":"                      {\u0027ex\u0027: ex, \u0027sg_name\u0027: vol_grp_name})"}],"source_content_type":"text/x-python","patch_set":7,"id":"bfdaf3ff_d63d142d","line":4061,"updated":"2019-01-10 20:40:37.000000000","message":"The same as above","commit_id":"a1db3e7c8d2973c1f13f21535c6aad8cd780ba0b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"80c927d7e31ff71b5649a443f79c2955455a1409","unresolved":false,"context_lines":[{"line_number":2515,"context_line":"                  \"was not possible to remove the OS- prefix. Error \""},{"line_number":2516,"context_line":"                  \"message is: %(e)s.\")"},{"line_number":2517,"context_line":"                % {\u0027snap_name\u0027: snap_name, \u0027e\u0027: six.text_type(e)})"},{"line_number":2518,"context_line":"            LOG.exception(exception_message)"},{"line_number":2519,"context_line":"            raise exception.VolumeBackendAPIException("},{"line_number":2520,"context_line":"                message\u003dexception_message)"},{"line_number":2521,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_74686b20","line":2518,"range":{"start_line":2518,"start_character":16,"end_line":2518,"end_character":25},"updated":"2019-01-25 20:17:51.000000000","message":"Not part of this patch, but noticed it from looking for other cases from below. Would be great to fix this too so there aren\u0027t any more copy/paste issues.","commit_id":"598de42eeddd5482ae2d57cac8faf834b0e64845"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"356931e30652b562512e3b1af4b0126c071465b3","unresolved":false,"context_lines":[{"line_number":2515,"context_line":"                  \"was not possible to remove the OS- prefix. Error \""},{"line_number":2516,"context_line":"                  \"message is: %(e)s.\")"},{"line_number":2517,"context_line":"                % {\u0027snap_name\u0027: snap_name, \u0027e\u0027: six.text_type(e)})"},{"line_number":2518,"context_line":"            LOG.exception(exception_message)"},{"line_number":2519,"context_line":"            raise exception.VolumeBackendAPIException("},{"line_number":2520,"context_line":"                message\u003dexception_message)"},{"line_number":2521,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_b238233d","line":2518,"range":{"start_line":2518,"start_character":16,"end_line":2518,"end_character":25},"in_reply_to":"9fdfeff1_74686b20","updated":"2019-01-25 22:39:19.000000000","message":"Sure. I will fix.","commit_id":"598de42eeddd5482ae2d57cac8faf834b0e64845"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"80c927d7e31ff71b5649a443f79c2955455a1409","unresolved":false,"context_lines":[{"line_number":3724,"context_line":"            exception_message \u003d (_(\"Error extending volume. \""},{"line_number":3725,"context_line":"                                   \"Error received was %(e)s\") %"},{"line_number":3726,"context_line":"                                 {\u0027e\u0027: e})"},{"line_number":3727,"context_line":"            LOG.exception(exception_message)"},{"line_number":3728,"context_line":"            raise exception.VolumeBackendAPIException("},{"line_number":3729,"context_line":"                message\u003dexception_message)"},{"line_number":3730,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_743aab34","line":3727,"range":{"start_line":3727,"start_character":12,"end_line":3727,"end_character":44},"updated":"2019-01-25 20:17:51.000000000","message":"The exception should not be formatted into a message used for LOG.exception calls. This should be changed to LOG.error or the exception removed from the string formatting.","commit_id":"598de42eeddd5482ae2d57cac8faf834b0e64845"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"356931e30652b562512e3b1af4b0126c071465b3","unresolved":false,"context_lines":[{"line_number":3724,"context_line":"            exception_message \u003d (_(\"Error extending volume. \""},{"line_number":3725,"context_line":"                                   \"Error received was %(e)s\") %"},{"line_number":3726,"context_line":"                                 {\u0027e\u0027: e})"},{"line_number":3727,"context_line":"            LOG.exception(exception_message)"},{"line_number":3728,"context_line":"            raise exception.VolumeBackendAPIException("},{"line_number":3729,"context_line":"                message\u003dexception_message)"},{"line_number":3730,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_d214c7a2","line":3727,"range":{"start_line":3727,"start_character":12,"end_line":3727,"end_character":44},"in_reply_to":"9fdfeff1_743aab34","updated":"2019-01-25 22:39:19.000000000","message":"Thanks, I will change this and others","commit_id":"598de42eeddd5482ae2d57cac8faf834b0e64845"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"80c927d7e31ff71b5649a443f79c2955455a1409","unresolved":false,"context_lines":[{"line_number":4036,"context_line":"        :returns: volumes_model_update"},{"line_number":4037,"context_line":"        \"\"\""},{"line_number":4038,"context_line":"        # Update the volumes_model_update"},{"line_number":4039,"context_line":"        if len(deleted_volume_device_ids) is not 0:"},{"line_number":4040,"context_line":"            LOG.debug(\"Device ids: %(dev)s are deleted.\","},{"line_number":4041,"context_line":"                      {\u0027dev\u0027: deleted_volume_device_ids})"},{"line_number":4042,"context_line":"        volumes_not_deleted \u003d []"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_b411f3ae","line":4039,"range":{"start_line":4039,"start_character":8,"end_line":4039,"end_character":50},"updated":"2019-01-25 20:17:51.000000000","message":"Should be \"len(deleted_volume_device_ids) \u003e 0\" or just \"if deleted_volume_device_ids:\"","commit_id":"598de42eeddd5482ae2d57cac8faf834b0e64845"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"356931e30652b562512e3b1af4b0126c071465b3","unresolved":false,"context_lines":[{"line_number":4036,"context_line":"        :returns: volumes_model_update"},{"line_number":4037,"context_line":"        \"\"\""},{"line_number":4038,"context_line":"        # Update the volumes_model_update"},{"line_number":4039,"context_line":"        if len(deleted_volume_device_ids) is not 0:"},{"line_number":4040,"context_line":"            LOG.debug(\"Device ids: %(dev)s are deleted.\","},{"line_number":4041,"context_line":"                      {\u0027dev\u0027: deleted_volume_device_ids})"},{"line_number":4042,"context_line":"        volumes_not_deleted \u003d []"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_324433b7","line":4039,"range":{"start_line":4039,"start_character":8,"end_line":4039,"end_character":50},"in_reply_to":"9fdfeff1_b411f3ae","updated":"2019-01-25 22:39:19.000000000","message":"Sure","commit_id":"598de42eeddd5482ae2d57cac8faf834b0e64845"}],"cinder/volume/drivers/dell_emc/powermax/metadata.py":[{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"8d32816bf8c0c39c629cb21811200602c5e08282","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        # Some distributions override with more meaningful information"},{"line_number":137,"context_line":"        self._update_info_from_version_info()"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def _update_vmax_info(self, serial_number):"},{"line_number":140,"context_line":"        \"\"\"Update PowerMax/VMAX info."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        :param serial_number: the serial number of the array"}],"source_content_type":"text/x-python","patch_set":5,"id":"ffd0ebdf_9266b151","line":139,"range":{"start_line":139,"start_character":16,"end_line":139,"end_character":20},"updated":"2019-01-03 14:26:32.000000000","message":"If we are changing everything to PowerMax is there a reason this was left as VMAX? Would it make sense to have something like _update_array_info so it is not version specific?","commit_id":"1eb01827bcfac0ce8f6a09a85026f1a878e33158"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"346c54b679f542d0e2952bdc2b5c1e810720c3aa","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        # Some distributions override with more meaningful information"},{"line_number":137,"context_line":"        self._update_info_from_version_info()"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def _update_vmax_info(self, serial_number):"},{"line_number":140,"context_line":"        \"\"\"Update PowerMax/VMAX info."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        :param serial_number: the serial number of the array"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfd5e7cf_bf993920","line":139,"range":{"start_line":139,"start_character":16,"end_line":139,"end_character":20},"in_reply_to":"ffd0ebdf_9266b151","updated":"2019-01-07 10:33:58.000000000","message":"Sure, I can change it to _update_array_info.  There are still method names and variable names with \u0027vmax\u0027, we can phase them out over time","commit_id":"1eb01827bcfac0ce8f6a09a85026f1a878e33158"}],"cinder/volume/drivers/dell_emc/powermax/rest.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"80c927d7e31ff71b5649a443f79c2955455a1409","unresolved":false,"context_lines":[{"line_number":25,"context_line":"import requests.exceptions as r_exc"},{"line_number":26,"context_line":"try:"},{"line_number":27,"context_line":"    import requests.packages.urllib3.exceptions as urllib_exp"},{"line_number":28,"context_line":"except Exception:"},{"line_number":29,"context_line":"    import urllib3.exceptions as urllib_exp"},{"line_number":30,"context_line":"try:"},{"line_number":31,"context_line":"    import requests.packages.urllib3.util.retry as requests_retry"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_5456875e","line":28,"updated":"2019-01-25 20:17:51.000000000","message":"Are these needed? AFAIK, requests should always have this.","commit_id":"598de42eeddd5482ae2d57cac8faf834b0e64845"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"5083945a8803330403b1c9488ec87af46997168d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"import requests.exceptions as r_exc"},{"line_number":26,"context_line":"try:"},{"line_number":27,"context_line":"    import requests.packages.urllib3.exceptions as urllib_exp"},{"line_number":28,"context_line":"except Exception:"},{"line_number":29,"context_line":"    import urllib3.exceptions as urllib_exp"},{"line_number":30,"context_line":"try:"},{"line_number":31,"context_line":"    import requests.packages.urllib3.util.retry as requests_retry"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_d711075f","line":28,"in_reply_to":"9fdfeff1_3203d311","updated":"2019-01-28 11:26:17.000000000","message":"Thanks Sean","commit_id":"598de42eeddd5482ae2d57cac8faf834b0e64845"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"356931e30652b562512e3b1af4b0126c071465b3","unresolved":false,"context_lines":[{"line_number":25,"context_line":"import requests.exceptions as r_exc"},{"line_number":26,"context_line":"try:"},{"line_number":27,"context_line":"    import requests.packages.urllib3.exceptions as urllib_exp"},{"line_number":28,"context_line":"except Exception:"},{"line_number":29,"context_line":"    import urllib3.exceptions as urllib_exp"},{"line_number":30,"context_line":"try:"},{"line_number":31,"context_line":"    import requests.packages.urllib3.util.retry as requests_retry"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_f27c6bec","line":28,"in_reply_to":"9fdfeff1_5456875e","updated":"2019-01-25 22:39:19.000000000","message":"It was to fix a pylint issue. Should I just disable the warning in pylint?","commit_id":"598de42eeddd5482ae2d57cac8faf834b0e64845"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"647639732df7813d75af8e7b2ca4fd6b108173c3","unresolved":false,"context_lines":[{"line_number":25,"context_line":"import requests.exceptions as r_exc"},{"line_number":26,"context_line":"try:"},{"line_number":27,"context_line":"    import requests.packages.urllib3.exceptions as urllib_exp"},{"line_number":28,"context_line":"except Exception:"},{"line_number":29,"context_line":"    import urllib3.exceptions as urllib_exp"},{"line_number":30,"context_line":"try:"},{"line_number":31,"context_line":"    import requests.packages.urllib3.util.retry as requests_retry"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_3203d311","line":28,"in_reply_to":"9fdfeff1_f27c6bec","updated":"2019-01-25 23:03:45.000000000","message":"Ah, right, I\u0027ve seen that issue with pylint before due to the way requests loads in urllib3. Yeah, I think just disabling it here is probably good.","commit_id":"598de42eeddd5482ae2d57cac8faf834b0e64845"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"80c927d7e31ff71b5649a443f79c2955455a1409","unresolved":false,"context_lines":[{"line_number":39,"context_line":"from cinder.utils import retry"},{"line_number":40,"context_line":"from cinder.volume.drivers.dell_emc.powermax import utils"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"requests.packages.urllib3.disable_warnings(  # pylint: disable\u003dE1101"},{"line_number":43,"context_line":"    urllib_exp.InsecureRequestWarning)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":46,"context_line":"SLOPROVISIONING \u003d \u0027sloprovisioning\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_54dbe7eb","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":38},"updated":"2019-01-25 20:17:51.000000000","message":"This should actually be removed. The driver shouldn\u0027t be disabling this warning. That will override things for the entire service. This should be left for whether the user has set suppress_requests_ssl_warnings in cinder.conf.","commit_id":"598de42eeddd5482ae2d57cac8faf834b0e64845"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"356931e30652b562512e3b1af4b0126c071465b3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"from cinder.utils import retry"},{"line_number":40,"context_line":"from cinder.volume.drivers.dell_emc.powermax import utils"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"requests.packages.urllib3.disable_warnings(  # pylint: disable\u003dE1101"},{"line_number":43,"context_line":"    urllib_exp.InsecureRequestWarning)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":46,"context_line":"SLOPROVISIONING \u003d \u0027sloprovisioning\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_1277af04","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":38},"in_reply_to":"9fdfeff1_54dbe7eb","updated":"2019-01-25 22:39:19.000000000","message":"Thanks Sean, we will remove it.","commit_id":"598de42eeddd5482ae2d57cac8faf834b0e64845"}]}