)]}'
{"cinder/tests/unit/group/test_groups_manager.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3632fae7bc5d9a1774fddf91233050d19a2615cb","unresolved":false,"context_lines":[{"line_number":748,"context_line":"        }"},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"        quota.QUOTAS.add_volume_type_opts.assert_called()"},{"line_number":751,"context_line":"        self.assertEqual("},{"line_number":752,"context_line":"            quota.QUOTAS.add_volume_type_opts.call_args[0][1:],"},{"line_number":753,"context_line":"            (reserve_opts, fake.VOLUME_TYPE_ID)"},{"line_number":754,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfdaf3ff_140d54a0","line":751,"range":{"start_line":751,"start_character":13,"end_line":751,"end_character":24},"updated":"2019-01-17 16:33:25.000000000","message":"assertEqual argument order should be (EXPECTED, ACTUAL), so it looks like this is backwards here.","commit_id":"015529b76926927c488db8176b3eaf46b80330d2"}],"cinder/tests/unit/utils.py":[{"author":{"_account_id":8674,"name":"Yves-Gwenael Bourhis","email":"ygbourhis@gmail.com","username":"yves"},"change_message_id":"1a0234ab53f6f14b675624679286060d48b1eff8","unresolved":false,"context_lines":[{"line_number":560,"context_line":""},{"line_number":561,"context_line":"    Also, we want to check when a method is called even if it raised an error."},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    This function is to do what MagickMock brilliantly fails to do."},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    \"\"\""},{"line_number":566,"context_line":"    logged_args \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfdaf3ff_6e4bccaf","line":563,"updated":"2019-01-16 15:34:12.000000000","message":"Indeed, this here:\n\nhttps://stackoverflow.com/questions/50970170/python-check-if-a-method-is-called-without-mocking-it-away\n\nfails completely.","commit_id":"5827eee6cb384d1980ea81c707aa8be1ff56d048"},{"author":{"_account_id":8674,"name":"Yves-Gwenael Bourhis","email":"ygbourhis@gmail.com","username":"yves"},"change_message_id":"cd740ae94876d5ab1cf49c3e6a866ab76eca8a6c","unresolved":false,"context_lines":[{"line_number":560,"context_line":""},{"line_number":561,"context_line":"    Also, we want to check when a method is called even if it raised an error."},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    This function is to do what MagickMock brilliantly fails to do."},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    \"\"\""},{"line_number":566,"context_line":"    logged_args \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfdaf3ff_c10e498c","line":563,"in_reply_to":"bfdaf3ff_6e4bccaf","updated":"2019-01-16 16:05:31.000000000","message":"Forgot to mention: it fails when mocking methods on classes, but if you happen to have access to the instance, it works when mocking a method on the instance (not on the class).","commit_id":"5827eee6cb384d1980ea81c707aa8be1ff56d048"}],"cinder/volume/manager.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3632fae7bc5d9a1774fddf91233050d19a2615cb","unresolved":false,"context_lines":[{"line_number":3929,"context_line":"        for snapshot in snapshots:"},{"line_number":3930,"context_line":"            # Get reservations"},{"line_number":3931,"context_line":"            try:"},{"line_number":3932,"context_line":"                if CONF.no_snapshot_gb_quota:"},{"line_number":3933,"context_line":"                    reserve_opts \u003d {\u0027snapshots\u0027: -1}"},{"line_number":3934,"context_line":"                else:"},{"line_number":3935,"context_line":"                    reserve_opts \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfdaf3ff_d43d8cdd","line":3932,"updated":"2019-01-17 16:33:25.000000000","message":"I think it might be cleaner to do something like:\n\nreserve_opts \u003d {\u0027snapshots\u0027: -1}\nif not CONF.no_snapshot_gb_quota:\n    reserve_opts[\u0027gigabytes\u0027] \u003d -snapshot.volume_size","commit_id":"015529b76926927c488db8176b3eaf46b80330d2"}]}