)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"16b82ab1734470e4e8ff726fc6aa31c9e9e2bdcf","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Unfortunately, if we have already called the _initialize_filters in"},{"line_number":19,"context_line":"other case (before this case), this error will not be exposed. So, we"},{"line_number":20,"context_line":"didn\u0027t found this error happened in first-CI."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"This patch try to fix this issue."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f769fc5_97d9c884","line":20,"range":{"start_line":20,"start_character":7,"end_line":20,"end_character":12},"updated":"2018-12-27 04:53:18.000000000","message":"find","commit_id":"94f8bda47c710bc5f13d305ac61caf7ddcd12f75"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"16b82ab1734470e4e8ff726fc6aa31c9e9e2bdcf","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Unfortunately, if we have already called the _initialize_filters in"},{"line_number":19,"context_line":"other case (before this case), this error will not be exposed. So, we"},{"line_number":20,"context_line":"didn\u0027t found this error happened in first-CI."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"This patch try to fix this issue."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f769fc5_37e6b446","line":20,"range":{"start_line":20,"start_character":24,"end_line":20,"end_character":32},"updated":"2018-12-27 04:53:18.000000000","message":"occurring","commit_id":"94f8bda47c710bc5f13d305ac61caf7ddcd12f75"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"54d7168727d973996ac75775e1c4c367f1afd56b","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Unfortunately, if we have already called the _initialize_filters in"},{"line_number":19,"context_line":"other case (before this case), this error will not be exposed. So, we"},{"line_number":20,"context_line":"didn\u0027t found this error happened in first-CI."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"This patch try to fix this issue."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f769fc5_fc26c2b7","line":20,"range":{"start_line":20,"start_character":24,"end_line":20,"end_character":32},"in_reply_to":"1f769fc5_37e6b446","updated":"2019-01-02 05:42:20.000000000","message":"Done","commit_id":"94f8bda47c710bc5f13d305ac61caf7ddcd12f75"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"54d7168727d973996ac75775e1c4c367f1afd56b","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Unfortunately, if we have already called the _initialize_filters in"},{"line_number":19,"context_line":"other case (before this case), this error will not be exposed. So, we"},{"line_number":20,"context_line":"didn\u0027t found this error happened in first-CI."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"This patch try to fix this issue."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f769fc5_9c3b0ed0","line":20,"range":{"start_line":20,"start_character":7,"end_line":20,"end_character":12},"in_reply_to":"1f769fc5_97d9c884","updated":"2019-01-02 05:42:20.000000000","message":"Done","commit_id":"94f8bda47c710bc5f13d305ac61caf7ddcd12f75"}],"cinder/tests/unit/api/v2/test_volumes.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"12335d465e85b425b3ee203d9834c1085946a0b1","unresolved":false,"context_lines":[{"line_number":1682,"context_line":"                         self.controller._get_volume_filter_options())"},{"line_number":1683,"context_line":"        # Clear the filters collection to avoid leaking other case, and it"},{"line_number":1684,"context_line":"        # will be re-loaded from CONF.resource_query_filters_file in next"},{"line_number":1685,"context_line":"        # called."},{"line_number":1686,"context_line":"        common._FILTERS_COLLECTION \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f769fc5_0efff1aa","line":1685,"range":{"start_line":1685,"start_character":10,"end_line":1685,"end_character":16},"updated":"2018-12-25 08:23:30.000000000","message":"call","commit_id":"37da23318b1086a3ad630f4a5329d7aaac2864c4"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"33444f4ddfa5df0e54e3b5c9d5ea483f87bfed6f","unresolved":false,"context_lines":[{"line_number":1683,"context_line":"        # Clear the filters collection to avoid leaking other case, and it"},{"line_number":1684,"context_line":"        # will be re-loaded from CONF.resource_query_filters_file in next"},{"line_number":1685,"context_line":"        # called."},{"line_number":1686,"context_line":"        common._FILTERS_COLLECTION \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f769fc5_f9e03d99","line":1686,"range":{"start_line":1686,"start_character":8,"end_line":1686,"end_character":41},"updated":"2018-12-25 09:34:38.000000000","message":"I suggest we should use override correctly to test the config file working right here:\nThe example patch: https://review.openstack.org/#/c/627255/1\n\nSo I think we can merge those code into this patch to fix the bug appropriately.","commit_id":"37da23318b1086a3ad630f4a5329d7aaac2864c4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"12335d465e85b425b3ee203d9834c1085946a0b1","unresolved":false,"context_lines":[{"line_number":1683,"context_line":"        # Clear the filters collection to avoid leaking other case, and it"},{"line_number":1684,"context_line":"        # will be re-loaded from CONF.resource_query_filters_file in next"},{"line_number":1685,"context_line":"        # called."},{"line_number":1686,"context_line":"        common._FILTERS_COLLECTION \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f769fc5_6ee6a5eb","line":1686,"range":{"start_line":1686,"start_character":8,"end_line":1686,"end_character":41},"updated":"2018-12-25 08:23:30.000000000","message":"This type of cleaning should be done in all tests so that one test doesn\u0027t affect the other.\nThis is the reason the last patch didn\u0027t fail as the initialize_filter of one test had effects on this one that made this to pass.","commit_id":"37da23318b1086a3ad630f4a5329d7aaac2864c4"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"784b3d2280a2bcee3ead402b482484ab1c9edd63","unresolved":false,"context_lines":[{"line_number":1684,"context_line":"        # Reset the CONF.resource_query_filters_file and clear the filters"},{"line_number":1685,"context_line":"        # collection to make sure the filters collection cache can be reloaded"},{"line_number":1686,"context_line":"        # using tmp filter file."},{"line_number":1687,"context_line":"        self._reset_filter_file()"},{"line_number":1688,"context_line":"        tmp_filter_file \u003d self.tmp_path + \u0027/resource_filters_tests.json\u0027"},{"line_number":1689,"context_line":"        self.override_config(\u0027resource_query_filters_file\u0027, tmp_filter_file)"},{"line_number":1690,"context_line":"        with open(tmp_filter_file, \u0027w\u0027) as f:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f769fc5_4e272414","line":1687,"range":{"start_line":1687,"start_character":8,"end_line":1687,"end_character":33},"updated":"2018-12-26 04:05:36.000000000","message":"I feel here we just to clear the _FILTERS_COLLECTION and no need to reset the resource_query_filters_file config again.","commit_id":"1694aa356f729eaf77eb7f277a3949ba1d8ba955"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"784b3d2280a2bcee3ead402b482484ab1c9edd63","unresolved":false,"context_lines":[{"line_number":1686,"context_line":"        # using tmp filter file."},{"line_number":1687,"context_line":"        self._reset_filter_file()"},{"line_number":1688,"context_line":"        tmp_filter_file \u003d self.tmp_path + \u0027/resource_filters_tests.json\u0027"},{"line_number":1689,"context_line":"        self.override_config(\u0027resource_query_filters_file\u0027, tmp_filter_file)"},{"line_number":1690,"context_line":"        with open(tmp_filter_file, \u0027w\u0027) as f:"},{"line_number":1691,"context_line":"            f.write(json.dumps({\"volume\": filter_list}))"},{"line_number":1692,"context_line":"        self.assertEqual(filter_list,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f769fc5_0e212cfc","line":1689,"range":{"start_line":1689,"start_character":60,"end_line":1689,"end_character":75},"updated":"2018-12-26 04:05:36.000000000","message":"and we also need to clear the tmp filter file at last","commit_id":"1694aa356f729eaf77eb7f277a3949ba1d8ba955"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"3b582c6d8f255bb63e09ffff61cf9d68b282d480","unresolved":false,"context_lines":[{"line_number":1686,"context_line":"        # using tmp filter file."},{"line_number":1687,"context_line":"        self._reset_filter_file()"},{"line_number":1688,"context_line":"        tmp_filter_file \u003d self.tmp_path + \u0027/resource_filters_tests.json\u0027"},{"line_number":1689,"context_line":"        self.override_config(\u0027resource_query_filters_file\u0027, tmp_filter_file)"},{"line_number":1690,"context_line":"        with open(tmp_filter_file, \u0027w\u0027) as f:"},{"line_number":1691,"context_line":"            f.write(json.dumps({\"volume\": filter_list}))"},{"line_number":1692,"context_line":"        self.assertEqual(filter_list,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f769fc5_8e9e9c05","line":1689,"range":{"start_line":1689,"start_character":60,"end_line":1689,"end_character":75},"in_reply_to":"1f769fc5_0e212cfc","updated":"2018-12-26 04:33:47.000000000","message":"Got this, no need this step.","commit_id":"1694aa356f729eaf77eb7f277a3949ba1d8ba955"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"892d9b4de81ab15035215116bd95864ae990fac8","unresolved":false,"context_lines":[{"line_number":1682,"context_line":"        filter_list \u003d [\"name\", \"status\", \"metadata\", \"bootable\","},{"line_number":1683,"context_line":"                       \"migration_status\", \"availability_zone\", \"group_id\"]"},{"line_number":1684,"context_line":"        # Clear the filters collection to make sure the filters collection"},{"line_number":1685,"context_line":"        # cache can be reloaded using tmp filter file."},{"line_number":1686,"context_line":"        common._FILTERS_COLLECTION \u003d None"},{"line_number":1687,"context_line":"        tmp_filter_file \u003d self.tmp_path + \u0027/resource_filters_tests.json\u0027"},{"line_number":1688,"context_line":"        self.override_config(\u0027resource_query_filters_file\u0027, tmp_filter_file)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f769fc5_31748935","line":1685,"updated":"2018-12-26 06:20:04.000000000","message":"++","commit_id":"d91d5ba72060bd8c31a3dd5f84f9d590731283ca"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"a86e13c747b4dafac0575c3edd9fc952472bd3c4","unresolved":false,"context_lines":[{"line_number":1693,"context_line":"        # Reset the CONF.resource_query_filters_file and clear the filters"},{"line_number":1694,"context_line":"        # collection to avoid leaking other cases, and it will be re-loaded"},{"line_number":1695,"context_line":"        # from CONF.resource_query_filters_file in next call."},{"line_number":1696,"context_line":"        self._reset_filter_file(tmp_filter_file)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f769fc5_b1af3993","line":1696,"range":{"start_line":1696,"start_character":32,"end_line":1696,"end_character":47},"updated":"2018-12-26 06:15:56.000000000","message":"typo?","commit_id":"d91d5ba72060bd8c31a3dd5f84f9d590731283ca"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"54381a9e31c9a8d45f3f24128250d91382ab7ab1","unresolved":false,"context_lines":[{"line_number":1693,"context_line":"        # Reset the CONF.resource_query_filters_file and clear the filters"},{"line_number":1694,"context_line":"        # collection to avoid leaking other cases, and it will be re-loaded"},{"line_number":1695,"context_line":"        # from CONF.resource_query_filters_file in next call."},{"line_number":1696,"context_line":"        self._reset_filter_file(tmp_filter_file)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f769fc5_e4665152","line":1696,"range":{"start_line":1696,"start_character":32,"end_line":1696,"end_character":47},"in_reply_to":"1f769fc5_b1af3993","updated":"2018-12-26 08:20:56.000000000","message":"good catch, should be removed","commit_id":"d91d5ba72060bd8c31a3dd5f84f9d590731283ca"}],"cinder/tests/unit/api/v3/test_volumes.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"12335d465e85b425b3ee203d9834c1085946a0b1","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            volume_get.assert_called_with(filters, False)"},{"line_number":77,"context_line":"            # Clear the filters collection to avoid leaking other case, and it"},{"line_number":78,"context_line":"            # will be re-loaded from CONF.resource_query_filters_file in next"},{"line_number":79,"context_line":"            # called."},{"line_number":80,"context_line":"            common._FILTERS_COLLECTION \u003d None"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def test_check_volume_filters_strict_called(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f769fc5_2e218d4e","line":79,"range":{"start_line":79,"start_character":14,"end_line":79,"end_character":20},"updated":"2018-12-25 08:23:30.000000000","message":"call","commit_id":"37da23318b1086a3ad630f4a5329d7aaac2864c4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"12335d465e85b425b3ee203d9834c1085946a0b1","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            volume_get.assert_called_with(filters, True)"},{"line_number":99,"context_line":"            # Clear the filters collection to avoid leaking other case, and it"},{"line_number":100,"context_line":"            # will be re-loaded from CONF.resource_query_filters_file in next"},{"line_number":101,"context_line":"            # called."},{"line_number":102,"context_line":"            common._FILTERS_COLLECTION \u003d None"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def _create_volume_with_glance_metadata(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f769fc5_0e18511b","line":101,"range":{"start_line":101,"start_character":14,"end_line":101,"end_character":20},"updated":"2018-12-25 08:23:30.000000000","message":"call","commit_id":"37da23318b1086a3ad630f4a5329d7aaac2864c4"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"892d9b4de81ab15035215116bd95864ae990fac8","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        self.tmp_path \u003d self.useFixture(fixtures.TempDir()).path"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_check_volume_filters_called(self):"},{"line_number":68,"context_line":"        # Clear the filters collection to make sure the filters collection"},{"line_number":69,"context_line":"        # cache can be reloaded using tmp filter file."},{"line_number":70,"context_line":"        common._FILTERS_COLLECTION \u003d None"},{"line_number":71,"context_line":"        with mock.patch.object(vol_get.API,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f769fc5_d18e7526","line":68,"updated":"2018-12-26 06:20:04.000000000","message":"++","commit_id":"d91d5ba72060bd8c31a3dd5f84f9d590731283ca"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"892d9b4de81ab15035215116bd95864ae990fac8","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self._reset_filter_file()"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def test_check_volume_filters_strict_called(self):"},{"line_number":94,"context_line":"        # Clear the filters collection to make sure the filters collection"},{"line_number":95,"context_line":"        # cache can be reloaded using tmp filter file."},{"line_number":96,"context_line":"        common._FILTERS_COLLECTION \u003d None"},{"line_number":97,"context_line":"        with mock.patch.object(vol_get.API,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f769fc5_f193714e","line":94,"updated":"2018-12-26 06:20:04.000000000","message":"++","commit_id":"d91d5ba72060bd8c31a3dd5f84f9d590731283ca"}]}