)]}'
{"cinder/keymgr/migration.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"246c7a5e804db16e278298da36d90d5c8698e5b9","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from cinder import context"},{"line_number":28,"context_line":"from cinder import coordination"},{"line_number":29,"context_line":"from cinder import objects"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from cinder.volume import volume_migration as volume_migration"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_ba5ee70f","line":30,"updated":"2019-01-09 22:11:48.000000000","message":"Extra blank line should be removed.","commit_id":"5b08390b9d203a32892a6424576eee5a5a5f0bc8"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"246c7a5e804db16e278298da36d90d5c8698e5b9","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        item.encryption_key_id \u003d encryption_key_id"},{"line_number":148,"context_line":"        item.save()"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        if isinstance(item, volume_migration.VolumeMigration) or \\"},{"line_number":151,"context_line":"                isinstance(item, objects.volume.Volume):"},{"line_number":152,"context_line":"            snapshots \u003d objects.snapshot.SnapshotList.get_all_for_volume("},{"line_number":153,"context_line":"                self.admin_context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_5a9b3bc8","line":150,"range":{"start_line":150,"start_character":65,"end_line":150,"end_character":66},"updated":"2019-01-09 22:11:48.000000000","message":"Please don\u0027t use \\ to span multiple lines. Wrap the conditional in () if needed.","commit_id":"5b08390b9d203a32892a6424576eee5a5a5f0bc8"}],"cinder/volume/manager.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"246c7a5e804db16e278298da36d90d5c8698e5b9","unresolved":false,"context_lines":[{"line_number":464,"context_line":""},{"line_number":465,"context_line":"        if use_batch_objects_retrieval:"},{"line_number":466,"context_line":"            # Get total number of volumes"},{"line_number":467,"context_line":"            num_vols, _, _ \u003d self._get_my_volumes_summary(ctxt)"},{"line_number":468,"context_line":"            # Get total number of snapshots"},{"line_number":469,"context_line":"            num_snaps, _ \u003d self._get_my_snapshots_summary(ctxt)"},{"line_number":470,"context_line":"            # Calculate highest number of the objects (volumes or snapshots)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_9a91a39c","line":467,"range":{"start_line":467,"start_character":22,"end_line":467,"end_character":24},"updated":"2019-01-09 22:11:48.000000000","message":"This is normally a good practice, but the problem in OpenStack code is the i18n translation uses _() to mark translatable strings, so this hides that import. Double underscore is probably better.","commit_id":"5b08390b9d203a32892a6424576eee5a5a5f0bc8"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"246c7a5e804db16e278298da36d90d5c8698e5b9","unresolved":false,"context_lines":[{"line_number":479,"context_line":"            # Retrieve \u0027req_limit\u0027 number of objects starting from"},{"line_number":480,"context_line":"            # \u0027req_offset\u0027 position"},{"line_number":481,"context_line":"            if use_batch_objects_retrieval:"},{"line_number":482,"context_line":"                volumes \u003d self._get_my_volumes(ctxt, req_limit, req_offset) \\"},{"line_number":483,"context_line":"                    if req_offset \u003c num_vols \\"},{"line_number":484,"context_line":"                    else objects.VolumeList()"},{"line_number":485,"context_line":"                snapshots \u003d self._get_my_snapshots(ctxt, req_limit, req_offset) \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_ba8ca77f","line":482,"range":{"start_line":482,"start_character":76,"end_line":482,"end_character":77},"updated":"2019-01-09 22:11:48.000000000","message":"Don\u0027t use \\","commit_id":"5b08390b9d203a32892a6424576eee5a5a5f0bc8"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"246c7a5e804db16e278298da36d90d5c8698e5b9","unresolved":false,"context_lines":[{"line_number":482,"context_line":"                volumes \u003d self._get_my_volumes(ctxt, req_limit, req_offset) \\"},{"line_number":483,"context_line":"                    if req_offset \u003c num_vols \\"},{"line_number":484,"context_line":"                    else objects.VolumeList()"},{"line_number":485,"context_line":"                snapshots \u003d self._get_my_snapshots(ctxt, req_limit, req_offset) \\"},{"line_number":486,"context_line":"                    if req_offset \u003c num_snaps \\"},{"line_number":487,"context_line":"                    else objects.SnapshotList()"},{"line_number":488,"context_line":"            # or retrieve all volumes and snapshots per single request"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_5ae9fb17","line":485,"range":{"start_line":485,"start_character":79,"end_line":485,"end_character":81},"updated":"2019-01-09 22:11:48.000000000","message":"Line needs to stay within 80 characters.","commit_id":"5b08390b9d203a32892a6424576eee5a5a5f0bc8"}],"cinder/volume/volume_migration.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"246c7a5e804db16e278298da36d90d5c8698e5b9","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def save(self):"},{"line_number":48,"context_line":"        updates \u003d self._get_updates()"},{"line_number":49,"context_line":"        if len(updates):"},{"line_number":50,"context_line":"            db.volume_update(self._context, self.id, updates)"},{"line_number":51,"context_line":"            self._reset_changes()"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_7a871f63","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":24},"updated":"2019-01-09 22:11:48.000000000","message":"Not important, but this could just be:\n\nif updates:","commit_id":"5b08390b9d203a32892a6424576eee5a5a5f0bc8"}],"releasenotes/notes/volume_init_max_objects_retrieval-966f607c46190946.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"301481b42aedc71b4b031015d22fae16f7fd8e2b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Volume Manager now uses the configuration option"},{"line_number":4,"context_line":"    init_host_max_objects_retrieval to set max number of"},{"line_number":5,"context_line":"    volumes and snapshots to be retrieved per batch during"},{"line_number":6,"context_line":"    volume manager host initialization. Query results will"},{"line_number":7,"context_line":"    be obtained in batches from the database and not in one"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dfd5e7cf_28c85f20","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":35},"updated":"2019-01-10 17:31:45.000000000","message":"If you do an update, please change this to ``init_host_max_objects_retrieval`` so it is formatted in the generated output.","commit_id":"6274fed270ebc63a24a13c7abab3ca1de8ade5f2"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"301481b42aedc71b4b031015d22fae16f7fd8e2b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    volume manager host initialization. Query results will"},{"line_number":7,"context_line":"    be obtained in batches from the database and not in one"},{"line_number":8,"context_line":"    shot to avoid extreme memory usage."},{"line_number":9,"context_line":"    Default value is 0 and disable this functionality."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dfd5e7cf_6850a75e","line":9,"range":{"start_line":9,"start_character":27,"end_line":9,"end_character":34},"updated":"2019-01-10 17:31:45.000000000","message":"disables","commit_id":"6274fed270ebc63a24a13c7abab3ca1de8ade5f2"}]}