)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"b61b53e6b074f9e46cec74a690d6fb943b18c40c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refresh the Service.service_id after re-spawning children"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, the oslo.service provider a mechanism that the main process"},{"line_number":10,"context_line":"will re-spawn the children as necessary. But if we kill the children"},{"line_number":11,"context_line":"service, the services (except the latest service) are always down"},{"line_number":12,"context_line":"after re-spawn."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bfdaf3ff_2beaa074","line":9,"range":{"start_line":9,"start_character":28,"end_line":9,"end_character":36},"updated":"2019-01-16 16:46:14.000000000","message":"provides","commit_id":"dbdb8e6b8935abfcc47ba32a472e47fabe35fed3"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"b61b53e6b074f9e46cec74a690d6fb943b18c40c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"This reason of this problem is that the Service.service_id is inherited"},{"line_number":15,"context_line":"from the parent process [1] (the parent Service service id class"},{"line_number":16,"context_line":"attribute) and has been recorded as the last created service [2][3]"},{"line_number":17,"context_line":"when latest process is stared. But when re-spawning child process,"},{"line_number":18,"context_line":"only start() method would be called[1], so that the Service.service_id"},{"line_number":19,"context_line":"is not refreshed as expected."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bfdaf3ff_eb033841","line":17,"range":{"start_line":17,"start_character":23,"end_line":17,"end_character":29},"updated":"2019-01-16 16:46:14.000000000","message":"started","commit_id":"dbdb8e6b8935abfcc47ba32a472e47fabe35fed3"}],"cinder/service.py":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"a924886447714109815977024e1b6b6fd3d952a0","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        # the Service.service_id will be inherited from the parent process,"},{"line_number":225,"context_line":"        # and will be recorded as the last created service id by mistaken."},{"line_number":226,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":227,"context_line":"        service_ref \u003d objects.Service.get_by_args(ctxt, self.host,"},{"line_number":228,"context_line":"                                                  self.binary)"},{"line_number":229,"context_line":"        Service.service_id \u003d service_ref.id"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bfdaf3ff_eb314aee","line":227,"updated":"2019-01-11 08:56:44.000000000","message":"I know sounds like it need a exception process to catch the not found things, but we already create this record when __init__ service, so I thought the not found exception should not be check again. Any other idea?","commit_id":"dbdb8e6b8935abfcc47ba32a472e47fabe35fed3"}]}
