)]}'
{"cinder/api/views/versions.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"12613255ec8e442249c345770dde9a9adddf8f4e","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        \"\"\"Create a URL that refers to a specific version_number.\"\"\""},{"line_number":70,"context_line":"        base_url \u003d self._get_base_url_without_version()"},{"line_number":71,"context_line":"        # Aways add \u0027/\u0027 to base_url end for urljoin href url"},{"line_number":72,"context_line":"        base_url \u003d base_url.rstrip(\u0027/\u0027) + \u0027/\u0027"},{"line_number":73,"context_line":"        rel_version \u003d version.lstrip(\u0027/\u0027)"},{"line_number":74,"context_line":"        href \u003d urllib.parse.urljoin(base_url, rel_version).rstrip(\u0027/\u0027) + \u0027/\u0027"},{"line_number":75,"context_line":"        if path:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfdaf3ff_36c80e54","line":72,"updated":"2019-01-11 14:51:46.000000000","message":"urljoin adds a / if one is not present when joining, so this doesn\u0027t actually do anything.\n\nThe commit message isn\u0027t really clear either, so maybe I\u0027m misreading what you\u0027re trying to do here. But this doesn\u0027t appear to actually change anything other than adding a very slight extra overhead of manipulating the string.\n\nThis should at least have a unit test that shows a failure without the code change, and passing with the code change.","commit_id":"3d755e312eddfd08291812799bfc8f4ed5a36c45"}]}