)]}'
{"cinder/tests/test_vmware_vmdk.py":[{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"7299ff788e8fc38544e300a28addaece8edf790a","unresolved":false,"context_lines":[{"line_number":1274,"context_line":"                    \u0027size\u0027: fake_size,"},{"line_number":1275,"context_line":"                    \u0027id\u0027: \u0027a720b3c0-d1f0-11e1-9b23-0800200c9a66\u0027}"},{"line_number":1276,"context_line":""},{"line_number":1277,"context_line":"        self.mox.StubOutWithMock(self._driver, \u0027_resize_volume\u0027)"},{"line_number":1278,"context_line":"        self._driver._resize_volume(fake_vol[\u0027name\u0027], fake_size)"},{"line_number":1279,"context_line":""},{"line_number":1280,"context_line":"        self.mox.ReplayAll()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F84ZM%3D","line":1277,"updated":"2013-12-19 08:20:16.000000000","message":"When possible we\u0027ve been trying to do new test cases with mock instead of mox. In the interest of getting things more py3 compat. http://www.voidspace.org.uk/python/mock http://eavesdrop.openstack.org/meetings/cinder/2013/cinder.2013-11-27-16.02.log.txt","commit_id":"cecffcac5a06d23acc41e0e4c0d8d4d57b6d91d1"},{"author":{"_account_id":7948,"name":"Subbu","email":"subramanian.neelakantan@gmail.com","username":"subbu"},"change_message_id":"7f60172b1567bcf9c9b04f3c94ad6231dd9cb8c9","unresolved":false,"context_lines":[{"line_number":1316,"context_line":"        self._test_extend_volume(volume_ops, _extend_vmdk_virtual_disk,"},{"line_number":1317,"context_line":"                                 _select_ds_for_volume)"},{"line_number":1318,"context_line":""},{"line_number":1319,"context_line":"    def _test_extend_volume(self, volume_ops, _extend_vmdk_virtual_disk,"},{"line_number":1320,"context_line":"                            _select_ds_for_volume):"},{"line_number":1321,"context_line":"        fake_name \u003d u\u0027volume-00000001\u0027"},{"line_number":1322,"context_line":"        new_size \u003d \u002721\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUX%2F%2B7r8%3D","line":1319,"updated":"2014-02-18 06:57:39.000000000","message":"Is there a reason to implement a private test method? Could we just move this contents to the test_extend_volume method itself?","commit_id":"3b18bcfa80ec234ed729230232b357d53c1d65f6"},{"author":{"_account_id":7948,"name":"Subbu","email":"subramanian.neelakantan@gmail.com","username":"subbu"},"change_message_id":"0095e576222cc29bc041e239ee476d085cb19e86","unresolved":false,"context_lines":[{"line_number":1316,"context_line":"        self._test_extend_volume(volume_ops, _extend_vmdk_virtual_disk,"},{"line_number":1317,"context_line":"                                 _select_ds_for_volume)"},{"line_number":1318,"context_line":""},{"line_number":1319,"context_line":"    def _test_extend_volume(self, volume_ops, _extend_vmdk_virtual_disk,"},{"line_number":1320,"context_line":"                            _select_ds_for_volume):"},{"line_number":1321,"context_line":"        fake_name \u003d u\u0027volume-00000001\u0027"},{"line_number":1322,"context_line":"        new_size \u003d \u002721\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUX%2F%2ByNc%3D","line":1319,"in_reply_to":"AAAAUX%2F%2B6ME%3D","updated":"2014-02-19 03:35:15.000000000","message":"Vincent, could you look at the third comment below (starting with \"if you remove the _test* method...). There I have explained how you can patch with vmdk.VMwareVcVmdkDriver and still call the base test method.","commit_id":"3b18bcfa80ec234ed729230232b357d53c1d65f6"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"07fc891882f6eda04fa7ebd079a30662b3c351a4","unresolved":false,"context_lines":[{"line_number":1316,"context_line":"        self._test_extend_volume(volume_ops, _extend_vmdk_virtual_disk,"},{"line_number":1317,"context_line":"                                 _select_ds_for_volume)"},{"line_number":1318,"context_line":""},{"line_number":1319,"context_line":"    def _test_extend_volume(self, volume_ops, _extend_vmdk_virtual_disk,"},{"line_number":1320,"context_line":"                            _select_ds_for_volume):"},{"line_number":1321,"context_line":"        fake_name \u003d u\u0027volume-00000001\u0027"},{"line_number":1322,"context_line":"        new_size \u003d \u002721\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUX%2F%2B6ME%3D","line":1319,"in_reply_to":"AAAAUX%2F%2B7r8%3D","updated":"2014-02-18 09:13:11.000000000","message":"Yes. Because in VMwareVcVmdkDriverTestCase, we need to patch vmdk.VMwareVcVmdkDriver, not vmdk.VMwareEsxVmdkDriver. Otherwise, VMwareVcVmdkDriverTestCase.test_extend_volume will not pass, though VMwareEsxVmdkDriver.test_extend_volume can.\nThat is why I apply a private method to call.","commit_id":"3b18bcfa80ec234ed729230232b357d53c1d65f6"},{"author":{"_account_id":7948,"name":"Subbu","email":"subramanian.neelakantan@gmail.com","username":"subbu"},"change_message_id":"7f60172b1567bcf9c9b04f3c94ad6231dd9cb8c9","unresolved":false,"context_lines":[{"line_number":1353,"context_line":"        # _extend_vmdk_virtual_disk is called, VimFaultException is raised. The"},{"line_number":1354,"context_line":"        # second time it is called, there is no exception."},{"line_number":1355,"context_line":"        _extend_vmdk_virtual_disk.reset_mock()"},{"line_number":1356,"context_line":"        _extend_vmdk_virtual_disk.side_effect \u003d side_effect"},{"line_number":1357,"context_line":"        # When _select_ds_for_volume raises no exception."},{"line_number":1358,"context_line":"        _select_ds_for_volume.return_value \u003d (fake_host, fake_rp,"},{"line_number":1359,"context_line":"                                              fake_folder, fake_summary)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUX%2F%2B7NI%3D","line":1356,"updated":"2014-02-18 06:57:39.000000000","message":"Optional: I think this can also be done as:\n_extend_vmdk_virtual_disk.side_effect \u003d [error_util.VimFaultException(mock.Mock(), \u0027Error\u0027), None]. That way you can do away with the extra nested method named \"side_effect\"","commit_id":"3b18bcfa80ec234ed729230232b357d53c1d65f6"},{"author":{"_account_id":7948,"name":"Subbu","email":"subramanian.neelakantan@gmail.com","username":"subbu"},"change_message_id":"7f60172b1567bcf9c9b04f3c94ad6231dd9cb8c9","unresolved":false,"context_lines":[{"line_number":2338,"context_line":"    def test_extend_volume(self, volume_ops, _extend_vmdk_virtual_disk,"},{"line_number":2339,"context_line":"                           _select_ds_for_volume):"},{"line_number":2340,"context_line":"        \"\"\"Test extend_volume.\"\"\""},{"line_number":2341,"context_line":"        self._test_extend_volume(volume_ops, _extend_vmdk_virtual_disk,"},{"line_number":2342,"context_line":"                                 _select_ds_for_volume)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUX%2F%2B7Lk%3D","line":2341,"updated":"2014-02-18 06:57:39.000000000","message":"If you remove the _test* method then you can replace this with:\nsuper(VMwareVcVmdkDriverTestCase, self).test_extend_volume(...)","commit_id":"3b18bcfa80ec234ed729230232b357d53c1d65f6"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"af6c71273b767955d6cd85d1354bb6476d7b8b51","unresolved":false,"context_lines":[{"line_number":2338,"context_line":"    def test_extend_volume(self, volume_ops, _extend_vmdk_virtual_disk,"},{"line_number":2339,"context_line":"                           _select_ds_for_volume):"},{"line_number":2340,"context_line":"        \"\"\"Test extend_volume.\"\"\""},{"line_number":2341,"context_line":"        self._test_extend_volume(volume_ops, _extend_vmdk_virtual_disk,"},{"line_number":2342,"context_line":"                                 _select_ds_for_volume)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUX%2F%2BwXs%3D","line":2341,"in_reply_to":"AAAAUX%2F%2B7Lk%3D","updated":"2014-02-19 09:30:19.000000000","message":"If I use super(VMwareVcVmdkDriverTestCase, self).test_extend_volume(...), the test cases does not pass, because test_extend_volume has been patched with three more parameters, volume_ops, _extend_... and _select....\r\n\r\nWhen I call super(VMwareVcVmdkDriverTestCase, self).test_extend_volume(volume_ops, _extend_.., _select_..), it says I am giving more parameters than expected. Please give more guidance to me.","commit_id":"3b18bcfa80ec234ed729230232b357d53c1d65f6"},{"author":{"_account_id":7948,"name":"Subbu","email":"subramanian.neelakantan@gmail.com","username":"subbu"},"change_message_id":"0b21e81e09e818f91bbef432b498aa0998f6c0c6","unresolved":false,"context_lines":[{"line_number":2338,"context_line":"    def test_extend_volume(self, volume_ops, _extend_vmdk_virtual_disk,"},{"line_number":2339,"context_line":"                           _select_ds_for_volume):"},{"line_number":2340,"context_line":"        \"\"\"Test extend_volume.\"\"\""},{"line_number":2341,"context_line":"        self._test_extend_volume(volume_ops, _extend_vmdk_virtual_disk,"},{"line_number":2342,"context_line":"                                 _select_ds_for_volume)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUX%2F%2BooY%3D","line":2341,"in_reply_to":"AAAAUX%2F%2BpgE%3D","updated":"2014-02-20 03:50:41.000000000","message":"Sorry for my wrong advice Vincent. This was working in a slightly different context (see: eg https://review.openstack.org/#/c/69771/2/cinder/tests/test_vmware_vmdk.py). Here I think your approach of using private method is fine.","commit_id":"3b18bcfa80ec234ed729230232b357d53c1d65f6"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"7bec7a83492ec565f9e67602f5f04a1dee94f1a9","unresolved":false,"context_lines":[{"line_number":2338,"context_line":"    def test_extend_volume(self, volume_ops, _extend_vmdk_virtual_disk,"},{"line_number":2339,"context_line":"                           _select_ds_for_volume):"},{"line_number":2340,"context_line":"        \"\"\"Test extend_volume.\"\"\""},{"line_number":2341,"context_line":"        self._test_extend_volume(volume_ops, _extend_vmdk_virtual_disk,"},{"line_number":2342,"context_line":"                                 _select_ds_for_volume)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUX%2F%2BpgE%3D","line":2341,"in_reply_to":"AAAAUX%2F%2Bv18%3D","updated":"2014-02-20 01:11:55.000000000","message":"Subbu, I tried this case as well. It did not work either, vmdk.VMwareVcVmdkDriver is not able to be passed, test_extend_volume is still using vmdk.VMwareEsxVmdkDriver.","commit_id":"3b18bcfa80ec234ed729230232b357d53c1d65f6"},{"author":{"_account_id":7948,"name":"Subbu","email":"subramanian.neelakantan@gmail.com","username":"subbu"},"change_message_id":"c2b25fba1025727cee5f4d347d7a30f983298eba","unresolved":false,"context_lines":[{"line_number":2338,"context_line":"    def test_extend_volume(self, volume_ops, _extend_vmdk_virtual_disk,"},{"line_number":2339,"context_line":"                           _select_ds_for_volume):"},{"line_number":2340,"context_line":"        \"\"\"Test extend_volume.\"\"\""},{"line_number":2341,"context_line":"        self._test_extend_volume(volume_ops, _extend_vmdk_virtual_disk,"},{"line_number":2342,"context_line":"                                 _select_ds_for_volume)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUX%2F%2Bv18%3D","line":2341,"in_reply_to":"AAAAUX%2F%2BwXs%3D","updated":"2014-02-19 10:41:10.000000000","message":"You can use super(VMwareVcVmdkDriverTestCase, self).test_extend_volume() with no args. Sorry for the confusion caused.","commit_id":"3b18bcfa80ec234ed729230232b357d53c1d65f6"}],"cinder/volume/drivers/vmware/vmdk.py":[{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"7299ff788e8fc38544e300a28addaece8edf790a","unresolved":false,"context_lines":[{"line_number":762,"context_line":"                 {\u0027id\u0027: image_id, \u0027vol\u0027: volume[\u0027name\u0027]})"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"    def extend_volume(self, volume, new_size):"},{"line_number":765,"context_line":"        \"\"\"Extend the size of the volume."},{"line_number":766,"context_line":"        \"\"\""},{"line_number":767,"context_line":"        self._resize_volume(volume[\u0027name\u0027], new_size)"},{"line_number":768,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F84bc%3D","line":765,"updated":"2013-12-19 08:20:16.000000000","message":"Fix this one line doc string: http://docs.openstack.org/developer/hacking/#docstrings","commit_id":"cecffcac5a06d23acc41e0e4c0d8d4d57b6d91d1"},{"author":{"_account_id":7948,"name":"Subbu","email":"subramanian.neelakantan@gmail.com","username":"subbu"},"change_message_id":"9402fab0260a1e9b811e2ca4b55ae7bb3065d92b","unresolved":false,"context_lines":[{"line_number":768,"context_line":""},{"line_number":769,"context_line":"    def _resize_volume(self, name, size):"},{"line_number":770,"context_line":"        size \u003d int(size) * units.MiB"},{"line_number":771,"context_line":"        backing \u003d self.volumeops.get_backing(name)"},{"line_number":772,"context_line":"        root_vmdk_path \u003d self._get_ds_name_vmdk_path(backing, name)"},{"line_number":773,"context_line":"        datacenter \u003d self.volumeops.get_dc(backing)"},{"line_number":774,"context_line":"        self.volumeops._extend_virtual_disk(size, root_vmdk_path, datacenter)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F84lg%3D","line":771,"updated":"2013-12-19 10:27:33.000000000","message":"The backing may not be available if it has not been attached at least once since we lazy create the backing. Please add the check and \"do nothing\" if backing does not exist.","commit_id":"cecffcac5a06d23acc41e0e4c0d8d4d57b6d91d1"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"ef90409522cb1636459074e598adeb2a32b48b9f","unresolved":false,"context_lines":[{"line_number":768,"context_line":""},{"line_number":769,"context_line":"    def _resize_volume(self, name, size):"},{"line_number":770,"context_line":"        size \u003d int(size) * units.MiB"},{"line_number":771,"context_line":"        backing \u003d self.volumeops.get_backing(name)"},{"line_number":772,"context_line":"        root_vmdk_path \u003d self._get_ds_name_vmdk_path(backing, name)"},{"line_number":773,"context_line":"        datacenter \u003d self.volumeops.get_dc(backing)"},{"line_number":774,"context_line":"        self.volumeops._extend_virtual_disk(size, root_vmdk_path, datacenter)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F817o%3D","line":771,"in_reply_to":"AAAATn%2F84lg%3D","updated":"2013-12-19 16:46:24.000000000","message":"Recommend at least printing an info, or perhaps warning level message if this happens.","commit_id":"cecffcac5a06d23acc41e0e4c0d8d4d57b6d91d1"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"7299ff788e8fc38544e300a28addaece8edf790a","unresolved":false,"context_lines":[{"line_number":769,"context_line":"    def _resize_volume(self, name, size):"},{"line_number":770,"context_line":"        size \u003d int(size) * units.MiB"},{"line_number":771,"context_line":"        backing \u003d self.volumeops.get_backing(name)"},{"line_number":772,"context_line":"        root_vmdk_path \u003d self._get_ds_name_vmdk_path(backing, name)"},{"line_number":773,"context_line":"        datacenter \u003d self.volumeops.get_dc(backing)"},{"line_number":774,"context_line":"        self.volumeops._extend_virtual_disk(size, root_vmdk_path, datacenter)"},{"line_number":775,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F84aI%3D","line":772,"updated":"2013-12-19 08:20:16.000000000","message":"This returns a list. I think you just want the second element?","commit_id":"cecffcac5a06d23acc41e0e4c0d8d4d57b6d91d1"},{"author":{"_account_id":7948,"name":"Subbu","email":"subramanian.neelakantan@gmail.com","username":"subbu"},"change_message_id":"9402fab0260a1e9b811e2ca4b55ae7bb3065d92b","unresolved":false,"context_lines":[{"line_number":771,"context_line":"        backing \u003d self.volumeops.get_backing(name)"},{"line_number":772,"context_line":"        root_vmdk_path \u003d self._get_ds_name_vmdk_path(backing, name)"},{"line_number":773,"context_line":"        datacenter \u003d self.volumeops.get_dc(backing)"},{"line_number":774,"context_line":"        self.volumeops._extend_virtual_disk(size, root_vmdk_path, datacenter)"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"    def copy_image_to_volume(self, context, volume, image_service, image_id):"},{"line_number":777,"context_line":"        \"\"\"Creates volume from image."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F84lA%3D","line":774,"updated":"2013-12-19 10:27:33.000000000","message":"You would have to add a dependency on https://review.openstack.org/#/c/59924 since you are invoking _extend_virtual_disk().","commit_id":"cecffcac5a06d23acc41e0e4c0d8d4d57b6d91d1"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"94006093fb93f97be2ff111ae5e9da5e780c47ac","unresolved":false,"context_lines":[{"line_number":934,"context_line":"        # try extending vmdk in place"},{"line_number":935,"context_line":"        try:"},{"line_number":936,"context_line":"            self._extend_vmdk_virtual_disk(vol_name, new_size)"},{"line_number":937,"context_line":"            LOG.info(_(\"Done extending volume %(vol)s to size %(size)s GB\") %"},{"line_number":938,"context_line":"                     {\u0027vol\u0027: vol_name, \u0027size\u0027: new_size})"},{"line_number":939,"context_line":"            return"},{"line_number":940,"context_line":"        except error_util.VimFaultException as excep:"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUX%2F%2BZVA%3D","line":937,"updated":"2014-02-21 12:47:30.000000000","message":"Following on Jay\u0027s lines, recommend finishing the string with a \u0027.\u0027 :)","commit_id":"7a902fca5f0c5ddb4143cee0045684cf0512c8c0"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"94006093fb93f97be2ff111ae5e9da5e780c47ac","unresolved":false,"context_lines":[{"line_number":938,"context_line":"                     {\u0027vol\u0027: vol_name, \u0027size\u0027: new_size})"},{"line_number":939,"context_line":"            return"},{"line_number":940,"context_line":"        except error_util.VimFaultException as excep:"},{"line_number":941,"context_line":"            LOG.debug(_(\"Relocating volume %s vmdk to a different datastore\""},{"line_number":942,"context_line":"                        \" since trying to extend vmdk file in place failed.\"),"},{"line_number":943,"context_line":"                      vol_name)"},{"line_number":944,"context_line":"        # If in place extend fails, then try to relocate the volume"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUX%2F%2BZUU%3D","line":941,"updated":"2014-02-21 12:47:30.000000000","message":"Generally we put the space at the end of the first line, instead of the start of the next line..","commit_id":"7a902fca5f0c5ddb4143cee0045684cf0512c8c0"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"94006093fb93f97be2ff111ae5e9da5e780c47ac","unresolved":false,"context_lines":[{"line_number":963,"context_line":"            LOG.exception(_(\"Not able to relocate volume %s for extending.\"),"},{"line_number":964,"context_line":"                          vol_name)"},{"line_number":965,"context_line":"            raise excep"},{"line_number":966,"context_line":"        LOG.info(_(\"Done extending volume %(vol)s to size %(size)s GB\") %"},{"line_number":967,"context_line":"                 {\u0027vol\u0027: vol_name, \u0027size\u0027: new_size})"},{"line_number":968,"context_line":""},{"line_number":969,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUX%2F%2BZT0%3D","line":966,"updated":"2014-02-21 12:47:30.000000000","message":"Recommend finishing the string with a \u0027.\u0027","commit_id":"7a902fca5f0c5ddb4143cee0045684cf0512c8c0"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"b97618620a3103c695f1ed5e2529acc6cdbfbdc7","unresolved":false,"context_lines":[{"line_number":738,"context_line":"            LOG.info(_(\"Done copying image: %(id)s to volume: %(vol)s.\") %"},{"line_number":739,"context_line":"                     {\u0027id\u0027: image_id, \u0027vol\u0027: volume[\u0027name\u0027]})"},{"line_number":740,"context_line":"        except Exception as excep:"},{"line_number":741,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":742,"context_line":"                LOG.exception(_(\"Exception in copy_image_to_volume: \""},{"line_number":743,"context_line":"                                \"%(excep)s. Deleting the backing: \""},{"line_number":744,"context_line":"                                \"%(back)s.\") %"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAVn%2F%2F%2FTc%3D","line":741,"updated":"2014-03-02 22:26:52.000000000","message":"Probably another spot that we should be raising a BackendVolume exception, there\u0027s a number of things that can get raised here (I think) and trying to cover all of them in the manager isn\u0027t going to happen.","commit_id":"a10d5f8bc4917c1ff537563bf8c9ce00c7dd8484"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"27f46b1d57434856f05afc75167c05b94788c3cf","unresolved":false,"context_lines":[{"line_number":738,"context_line":"            LOG.info(_(\"Done copying image: %(id)s to volume: %(vol)s.\") %"},{"line_number":739,"context_line":"                     {\u0027id\u0027: image_id, \u0027vol\u0027: volume[\u0027name\u0027]})"},{"line_number":740,"context_line":"        except Exception as excep:"},{"line_number":741,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":742,"context_line":"                LOG.exception(_(\"Exception in copy_image_to_volume: \""},{"line_number":743,"context_line":"                                \"%(excep)s. Deleting the backing: \""},{"line_number":744,"context_line":"                                \"%(back)s.\") %"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAVn%2F%2F91s%3D","line":741,"in_reply_to":"AAAAVn%2F%2F%2FTc%3D","updated":"2014-03-03 05:13:48.000000000","message":"Done","commit_id":"a10d5f8bc4917c1ff537563bf8c9ce00c7dd8484"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"b97618620a3103c695f1ed5e2529acc6cdbfbdc7","unresolved":false,"context_lines":[{"line_number":760,"context_line":"            size_gb \u003d volume[\u0027size\u0027]"},{"line_number":761,"context_line":"            (host, rp, folder, summary) \u003d self._select_ds_for_volume(size_gb)"},{"line_number":762,"context_line":"        except error_util.VimException as excep:"},{"line_number":763,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":764,"context_line":"                LOG.exception(_(\"Exception in _select_ds_for_volume: \""},{"line_number":765,"context_line":"                                \"%s.\"), excep)"},{"line_number":766,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAVn%2F%2F%2FTM%3D","line":763,"updated":"2014-03-02 22:26:52.000000000","message":"It would be better if you could translate this to a CinderVolumeBackendAPIException so we don\u0027t have to try and handle all these various exceptions raised from the backend.","commit_id":"a10d5f8bc4917c1ff537563bf8c9ce00c7dd8484"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"27f46b1d57434856f05afc75167c05b94788c3cf","unresolved":false,"context_lines":[{"line_number":760,"context_line":"            size_gb \u003d volume[\u0027size\u0027]"},{"line_number":761,"context_line":"            (host, rp, folder, summary) \u003d self._select_ds_for_volume(size_gb)"},{"line_number":762,"context_line":"        except error_util.VimException as excep:"},{"line_number":763,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":764,"context_line":"                LOG.exception(_(\"Exception in _select_ds_for_volume: \""},{"line_number":765,"context_line":"                                \"%s.\"), excep)"},{"line_number":766,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAVn%2F%2F91w%3D","line":763,"in_reply_to":"AAAAVn%2F%2F%2FTM%3D","updated":"2014-03-03 05:13:48.000000000","message":"Done","commit_id":"a10d5f8bc4917c1ff537563bf8c9ce00c7dd8484"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"b97618620a3103c695f1ed5e2529acc6cdbfbdc7","unresolved":false,"context_lines":[{"line_number":873,"context_line":"        if properties and \u0027vmware_disktype\u0027 in properties:"},{"line_number":874,"context_line":"            disk_type \u003d properties[\u0027vmware_disktype\u0027]"},{"line_number":875,"context_line":""},{"line_number":876,"context_line":"        if disk_type \u003d\u003d \u0027streamOptimized\u0027:"},{"line_number":877,"context_line":"            self._fetch_stream_optimized_image(context, volume, image_service,"},{"line_number":878,"context_line":"                                               image_id, image_size_in_bytes)"},{"line_number":879,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAVn%2F%2F%2FUE%3D","line":876,"updated":"2014-03-02 22:26:52.000000000","message":"Would you want to try/except here, translate and reraise maybe?","commit_id":"a10d5f8bc4917c1ff537563bf8c9ce00c7dd8484"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"27f46b1d57434856f05afc75167c05b94788c3cf","unresolved":false,"context_lines":[{"line_number":873,"context_line":"        if properties and \u0027vmware_disktype\u0027 in properties:"},{"line_number":874,"context_line":"            disk_type \u003d properties[\u0027vmware_disktype\u0027]"},{"line_number":875,"context_line":""},{"line_number":876,"context_line":"        if disk_type \u003d\u003d \u0027streamOptimized\u0027:"},{"line_number":877,"context_line":"            self._fetch_stream_optimized_image(context, volume, image_service,"},{"line_number":878,"context_line":"                                               image_id, image_size_in_bytes)"},{"line_number":879,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAVn%2F%2F93Q%3D","line":876,"in_reply_to":"AAAAVn%2F%2F%2FUE%3D","updated":"2014-03-03 05:13:48.000000000","message":"Done","commit_id":"a10d5f8bc4917c1ff537563bf8c9ce00c7dd8484"},{"author":{"_account_id":7236,"name":"Kiyohiro Adachi","email":"kiy-adachi@vx.jp.nec.com","username":"kadachi"},"change_message_id":"6e582ed00514a9f5c97b1ac67b027f83d5b29407","unresolved":false,"context_lines":[{"line_number":1079,"context_line":"            LOG.info(_(\"Done extending volume %(vol)s to size %(size)s GB.\") %"},{"line_number":1080,"context_line":"                     {\u0027vol\u0027: vol_name, \u0027size\u0027: new_size})"},{"line_number":1081,"context_line":"            return"},{"line_number":1082,"context_line":"        except error_util.VimFaultException as excep:"},{"line_number":1083,"context_line":"            LOG.info(_(\"Relocating volume %s vmdk to a different \""},{"line_number":1084,"context_line":"                       \"datastore since trying to extend vmdk file \""},{"line_number":1085,"context_line":"                       \"in place failed.\"), vol_name)"}],"source_content_type":"text/x-python","patch_set":33,"id":"AAAAWH%2F%2FtI8%3D","line":1082,"updated":"2014-03-14 11:12:01.000000000","message":"\u0027as excep\u0027 is not required.","commit_id":"2862750b12ee65936d8040490bccff5f21757bcc"}]}