)]}'
{"cinder/tests/unit/volume/drivers/dell_emc/powermax/test_powermax.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"48f572ecfe57971c9a1130fcc4d5c858b7ad69c7","unresolved":false,"context_lines":[{"line_number":7157,"context_line":"        self.assertRaises("},{"line_number":7158,"context_line":"            exception.VolumeBackendAPIException,"},{"line_number":7159,"context_line":"            self.driver.masking._sanity_port_group_check,"},{"line_number":7160,"context_line":"            self.data.array, None)"},{"line_number":7161,"context_line":""},{"line_number":7162,"context_line":"    @mock.patch.object("},{"line_number":7163,"context_line":"        rest.PowerMaxRest,"}],"source_content_type":"text/x-python","patch_set":12,"id":"5fc1f717_fdf0eacb","line":7160,"range":{"start_line":7160,"start_character":12,"end_line":7160,"end_character":33},"updated":"2019-03-08 14:48:51.000000000","message":"is this ordering of positional args correct?\nshouldn\u0027t \u0027port_group_name\u0027 be passed first?","commit_id":"a8b8ccc8d231c52350d354b037e7b2ad9c067a3e"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"50b05885452db43b5de679e643e68513569d40f7","unresolved":false,"context_lines":[{"line_number":7157,"context_line":"        self.assertRaises("},{"line_number":7158,"context_line":"            exception.VolumeBackendAPIException,"},{"line_number":7159,"context_line":"            self.driver.masking._sanity_port_group_check,"},{"line_number":7160,"context_line":"            self.data.array, None)"},{"line_number":7161,"context_line":""},{"line_number":7162,"context_line":"    @mock.patch.object("},{"line_number":7163,"context_line":"        rest.PowerMaxRest,"}],"source_content_type":"text/x-python","patch_set":12,"id":"5fc1f717_58234c06","line":7160,"range":{"start_line":7160,"start_character":12,"end_line":7160,"end_character":33},"in_reply_to":"5fc1f717_bd14a2a1","updated":"2019-03-08 15:36:22.000000000","message":"Fixed in https://review.openstack.org/642061.  Thank you for the feedback","commit_id":"a8b8ccc8d231c52350d354b037e7b2ad9c067a3e"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"0829bed88be874a456922d82badc2ad3ba6e408b","unresolved":false,"context_lines":[{"line_number":7157,"context_line":"        self.assertRaises("},{"line_number":7158,"context_line":"            exception.VolumeBackendAPIException,"},{"line_number":7159,"context_line":"            self.driver.masking._sanity_port_group_check,"},{"line_number":7160,"context_line":"            self.data.array, None)"},{"line_number":7161,"context_line":""},{"line_number":7162,"context_line":"    @mock.patch.object("},{"line_number":7163,"context_line":"        rest.PowerMaxRest,"}],"source_content_type":"text/x-python","patch_set":12,"id":"5fc1f717_bd14a2a1","line":7160,"range":{"start_line":7160,"start_character":12,"end_line":7160,"end_character":33},"in_reply_to":"5fc1f717_fdf0eacb","updated":"2019-03-08 15:00:01.000000000","message":"Yes, thank you.  As it (and 3 of its dependencies) are already at the gate, I will fix it in a separate patch","commit_id":"a8b8ccc8d231c52350d354b037e7b2ad9c067a3e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"48f572ecfe57971c9a1130fcc4d5c858b7ad69c7","unresolved":false,"context_lines":[{"line_number":7167,"context_line":"        self.assertRaises("},{"line_number":7168,"context_line":"            exception.VolumeBackendAPIException,"},{"line_number":7169,"context_line":"            self.driver.masking._sanity_port_group_check,"},{"line_number":7170,"context_line":"            self.data.array, None)"},{"line_number":7171,"context_line":""},{"line_number":7172,"context_line":"    @mock.patch.object("},{"line_number":7173,"context_line":"        rest.PowerMaxRest,"}],"source_content_type":"text/x-python","patch_set":12,"id":"5fc1f717_1decd6f1","line":7170,"range":{"start_line":7170,"start_character":12,"end_line":7170,"end_character":33},"updated":"2019-03-08 14:48:51.000000000","message":"same","commit_id":"a8b8ccc8d231c52350d354b037e7b2ad9c067a3e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"48f572ecfe57971c9a1130fcc4d5c858b7ad69c7","unresolved":false,"context_lines":[{"line_number":7175,"context_line":"        return_value\u003dPowerMaxCommonData.portgroup)"},{"line_number":7176,"context_line":"    def test_sanity_port_group_check(self, mock_pg):"},{"line_number":7177,"context_line":"        self.driver.masking._sanity_port_group_check("},{"line_number":7178,"context_line":"            self.data.array, self.data.port_group_name_f)"},{"line_number":7179,"context_line":""},{"line_number":7180,"context_line":"    @mock.patch.object("},{"line_number":7181,"context_line":"        masking.PowerMaxMasking,"}],"source_content_type":"text/x-python","patch_set":12,"id":"5fc1f717_bdbca2dc","line":7178,"range":{"start_line":7178,"start_character":12,"end_line":7178,"end_character":56},"updated":"2019-03-08 14:48:51.000000000","message":"same","commit_id":"a8b8ccc8d231c52350d354b037e7b2ad9c067a3e"}],"cinder/volume/drivers/dell_emc/powermax/common.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"7b25483fe8aaacd3933568b55f07b545faf4e21d","unresolved":false,"context_lines":[{"line_number":1454,"context_line":"            LOG.warning(\"You must supply a valid pre-created port group \""},{"line_number":1455,"context_line":"                        \"in cinder.conf or as an extra spec. Port group \""},{"line_number":1456,"context_line":"                        \"cannot be left empty as creating a new masking \""},{"line_number":1457,"context_line":"                        \"view will fail.\")"},{"line_number":1458,"context_line":"        masking_view_dict[utils.PORTGROUPNAME] \u003d ("},{"line_number":1459,"context_line":"            extra_specs[utils.PORTGROUPNAME])"},{"line_number":1460,"context_line":"        masking_view_dict[utils.INITIATOR_CHECK] \u003d ("}],"source_content_type":"text/x-python","patch_set":12,"id":"9fdfeff1_b615129e","line":1457,"updated":"2019-02-15 17:54:05.000000000","message":"Should this raise an error now rather than waiting to fail later?","commit_id":"a8b8ccc8d231c52350d354b037e7b2ad9c067a3e"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"e50b50054da6063082861abc3894a77980f9b1c6","unresolved":false,"context_lines":[{"line_number":1454,"context_line":"            LOG.warning(\"You must supply a valid pre-created port group \""},{"line_number":1455,"context_line":"                        \"in cinder.conf or as an extra spec. Port group \""},{"line_number":1456,"context_line":"                        \"cannot be left empty as creating a new masking \""},{"line_number":1457,"context_line":"                        \"view will fail.\")"},{"line_number":1458,"context_line":"        masking_view_dict[utils.PORTGROUPNAME] \u003d ("},{"line_number":1459,"context_line":"            extra_specs[utils.PORTGROUPNAME])"},{"line_number":1460,"context_line":"        masking_view_dict[utils.INITIATOR_CHECK] \u003d ("}],"source_content_type":"text/x-python","patch_set":12,"id":"9fdfeff1_756569ae","line":1457,"in_reply_to":"9fdfeff1_b615129e","updated":"2019-02-28 12:39:28.000000000","message":"The reason we did not fail here, was there may be an existing masking view created already with a valid portgroup that we may re-use in the attach operation. Port groups can be randomly selected from a list in cinder.conf or as an extra spec on the volume type, if the user wishes to specify a particular port group.","commit_id":"a8b8ccc8d231c52350d354b037e7b2ad9c067a3e"}]}