)]}'
{"cinder/image/image_utils.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"42c6e34dea62906c5393a301cd8b1ddef6706463","unresolved":false,"context_lines":[{"line_number":671,"context_line":"def check_available_space(dest, image_size, image_id):"},{"line_number":672,"context_line":"    # TODO(e0ne): replace psutil with shutil.disk_usage when we drop"},{"line_number":673,"context_line":"    # Python 2.7 support."},{"line_number":674,"context_line":"    if utils.is_blk_device(dest):"},{"line_number":675,"context_line":"        return"},{"line_number":676,"context_line":"    if not os.path.isdir(dest):"},{"line_number":677,"context_line":"        dest \u003d os.path.dirname(dest)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_fa0c2bed","line":674,"updated":"2019-01-28 15:38:26.000000000","message":"Where is check_available_space() ever called from that \"dest\" could be a block device?\n\nI don\u0027t see code that does this.","commit_id":"48aa5b69b43b3b816265229503336ee15291f81d"},{"author":{"_account_id":23561,"name":"iain MacDonnell","email":"iain.macdonnell@oracle.com","username":"imacdonn"},"change_message_id":"3d32f057df4d6664de4757ed324ff67d0a4a4080","unresolved":false,"context_lines":[{"line_number":671,"context_line":"def check_available_space(dest, image_size, image_id):"},{"line_number":672,"context_line":"    # TODO(e0ne): replace psutil with shutil.disk_usage when we drop"},{"line_number":673,"context_line":"    # Python 2.7 support."},{"line_number":674,"context_line":"    if utils.is_blk_device(dest):"},{"line_number":675,"context_line":"        return"},{"line_number":676,"context_line":"    if not os.path.isdir(dest):"},{"line_number":677,"context_line":"        dest \u003d os.path.dirname(dest)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_aba417a7","line":674,"in_reply_to":"9fdfeff1_0b2be32f","updated":"2019-01-28 17:51:34.000000000","message":"Scratch the second paragraph. I haven\u0027t absorbed enough caffeine yet this morning. Of course the point of the change is to \"not even go there\".","commit_id":"48aa5b69b43b3b816265229503336ee15291f81d"},{"author":{"_account_id":23561,"name":"iain MacDonnell","email":"iain.macdonnell@oracle.com","username":"imacdonn"},"change_message_id":"8618b2df11c768c852236c9df1f756a7fc896c73","unresolved":false,"context_lines":[{"line_number":671,"context_line":"def check_available_space(dest, image_size, image_id):"},{"line_number":672,"context_line":"    # TODO(e0ne): replace psutil with shutil.disk_usage when we drop"},{"line_number":673,"context_line":"    # Python 2.7 support."},{"line_number":674,"context_line":"    if utils.is_blk_device(dest):"},{"line_number":675,"context_line":"        return"},{"line_number":676,"context_line":"    if not os.path.isdir(dest):"},{"line_number":677,"context_line":"        dest \u003d os.path.dirname(dest)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_0b2be32f","line":674,"in_reply_to":"9fdfeff1_fa0c2bed","updated":"2019-01-28 17:48:30.000000000","message":"We removed one in https://review.openstack.org/#/c/555100/\n\nThe bigger(?) concern I have is that (I think) the following code (still) doesn\u0027t work if the dest *is* a block device. In that case, it is not a directory, so the code immediately below will change focus to the directory containing the special file representing the block device, which is not pertinent for a space check.","commit_id":"48aa5b69b43b3b816265229503336ee15291f81d"}]}