)]}'
{"cinder/volume/drivers/solidfire.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9ead78db1fa3d62aa19fe3982f6bd0b737e81024","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    cfg.StrOpt(\u0027sf_provisioning_calc\u0027,"},{"line_number":100,"context_line":"               default\u003d\u0027maxProvisionedSpace\u0027,"},{"line_number":101,"context_line":"               choices\u003d[\u0027maxProvisionedSpace\u0027, \u0027usedSpace\u0027],"},{"line_number":102,"context_line":"               help\u003d\u0027Change how SolidFire reports used_space and \u0027"},{"line_number":103,"context_line":"                    \u0027provisioning calculations. If usedSpace is used, the \u0027"},{"line_number":104,"context_line":"                    \u0027driver will report correct values as expected by Cinder \u0027"},{"line_number":105,"context_line":"                    \u0027thin provisioning. For compatibility reasons, \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_a82fe1f3","line":102,"range":{"start_line":102,"start_character":50,"end_line":102,"end_character":60},"updated":"2019-02-17 14:39:46.000000000","message":"since it isn\u0027t referring to any predefined name, we can write \u0027used space\u0027","commit_id":"1fb7387e7e1a38363e7e31ebbb6b8df3f9119760"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"c2a091c5dd198061337346d0361447419aaf02dd","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    cfg.StrOpt(\u0027sf_provisioning_calc\u0027,"},{"line_number":100,"context_line":"               default\u003d\u0027maxProvisionedSpace\u0027,"},{"line_number":101,"context_line":"               choices\u003d[\u0027maxProvisionedSpace\u0027, \u0027usedSpace\u0027],"},{"line_number":102,"context_line":"               help\u003d\u0027Change how SolidFire reports used_space and \u0027"},{"line_number":103,"context_line":"                    \u0027provisioning calculations. If usedSpace is used, the \u0027"},{"line_number":104,"context_line":"                    \u0027driver will report correct values as expected by Cinder \u0027"},{"line_number":105,"context_line":"                    \u0027thin provisioning. For compatibility reasons, \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_3de7a4e5","line":102,"range":{"start_line":102,"start_character":50,"end_line":102,"end_character":60},"in_reply_to":"9fdfeff1_a82fe1f3","updated":"2019-02-18 13:30:51.000000000","message":"Done","commit_id":"1fb7387e7e1a38363e7e31ebbb6b8df3f9119760"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9ead78db1fa3d62aa19fe3982f6bd0b737e81024","unresolved":false,"context_lines":[{"line_number":100,"context_line":"               default\u003d\u0027maxProvisionedSpace\u0027,"},{"line_number":101,"context_line":"               choices\u003d[\u0027maxProvisionedSpace\u0027, \u0027usedSpace\u0027],"},{"line_number":102,"context_line":"               help\u003d\u0027Change how SolidFire reports used_space and \u0027"},{"line_number":103,"context_line":"                    \u0027provisioning calculations. If usedSpace is used, the \u0027"},{"line_number":104,"context_line":"                    \u0027driver will report correct values as expected by Cinder \u0027"},{"line_number":105,"context_line":"                    \u0027thin provisioning. For compatibility reasons, \u0027"},{"line_number":106,"context_line":"                    \u0027maxProvisionedSpace is the default behaviour and that \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_08406da4","line":103,"range":{"start_line":103,"start_character":48,"end_line":103,"end_character":68},"updated":"2019-02-17 14:39:46.000000000","message":"little confusing, can we write it as,\nIf this parameter is set to/as usedSpace, ...","commit_id":"1fb7387e7e1a38363e7e31ebbb6b8df3f9119760"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"c2a091c5dd198061337346d0361447419aaf02dd","unresolved":false,"context_lines":[{"line_number":100,"context_line":"               default\u003d\u0027maxProvisionedSpace\u0027,"},{"line_number":101,"context_line":"               choices\u003d[\u0027maxProvisionedSpace\u0027, \u0027usedSpace\u0027],"},{"line_number":102,"context_line":"               help\u003d\u0027Change how SolidFire reports used_space and \u0027"},{"line_number":103,"context_line":"                    \u0027provisioning calculations. If usedSpace is used, the \u0027"},{"line_number":104,"context_line":"                    \u0027driver will report correct values as expected by Cinder \u0027"},{"line_number":105,"context_line":"                    \u0027thin provisioning. For compatibility reasons, \u0027"},{"line_number":106,"context_line":"                    \u0027maxProvisionedSpace is the default behaviour and that \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_fdf59c83","line":103,"range":{"start_line":103,"start_character":48,"end_line":103,"end_character":68},"in_reply_to":"9fdfeff1_08406da4","updated":"2019-02-18 13:30:51.000000000","message":"Done","commit_id":"1fb7387e7e1a38363e7e31ebbb6b8df3f9119760"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9ead78db1fa3d62aa19fe3982f6bd0b737e81024","unresolved":false,"context_lines":[{"line_number":101,"context_line":"               choices\u003d[\u0027maxProvisionedSpace\u0027, \u0027usedSpace\u0027],"},{"line_number":102,"context_line":"               help\u003d\u0027Change how SolidFire reports used_space and \u0027"},{"line_number":103,"context_line":"                    \u0027provisioning calculations. If usedSpace is used, the \u0027"},{"line_number":104,"context_line":"                    \u0027driver will report correct values as expected by Cinder \u0027"},{"line_number":105,"context_line":"                    \u0027thin provisioning. For compatibility reasons, \u0027"},{"line_number":106,"context_line":"                    \u0027maxProvisionedSpace is the default behaviour and that \u0027"},{"line_number":107,"context_line":"                    \u0027will keep the driver reporting in the old fashion.\u0027)]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_283bf137","line":104,"range":{"start_line":104,"start_character":40,"end_line":104,"end_character":54},"updated":"2019-02-17 14:39:46.000000000","message":"maybe can be elaborated in the commit msg or releasenote","commit_id":"1fb7387e7e1a38363e7e31ebbb6b8df3f9119760"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"c2a091c5dd198061337346d0361447419aaf02dd","unresolved":false,"context_lines":[{"line_number":101,"context_line":"               choices\u003d[\u0027maxProvisionedSpace\u0027, \u0027usedSpace\u0027],"},{"line_number":102,"context_line":"               help\u003d\u0027Change how SolidFire reports used_space and \u0027"},{"line_number":103,"context_line":"                    \u0027provisioning calculations. If usedSpace is used, the \u0027"},{"line_number":104,"context_line":"                    \u0027driver will report correct values as expected by Cinder \u0027"},{"line_number":105,"context_line":"                    \u0027thin provisioning. For compatibility reasons, \u0027"},{"line_number":106,"context_line":"                    \u0027maxProvisionedSpace is the default behaviour and that \u0027"},{"line_number":107,"context_line":"                    \u0027will keep the driver reporting in the old fashion.\u0027)]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_7d18ccd1","line":104,"range":{"start_line":104,"start_character":40,"end_line":104,"end_character":54},"in_reply_to":"9fdfeff1_283bf137","updated":"2019-02-18 13:30:51.000000000","message":"Done","commit_id":"1fb7387e7e1a38363e7e31ebbb6b8df3f9119760"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9ead78db1fa3d62aa19fe3982f6bd0b737e81024","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                    \u0027driver will report correct values as expected by Cinder \u0027"},{"line_number":105,"context_line":"                    \u0027thin provisioning. For compatibility reasons, \u0027"},{"line_number":106,"context_line":"                    \u0027maxProvisionedSpace is the default behaviour and that \u0027"},{"line_number":107,"context_line":"                    \u0027will keep the driver reporting in the old fashion.\u0027)]"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"CONF \u003d cfg.CONF"},{"line_number":110,"context_line":"CONF.register_opts(sf_opts, group\u003dconfiguration.SHARED_CONF_GROUP)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_680ed98c","line":107,"range":{"start_line":107,"start_character":59,"end_line":107,"end_character":70},"updated":"2019-02-17 14:39:46.000000000","message":"old fashion/old way\nwhichever suites","commit_id":"1fb7387e7e1a38363e7e31ebbb6b8df3f9119760"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"c2a091c5dd198061337346d0361447419aaf02dd","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                    \u0027driver will report correct values as expected by Cinder \u0027"},{"line_number":105,"context_line":"                    \u0027thin provisioning. For compatibility reasons, \u0027"},{"line_number":106,"context_line":"                    \u0027maxProvisionedSpace is the default behaviour and that \u0027"},{"line_number":107,"context_line":"                    \u0027will keep the driver reporting in the old fashion.\u0027)]"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"CONF \u003d cfg.CONF"},{"line_number":110,"context_line":"CONF.register_opts(sf_opts, group\u003dconfiguration.SHARED_CONF_GROUP)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_dd6d3832","line":107,"range":{"start_line":107,"start_character":59,"end_line":107,"end_character":70},"in_reply_to":"9fdfeff1_680ed98c","updated":"2019-02-18 13:30:51.000000000","message":"Done","commit_id":"1fb7387e7e1a38363e7e31ebbb6b8df3f9119760"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9ead78db1fa3d62aa19fe3982f6bd0b737e81024","unresolved":false,"context_lines":[{"line_number":1904,"context_line":"        self._issue_api_request(\u0027ModifyVolume\u0027,"},{"line_number":1905,"context_line":"                                params, version\u003d\u00275.0\u0027)"},{"line_number":1906,"context_line":""},{"line_number":1907,"context_line":"    def _get_provisioned_volumes(self):"},{"line_number":1908,"context_line":"        response \u003d self._issue_api_request(\u0027ListVolumes\u0027, {}, version\u003d\u00278.0\u0027)"},{"line_number":1909,"context_line":"        volumes \u003d response[\u0027result\u0027][\u0027volumes\u0027]"},{"line_number":1910,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_c81ee5b9","line":1907,"range":{"start_line":1907,"start_character":8,"end_line":1907,"end_character":32},"updated":"2019-02-17 14:39:46.000000000","message":"I think this function returns the provisioned capacity, can we rename it as \u0027_get_provisioned_volumes_capacity\u0027","commit_id":"1fb7387e7e1a38363e7e31ebbb6b8df3f9119760"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"c2a091c5dd198061337346d0361447419aaf02dd","unresolved":false,"context_lines":[{"line_number":1904,"context_line":"        self._issue_api_request(\u0027ModifyVolume\u0027,"},{"line_number":1905,"context_line":"                                params, version\u003d\u00275.0\u0027)"},{"line_number":1906,"context_line":""},{"line_number":1907,"context_line":"    def _get_provisioned_volumes(self):"},{"line_number":1908,"context_line":"        response \u003d self._issue_api_request(\u0027ListVolumes\u0027, {}, version\u003d\u00278.0\u0027)"},{"line_number":1909,"context_line":"        volumes \u003d response[\u0027result\u0027][\u0027volumes\u0027]"},{"line_number":1910,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_1dce602c","line":1907,"range":{"start_line":1907,"start_character":8,"end_line":1907,"end_character":32},"in_reply_to":"9fdfeff1_c81ee5b9","updated":"2019-02-18 13:30:51.000000000","message":"Done","commit_id":"1fb7387e7e1a38363e7e31ebbb6b8df3f9119760"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9ead78db1fa3d62aa19fe3982f6bd0b737e81024","unresolved":false,"context_lines":[{"line_number":1948,"context_line":"        if self.configuration.sf_provisioning_calc \u003d\u003d \u0027usedSpace\u0027:"},{"line_number":1949,"context_line":"            free_capacity \u003d ("},{"line_number":1950,"context_line":"                results[\u0027maxUsedSpace\u0027] - results[\u0027usedSpace\u0027])"},{"line_number":1951,"context_line":"            data[\u0027total_capacity_gb\u0027] \u003d ("},{"line_number":1952,"context_line":"                float(results[\u0027maxUsedSpace\u0027] / units.Gi))"},{"line_number":1953,"context_line":"            data[\u0027thin_provisioning_support\u0027] \u003d True"},{"line_number":1954,"context_line":"            data[\u0027provisioned_capacity_gb\u0027] \u003d ("},{"line_number":1955,"context_line":"                self._get_provisioned_volumes() / units.Gi)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_e86e492a","line":1952,"range":{"start_line":1951,"start_character":40,"end_line":1952,"end_character":58},"updated":"2019-02-17 14:39:46.000000000","message":"(float(results[\u0027maxUsedSpace\u0027]) / units.Gi) ??","commit_id":"1fb7387e7e1a38363e7e31ebbb6b8df3f9119760"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"c2a091c5dd198061337346d0361447419aaf02dd","unresolved":false,"context_lines":[{"line_number":1948,"context_line":"        if self.configuration.sf_provisioning_calc \u003d\u003d \u0027usedSpace\u0027:"},{"line_number":1949,"context_line":"            free_capacity \u003d ("},{"line_number":1950,"context_line":"                results[\u0027maxUsedSpace\u0027] - results[\u0027usedSpace\u0027])"},{"line_number":1951,"context_line":"            data[\u0027total_capacity_gb\u0027] \u003d ("},{"line_number":1952,"context_line":"                float(results[\u0027maxUsedSpace\u0027] / units.Gi))"},{"line_number":1953,"context_line":"            data[\u0027thin_provisioning_support\u0027] \u003d True"},{"line_number":1954,"context_line":"            data[\u0027provisioned_capacity_gb\u0027] \u003d ("},{"line_number":1955,"context_line":"                self._get_provisioned_volumes() / units.Gi)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_3dea4473","line":1952,"range":{"start_line":1951,"start_character":40,"end_line":1952,"end_character":58},"in_reply_to":"9fdfeff1_e86e492a","updated":"2019-02-18 13:30:51.000000000","message":"Yes, it makes more sense. But I think this is not even necessary as if results[\u0027maxUsedSpace\u0027] wasn\u0027t float we would get an exception here.","commit_id":"1fb7387e7e1a38363e7e31ebbb6b8df3f9119760"}],"releasenotes/notes/fix-solidfire-provisioning-report-880141e64c1ea52f.yaml":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"f4bc6674bd91c98d31c5fcdb07bb84419b6681b4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fix SolidFire free_capacity_gb reporting and also reports"},{"line_number":5,"context_line":"    thin_provisioning_support\u003dTrue. This allow the use of Cinder scheduler\u0027s"},{"line_number":6,"context_line":"    parameters for thin provisioning in the SolidFire plataform."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fdfeff1_492a3c2c","line":5,"range":{"start_line":5,"start_character":41,"end_line":5,"end_character":46},"updated":"2019-01-29 21:11:46.000000000","message":"allows","commit_id":"9fcf55b82c864773ee3baaff9e1f2de416ddeac0"}]}