)]}'
{"cinder/tests/unit/volume/drivers/huawei/test_huawei_drivers.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"493a0c4c042a06e09ab150920e2851633578b35a","unresolved":false,"context_lines":[{"line_number":3349,"context_line":"    @mock.patch.object(rest_client.RestClient, \u0027find_available_qos\u0027,"},{"line_number":3350,"context_line":"                       return_value\u003d(None, []))"},{"line_number":3351,"context_line":"    @mock.patch.object(rest_client.RestClient, \u0027activate_deactivate_qos\u0027)"},{"line_number":3352,"context_line":"    def test_create_smartqos_on_v3r3_active_failed(self,"},{"line_number":3353,"context_line":"                                                   pool_data,"},{"line_number":3354,"context_line":"                                                   mock_activate_qos,"},{"line_number":3355,"context_line":"                                                   mock_find_available_qos,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_79c9c923","line":3352,"updated":"2019-02-02 08:20:53.000000000","message":"The retry interval or wait time needs to be mocked for this as right now it is causing the unit test to hang for 60 seconds.","commit_id":"777bb46af4ab743d93309706ca5c24e5b3eeea2d"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"317eee7f03249d285a0112467c2812c170b2563f","unresolved":false,"context_lines":[{"line_number":3349,"context_line":"    @mock.patch.object(rest_client.RestClient, \u0027find_available_qos\u0027,"},{"line_number":3350,"context_line":"                       return_value\u003d(None, []))"},{"line_number":3351,"context_line":"    @mock.patch.object(rest_client.RestClient, \u0027activate_deactivate_qos\u0027)"},{"line_number":3352,"context_line":"    def test_create_smartqos_on_v3r3_active_failed(self,"},{"line_number":3353,"context_line":"                                                   pool_data,"},{"line_number":3354,"context_line":"                                                   mock_activate_qos,"},{"line_number":3355,"context_line":"                                                   mock_find_available_qos,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_9a67bb4d","line":3352,"in_reply_to":"9fdfeff1_79c9c923","updated":"2019-02-03 03:37:43.000000000","message":"Done","commit_id":"777bb46af4ab743d93309706ca5c24e5b3eeea2d"}],"cinder/volume/drivers/huawei/huawei_utils.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"493a0c4c042a06e09ab150920e2851633578b35a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import retrying"},{"line_number":19,"context_line":"import six"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":"from oslo_utils import strutils"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from cinder import context"},{"line_number":25,"context_line":"from cinder import exception"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_395a6182","line":22,"range":{"start_line":21,"start_character":0,"end_line":22,"end_character":31},"updated":"2019-02-02 08:20:53.000000000","message":"This section should not have been moved. These and retrying and six are all third party imports that should be grouped together.","commit_id":"777bb46af4ab743d93309706ca5c24e5b3eeea2d"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"317eee7f03249d285a0112467c2812c170b2563f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import retrying"},{"line_number":19,"context_line":"import six"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":"from oslo_utils import strutils"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from cinder import context"},{"line_number":25,"context_line":"from cinder import exception"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_fa57e756","line":22,"range":{"start_line":21,"start_character":0,"end_line":22,"end_character":31},"in_reply_to":"9fdfeff1_395a6182","updated":"2019-02-03 03:37:43.000000000","message":"Done","commit_id":"777bb46af4ab743d93309706ca5c24e5b3eeea2d"}],"cinder/volume/drivers/huawei/smartx.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"493a0c4c042a06e09ab150920e2851633578b35a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        if lun_id in lun_list:"},{"line_number":63,"context_line":"            lun_list.remove(lun_id)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        if len(lun_list) \u003c\u003d 0:"},{"line_number":66,"context_line":"            if qos_info[\u0027RUNNINGSTATUS\u0027] !\u003d constants.QOS_INACTIVATED:"},{"line_number":67,"context_line":"                self.client.activate_deactivate_qos(qos_id, False)"},{"line_number":68,"context_line":"            self.client.delete_qos(qos_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_99ccad35","line":65,"range":{"start_line":65,"start_character":25,"end_line":65,"end_character":27},"updated":"2019-02-02 08:20:53.000000000","message":"len() will never be \u003c 0.","commit_id":"777bb46af4ab743d93309706ca5c24e5b3eeea2d"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"317eee7f03249d285a0112467c2812c170b2563f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        if lun_id in lun_list:"},{"line_number":63,"context_line":"            lun_list.remove(lun_id)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        if len(lun_list) \u003c\u003d 0:"},{"line_number":66,"context_line":"            if qos_info[\u0027RUNNINGSTATUS\u0027] !\u003d constants.QOS_INACTIVATED:"},{"line_number":67,"context_line":"                self.client.activate_deactivate_qos(qos_id, False)"},{"line_number":68,"context_line":"            self.client.delete_qos(qos_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_da48e3b3","line":65,"range":{"start_line":65,"start_character":25,"end_line":65,"end_character":27},"in_reply_to":"9fdfeff1_99ccad35","updated":"2019-02-03 03:37:43.000000000","message":"Done","commit_id":"777bb46af4ab743d93309706ca5c24e5b3eeea2d"}]}