)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"870824fa93b8eb97e7a80ffc53df375c58c21dd6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michal Arbet \u003cmichal.arbet@ultimum.io\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-02-06 16:47:53 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix python3 compatibility"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In python3 self._get_fsid() is represented as binary."},{"line_number":10,"context_line":"This patch is fixing this."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_fd8009c2","line":7,"updated":"2019-02-20 12:40:31.000000000","message":"Please update this to include \" of rbd get_fsid\" to be a little more specific.","commit_id":"0cf151c2488695fa40a0b6ee901643aef3a7f81c"}],"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f96f207b522c41fa4cf4878a978eaf82c4c29217","unresolved":false,"context_lines":[{"line_number":1381,"context_line":""},{"line_number":1382,"context_line":"    def _get_fsid(self):"},{"line_number":1383,"context_line":"        with RADOSClient(self) as client:"},{"line_number":1384,"context_line":"            return client.cluster.get_fsid()"},{"line_number":1385,"context_line":""},{"line_number":1386,"context_line":"    def _is_cloneable(self, image_location, image_meta):"},{"line_number":1387,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_bfb307e9","line":1384,"range":{"start_line":1384,"start_character":12,"end_line":1384,"end_character":44},"updated":"2019-02-11 22:17:04.000000000","message":"Is there a reason not to fix it here? It doesn\u0027t seem like a good idea that consumers of the method should need to know that the result would need to be decoded to be used in normal circumstances, especially when doing something like comparing _get_fsid with the value of fsid.","commit_id":"0cf151c2488695fa40a0b6ee901643aef3a7f81c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2d4be88d6aa4cafec20ddaba24583db15cb0f368","unresolved":false,"context_lines":[{"line_number":1381,"context_line":""},{"line_number":1382,"context_line":"    def _get_fsid(self):"},{"line_number":1383,"context_line":"        with RADOSClient(self) as client:"},{"line_number":1384,"context_line":"            return client.cluster.get_fsid()"},{"line_number":1385,"context_line":""},{"line_number":1386,"context_line":"    def _is_cloneable(self, image_location, image_meta):"},{"line_number":1387,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_8f425a0e","line":1384,"range":{"start_line":1384,"start_character":12,"end_line":1384,"end_character":44},"in_reply_to":"9fdfeff1_bfb307e9","updated":"2019-02-14 06:09:40.000000000","message":"+1\nthe _get_fsid is used at multiple places (like at L#1749), we can\u0027t decode it everytime we want the fsid.\nIMO this needs to be fixed here.","commit_id":"0cf151c2488695fa40a0b6ee901643aef3a7f81c"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5a154b31d3e0c3e0f34b1a1a446ab95c7328806e","unresolved":false,"context_lines":[{"line_number":1381,"context_line":""},{"line_number":1382,"context_line":"    def _get_fsid(self):"},{"line_number":1383,"context_line":"        with RADOSClient(self) as client:"},{"line_number":1384,"context_line":"            return client.cluster.get_fsid()"},{"line_number":1385,"context_line":""},{"line_number":1386,"context_line":"    def _is_cloneable(self, image_location, image_meta):"},{"line_number":1387,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_2b059411","line":1384,"range":{"start_line":1384,"start_character":12,"end_line":1384,"end_character":44},"in_reply_to":"9fdfeff1_bfb307e9","updated":"2019-02-22 12:20:23.000000000","message":"Yeah, you are right. It should work , but i want to be sure that it will be OK , so I have to build my DEV with ceph and try it. When it will be done, i will return back with new patch or comment :)","commit_id":"0cf151c2488695fa40a0b6ee901643aef3a7f81c"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b5b4b5e1026988116593edd4bba62a5bd40438f2","unresolved":false,"context_lines":[{"line_number":1383,"context_line":"        with RADOSClient(self) as client:"},{"line_number":1384,"context_line":"            # Librados\u0027s get_fsid is represented as binary"},{"line_number":1385,"context_line":"            # in py3 instead of str as it is in py2."},{"line_number":1386,"context_line":"            # This is causing problems with ceph."},{"line_number":1387,"context_line":"            # Decode binary to str fixes these issues."},{"line_number":1388,"context_line":"            # Fix with encodeutils.safe_decode CAN BE REMOVED"},{"line_number":1389,"context_line":"            # after librados\u0027s fix will be in stable for some time."}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_e61cfa14","line":1386,"updated":"2019-02-20 14:46:44.000000000","message":"It doesn\u0027t cause problems with ceph, it causes problems for the cinder rbd driver because we rely on this value being a string...","commit_id":"353ae793932b13f25260928fcbcf16fed63d5958"}]}