)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"293e1e979b5908be25647963001a14f9a93352df","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Database migration tests (specifically test_walk_versions"},{"line_number":10,"context_line":"and test_mysql_innodb) are failing due to multiple reasons"},{"line_number":11,"context_line":"from oslo.db side mentioned in the code comments."},{"line_number":12,"context_line":"Setting a timeout appears to be a general solution for all the"},{"line_number":13,"context_line":"cases."},{"line_number":14,"context_line":"This solution is adopted from manila [1] and also implemented"},{"line_number":15,"context_line":"in neutron [2] for the same and hopefully they\u0027re not facing the"},{"line_number":16,"context_line":"issue currently."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_6491cb9a","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":6},"updated":"2019-02-21 14:38:07.000000000","message":"This should just explain that setting a longer timeout will allow the test to complete on slow nodes.  The commit message doesn\u0027t say anywhere that the main point of this change is to increase the timeout.","commit_id":"b70ebee13c09386ef3d9aa562c80add980af08b6"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c8eee5614fa9f6ff7089a8fd247aaf5db9cfeba8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Database migration tests (specifically test_walk_versions"},{"line_number":10,"context_line":"and test_mysql_innodb) are failing due to multiple reasons"},{"line_number":11,"context_line":"from oslo.db side mentioned in the code comments."},{"line_number":12,"context_line":"Setting a timeout appears to be a general solution for all the"},{"line_number":13,"context_line":"cases."},{"line_number":14,"context_line":"This solution is adopted from manila [1] and also implemented"},{"line_number":15,"context_line":"in neutron [2] for the same and hopefully they\u0027re not facing the"},{"line_number":16,"context_line":"issue currently."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_4472877e","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":6},"in_reply_to":"9fdfeff1_6491cb9a","updated":"2019-02-21 14:43:14.000000000","message":"Done","commit_id":"b70ebee13c09386ef3d9aa562c80add980af08b6"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6ac6cafb5b4392d8882f076bf857a794e4990025","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rajat Dhasmana \u003crajatdhasmana@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-02-21 14:42:25 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding timeout for database migration tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Database migration tests (specifically test_walk_versions"},{"line_number":10,"context_line":"and test_mysql_innodb) are failing due to multiple reasons"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_34ef36b2","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"updated":"2019-02-25 15:34:20.000000000","message":"Extend*","commit_id":"744915a4f1d6efbf55cbc9e08e1b0b20089ecc57"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b48b4554583e0602cbe3f1227a1823b475981d7b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rajat Dhasmana \u003crajatdhasmana@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-02-21 14:42:25 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding timeout for database migration tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Database migration tests (specifically test_walk_versions"},{"line_number":10,"context_line":"and test_mysql_innodb) are failing due to multiple reasons"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_1430f255","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"in_reply_to":"9fdfeff1_34ef36b2","updated":"2019-02-25 15:35:10.000000000","message":"Will just fix this since this is in merge conflict anyway.","commit_id":"744915a4f1d6efbf55cbc9e08e1b0b20089ecc57"}],"cinder/tests/unit/db/test_migrations.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"33162527b984bb9e92d13aa5654b3a909172cf0d","unresolved":false,"context_lines":[{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    # NOTE: this test becomes slower with each addition of new DB migration."},{"line_number":433,"context_line":"    # \u0027pymysql\u0027 works much slower on slow nodes than \u0027psycopg2\u0027. And such"},{"line_number":434,"context_line":"    # timeout mostly required for testing of \u0027mysql\u0027 backend."},{"line_number":435,"context_line":"    @test_utils.set_timeout(300)"},{"line_number":436,"context_line":"    def test_walk_versions(self):"},{"line_number":437,"context_line":"        self.walk_versions(False, False)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_496392b2","line":434,"updated":"2019-02-20 19:14:25.000000000","message":"The last sentence of this comment doesn\u0027t make a lot of sense by itself -- why is the timeout required?\n\nThis test runs slowly, so we want to make it fail more often rather than take a while to finish?  Why?","commit_id":"b70ebee13c09386ef3d9aa562c80add980af08b6"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3c92473c68c602561e3d4678c15055c127d30a2c","unresolved":false,"context_lines":[{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    # NOTE: this test becomes slower with each addition of new DB migration."},{"line_number":433,"context_line":"    # \u0027pymysql\u0027 works much slower on slow nodes than \u0027psycopg2\u0027. And such"},{"line_number":434,"context_line":"    # timeout mostly required for testing of \u0027mysql\u0027 backend."},{"line_number":435,"context_line":"    @test_utils.set_timeout(300)"},{"line_number":436,"context_line":"    def test_walk_versions(self):"},{"line_number":437,"context_line":"        self.walk_versions(False, False)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_e925a65d","line":434,"in_reply_to":"9fdfeff1_496392b2","updated":"2019-02-20 19:15:12.000000000","message":"Is it that having a 300s timeout overrides some shorter default timeout?","commit_id":"b70ebee13c09386ef3d9aa562c80add980af08b6"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7ad7d5630a86540e1d9d169840952507d12953a8","unresolved":false,"context_lines":[{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    # NOTE: this test becomes slower with each addition of new DB migration."},{"line_number":433,"context_line":"    # \u0027pymysql\u0027 works much slower on slow nodes than \u0027psycopg2\u0027. And such"},{"line_number":434,"context_line":"    # timeout mostly required for testing of \u0027mysql\u0027 backend."},{"line_number":435,"context_line":"    @test_utils.set_timeout(300)"},{"line_number":436,"context_line":"    def test_walk_versions(self):"},{"line_number":437,"context_line":"        self.walk_versions(False, False)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_dcb3be09","line":434,"in_reply_to":"9fdfeff1_496392b2","updated":"2019-02-21 09:13:01.000000000","message":"Since we have a multiple db backends available (postgres, mysql), they take different time for testing migrations[1].\nNormally they execute within the estimated time frame[1] but sometimes they cause random gate failures[2][3].\n[1] http://logs.openstack.org/81/620881/9/check/openstack-tox-py27/ff840f6/job-output.txt.gz#_2019-02-20_14_25_21_174393\n[2] http://logs.openstack.org/81/602181/13/check/openstack-tox-py27/38cb4e3/job-output.txt.gz#_2019-02-01_02_56_44_910963\n[3] http://logs.openstack.org/81/602181/13/check/openstack-tox-py27/38cb4e3/job-output.txt.gz#_2019-02-01_02_56_54_938114","commit_id":"b70ebee13c09386ef3d9aa562c80add980af08b6"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7ad7d5630a86540e1d9d169840952507d12953a8","unresolved":false,"context_lines":[{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    # NOTE: this test becomes slower with each addition of new DB migration."},{"line_number":433,"context_line":"    # \u0027pymysql\u0027 works much slower on slow nodes than \u0027psycopg2\u0027. And such"},{"line_number":434,"context_line":"    # timeout mostly required for testing of \u0027mysql\u0027 backend."},{"line_number":435,"context_line":"    @test_utils.set_timeout(300)"},{"line_number":436,"context_line":"    def test_walk_versions(self):"},{"line_number":437,"context_line":"        self.walk_versions(False, False)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_16111a54","line":434,"in_reply_to":"9fdfeff1_e925a65d","updated":"2019-02-21 09:13:01.000000000","message":"That\u0027s my understanding, will confirm with manila team for more details as they\u0027re the one that came up with this solution.","commit_id":"b70ebee13c09386ef3d9aa562c80add980af08b6"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"b94467cb0350d696837f7b123640a8c35aafa667","unresolved":false,"context_lines":[{"line_number":432,"context_line":"    # NOTE: this test becomes slower with each addition of new DB migration."},{"line_number":433,"context_line":"    # \u0027pymysql\u0027 works much slower on slow nodes than \u0027psycopg2\u0027. And such"},{"line_number":434,"context_line":"    # timeout mostly required for testing of \u0027mysql\u0027 backend."},{"line_number":435,"context_line":"    @test_utils.set_timeout(300)"},{"line_number":436,"context_line":"    def test_walk_versions(self):"},{"line_number":437,"context_line":"        self.walk_versions(False, False)"},{"line_number":438,"context_line":"        self.assert_each_foreign_key_is_part_of_an_index()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_8548922e","line":435,"updated":"2019-02-20 00:41:27.000000000","message":"Once the test can\u0027t finish in 300s, the test will fail. Right?","commit_id":"b70ebee13c09386ef3d9aa562c80add980af08b6"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b904edda9ad56bb42820293398dc5f93bb1532e9","unresolved":false,"context_lines":[{"line_number":432,"context_line":"    # NOTE: this test becomes slower with each addition of new DB migration."},{"line_number":433,"context_line":"    # \u0027pymysql\u0027 works much slower on slow nodes than \u0027psycopg2\u0027. And such"},{"line_number":434,"context_line":"    # timeout mostly required for testing of \u0027mysql\u0027 backend."},{"line_number":435,"context_line":"    @test_utils.set_timeout(300)"},{"line_number":436,"context_line":"    def test_walk_versions(self):"},{"line_number":437,"context_line":"        self.walk_versions(False, False)"},{"line_number":438,"context_line":"        self.assert_each_foreign_key_is_part_of_an_index()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_77c0bf7d","line":435,"in_reply_to":"9fdfeff1_8548922e","updated":"2019-02-20 04:51:05.000000000","message":"Yes. The timeout is a safety mechanism to ensure that the processing capability of different database backends doesn\u0027t affect the expected functionality resulting in these tests failure.\nSince these failures occur on the oslo.db side, we can do little regarding this from cinder side.","commit_id":"b70ebee13c09386ef3d9aa562c80add980af08b6"}]}