)]}'
{"cinder/volume/driver.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"de7905500e216ab375c897d886e3f5f3f06645c5","unresolved":false,"context_lines":[{"line_number":545,"context_line":"    def check_for_setup_error(self):"},{"line_number":546,"context_line":"        return"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    def get_driver_options():"},{"line_number":549,"context_line":"        return volume_opts"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_a33720fe","line":548,"updated":"2019-02-28 11:37:27.000000000","message":"nit: It would be nice to have a docstring explaining the purpose of this call and what we expect drivers to return here.","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7f52d760439c68a277d95a77322df8e1b46dc2d5","unresolved":false,"context_lines":[{"line_number":545,"context_line":"    def check_for_setup_error(self):"},{"line_number":546,"context_line":"        return"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    def get_driver_options():"},{"line_number":549,"context_line":"        return volume_opts"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_dff45557","line":548,"in_reply_to":"9fdfeff1_a33720fe","updated":"2019-03-01 13:32:55.000000000","message":"Done","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"}],"cinder/volume/drivers/hedvig/hedvig_cinder.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"de7905500e216ab375c897d886e3f5f3f06645c5","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @staticmethod"},{"line_number":65,"context_line":"    def get_driver_options():"},{"line_number":66,"context_line":"        return []"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def check_for_setup_error(self):"},{"line_number":69,"context_line":"        self.hrs.connect()"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_3ed263fe","line":66,"updated":"2019-02-28 11:37:27.000000000","message":"-1: This shouldn\u0027t be correct, right? It should have at least some of its parents\u0027 options.","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7f52d760439c68a277d95a77322df8e1b46dc2d5","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @staticmethod"},{"line_number":65,"context_line":"    def get_driver_options():"},{"line_number":66,"context_line":"        return []"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def check_for_setup_error(self):"},{"line_number":69,"context_line":"        self.hrs.connect()"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_bf8e31ce","line":66,"in_reply_to":"9fdfeff1_3ed263fe","updated":"2019-03-01 13:32:55.000000000","message":"for now I was only putting options specific to this driver in here.","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"}],"cinder/volume/drivers/ibm/gpfs.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"de7905500e216ab375c897d886e3f5f3f06645c5","unresolved":false,"context_lines":[{"line_number":154,"context_line":"       1.1.0 - Add volume retype, refactor volume migration"},{"line_number":155,"context_line":"       1.2.0 - Add consistency group support"},{"line_number":156,"context_line":"       1.3.0 - Add NFS based GPFS storage backend support"},{"line_number":157,"context_line":"       1.3.1 - Add GPFS native encryption (encryption of data at rest) support"},{"line_number":158,"context_line":"    \"\"\""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    VERSION \u003d \"1.3.1\""}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_3e4023a2","line":157,"updated":"2019-02-28 11:37:27.000000000","message":"Thanks for fixing this.","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"de7905500e216ab375c897d886e3f5f3f06645c5","unresolved":false,"context_lines":[{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"    @staticmethod"},{"line_number":1419,"context_line":"    def get_driver_options():"},{"line_number":1420,"context_line":"        return list(set(gpfs_opts + gpfs_remote_ssh_opts))"},{"line_number":1421,"context_line":""},{"line_number":1422,"context_line":"    def _gpfs_remote_execute(self, *cmd, **kwargs):"},{"line_number":1423,"context_line":"        check_exit_code \u003d kwargs.pop(\u0027check_exit_code\u0027, None)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_de1477a2","line":1420,"range":{"start_line":1420,"start_character":20,"end_line":1420,"end_character":23},"updated":"2019-02-28 11:37:27.000000000","message":"-1: This won\u0027t remove duplicates","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2b2c8bc5287a9130631acc047e141df09b210c84","unresolved":false,"context_lines":[{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"    @staticmethod"},{"line_number":1419,"context_line":"    def get_driver_options():"},{"line_number":1420,"context_line":"        return list(set(gpfs_opts + gpfs_remote_ssh_opts))"},{"line_number":1421,"context_line":""},{"line_number":1422,"context_line":"    def _gpfs_remote_execute(self, *cmd, **kwargs):"},{"line_number":1423,"context_line":"        check_exit_code \u003d kwargs.pop(\u0027check_exit_code\u0027, None)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_3ac80fa6","line":1420,"range":{"start_line":1420,"start_character":20,"end_line":1420,"end_character":23},"in_reply_to":"9fdfeff1_9f348dfc","updated":"2019-03-01 13:50:21.000000000","message":"That is correct, but the check of duplicates is done based on the hash of an object, and Oslo config options return different hash values for the same option in gpfs_opts and gpfs_remote_ssh_opts even if we copy and paste one option from one to the other (I have checked).  So doing `list(set(` here doesn\u0027t give us anything.\n\nI also believe we don\u0027t have duplicates, so I\u0027m OK with just returning `gpfs_opts + gpfs_remote_ssh_opts` here and the same for all the other cases.","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7f52d760439c68a277d95a77322df8e1b46dc2d5","unresolved":false,"context_lines":[{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"    @staticmethod"},{"line_number":1419,"context_line":"    def get_driver_options():"},{"line_number":1420,"context_line":"        return list(set(gpfs_opts + gpfs_remote_ssh_opts))"},{"line_number":1421,"context_line":""},{"line_number":1422,"context_line":"    def _gpfs_remote_execute(self, *cmd, **kwargs):"},{"line_number":1423,"context_line":"        check_exit_code \u003d kwargs.pop(\u0027check_exit_code\u0027, None)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_9f348dfc","line":1420,"range":{"start_line":1420,"start_character":20,"end_line":1420,"end_character":23},"in_reply_to":"9fdfeff1_de1477a2","updated":"2019-03-01 13:32:55.000000000","message":"a set by default doesn\u0027t have dupes.  Also, afaik we don\u0027t have duplicate options","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2b2c8bc5287a9130631acc047e141df09b210c84","unresolved":false,"context_lines":[{"line_number":1418,"context_line":""},{"line_number":1419,"context_line":"    @staticmethod"},{"line_number":1420,"context_line":"    def get_driver_options():"},{"line_number":1421,"context_line":"        return list(set(gpfs_opts + gpfs_remote_ssh_opts))"},{"line_number":1422,"context_line":""},{"line_number":1423,"context_line":"    def _gpfs_remote_execute(self, *cmd, **kwargs):"},{"line_number":1424,"context_line":"        check_exit_code \u003d kwargs.pop(\u0027check_exit_code\u0027, None)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_ba739f4d","line":1421,"range":{"start_line":1421,"start_character":15,"end_line":1421,"end_character":24},"updated":"2019-03-01 13:50:21.000000000","message":"-1: As mentioned on previous patch, this doesn\u0027t actually achieve what we want (remove possible duplicates), and it is the same as doing `gpfs_opts + gpfs_remote_ssh_opts`.","commit_id":"7203e834cea04a4f51e8fd3f234a4936578b9d66"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_fc.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"de7905500e216ab375c897d886e3f5f3f06645c5","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @staticmethod"},{"line_number":113,"context_line":"    def get_driver_options():"},{"line_number":114,"context_line":"        return list(set("},{"line_number":115,"context_line":"            storwize_common.storwize_svc_opts +"},{"line_number":116,"context_line":"            storwize_svc_fc_opts"},{"line_number":117,"context_line":"        ))"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_be0df38f","line":114,"range":{"start_line":114,"start_character":20,"end_line":114,"end_character":23},"updated":"2019-02-28 11:37:27.000000000","message":"-1: This won\u0027t remove duplicates","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"711e790c4c0ebfacdc3b22d503429e15cb28dc98","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @staticmethod"},{"line_number":113,"context_line":"    def get_driver_options():"},{"line_number":114,"context_line":"        return list(set("},{"line_number":115,"context_line":"            storwize_common.storwize_svc_opts +"},{"line_number":116,"context_line":"            storwize_svc_fc_opts"},{"line_number":117,"context_line":"        ))"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_64959de3","line":114,"range":{"start_line":114,"start_character":20,"end_line":114,"end_character":23},"in_reply_to":"9fdfeff1_be0df38f","updated":"2019-03-01 17:05:56.000000000","message":"Done","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_iscsi.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"de7905500e216ab375c897d886e3f5f3f06645c5","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @staticmethod"},{"line_number":113,"context_line":"    def get_driver_options():"},{"line_number":114,"context_line":"        return list(set("},{"line_number":115,"context_line":"            storwize_common.storwize_svc_opts +"},{"line_number":116,"context_line":"            storwize_svc_iscsi_opts"},{"line_number":117,"context_line":"        ))"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_1e1e7fba","line":114,"range":{"start_line":114,"start_character":20,"end_line":114,"end_character":23},"updated":"2019-02-28 11:37:27.000000000","message":"-1: This won\u0027t remove duplicates.","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"711e790c4c0ebfacdc3b22d503429e15cb28dc98","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @staticmethod"},{"line_number":113,"context_line":"    def get_driver_options():"},{"line_number":114,"context_line":"        return list(set("},{"line_number":115,"context_line":"            storwize_common.storwize_svc_opts +"},{"line_number":116,"context_line":"            storwize_svc_iscsi_opts"},{"line_number":117,"context_line":"        ))"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_249b1517","line":114,"range":{"start_line":114,"start_character":20,"end_line":114,"end_character":23},"in_reply_to":"9fdfeff1_1e1e7fba","updated":"2019-03-01 17:05:56.000000000","message":"Done","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"}],"cinder/volume/drivers/lenovo/lenovo_iscsi.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"de7905500e216ab375c897d886e3f5f3f06645c5","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @staticmethod"},{"line_number":49,"context_line":"    def get_driver_options():"},{"line_number":50,"context_line":"        return list(set(lenovo_common.common_opts +"},{"line_number":51,"context_line":"                        lenovo_common.iscsi_opts))"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _init_common(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_fe7cdbeb","line":50,"range":{"start_line":50,"start_character":20,"end_line":50,"end_character":23},"updated":"2019-02-28 11:37:27.000000000","message":"-1: This won\u0027t remove duplicates","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"711e790c4c0ebfacdc3b22d503429e15cb28dc98","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @staticmethod"},{"line_number":49,"context_line":"    def get_driver_options():"},{"line_number":50,"context_line":"        return list(set(lenovo_common.common_opts +"},{"line_number":51,"context_line":"                        lenovo_common.iscsi_opts))"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _init_common(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_e4b18d90","line":50,"range":{"start_line":50,"start_character":20,"end_line":50,"end_character":23},"in_reply_to":"9fdfeff1_fe7cdbeb","updated":"2019-03-01 17:05:56.000000000","message":"Done","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"}],"cinder/volume/drivers/lvm.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"de7905500e216ab375c897d886e3f5f3f06645c5","unresolved":false,"context_lines":[{"line_number":356,"context_line":"            # Enable sparse copy since lvm_type is \u0027thin\u0027"},{"line_number":357,"context_line":"            self._sparse_copy_volume \u003d True"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    @utils.trace"},{"line_number":360,"context_line":"    def create_volume(self, volume):"},{"line_number":361,"context_line":"        \"\"\"Creates a logical volume.\"\"\""},{"line_number":362,"context_line":"        mirror_count \u003d 0"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_5e56475e","line":359,"updated":"2019-02-28 11:37:27.000000000","message":"-1: I don\u0027t think we should be adding these here...","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"711e790c4c0ebfacdc3b22d503429e15cb28dc98","unresolved":false,"context_lines":[{"line_number":356,"context_line":"            # Enable sparse copy since lvm_type is \u0027thin\u0027"},{"line_number":357,"context_line":"            self._sparse_copy_volume \u003d True"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    @utils.trace"},{"line_number":360,"context_line":"    def create_volume(self, volume):"},{"line_number":361,"context_line":"        \"\"\"Creates a logical volume.\"\"\""},{"line_number":362,"context_line":"        mirror_count \u003d 0"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_84668128","line":359,"in_reply_to":"9fdfeff1_5e56475e","updated":"2019-03-01 17:05:56.000000000","message":"Done","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2b2c8bc5287a9130631acc047e141df09b210c84","unresolved":false,"context_lines":[{"line_number":356,"context_line":"            # Enable sparse copy since lvm_type is \u0027thin\u0027"},{"line_number":357,"context_line":"            self._sparse_copy_volume \u003d True"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    @utils.trace"},{"line_number":360,"context_line":"    def create_volume(self, volume):"},{"line_number":361,"context_line":"        \"\"\"Creates a logical volume.\"\"\""},{"line_number":362,"context_line":"        mirror_count \u003d 0"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_3aa7afbe","line":359,"updated":"2019-03-01 13:50:21.000000000","message":"-1: I still believe this is not appropriate to be added in this patch.","commit_id":"7203e834cea04a4f51e8fd3f234a4936578b9d66"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"711e790c4c0ebfacdc3b22d503429e15cb28dc98","unresolved":false,"context_lines":[{"line_number":356,"context_line":"            # Enable sparse copy since lvm_type is \u0027thin\u0027"},{"line_number":357,"context_line":"            self._sparse_copy_volume \u003d True"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    @utils.trace"},{"line_number":360,"context_line":"    def create_volume(self, volume):"},{"line_number":361,"context_line":"        \"\"\"Creates a logical volume.\"\"\""},{"line_number":362,"context_line":"        mirror_count \u003d 0"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fdfeff1_847c41eb","line":359,"in_reply_to":"9fdfeff1_3aa7afbe","updated":"2019-03-01 17:05:56.000000000","message":"Done","commit_id":"7203e834cea04a4f51e8fd3f234a4936578b9d66"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b2799aeb5e2732707d17958b1f8ae3aa50392c55","unresolved":false,"context_lines":[{"line_number":435,"context_line":"                             execute\u003dself._execute,"},{"line_number":436,"context_line":"                             sparse\u003dself._sparse_copy_volume)"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    @utils.trace"},{"line_number":439,"context_line":"    def delete_volume(self, volume):"},{"line_number":440,"context_line":"        \"\"\"Deletes a logical volume.\"\"\""},{"line_number":441,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5fc1f717_46595458","line":438,"updated":"2019-03-07 02:19:58.000000000","message":"I think these were supposed to be removed?","commit_id":"dc09991db56245e86d7574a2d2f4e7cf26a2f726"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b73d1cf3455c36fbe8cf5b4f00fe399107422326","unresolved":false,"context_lines":[{"line_number":435,"context_line":"                             execute\u003dself._execute,"},{"line_number":436,"context_line":"                             sparse\u003dself._sparse_copy_volume)"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    @utils.trace"},{"line_number":439,"context_line":"    def delete_volume(self, volume):"},{"line_number":440,"context_line":"        \"\"\"Deletes a logical volume.\"\"\""},{"line_number":441,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5fc1f717_488f1523","line":438,"in_reply_to":"5fc1f717_46595458","updated":"2019-03-07 14:15:18.000000000","message":"w i t f.  I have removed this line twice, commited and pushed up.  why is it still here?","commit_id":"dc09991db56245e86d7574a2d2f4e7cf26a2f726"}],"cinder/volume/drivers/netapp/dataontap/fc_cmode.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"de7905500e216ab375c897d886e3f5f3f06645c5","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @staticmethod"},{"line_number":42,"context_line":"    def get_driver_options():"},{"line_number":43,"context_line":"        return []"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def do_setup(self, context):"},{"line_number":46,"context_line":"        self.library.do_setup(context)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_1e4c3fc6","line":43,"updated":"2019-02-28 11:37:27.000000000","message":"-1: This should not be the right thing to return here, right?","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7f52d760439c68a277d95a77322df8e1b46dc2d5","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @staticmethod"},{"line_number":42,"context_line":"    def get_driver_options():"},{"line_number":43,"context_line":"        return []"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def do_setup(self, context):"},{"line_number":46,"context_line":"        self.library.do_setup(context)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_ff559950","line":43,"in_reply_to":"9fdfeff1_1e4c3fc6","updated":"2019-03-01 13:32:55.000000000","message":"found the options on this one.","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"}],"cinder/volume/drivers/netapp/dataontap/iscsi_cmode.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"de7905500e216ab375c897d886e3f5f3f06645c5","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @staticmethod"},{"line_number":41,"context_line":"    def get_driver_options():"},{"line_number":42,"context_line":"        return []"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def do_setup(self, context):"},{"line_number":45,"context_line":"        self.library.do_setup(context)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_3e47c3a5","line":42,"updated":"2019-02-28 11:37:27.000000000","message":"-1: This should not be the right thing to return here, right?","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7f52d760439c68a277d95a77322df8e1b46dc2d5","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @staticmethod"},{"line_number":41,"context_line":"    def get_driver_options():"},{"line_number":42,"context_line":"        return []"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def do_setup(self, context):"},{"line_number":45,"context_line":"        self.library.do_setup(context)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_5fd065c8","line":42,"in_reply_to":"9fdfeff1_3e47c3a5","updated":"2019-03-01 13:32:55.000000000","message":"Done","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"}],"cinder/volume/drivers/nexenta/iscsi.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"de7905500e216ab375c897d886e3f5f3f06645c5","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @staticmethod"},{"line_number":95,"context_line":"    def get_driver_options():"},{"line_number":96,"context_line":"        return list(set("},{"line_number":97,"context_line":"            options.NEXENTA_CONNECTION_OPTS +"},{"line_number":98,"context_line":"            options.NEXENTA_ISCSI_OPTS +"},{"line_number":99,"context_line":"            options.NEXENTA_DATASET_OPTS +"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_feca9b17","line":96,"range":{"start_line":96,"start_character":20,"end_line":96,"end_character":23},"updated":"2019-02-28 11:37:27.000000000","message":"-1: This will not remove duplicates.","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"711e790c4c0ebfacdc3b22d503429e15cb28dc98","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @staticmethod"},{"line_number":95,"context_line":"    def get_driver_options():"},{"line_number":96,"context_line":"        return list(set("},{"line_number":97,"context_line":"            options.NEXENTA_CONNECTION_OPTS +"},{"line_number":98,"context_line":"            options.NEXENTA_ISCSI_OPTS +"},{"line_number":99,"context_line":"            options.NEXENTA_DATASET_OPTS +"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_a47ce5b5","line":96,"range":{"start_line":96,"start_character":20,"end_line":96,"end_character":23},"in_reply_to":"9fdfeff1_feca9b17","updated":"2019-03-01 17:05:56.000000000","message":"Done","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"}],"cinder/volume/drivers/nexenta/nexentaedge/iscsi.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"de7905500e216ab375c897d886e3f5f3f06645c5","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @staticmethod"},{"line_number":105,"context_line":"    def get_driver_options():"},{"line_number":106,"context_line":"        return list(set("},{"line_number":107,"context_line":"            options.NEXENTA_CONNECTION_OPTS +"},{"line_number":108,"context_line":"            options.NEXENTA_ISCSI_OPTS +"},{"line_number":109,"context_line":"            options.NEXENTA_DATASET_OPTS +"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_1ee19f9b","line":106,"range":{"start_line":106,"start_character":20,"end_line":106,"end_character":23},"updated":"2019-02-28 11:37:27.000000000","message":"-1: This will not remove duplicates","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"711e790c4c0ebfacdc3b22d503429e15cb28dc98","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @staticmethod"},{"line_number":105,"context_line":"    def get_driver_options():"},{"line_number":106,"context_line":"        return list(set("},{"line_number":107,"context_line":"            options.NEXENTA_CONNECTION_OPTS +"},{"line_number":108,"context_line":"            options.NEXENTA_ISCSI_OPTS +"},{"line_number":109,"context_line":"            options.NEXENTA_DATASET_OPTS +"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_e45f4d3e","line":106,"range":{"start_line":106,"start_character":20,"end_line":106,"end_character":23},"in_reply_to":"9fdfeff1_1ee19f9b","updated":"2019-03-01 17:05:56.000000000","message":"Done","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"}],"cinder/volume/drivers/nexenta/nfs.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"de7905500e216ab375c897d886e3f5f3f06645c5","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @staticmethod"},{"line_number":98,"context_line":"    def get_driver_options():"},{"line_number":99,"context_line":"        return list(set("},{"line_number":100,"context_line":"            options.NEXENTA_CONNECTION_OPTS +"},{"line_number":101,"context_line":"            options.NEXENTA_NFS_OPTS +"},{"line_number":102,"context_line":"            options.NEXENTA_DATASET_OPTS +"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_def0f769","line":99,"range":{"start_line":99,"start_character":20,"end_line":99,"end_character":23},"updated":"2019-02-28 11:37:27.000000000","message":"-1: This will not remove duplicates","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"711e790c4c0ebfacdc3b22d503429e15cb28dc98","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @staticmethod"},{"line_number":98,"context_line":"    def get_driver_options():"},{"line_number":99,"context_line":"        return list(set("},{"line_number":100,"context_line":"            options.NEXENTA_CONNECTION_OPTS +"},{"line_number":101,"context_line":"            options.NEXENTA_NFS_OPTS +"},{"line_number":102,"context_line":"            options.NEXENTA_DATASET_OPTS +"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_0409312f","line":99,"range":{"start_line":99,"start_character":20,"end_line":99,"end_character":23},"in_reply_to":"9fdfeff1_def0f769","updated":"2019-03-01 17:05:56.000000000","message":"Done","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"}],"cinder/volume/drivers/nexenta/ns5/iscsi.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"de7905500e216ab375c897d886e3f5f3f06645c5","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    @staticmethod"},{"line_number":86,"context_line":"    def get_driver_options():"},{"line_number":87,"context_line":"        return list(set("},{"line_number":88,"context_line":"            options.NEXENTA_CONNECTION_OPTS +"},{"line_number":89,"context_line":"            options.NEXENTA_ISCSI_OPTS +"},{"line_number":90,"context_line":"            options.NEXENTA_DATASET_OPTS +"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_1efaff41","line":87,"range":{"start_line":87,"start_character":20,"end_line":87,"end_character":23},"updated":"2019-02-28 11:37:27.000000000","message":"-1: This will not remove duplicates","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"711e790c4c0ebfacdc3b22d503429e15cb28dc98","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    @staticmethod"},{"line_number":86,"context_line":"    def get_driver_options():"},{"line_number":87,"context_line":"        return list(set("},{"line_number":88,"context_line":"            options.NEXENTA_CONNECTION_OPTS +"},{"line_number":89,"context_line":"            options.NEXENTA_ISCSI_OPTS +"},{"line_number":90,"context_line":"            options.NEXENTA_DATASET_OPTS +"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_271eb75e","line":87,"range":{"start_line":87,"start_character":20,"end_line":87,"end_character":23},"in_reply_to":"9fdfeff1_1efaff41","updated":"2019-03-01 17:05:56.000000000","message":"Done","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"}],"cinder/volume/drivers/nexenta/ns5/nfs.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"de7905500e216ab375c897d886e3f5f3f06645c5","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    @staticmethod"},{"line_number":86,"context_line":"    def get_driver_options():"},{"line_number":87,"context_line":"        return list(set("},{"line_number":88,"context_line":"            options.NEXENTA_CONNECTION_OPTS +"},{"line_number":89,"context_line":"            options.NEXENTA_NFS_OPTS +"},{"line_number":90,"context_line":"            options.NEXENTA_DATASET_OPTS"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_fe985b1b","line":87,"range":{"start_line":87,"start_character":20,"end_line":87,"end_character":23},"updated":"2019-02-28 11:37:27.000000000","message":"-1: ditto","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"711e790c4c0ebfacdc3b22d503429e15cb28dc98","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    @staticmethod"},{"line_number":86,"context_line":"    def get_driver_options():"},{"line_number":87,"context_line":"        return list(set("},{"line_number":88,"context_line":"            options.NEXENTA_CONNECTION_OPTS +"},{"line_number":89,"context_line":"            options.NEXENTA_NFS_OPTS +"},{"line_number":90,"context_line":"            options.NEXENTA_DATASET_OPTS"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_a73147ef","line":87,"range":{"start_line":87,"start_character":20,"end_line":87,"end_character":23},"in_reply_to":"9fdfeff1_fe985b1b","updated":"2019-03-01 17:05:56.000000000","message":"Done","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"}],"cinder/volume/drivers/nfs.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"fa2cce5858340c1bb3a4dc32fd45f79c987ddb0b","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @staticmethod"},{"line_number":126,"context_line":"    def get_driver_options():"},{"line_number":127,"context_line":"        return nfs_opts"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def initialize_connection(self, volume, connector):"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_e1e5b239","line":127,"updated":"2019-02-07 14:29:58.000000000","message":"I think this should be\n\n return nfs_ops + super(NfsDriver, self).get_driver_options()\n\nOr:\n\n return nfs_ops + remotefs.nas_opts\n\nOr\n\n return nfs_ops + remotefs.RemoteFSSnapDriverDistributed.get_driver_options()","commit_id":"7fb8705d23e5896f303f1650aa95de69d498ee2c"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b8150e19b68305aefc1d23ad73cdef4a18eb00ac","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @staticmethod"},{"line_number":126,"context_line":"    def get_driver_options():"},{"line_number":127,"context_line":"        return nfs_opts"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def initialize_connection(self, volume, connector):"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_33e6ab18","line":127,"in_reply_to":"9fdfeff1_e1e5b239","updated":"2019-02-07 16:36:26.000000000","message":"Done","commit_id":"7fb8705d23e5896f303f1650aa95de69d498ee2c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"de7905500e216ab375c897d886e3f5f3f06645c5","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @staticmethod"},{"line_number":126,"context_line":"    def get_driver_options():"},{"line_number":127,"context_line":"        return list(set("},{"line_number":128,"context_line":"            nfs_opts +"},{"line_number":129,"context_line":"            remotefs.nas_opts))"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_3e96e34a","line":127,"range":{"start_line":127,"start_character":20,"end_line":127,"end_character":23},"updated":"2019-02-28 11:37:27.000000000","message":"-1: This does not work to remove duplicates from oslo config options.","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"711e790c4c0ebfacdc3b22d503429e15cb28dc98","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @staticmethod"},{"line_number":126,"context_line":"    def get_driver_options():"},{"line_number":127,"context_line":"        return list(set("},{"line_number":128,"context_line":"            nfs_opts +"},{"line_number":129,"context_line":"            remotefs.nas_opts))"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_27531718","line":127,"range":{"start_line":127,"start_character":20,"end_line":127,"end_character":23},"in_reply_to":"9fdfeff1_3e96e34a","updated":"2019-03-01 17:05:56.000000000","message":"Done","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"}],"cinder/volume/drivers/san/hp/hpmsa_iscsi.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"de7905500e216ab375c897d886e3f5f3f06645c5","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @staticmethod"},{"line_number":49,"context_line":"    def get_driver_options():"},{"line_number":50,"context_line":"        return list(set(hpmsa_common.common_opts +"},{"line_number":51,"context_line":"                        hpmsa_common.iscsi_opts))"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _init_common(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_be989368","line":50,"range":{"start_line":50,"start_character":20,"end_line":50,"end_character":23},"updated":"2019-02-28 11:37:27.000000000","message":"-1: This does not remove duplicates.","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"}],"tools/generate_driver_list.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"de7905500e216ab375c897d886e3f5f3f06645c5","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        output.write(\u0027\u0027)"},{"line_number":83,"context_line":"        output.write(\u0027.. list-table:: **Driver configuration options**\u0027)"},{"line_number":84,"context_line":"        output.write(\u0027   :header-rows: 1\u0027)"},{"line_number":85,"context_line":"        output.write(\u0027   :widths: 14 30\u0027)"},{"line_number":86,"context_line":"        output.write(\u0027\u0027)"},{"line_number":87,"context_line":"        output.write(\u0027   * - Name \u003d Default Value\u0027)"},{"line_number":88,"context_line":"        output.write(\u0027     - (Type) Description\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_5eaf27e2","line":85,"updated":"2019-02-28 11:37:27.000000000","message":"?: Looks good, but is there any specific reason to have 2 columns instead of 4?","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7f52d760439c68a277d95a77322df8e1b46dc2d5","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        output.write(\u0027\u0027)"},{"line_number":83,"context_line":"        output.write(\u0027.. list-table:: **Driver configuration options**\u0027)"},{"line_number":84,"context_line":"        output.write(\u0027   :header-rows: 1\u0027)"},{"line_number":85,"context_line":"        output.write(\u0027   :widths: 14 30\u0027)"},{"line_number":86,"context_line":"        output.write(\u0027\u0027)"},{"line_number":87,"context_line":"        output.write(\u0027   * - Name \u003d Default Value\u0027)"},{"line_number":88,"context_line":"        output.write(\u0027     - (Type) Description\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_7cb1c4df","line":85,"in_reply_to":"9fdfeff1_5eaf27e2","updated":"2019-03-01 13:32:55.000000000","message":"because there are only 2 columns of data this is outputting.  The name with a default value in column 1\nthe type and description in column 2","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2b2c8bc5287a9130631acc047e141df09b210c84","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        output.write(\u0027\u0027)"},{"line_number":83,"context_line":"        output.write(\u0027.. list-table:: **Driver configuration options**\u0027)"},{"line_number":84,"context_line":"        output.write(\u0027   :header-rows: 1\u0027)"},{"line_number":85,"context_line":"        output.write(\u0027   :widths: 14 30\u0027)"},{"line_number":86,"context_line":"        output.write(\u0027\u0027)"},{"line_number":87,"context_line":"        output.write(\u0027   * - Name \u003d Default Value\u0027)"},{"line_number":88,"context_line":"        output.write(\u0027     - (Type) Description\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_bafe3fac","line":85,"in_reply_to":"9fdfeff1_7cb1c4df","updated":"2019-03-01 13:50:21.000000000","message":"Sorry for being unclear.  Why do we create 2 columns aggregating 2 values for each column instead of just having an independent column for each of the 4 data elements we are returning?\n\nIs it because the widths get more complicated?  Is it because it\u0027s easier to read?  I\u0027m asking out of curiosity, not that I think this is wrong or anything.  It looked good when I looked at the output.","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"711e790c4c0ebfacdc3b22d503429e15cb28dc98","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        output.write(\u0027\u0027)"},{"line_number":83,"context_line":"        output.write(\u0027.. list-table:: **Driver configuration options**\u0027)"},{"line_number":84,"context_line":"        output.write(\u0027   :header-rows: 1\u0027)"},{"line_number":85,"context_line":"        output.write(\u0027   :widths: 14 30\u0027)"},{"line_number":86,"context_line":"        output.write(\u0027\u0027)"},{"line_number":87,"context_line":"        output.write(\u0027   * - Name \u003d Default Value\u0027)"},{"line_number":88,"context_line":"        output.write(\u0027     - (Type) Description\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_e4550d51","line":85,"in_reply_to":"9fdfeff1_bafe3fac","updated":"2019-03-01 17:05:56.000000000","message":"Thanks for the clarification.   I was basically duplicating the same output format as other sections of the driver docs to be consistent.  You can see the existing format on the lvm docs page here:\n\nhttps://docs.openstack.org/cinder/rocky/configuration/block-storage/drivers/lvm-volume-driver.html","commit_id":"217b20b96bbb34ee11d49c3ac44a6653d342355f"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"958481d82e41512d208644972966253b909bc4af","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        output.write(\u0027\u0027)"},{"line_number":87,"context_line":"        output.write(\u0027   * - Name \u003d Default Value\u0027)"},{"line_number":88,"context_line":"        output.write(\u0027     - (Type) Description\u0027)"},{"line_number":89,"context_line":"        sorted_options \u003d sorted(driver_options,"},{"line_number":90,"context_line":"                                key\u003doperator.attrgetter(\u0027name\u0027))"},{"line_number":91,"context_line":"        for opt in sorted_options:"},{"line_number":92,"context_line":"            output.write(\u0027   * - %s \u003d %s\u0027 %"}],"source_content_type":"text/x-python","patch_set":13,"id":"5fc1f717_2e289184","line":89,"updated":"2019-03-07 15:15:17.000000000","message":"I was hoping to address this by including the vendor_name in the field that we sort by so there is a more logical ordering to things, but this is definitely an improvement for now.","commit_id":"fb3b843b662716a190275b73b14faf48444ea909"}]}