)]}'
{"cinder/volume/drivers/dell_emc/powermax/common.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"32f1cc315457d6b2d9e55cd6f0273184cd67912e","unresolved":false,"context_lines":[{"line_number":2929,"context_line":"                    rep_mode, is_rep_enabled, target_extra_specs)"},{"line_number":2930,"context_line":""},{"line_number":2931,"context_line":"        # Volume is not attached, retype as normal"},{"line_number":2932,"context_line":"        elif volume.attach_status !\u003d \u0027attached\u0027:"},{"line_number":2933,"context_line":"            if was_rep_enabled:"},{"line_number":2934,"context_line":"                if not is_rep_enabled:"},{"line_number":2935,"context_line":"                    # Disable replication is True"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_fdb71784","line":2932,"range":{"start_line":2932,"start_character":8,"end_line":2932,"end_character":48},"updated":"2019-02-27 17:29:32.000000000","message":"This could just be \"else\"...","commit_id":"9638cc1774526501efdc0e598f7e603f49e63609"},{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"05b9be8c8281674ec11a9f6caeacaf2bf586b43d","unresolved":false,"context_lines":[{"line_number":2929,"context_line":"                    rep_mode, is_rep_enabled, target_extra_specs)"},{"line_number":2930,"context_line":""},{"line_number":2931,"context_line":"        # Volume is not attached, retype as normal"},{"line_number":2932,"context_line":"        elif volume.attach_status !\u003d \u0027attached\u0027:"},{"line_number":2933,"context_line":"            if was_rep_enabled:"},{"line_number":2934,"context_line":"                if not is_rep_enabled:"},{"line_number":2935,"context_line":"                    # Disable replication is True"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_2bd8cb7c","line":2932,"range":{"start_line":2932,"start_character":8,"end_line":2932,"end_character":48},"in_reply_to":"9fdfeff1_fdb71784","updated":"2019-03-01 09:51:22.000000000","message":"I will get this fixed in a future patch, whilst the code is not technically incorrect I do see your point on changing this to else over a specific elif case","commit_id":"9638cc1774526501efdc0e598f7e603f49e63609"}],"cinder/volume/drivers/dell_emc/powermax/rest.py":[{"author":{"_account_id":26402,"name":"Kumar Prashant","email":"kumar.prashant@dell.com","username":"prashk"},"change_message_id":"684d28e060e05331bf4e4781223cdc447ad044e5","unresolved":false,"context_lines":[{"line_number":734,"context_line":"            \"addExistingStorageGroupParam\": {"},{"line_number":735,"context_line":"                \"storageGroupId\": [child_sg]}}}"},{"line_number":736,"context_line":"        sc, job \u003d self.modify_storage_group(array, parent_sg, payload,"},{"line_number":737,"context_line":"                                            version\u003d\"83\")"},{"line_number":738,"context_line":"        self.wait_for_job(\u0027Add child sg to parent sg\u0027, sc, job, extra_specs)"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"    def remove_child_sg_from_parent_sg("}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_a8c9e6ac","line":737,"updated":"2019-02-20 08:23:45.000000000","message":"Any particular reason for falling back to the older version of the API?","commit_id":"9638cc1774526501efdc0e598f7e603f49e63609"}]}