)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1ee613090c7f2ec5e95442ddbabaad6cca1f9a51","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the auth version, then authenticate with identifier"},{"line_number":12,"context_line":"rather than randomno when authversion is not 1."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Also, the formatting of nsinfo.htm has changed,"},{"line_number":15,"context_line":"so now using the formatted nsinfo.html page"},{"line_number":16,"context_line":"to gather nport wwns from the name server."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9fdfeff1_d532b15e","line":14,"range":{"start_line":14,"start_character":6,"end_line":14,"end_character":46},"updated":"2019-02-20 22:53:34.000000000","message":"I\u0027m assuming this is a backward compatible change, i.e., the \"new\" format is available on older name servers?","commit_id":"28a696ea625e4113706e030b773fcf39cb1c49a1"}],"cinder/zonemanager/drivers/brocade/brcd_http_fc_zone_client.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"e4469bdb75ea720539714d08da7d974f1fd92d25","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            self.auth_version \u003d self.get_nvp_value(parsed_data,"},{"line_number":160,"context_line":"                                                   zone_constant.AUTHVERSION)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"            if (self.auth_version \u003d\u003d \"1\"):"},{"line_number":163,"context_line":"                # Extract the random no from secinfo.html response"},{"line_number":164,"context_line":"                self.random_no \u003d self.get_nvp_value(parsed_data,"},{"line_number":165,"context_line":"                                                    zone_constant.RANDOM)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_225c7c17","line":162,"range":{"start_line":162,"start_character":15,"end_line":162,"end_character":16},"updated":"2019-02-15 20:34:13.000000000","message":"nit in case you update, no need for () on these if statements.","commit_id":"8c8c3a22a360cedd1217f49a33263f593ecd73b4"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"0a49b48383d2ac0f55ff04f3593fe601129202ad","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            self.auth_version \u003d self.get_nvp_value(parsed_data,"},{"line_number":160,"context_line":"                                                   zone_constant.AUTHVERSION)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"            if (self.auth_version \u003d\u003d \"1\"):"},{"line_number":163,"context_line":"                # Extract the random no from secinfo.html response"},{"line_number":164,"context_line":"                self.random_no \u003d self.get_nvp_value(parsed_data,"},{"line_number":165,"context_line":"                                                    zone_constant.RANDOM)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_a2f38c08","line":162,"range":{"start_line":162,"start_character":15,"end_line":162,"end_character":16},"in_reply_to":"9fdfeff1_225c7c17","updated":"2019-02-15 20:37:34.000000000","message":"Thanks Sean, I will change this.  It\u0027s the java coder in me, not a pythoner by any means.","commit_id":"8c8c3a22a360cedd1217f49a33263f593ecd73b4"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ba9a0453a65ba314e1c97f5c8ca7e70b193c1d7a","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            self.auth_version \u003d self.get_nvp_value(parsed_data,"},{"line_number":160,"context_line":"                                                   zone_constant.AUTHVERSION)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"            if (self.auth_version \u003d\u003d \"1\"):"},{"line_number":163,"context_line":"                # Extract the random no from secinfo.html response"},{"line_number":164,"context_line":"                self.random_no \u003d self.get_nvp_value(parsed_data,"},{"line_number":165,"context_line":"                                                    zone_constant.RANDOM)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_629fe44f","line":162,"range":{"start_line":162,"start_character":15,"end_line":162,"end_character":16},"in_reply_to":"9fdfeff1_a2f38c08","updated":"2019-02-15 20:53:16.000000000","message":"I completely understand. It was harder than expected for me to get over the habit too. ;)","commit_id":"8c8c3a22a360cedd1217f49a33263f593ecd73b4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1ee613090c7f2ec5e95442ddbabaad6cca1f9a51","unresolved":false,"context_lines":[{"line_number":199,"context_line":"            isauthenticated \u003d self.get_nvp_value("},{"line_number":200,"context_line":"                parsed_data, zone_constant.AUTHENTICATED)"},{"line_number":201,"context_line":"            if isauthenticated \u003d\u003d \"yes\":"},{"line_number":202,"context_line":"                if self.auth_version \u003d\u003d \"3\":"},{"line_number":203,"context_line":"                    auth_id \u003d self.get_nvp_value(parsed_data,"},{"line_number":204,"context_line":"                                                 zone_constant.IDENTIFIER)"},{"line_number":205,"context_line":"                    auth_string \u003d \u0027%s:xxx:%s\u0027 % (self.switch_user, auth_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_15db5921","line":202,"updated":"2019-02-20 22:53:34.000000000","message":"Your commit message says that you are adding the check for authversion !\u003d \"1\", and that\u0027s basically what you\u0027re doing up at line 162 in this file.  This is a bit different; here you are doing the new stuff when authversion \u003d\u003d \"3\" and the old stuff whenever authversion !\u003d \"1\".  I guess it doesn\u0027t matter if the only authversions are 1 and 3, but otherwise this seems kind of brittle.  (Or the commit message is misleading about this fix.)","commit_id":"28a696ea625e4113706e030b773fcf39cb1c49a1"}],"cinder/zonemanager/drivers/brocade/fc_zone_constants.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1ee613090c7f2ec5e95442ddbabaad6cca1f9a51","unresolved":false,"context_lines":[{"line_number":88,"context_line":"IFA_DELIM \u003d \"\\x06\""},{"line_number":89,"context_line":"ACTIVE_CFG_DELIM \u003d \"\\x07\""},{"line_number":90,"context_line":"DEFAULT_CFG \u003d \"d__efault__Cfg\""},{"line_number":91,"context_line":"NS_PAGE \u003d \"/nsinfo.htm?format\u003d1\u0026type\u003dall\""},{"line_number":92,"context_line":"NS_DELIM \u003d \"deviceport.portwwn\u003d\""},{"line_number":93,"context_line":"ZONE_TX_BEGIN \u003d \"--BEGIN ZONE_TXN_INFO\""},{"line_number":94,"context_line":"ZONE_TX_END \u003d \"--END ZONE_TXN_INFO\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_f5433512","line":91,"range":{"start_line":91,"start_character":12,"end_line":91,"end_character":22},"updated":"2019-02-20 22:53:34.000000000","message":"In your commit message and in your comment on line 778 in brcd_http_fc_zone_client.py, you say this is \u0027nsinfo.html\u0027.  This file has a mix of .htm and .html defined, so maybe it doesn\u0027t matter, but it might be helpful to be consistent in your patch.","commit_id":"28a696ea625e4113706e030b773fcf39cb1c49a1"}]}