)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"20005f9bf3bffa369a58f12044d28a4b982db0bb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update json module to jsonutils"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"json is not recommend, should use oslo_serialization.jsonutils"},{"line_number":10,"context_line":"instead."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8d46acade9d3e7b9e5f959f6591ec276183e6fd7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5fc1f717_26ee8822","line":9,"updated":"2019-03-07 01:28:18.000000000","message":"Please explain why. This is part of the standard library, so it is very commonly used by more than just Cinder or OpenStack.","commit_id":"fe22d99f65620e10b6630c1418530c86b121070e"},{"author":{"_account_id":27781,"name":"zhulingjie","email":"easyzlj@gmail.com","username":"zhulingjie"},"change_message_id":"dbc7190d729da4f2221bcc99d44121f1243b98ce","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update json module to jsonutils"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"json is not recommend, should use oslo_serialization.jsonutils"},{"line_number":10,"context_line":"instead."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8d46acade9d3e7b9e5f959f6591ec276183e6fd7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5fc1f717_6e5f8241","line":9,"in_reply_to":"5fc1f717_26ee8822","updated":"2019-03-07 08:52:01.000000000","message":"well, oslo.serialization provide the jsonutils [1], it support encode utf-8 directly, and we can use it for more simple code.\nmore openstack project use oslo, neutron prohibit use json now[2], cinder should update json to oslo to keep the pace with others\n\n[1]: https://github.com/openstack/oslo.serialization/blob/master/oslo_serialization/jsonutils.py\n[2]:https://github.com/openstack/neutron-lib/blob/master/HACKING.rst","commit_id":"fe22d99f65620e10b6630c1418530c86b121070e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"52b36dbab3dfb5a19243d6b0c79f41e2abfcece3","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"oslo project provide jsonutils, and cinder use it in many place[1],"},{"line_number":10,"context_line":"this PS to update the remained json module to oslo jsonutils for"},{"line_number":11,"context_line":"consistency."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1]: https://github.com/openstack/cinder/search?q\u003djsonutils\u0026unscoped_q\u003djsonutils"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5fc1f717_95fcac70","line":11,"updated":"2019-03-14 17:46:05.000000000","message":"Why?  Is calling json.load() via oslo really better than just calling python\u0027s json.load()?","commit_id":"d2ff8da8d6974e261c954f637402d12e421731a4"}],"cinder/backup/chunkeddriver.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0db4555755f3cb237012baed7d4e3fdeb0349dff","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from oslo_config import cfg"},{"line_number":31,"context_line":"from oslo_log import log as logging"},{"line_number":32,"context_line":"from oslo_service import loopingcall"},{"line_number":33,"context_line":"from oslo_serialization import jsonutils as json"},{"line_number":34,"context_line":"from oslo_utils import excutils"},{"line_number":35,"context_line":"from oslo_utils import units"},{"line_number":36,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":5,"id":"5fc1f717_3e3c3e92","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":48},"updated":"2019-03-07 18:41:12.000000000","message":"this should be above oslo_service","commit_id":"9d855096830474ae2d13d5c8249117af196368e7"}]}