)]}'
{"cinder/tests/unit/volume/drivers/test_gpfs.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"29ba6342337edbaed6c08dba68ef3f1918542acf","unresolved":false,"context_lines":[{"line_number":1596,"context_line":"        mock_exec.assert_any_call(*cmd)"},{"line_number":1597,"context_line":""},{"line_number":1598,"context_line":"    @mock.patch(\u0027cinder.privsep.gpfs.mmcrfileset\u0027)"},{"line_number":1599,"context_line":"    def test_create_consistencygroup_fail(self, mock_privsep):"},{"line_number":1600,"context_line":"        ctxt \u003d self.context"},{"line_number":1601,"context_line":"        group \u003d self._fake_group()"},{"line_number":1602,"context_line":"        mock_privsep.side_effect \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_0a3bcfd0","line":1599,"range":{"start_line":1599,"start_character":48,"end_line":1599,"end_character":60},"updated":"2019-02-26 16:45:04.000000000","message":"i see \u0027mock_privsep\u0027 for some commands and \u0027mock_priv\u0027 for some others.\nI understand the long naming convention for cases with multiple mocks but this shuffling of name is creating confusion.\nCould you do either of the following :\n* Either keep all mock names unique OR\n* Keep consistency between mock names","commit_id":"b0bb198fb4cde3c8861b77d9b9cc9ed44ce58ec4"}],"cinder/volume/drivers/ibm/gpfs.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"29ba6342337edbaed6c08dba68ef3f1918542acf","unresolved":false,"context_lines":[{"line_number":524,"context_line":"                options.extend([\u0027--block-group-factor\u0027, metadata[item]])"},{"line_number":525,"context_line":"            elif item \u003d\u003d \u0027write_affinity_failure_group\u0027:"},{"line_number":526,"context_line":"                options.extend([\u0027--write-affinity-failure-group\u0027,"},{"line_number":527,"context_line":"                                metadata[item]])"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"        # metadata value has precedence over value set in volume type"},{"line_number":530,"context_line":"        if self.configuration.gpfs_storage_pool and not set_pool:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_ca45c745","line":527,"range":{"start_line":527,"start_character":31,"end_line":527,"end_character":32},"updated":"2019-02-26 16:45:04.000000000","message":"this space isn\u0027t required","commit_id":"b0bb198fb4cde3c8861b77d9b9cc9ed44ce58ec4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"29ba6342337edbaed6c08dba68ef3f1918542acf","unresolved":false,"context_lines":[{"line_number":569,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":570,"context_line":"        snap_parent_vol \u003d self.db.volume_get(ctxt, snapshot[\u0027volume_id\u0027])"},{"line_number":571,"context_line":"        if (volume[\u0027group_id\u0027]"},{"line_number":572,"context_line":"                \u003d\u003d snap_parent_vol[\u0027group_id\u0027]):"},{"line_number":573,"context_line":"            clone \u003d True"},{"line_number":574,"context_line":"        volume_path \u003d self._get_volume_path(volume)"},{"line_number":575,"context_line":"        if clone:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_0a698fbc","line":572,"range":{"start_line":572,"start_character":16,"end_line":572,"end_character":18},"updated":"2019-02-26 16:45:04.000000000","message":"I\u0027m not sure how moving operators on the next line has any benefits, neither does it enhance the readability of the code.","commit_id":"b0bb198fb4cde3c8861b77d9b9cc9ed44ce58ec4"}]}