)]}'
{"api-ref/source/v2/samples/volume-os-migrate_volume_completion-request.json":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"dd0200a3d79a5eaf39b5fb43010bd9a98dd3bf93","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"os-migrate_volume_completion\": {"},{"line_number":3,"context_line":"        \"new_volume\": \"2b955850-f177-45f7-9f49-ecb2c256d161\","},{"line_number":4,"context_line":"        \"error\": \"False\","},{"line_number":5,"context_line":"    }"},{"line_number":6,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"9fdfeff1_f9f25e6f","line":4,"range":{"start_line":4,"start_character":17,"end_line":4,"end_character":24},"updated":"2019-02-20 11:31:58.000000000","message":"would suggest to use direct boolean types as supported in json\nhttps://github.com/openstack/cinder/blob/master/api-ref/source/v3/samples/volumes/volume-create-request.json#L7","commit_id":"8355be3c3780bd9c27207ac42b85546089b9cb86"}],"api-ref/source/v2/volumes-v2-volumes-actions.inc":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f609287f3adc4283f9725cdf739d5ae4b73b07a8","unresolved":false,"context_lines":[{"line_number":498,"context_line":""},{"line_number":499,"context_line":"* Both the volume and new volume ``migration_status`` must be ``None`` or be"},{"line_number":500,"context_line":"  set to a non ``None`` values together."},{"line_number":501,"context_line":"* Additionally when set the new volume ``migration_status`` must take the "},{"line_number":502,"context_line":"  form of ``target:VOLUME_ID`` where VOLUME_ID is the current volume ID."},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"**Asynchronous Postconditions**"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"9fdfeff1_9e10eaaa","line":501,"range":{"start_line":501,"start_character":73,"end_line":501,"end_character":74},"updated":"2019-02-19 16:36:22.000000000","message":"NIT: remove space","commit_id":"41ddcc1bbeec5d49d2a64e3379fd963d1894952f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f609287f3adc4283f9725cdf739d5ae4b73b07a8","unresolved":false,"context_lines":[{"line_number":505,"context_line":""},{"line_number":506,"context_line":"On success, the volume ``status`` will return to its original status of"},{"line_number":507,"context_line":"``available`` or ``in-use`` and the ``migration_status`` will be ``success``."},{"line_number":508,"context_line":"On failure, the ``migration_status`` will be ``error``. "},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"Response codes"},{"line_number":511,"context_line":"--------------"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"9fdfeff1_5e228203","line":508,"range":{"start_line":508,"start_character":55,"end_line":508,"end_character":56},"updated":"2019-02-19 16:36:22.000000000","message":"NIT: remove space","commit_id":"41ddcc1bbeec5d49d2a64e3379fd963d1894952f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"dd0200a3d79a5eaf39b5fb43010bd9a98dd3bf93","unresolved":false,"context_lines":[{"line_number":495,"context_line":"and finally deleting the original volume."},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"**Preconditions**"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"* Both the original and new volume ``migration_status`` must be ``None`` or"},{"line_number":500,"context_line":"  both must be set to a non ``None`` value."},{"line_number":501,"context_line":"* Additionally when set the new volume ``migration_status`` must take the"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"9fdfeff1_79d50eb7","line":498,"updated":"2019-02-20 11:31:58.000000000","message":"ditto","commit_id":"8355be3c3780bd9c27207ac42b85546089b9cb86"}],"api-ref/source/v3/samples/volume-os-migrate_volume_completion-request.json":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"dd0200a3d79a5eaf39b5fb43010bd9a98dd3bf93","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"os-migrate_volume_completion\": {"},{"line_number":3,"context_line":"        \"new_volume\": \"2b955850-f177-45f7-9f49-ecb2c256d161\","},{"line_number":4,"context_line":"        \"error\": \"False\","},{"line_number":5,"context_line":"    }"},{"line_number":6,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"9fdfeff1_59012a39","line":4,"range":{"start_line":4,"start_character":17,"end_line":4,"end_character":24},"updated":"2019-02-20 11:31:58.000000000","message":"ditto","commit_id":"8355be3c3780bd9c27207ac42b85546089b9cb86"}],"api-ref/source/v3/volumes-v3-volumes-actions.inc":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"89b81b4ed3f6402fb7505fd0ed913b37b38e0eff","unresolved":false,"context_lines":[{"line_number":554,"context_line":"Specify the ``os-migrate_volume_completion`` action in the request body."},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"Complete the migration of a volume, updating the new volume in the DB,"},{"line_number":557,"context_line":"returning the ``status`` of this volume to that of the original volume before"},{"line_number":558,"context_line":"the migration started and finally delete the original volume."},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"**Preconditions**"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"9fdfeff1_5e8362aa","line":557,"range":{"start_line":557,"start_character":33,"end_line":557,"end_character":39},"updated":"2019-02-19 16:50:43.000000000","message":"new volume","commit_id":"41ddcc1bbeec5d49d2a64e3379fd963d1894952f"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"ee6013bea41b0080f4787f06c8f8eee886164221","unresolved":false,"context_lines":[{"line_number":554,"context_line":"Specify the ``os-migrate_volume_completion`` action in the request body."},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"Complete the migration of a volume, updating the new volume in the DB,"},{"line_number":557,"context_line":"returning the ``status`` of this volume to that of the original volume before"},{"line_number":558,"context_line":"the migration started and finally delete the original volume."},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"**Preconditions**"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"9fdfeff1_d43093a1","line":557,"range":{"start_line":557,"start_character":33,"end_line":557,"end_character":39},"in_reply_to":"9fdfeff1_5e8362aa","updated":"2019-02-20 11:39:44.000000000","message":"Done","commit_id":"41ddcc1bbeec5d49d2a64e3379fd963d1894952f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"89b81b4ed3f6402fb7505fd0ed913b37b38e0eff","unresolved":false,"context_lines":[{"line_number":559,"context_line":""},{"line_number":560,"context_line":"**Preconditions**"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"* Both the volume and new volume ``migration_status`` must be ``None`` or be"},{"line_number":563,"context_line":"  set to a non ``None`` values together."},{"line_number":564,"context_line":"* Additionally when set the new volume ``migration_status`` must take the "},{"line_number":565,"context_line":"  form of ``target:VOLUME_ID`` where VOLUME_ID is the current volume ID."}],"source_content_type":"text/x-c++src","patch_set":2,"id":"9fdfeff1_5eacc234","line":562,"range":{"start_line":562,"start_character":11,"end_line":562,"end_character":17},"updated":"2019-02-19 16:50:43.000000000","message":"original volume","commit_id":"41ddcc1bbeec5d49d2a64e3379fd963d1894952f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f609287f3adc4283f9725cdf739d5ae4b73b07a8","unresolved":false,"context_lines":[{"line_number":561,"context_line":""},{"line_number":562,"context_line":"* Both the volume and new volume ``migration_status`` must be ``None`` or be"},{"line_number":563,"context_line":"  set to a non ``None`` values together."},{"line_number":564,"context_line":"* Additionally when set the new volume ``migration_status`` must take the "},{"line_number":565,"context_line":"  form of ``target:VOLUME_ID`` where VOLUME_ID is the current volume ID."},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"**Asynchronous Postconditions**"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"9fdfeff1_5e39223d","line":564,"range":{"start_line":564,"start_character":73,"end_line":564,"end_character":74},"updated":"2019-02-19 16:36:22.000000000","message":"NIT: remove space","commit_id":"41ddcc1bbeec5d49d2a64e3379fd963d1894952f"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"ee6013bea41b0080f4787f06c8f8eee886164221","unresolved":false,"context_lines":[{"line_number":561,"context_line":""},{"line_number":562,"context_line":"* Both the volume and new volume ``migration_status`` must be ``None`` or be"},{"line_number":563,"context_line":"  set to a non ``None`` values together."},{"line_number":564,"context_line":"* Additionally when set the new volume ``migration_status`` must take the "},{"line_number":565,"context_line":"  form of ``target:VOLUME_ID`` where VOLUME_ID is the current volume ID."},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"**Asynchronous Postconditions**"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"9fdfeff1_14fdbbb0","line":564,"range":{"start_line":564,"start_character":73,"end_line":564,"end_character":74},"in_reply_to":"9fdfeff1_5e39223d","updated":"2019-02-20 11:39:44.000000000","message":"Done","commit_id":"41ddcc1bbeec5d49d2a64e3379fd963d1894952f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"89b81b4ed3f6402fb7505fd0ed913b37b38e0eff","unresolved":false,"context_lines":[{"line_number":562,"context_line":"* Both the volume and new volume ``migration_status`` must be ``None`` or be"},{"line_number":563,"context_line":"  set to a non ``None`` values together."},{"line_number":564,"context_line":"* Additionally when set the new volume ``migration_status`` must take the "},{"line_number":565,"context_line":"  form of ``target:VOLUME_ID`` where VOLUME_ID is the current volume ID."},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"**Asynchronous Postconditions**"},{"line_number":568,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"9fdfeff1_fe04961a","line":565,"range":{"start_line":565,"start_character":37,"end_line":565,"end_character":71},"updated":"2019-02-19 16:50:43.000000000","message":"seems a little confusing, can we write it in terms of original and new volume instead?","commit_id":"41ddcc1bbeec5d49d2a64e3379fd963d1894952f"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"ee6013bea41b0080f4787f06c8f8eee886164221","unresolved":false,"context_lines":[{"line_number":562,"context_line":"* Both the volume and new volume ``migration_status`` must be ``None`` or be"},{"line_number":563,"context_line":"  set to a non ``None`` values together."},{"line_number":564,"context_line":"* Additionally when set the new volume ``migration_status`` must take the "},{"line_number":565,"context_line":"  form of ``target:VOLUME_ID`` where VOLUME_ID is the current volume ID."},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"**Asynchronous Postconditions**"},{"line_number":568,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"9fdfeff1_f4ffd7a8","line":565,"range":{"start_line":565,"start_character":37,"end_line":565,"end_character":71},"in_reply_to":"9fdfeff1_fe04961a","updated":"2019-02-20 11:39:44.000000000","message":"Done","commit_id":"41ddcc1bbeec5d49d2a64e3379fd963d1894952f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"89b81b4ed3f6402fb7505fd0ed913b37b38e0eff","unresolved":false,"context_lines":[{"line_number":563,"context_line":"  set to a non ``None`` values together."},{"line_number":564,"context_line":"* Additionally when set the new volume ``migration_status`` must take the "},{"line_number":565,"context_line":"  form of ``target:VOLUME_ID`` where VOLUME_ID is the current volume ID."},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"**Asynchronous Postconditions**"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"On success, the volume ``status`` will return to its original status of"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"9fdfeff1_796d20cb","line":566,"updated":"2019-02-19 16:50:43.000000000","message":"I think we need a pre-condition for volume ``status`` too\n\"The volume status must be available or in-use.\"","commit_id":"41ddcc1bbeec5d49d2a64e3379fd963d1894952f"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"ee6013bea41b0080f4787f06c8f8eee886164221","unresolved":false,"context_lines":[{"line_number":563,"context_line":"  set to a non ``None`` values together."},{"line_number":564,"context_line":"* Additionally when set the new volume ``migration_status`` must take the "},{"line_number":565,"context_line":"  form of ``target:VOLUME_ID`` where VOLUME_ID is the current volume ID."},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"**Asynchronous Postconditions**"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"On success, the volume ``status`` will return to its original status of"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"9fdfeff1_79da004c","line":566,"in_reply_to":"9fdfeff1_796d20cb","updated":"2019-02-20 11:39:44.000000000","message":"That\u0027s a pre-condition of the os-migrate_volume call above and not this subsequent call to os-migrate_volume_completion.","commit_id":"41ddcc1bbeec5d49d2a64e3379fd963d1894952f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f609287f3adc4283f9725cdf739d5ae4b73b07a8","unresolved":false,"context_lines":[{"line_number":568,"context_line":""},{"line_number":569,"context_line":"On success, the volume ``status`` will return to its original status of"},{"line_number":570,"context_line":"``available`` or ``in-use`` and the ``migration_status`` will be ``success``."},{"line_number":571,"context_line":"On failure, the ``migration_status`` will be ``error``. "},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"Response codes"},{"line_number":574,"context_line":"--------------"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"9fdfeff1_1e439ab1","line":571,"range":{"start_line":571,"start_character":55,"end_line":571,"end_character":56},"updated":"2019-02-19 16:36:22.000000000","message":"NIT: remove space","commit_id":"41ddcc1bbeec5d49d2a64e3379fd963d1894952f"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"ee6013bea41b0080f4787f06c8f8eee886164221","unresolved":false,"context_lines":[{"line_number":568,"context_line":""},{"line_number":569,"context_line":"On success, the volume ``status`` will return to its original status of"},{"line_number":570,"context_line":"``available`` or ``in-use`` and the ``migration_status`` will be ``success``."},{"line_number":571,"context_line":"On failure, the ``migration_status`` will be ``error``. "},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"Response codes"},{"line_number":574,"context_line":"--------------"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"9fdfeff1_54f343e8","line":571,"range":{"start_line":571,"start_character":55,"end_line":571,"end_character":56},"in_reply_to":"9fdfeff1_1e439ab1","updated":"2019-02-20 11:39:44.000000000","message":"Done","commit_id":"41ddcc1bbeec5d49d2a64e3379fd963d1894952f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"dd0200a3d79a5eaf39b5fb43010bd9a98dd3bf93","unresolved":false,"context_lines":[{"line_number":558,"context_line":"and finally deleting the original volume."},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"**Preconditions**"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"* Both the original and new volume ``migration_status`` must be ``None`` or"},{"line_number":563,"context_line":"  both must be set to a non ``None`` value."},{"line_number":564,"context_line":"* Additionally when set the new volume ``migration_status`` must take the"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"9fdfeff1_b9d376d5","line":561,"updated":"2019-02-20 11:31:58.000000000","message":"precondition for volume status missing as commented in previous patchset\n\"The volume status must be available or in-use\"","commit_id":"8355be3c3780bd9c27207ac42b85546089b9cb86"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"65428bc61c38cc498ce8ffa1c8c773995f6ab133","unresolved":false,"context_lines":[{"line_number":558,"context_line":"and finally deleting the original volume."},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"**Preconditions**"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"* Both the original and new volume ``migration_status`` must be ``None`` or"},{"line_number":563,"context_line":"  both must be set to a non ``None`` value."},{"line_number":564,"context_line":"* Additionally when set the new volume ``migration_status`` must take the"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"9fdfeff1_03a33002","line":561,"in_reply_to":"9fdfeff1_795aee50","updated":"2019-02-20 13:57:21.000000000","message":"Yes, correct. Got confused with all the mixed up status check from the old and new flow.\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L2346","commit_id":"8355be3c3780bd9c27207ac42b85546089b9cb86"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"ee6013bea41b0080f4787f06c8f8eee886164221","unresolved":false,"context_lines":[{"line_number":558,"context_line":"and finally deleting the original volume."},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"**Preconditions**"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"* Both the original and new volume ``migration_status`` must be ``None`` or"},{"line_number":563,"context_line":"  both must be set to a non ``None`` value."},{"line_number":564,"context_line":"* Additionally when set the new volume ``migration_status`` must take the"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"9fdfeff1_795aee50","line":561,"in_reply_to":"9fdfeff1_b9d376d5","updated":"2019-02-20 11:39:44.000000000","message":"AFAICT this isn\u0027t a precondition of this API, it is of the proceeding os-migrate_volume call above but there\u0027s no validation of the volume state for os-migrate_volume_completion.","commit_id":"8355be3c3780bd9c27207ac42b85546089b9cb86"}]}