)]}'
{"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ed23afba76d8a1a2f21acff0f06b4d90bbc726d4","unresolved":false,"context_lines":[{"line_number":674,"context_line":"@enginefacade.writer"},{"line_number":675,"context_line":"def untyped_volumes_online_data_migration(context, max_count):"},{"line_number":676,"context_line":"    from cinder.volume import volume_types"},{"line_number":677,"context_line":"    default_type \u003d volume_types.get_default_volume_type()"},{"line_number":678,"context_line":"    # get all volumes having volume_type\u003dNone"},{"line_number":679,"context_line":"    total \u003d 0"},{"line_number":680,"context_line":"    updated \u003d 0"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_31ba3ae1","line":677,"updated":"2019-02-20 15:26:29.000000000","message":"This isn\u0027t sufficient, we have to create a type if it doesn\u0027t exist...","commit_id":"d2f5b504ee56abe93270a2b53be407dfbd26192c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6f3178cb0f994fc043e3557c6dbfed2e246cc329","unresolved":false,"context_lines":[{"line_number":674,"context_line":"@enginefacade.writer"},{"line_number":675,"context_line":"def untyped_volumes_online_data_migration(context, max_count):"},{"line_number":676,"context_line":"    from cinder.volume import volume_types"},{"line_number":677,"context_line":"    default_type \u003d volume_types.get_default_volume_type()"},{"line_number":678,"context_line":"    # get all volumes having volume_type\u003dNone"},{"line_number":679,"context_line":"    total \u003d 0"},{"line_number":680,"context_line":"    updated \u003d 0"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_714682c3","line":677,"in_reply_to":"9fdfeff1_31ba3ae1","updated":"2019-02-20 15:41:35.000000000","message":"Since the default type will be created during cinder deployment, it will require a separate migration.\nCurrently i\u0027ve assumed that the default_volume_type permanently exists in the conf file and admins wouldn\u0027t be able to unset it (as mentioned in the PTG discussion).\nI\u0027m thinking of moving that part to a different patch considering this online migration is independent of that right now.\nwe can create the default type while fetching it from the conf (if not found) but is it the intended functionality?","commit_id":"d2f5b504ee56abe93270a2b53be407dfbd26192c"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"138ee52f7e8395d538d4538e3469528e05313919","unresolved":false,"context_lines":[{"line_number":674,"context_line":"@enginefacade.writer"},{"line_number":675,"context_line":"def untyped_volumes_online_data_migration(context, max_count):"},{"line_number":676,"context_line":"    from cinder.volume import volume_types"},{"line_number":677,"context_line":"    default_type \u003d volume_types.get_default_volume_type()"},{"line_number":678,"context_line":"    # get all volumes having volume_type\u003dNone"},{"line_number":679,"context_line":"    total \u003d 0"},{"line_number":680,"context_line":"    updated \u003d 0"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_c9aa99d0","line":677,"in_reply_to":"9fdfeff1_714682c3","updated":"2019-04-09 18:12:12.000000000","message":"part of the problem with this is that you can\u0027t guarantee that default_volume_type is set in cinder.conf, hence the need to make sure we have one always around called \u0027default\u0027 or whatever we decide on.\n\nSo, we need to make sure the \u0027default\u0027 is created here in the db migration first, and if cinder.conf doesn\u0027t have one set, then use that as the type for migration.","commit_id":"d2f5b504ee56abe93270a2b53be407dfbd26192c"}]}