)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"7663bf144614cf77d6a4d7bbd49de99d04b87876","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     whoami-rajat \u003crajatdhasmana@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-08-12 12:39:40 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add migrations for default volume type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The patch adds the following functionality:"},{"line_number":10,"context_line":"A default volume type will be created during cinder DB migration."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"7faddb67_27b96c78","line":7,"updated":"2019-08-28 16:25:23.000000000","message":"This could probably use a more descriptive summary that describes the feature itself, since it\u0027s not really just about adding migrations.","commit_id":"67e27d225129459b67841be4cf51d58aff3bd9fc"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"07df3892dc204f2162edc7295e7a5faa73c17b98","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     whoami-rajat \u003crajatdhasmana@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-08-12 12:39:40 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add migrations for default volume type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The patch adds the following functionality:"},{"line_number":10,"context_line":"A default volume type will be created during cinder DB migration."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"7faddb67_d6402909","line":7,"in_reply_to":"7faddb67_27b96c78","updated":"2019-08-30 11:20:57.000000000","message":"Done","commit_id":"67e27d225129459b67841be4cf51d58aff3bd9fc"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"7663bf144614cf77d6a4d7bbd49de99d04b87876","unresolved":false,"context_lines":[{"line_number":17,"context_line":"and snapshots to \u0027__DEFAULT__\u0027"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I4da0c13b5b3f8174a30b8557f968d6b9e641b091"},{"line_number":20,"context_line":"Partial-Implements: blueprint untyped-volumes-default-volume-type"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"7faddb67_27a08c42","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":18},"updated":"2019-08-28 16:25:23.000000000","message":"I think this should say \"Implements:\"?","commit_id":"67e27d225129459b67841be4cf51d58aff3bd9fc"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"07df3892dc204f2162edc7295e7a5faa73c17b98","unresolved":false,"context_lines":[{"line_number":17,"context_line":"and snapshots to \u0027__DEFAULT__\u0027"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I4da0c13b5b3f8174a30b8557f968d6b9e641b091"},{"line_number":20,"context_line":"Partial-Implements: blueprint untyped-volumes-default-volume-type"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"7faddb67_76493530","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":18},"in_reply_to":"7faddb67_27a08c42","updated":"2019-08-30 11:20:57.000000000","message":"Done","commit_id":"67e27d225129459b67841be4cf51d58aff3bd9fc"}],"cinder/common/config.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"36933dbf00ce5899eca8c30459863516a32d79d6","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                     \u0027default_availability_zone, then \u0027"},{"line_number":108,"context_line":"                     \u0027storage_availability_zone, instead of failing.\u0027),"},{"line_number":109,"context_line":"    cfg.StrOpt(\u0027default_volume_type\u0027,"},{"line_number":110,"context_line":"               default\u003d\"default_vol_type\","},{"line_number":111,"context_line":"               help\u003d\u0027Default volume type to use\u0027),"},{"line_number":112,"context_line":"    cfg.StrOpt(\u0027default_group_type\u0027,"},{"line_number":113,"context_line":"               help\u003d\u0027Default group type to use\u0027),"}],"source_content_type":"text/x-python","patch_set":31,"id":"7faddb67_4f7777d2","line":110,"updated":"2019-09-04 18:53:16.000000000","message":"shouldn\u0027t this be __DEFAULT__ ?","commit_id":"a3ac2032d81a8fa2e195c2b3a0403c4015c91e3c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"29c46feaa9dce99c52abf1ef6030b7ca6be1eb61","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                     \u0027default_availability_zone, then \u0027"},{"line_number":108,"context_line":"                     \u0027storage_availability_zone, instead of failing.\u0027),"},{"line_number":109,"context_line":"    cfg.StrOpt(\u0027default_volume_type\u0027,"},{"line_number":110,"context_line":"               default\u003d\"default_vol_type\","},{"line_number":111,"context_line":"               help\u003d\u0027Default volume type to use\u0027),"},{"line_number":112,"context_line":"    cfg.StrOpt(\u0027default_group_type\u0027,"},{"line_number":113,"context_line":"               help\u003d\u0027Default group type to use\u0027),"}],"source_content_type":"text/x-python","patch_set":31,"id":"7faddb67_72e6da18","line":110,"in_reply_to":"7faddb67_4f7777d2","updated":"2019-09-04 19:14:25.000000000","message":"Done","commit_id":"a3ac2032d81a8fa2e195c2b3a0403c4015c91e3c"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0236215c3bbc4e421c6c0547eae3f49e1ee90e98","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                     \u0027default_availability_zone, then \u0027"},{"line_number":108,"context_line":"                     \u0027storage_availability_zone, instead of failing.\u0027),"},{"line_number":109,"context_line":"    cfg.StrOpt(\u0027default_volume_type\u0027,"},{"line_number":110,"context_line":"               default\u003d\"__DEFAULT__\","},{"line_number":111,"context_line":"               help\u003d\u0027Default volume type to use\u0027),"},{"line_number":112,"context_line":"    cfg.StrOpt(\u0027default_group_type\u0027,"},{"line_number":113,"context_line":"               help\u003d\u0027Default group type to use\u0027),"}],"source_content_type":"text/x-python","patch_set":35,"id":"5faad753_c43acf32","line":110,"updated":"2019-09-11 16:35:34.000000000","message":"What happens if this is set to None/empty-string in the config?\n\nI think I would have expected the \"default\" handling of this to be done in code and not here.","commit_id":"9f1376fa218c67bc89a50b8e57f52ca7b8ff114d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0907607a951b7d6110092d00c85125c65c11085b","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                     \u0027default_availability_zone, then \u0027"},{"line_number":108,"context_line":"                     \u0027storage_availability_zone, instead of failing.\u0027),"},{"line_number":109,"context_line":"    cfg.StrOpt(\u0027default_volume_type\u0027,"},{"line_number":110,"context_line":"               default\u003d\"__DEFAULT__\","},{"line_number":111,"context_line":"               help\u003d\u0027Default volume type to use\u0027),"},{"line_number":112,"context_line":"    cfg.StrOpt(\u0027default_group_type\u0027,"},{"line_number":113,"context_line":"               help\u003d\u0027Default group type to use\u0027),"}],"source_content_type":"text/x-python","patch_set":35,"id":"5faad753_cda8948d","line":110,"in_reply_to":"5faad753_c43acf32","updated":"2019-09-12 17:56:15.000000000","message":"Removed the default\nHandled empty-string case in code\nhttps://review.opendev.org/#/c/639180/39/cinder/volume/volume_types.py@177","commit_id":"9f1376fa218c67bc89a50b8e57f52ca7b8ff114d"}],"cinder/db/sqlalchemy/migrate_repo/versions/129_create_default_volume_type.py":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"18a32a332a6ad898da41ba580947f8657077179c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    volumes.c.volume_type_id.alter(nullable\u003dFalse)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    snapshots \u003d Table(\u0027snapshots\u0027, meta, autoload\u003dTrue)"},{"line_number":32,"context_line":"    snapshots.c.volume_type_id.alter(nullable\u003dFalse)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    encryption \u003d Table(\u0027encryption\u0027, meta, autoload\u003dTrue)"},{"line_number":35,"context_line":"    encryption.c.volume_type_id.alter(nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_dba35f42","line":32,"updated":"2019-02-26 14:05:53.000000000","message":"We need add 129 to the exceptions list. :)\n[1] https://github.com/openstack/cinder/blob/8b39e1c/cinder/tests/unit/db/test_migrations.py#L109","commit_id":"cad730c490288b63466beb678e5edd1b6249f5eb"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"4c8407ddae4e1b2feb6a954ba5f327b5a8cbb556","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    volumes.c.volume_type_id.alter(nullable\u003dFalse)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    snapshots \u003d Table(\u0027snapshots\u0027, meta, autoload\u003dTrue)"},{"line_number":32,"context_line":"    snapshots.c.volume_type_id.alter(nullable\u003dFalse)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    encryption \u003d Table(\u0027encryption\u0027, meta, autoload\u003dTrue)"},{"line_number":35,"context_line":"    encryption.c.volume_type_id.alter(nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_c7f4765e","line":32,"in_reply_to":"9fdfeff1_dba35f42","updated":"2019-04-11 17:12:54.000000000","message":"We should not be marking these as nullable\u003dFalse until we make sure we have data in them for all the existing entries that don\u0027t have a volume type set.\n\n1) create the new volume type\n2) migrate data for volumes, snapshots, encryption tables to change Null to new volume type id\n3) alter the tables.","commit_id":"cad730c490288b63466beb678e5edd1b6249f5eb"}],"cinder/exception.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"849e0cff840f2e0f675f6e2c5af8dd026e812133","unresolved":false,"context_lines":[{"line_number":393,"context_line":""},{"line_number":394,"context_line":"class VolumeTypeDefault(CinderException):"},{"line_number":395,"context_line":"    message \u003d _(\"The volume type %(volume_type_name)s \""},{"line_number":396,"context_line":"                \"is default volume type and cannot be deleted.\")"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"class GroupTypeNotFound(NotFound):"}],"source_content_type":"text/x-python","patch_set":39,"id":"3fa7e38b_1574be67","line":396,"updated":"2019-09-19 14:38:55.000000000","message":"is the*","commit_id":"c649d3d607ec16c85605eddcf10a4fa1aacc41f9"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f8659a1a2ff461659cbd1f6e4f5254157d29bfc5","unresolved":false,"context_lines":[{"line_number":393,"context_line":""},{"line_number":394,"context_line":"class VolumeTypeDefault(CinderException):"},{"line_number":395,"context_line":"    message \u003d _(\"The volume type %(volume_type_name)s \""},{"line_number":396,"context_line":"                \"is default volume type and cannot be deleted.\")"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"class GroupTypeNotFound(NotFound):"}],"source_content_type":"text/x-python","patch_set":39,"id":"3fa7e38b_e2b9fce8","line":396,"in_reply_to":"3fa7e38b_1574be67","updated":"2019-09-23 06:10:48.000000000","message":"Done","commit_id":"c649d3d607ec16c85605eddcf10a4fa1aacc41f9"}],"cinder/volume/volume_types.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"4818932f6370d92866c9d2a1dde0b5e97aaee922","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        msg \u003d _(\"id cannot be None\")"},{"line_number":105,"context_line":"        raise exception.InvalidVolumeType(reason\u003dmsg)"},{"line_number":106,"context_line":"    vol_type \u003d get_volume_type(context, id)"},{"line_number":107,"context_line":"    if vol_type[\u0027name\u0027] \u003d\u003d DEFAULT_VOLUME_TYPE:"},{"line_number":108,"context_line":"        raise exception.VolumeTypeDefault(vol_type[\u0027name\u0027])"},{"line_number":109,"context_line":"    elevated \u003d context if context.is_admin else context.elevated()"},{"line_number":110,"context_line":"    return db.volume_type_destroy(elevated, id)"}],"source_content_type":"text/x-python","patch_set":35,"id":"5faad753_3b9c415c","line":107,"updated":"2019-09-10 15:14:45.000000000","message":"Should we check here for CONF.default_volume_type too?","commit_id":"9f1376fa218c67bc89a50b8e57f52ca7b8ff114d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5e1e5419f9c46de6f8b0a158cd1417dea27d029b","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        msg \u003d _(\"id cannot be None\")"},{"line_number":105,"context_line":"        raise exception.InvalidVolumeType(reason\u003dmsg)"},{"line_number":106,"context_line":"    vol_type \u003d get_volume_type(context, id)"},{"line_number":107,"context_line":"    if vol_type[\u0027name\u0027] \u003d\u003d DEFAULT_VOLUME_TYPE:"},{"line_number":108,"context_line":"        raise exception.VolumeTypeDefault(vol_type[\u0027name\u0027])"},{"line_number":109,"context_line":"    elevated \u003d context if context.is_admin else context.elevated()"},{"line_number":110,"context_line":"    return db.volume_type_destroy(elevated, id)"}],"source_content_type":"text/x-python","patch_set":35,"id":"5faad753_295aaaf2","line":107,"in_reply_to":"5faad753_3b9c415c","updated":"2019-09-11 06:37:00.000000000","message":"No. Default type could be set to any volume type and the purpose of this feature is that the specific type \u0027__DEFAULT__\u0027 created during db migration should exist at all time to avoid untyped volumes and snapshots.\nThat could be discussed and done additionally but IMO not important for this patch.","commit_id":"9f1376fa218c67bc89a50b8e57f52ca7b8ff114d"}],"releasenotes/notes/untyped_to_default_type-0068e6bc8000986c.yaml":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"8814848103407c94d78a2339d9fb4ea4b90aa42b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added a new default volume type ``__DEFAULT__`` used"},{"line_number":5,"context_line":"    when a new volume created without any type will be"},{"line_number":6,"context_line":"    assigned the ``__DEFAULT__`` type."},{"line_number":7,"context_line":"    All existing volume, snapshots without a type will"},{"line_number":8,"context_line":"    be migrated to the ``__DEFAULT__`` type."}],"source_content_type":"text/x-yaml","patch_set":39,"id":"3fa7e38b_f5680288","line":6,"range":{"start_line":4,"start_character":0,"end_line":6,"end_character":38},"updated":"2019-09-19 14:41:44.000000000","message":"The wording is also confusing.  Suggest:      Added a new default volume type ``__DEFAULT__`` which will be used\n    when a new volume is created without any type.  The volume will be\n    assigned the ``__DEFAULT__`` type.","commit_id":"c649d3d607ec16c85605eddcf10a4fa1aacc41f9"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ec5559a9ad75681823e6db2462a810d49caabc25","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added a new default volume type ``__DEFAULT__`` used"},{"line_number":5,"context_line":"    when a new volume created without any type will be"},{"line_number":6,"context_line":"    assigned the ``__DEFAULT__`` type."},{"line_number":7,"context_line":"    All existing volume, snapshots without a type will"},{"line_number":8,"context_line":"    be migrated to the ``__DEFAULT__`` type."}],"source_content_type":"text/x-yaml","patch_set":39,"id":"3fa7e38b_35d8da7d","line":6,"updated":"2019-09-19 14:35:30.000000000","message":"This is kind of ambiguous, any volume created without any type inside of Cinder ends up as __DEFAULT__.  But from an API point of view, a volume created w/o a type gets the default type assigned in config, or __DEFAULT__ if one isn\u0027t assigned.","commit_id":"c649d3d607ec16c85605eddcf10a4fa1aacc41f9"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f8659a1a2ff461659cbd1f6e4f5254157d29bfc5","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added a new default volume type ``__DEFAULT__`` used"},{"line_number":5,"context_line":"    when a new volume created without any type will be"},{"line_number":6,"context_line":"    assigned the ``__DEFAULT__`` type."},{"line_number":7,"context_line":"    All existing volume, snapshots without a type will"},{"line_number":8,"context_line":"    be migrated to the ``__DEFAULT__`` type."}],"source_content_type":"text/x-yaml","patch_set":39,"id":"3fa7e38b_82e7e812","line":6,"in_reply_to":"3fa7e38b_35d8da7d","updated":"2019-09-23 06:10:48.000000000","message":"Done","commit_id":"c649d3d607ec16c85605eddcf10a4fa1aacc41f9"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f8659a1a2ff461659cbd1f6e4f5254157d29bfc5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added a new default volume type ``__DEFAULT__`` used"},{"line_number":5,"context_line":"    when a new volume created without any type will be"},{"line_number":6,"context_line":"    assigned the ``__DEFAULT__`` type."},{"line_number":7,"context_line":"    All existing volume, snapshots without a type will"},{"line_number":8,"context_line":"    be migrated to the ``__DEFAULT__`` type."}],"source_content_type":"text/x-yaml","patch_set":39,"id":"3fa7e38b_42f1f0cc","line":6,"range":{"start_line":4,"start_character":0,"end_line":6,"end_character":38},"in_reply_to":"3fa7e38b_f5680288","updated":"2019-09-23 06:10:48.000000000","message":"Done","commit_id":"c649d3d607ec16c85605eddcf10a4fa1aacc41f9"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"01eab7541d5fe0e1df9abbd1ca2091cbf6066d9d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added a new default volume type ``__DEFAULT__`` which"},{"line_number":5,"context_line":"    will be used when"},{"line_number":6,"context_line":"    - A new volume is created without any type"},{"line_number":7,"context_line":"    - The `default_volume_type` option is unset in cinder.conf"},{"line_number":8,"context_line":"    The volume will be assigned the ``__DEFAULT__`` type."}],"source_content_type":"text/x-yaml","patch_set":41,"id":"3fa7e38b_f848922d","line":5,"updated":"2019-09-25 16:00:33.000000000","message":"need a blank line here","commit_id":"a550ade303c839abc285d6926dc02a15b5c73ff0"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"01eab7541d5fe0e1df9abbd1ca2091cbf6066d9d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Added a new default volume type ``__DEFAULT__`` which"},{"line_number":5,"context_line":"    will be used when"},{"line_number":6,"context_line":"    - A new volume is created without any type"},{"line_number":7,"context_line":"    - The `default_volume_type` option is unset in cinder.conf"},{"line_number":8,"context_line":"    The volume will be assigned the ``__DEFAULT__`` type."},{"line_number":9,"context_line":"    All existing volume, snapshots without a type will"},{"line_number":10,"context_line":"    be migrated to the ``__DEFAULT__`` type."}],"source_content_type":"text/x-yaml","patch_set":41,"id":"3fa7e38b_98515edc","line":7,"updated":"2019-09-25 16:00:33.000000000","message":"need a blank line here","commit_id":"a550ade303c839abc285d6926dc02a15b5c73ff0"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"01eab7541d5fe0e1df9abbd1ca2091cbf6066d9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"3fa7e38b_1857aecc","line":11,"updated":"2019-09-25 16:00:33.000000000","message":"I really think a database migration also needs to be mentioned in the \"upgrade\" section.","commit_id":"a550ade303c839abc285d6926dc02a15b5c73ff0"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b94169d3fe87feac8c625e5ede95c965b750e7fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"3fa7e38b_58320612","line":11,"in_reply_to":"3fa7e38b_1857aecc","updated":"2019-09-25 16:29:43.000000000","message":"agreed","commit_id":"a550ade303c839abc285d6926dc02a15b5c73ff0"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9269510e23facea2bf4d34be41b3e9e22a4e84df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"3fa7e38b_133a2fcb","line":11,"in_reply_to":"3fa7e38b_58320612","updated":"2019-09-25 16:33:26.000000000","message":"Be sure to mention the impact this change has on the current CONF.default_type (no change, but you need to point that out)","commit_id":"a550ade303c839abc285d6926dc02a15b5c73ff0"}]}