)]}'
{"cinder/tests/unit/volume/drivers/dell_emc/vnx/test_utils.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"aa9bd870f355982020f66ee184f20824ddc79455","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        async_migrate, provision \u003d vnx_utils.calc_migrate_and_provision("},{"line_number":213,"context_line":"            volume, default_async_migrate\u003dFalse)"},{"line_number":214,"context_line":"        self.assertFalse(async_migrate)"},{"line_number":215,"context_line":"        self.assertEqual(provision.name, \u0027THICK\u0027)"},{"line_number":216,"context_line":"        async_migrate, provision \u003d vnx_utils.calc_migrate_and_provision("},{"line_number":217,"context_line":"            volume, default_async_migrate\u003dTrue)"},{"line_number":218,"context_line":"        self.assertTrue(async_migrate)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_cdb6048b","line":215,"range":{"start_line":215,"start_character":25,"end_line":215,"end_character":48},"updated":"2019-05-30 14:21:00.000000000","message":"assertEqual argument order should be (EXPECTED_VALUE, ACTUAL_VALUE).","commit_id":"3ecdc2bfc827c5ae8003f877bd95ca8c1385c596"}],"cinder/volume/drivers/dell_emc/vnx/common.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"79b1ed0f417c84a55f7f28558f77526bbe08109c","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                \u0027By default, the value is False.\u0027),"},{"line_number":113,"context_line":"    cfg.BoolOpt(\u0027vnx_async_migrate\u0027,"},{"line_number":114,"context_line":"                default\u003dTrue,"},{"line_number":115,"context_line":"                help\u003d\u0027Always use asynchronous migration during volume cloning.\u0027"},{"line_number":116,"context_line":"                     \u0027As described in configuration doc, async migration has \u0027"},{"line_number":117,"context_line":"                     \u0027some constraints. Besides using metadata, customers\u0027"},{"line_number":118,"context_line":"                     \u0027could use this option to disable async migration. Be \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_85d976f5","line":115,"range":{"start_line":115,"start_character":63,"end_line":115,"end_character":77},"updated":"2019-03-20 15:49:02.000000000","message":"In other patch we discussed that async migration is also used create volume from snapshot right?\nmaybe that also needs to be mentioned here.","commit_id":"6fca9c6584dd3ab0e7d33ad2ad513a9e719853c0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"79b1ed0f417c84a55f7f28558f77526bbe08109c","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                default\u003dTrue,"},{"line_number":115,"context_line":"                help\u003d\u0027Always use asynchronous migration during volume cloning.\u0027"},{"line_number":116,"context_line":"                     \u0027As described in configuration doc, async migration has \u0027"},{"line_number":117,"context_line":"                     \u0027some constraints. Besides using metadata, customers\u0027"},{"line_number":118,"context_line":"                     \u0027could use this option to disable async migration. Be \u0027"},{"line_number":119,"context_line":"                     \u0027aware that `async_migrate` in metadata overrides this\u0027"},{"line_number":120,"context_line":"                     \u0027option when both are set. By default, the value is True.\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_85541656","line":117,"range":{"start_line":117,"start_character":73,"end_line":117,"end_character":74},"updated":"2019-03-20 15:49:02.000000000","message":"space here","commit_id":"6fca9c6584dd3ab0e7d33ad2ad513a9e719853c0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"79b1ed0f417c84a55f7f28558f77526bbe08109c","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                     \u0027As described in configuration doc, async migration has \u0027"},{"line_number":117,"context_line":"                     \u0027some constraints. Besides using metadata, customers\u0027"},{"line_number":118,"context_line":"                     \u0027could use this option to disable async migration. Be \u0027"},{"line_number":119,"context_line":"                     \u0027aware that `async_migrate` in metadata overrides this\u0027"},{"line_number":120,"context_line":"                     \u0027option when both are set. By default, the value is True.\u0027"},{"line_number":121,"context_line":"                )"},{"line_number":122,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_a5511265","line":119,"range":{"start_line":119,"start_character":75,"end_line":119,"end_character":76},"updated":"2019-03-20 15:49:02.000000000","message":"space here","commit_id":"6fca9c6584dd3ab0e7d33ad2ad513a9e719853c0"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"9c7d0e04e118179b941b55db02ed53d2be5e9306","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                default\u003dTrue,"},{"line_number":115,"context_line":"                help\u003d\u0027Always use asynchronous migration during volume cloning \u0027"},{"line_number":116,"context_line":"                     \u0027and creating from snapshot. As described in \u0027"},{"line_number":117,"context_line":"                     \u0027configuration doc, async migration has some \u0027"},{"line_number":118,"context_line":"                     \u0027constraints. Besides using metadata, customers could \u0027"},{"line_number":119,"context_line":"                     \u0027use this option to disable async migration. Be aware \u0027"},{"line_number":120,"context_line":"                     \u0027that `async_migrate` in metadata overrides this \u0027"},{"line_number":121,"context_line":"                     \u0027option when both are set. By default, the value is True.\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"5fc1f717_bde78fe3","line":118,"range":{"start_line":117,"start_character":41,"end_line":118,"end_character":33},"updated":"2019-04-05 14:15:04.000000000","message":"I\u0027m not sure the configuration doc actually explains what these constraints are.","commit_id":"3cdb52b2183febe81a2ae8671afb0b08d5c80e13"},{"author":{"_account_id":18742,"name":"Ryan Liang","email":"ryan.liang@emc.com","username":"RyanLiang"},"change_message_id":"114f939a78448127911150007e4418fcf2ba4df7","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                default\u003dTrue,"},{"line_number":115,"context_line":"                help\u003d\u0027Always use asynchronous migration during volume cloning \u0027"},{"line_number":116,"context_line":"                     \u0027and creating from snapshot. As described in \u0027"},{"line_number":117,"context_line":"                     \u0027configuration doc, async migration has some \u0027"},{"line_number":118,"context_line":"                     \u0027constraints. Besides using metadata, customers could \u0027"},{"line_number":119,"context_line":"                     \u0027use this option to disable async migration. Be aware \u0027"},{"line_number":120,"context_line":"                     \u0027that `async_migrate` in metadata overrides this \u0027"},{"line_number":121,"context_line":"                     \u0027option when both are set. By default, the value is True.\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"5fc1f717_c552ac67","line":118,"range":{"start_line":117,"start_character":41,"end_line":118,"end_character":33},"in_reply_to":"5fc1f717_bde78fe3","updated":"2019-04-08 02:23:57.000000000","message":"The constraints list in the Unity driver\u0027s config doc. Please refer to https://github.com/openstack/cinder/blob/master/doc/source/configuration/block-storage/drivers/dell-emc-vnx-driver.rst#asynchronous-migration-support","commit_id":"3cdb52b2183febe81a2ae8671afb0b08d5c80e13"}],"cinder/volume/drivers/dell_emc/vnx/utils.py":[{"author":{"_account_id":27406,"name":"Hao Sun","email":"hao.sun@emc.com"},"change_message_id":"371a303216377cb28922c67a9228929151018039","unresolved":false,"context_lines":[{"line_number":267,"context_line":"    meta \u003d get_metadata(volume)"},{"line_number":268,"context_line":"    if \u0027async_migrate\u0027 not in meta:"},{"line_number":269,"context_line":"        return default"},{"line_number":270,"context_line":"    return \u0027async_migrate\u0027 in meta and meta[\u0027async_migrate\u0027].lower() \u003d\u003d \u0027true\u0027"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"def get_migration_rate(volume):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_730aa1d2","line":270,"updated":"2019-02-26 09:43:56.000000000","message":"\u0027async_migrate\u0027 in meta is not necessary.","commit_id":"e1e3bfec1b22d4ee521abeba9f4c4b09aa5094ed"}],"doc/source/configuration/block-storage/drivers/dell-emc-vnx-driver.rst":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"79b1ed0f417c84a55f7f28558f77526bbe08109c","unresolved":false,"context_lines":[{"line_number":438,"context_line":""},{"line_number":439,"context_line":"Option ``vnx_async_migrate`` is used to set the default value of async"},{"line_number":440,"context_line":"migration for the backend. Default value is `True`. If ``async_migrate`` is not"},{"line_number":441,"context_line":"set in metadata of volume, the value of this option will be used. Otherwise,"},{"line_number":442,"context_line":"``async_migrate`` value in metadata will override the value of this option."},{"line_number":443,"context_line":"For more detail, refer to `asynchronous migration support`_."},{"line_number":444,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5fc1f717_2ee3baa6","line":441,"range":{"start_line":441,"start_character":31,"end_line":441,"end_character":36},"updated":"2019-03-20 15:49:02.000000000","message":"default value","commit_id":"6fca9c6584dd3ab0e7d33ad2ad513a9e719853c0"},{"author":{"_account_id":18742,"name":"Ryan Liang","email":"ryan.liang@emc.com","username":"RyanLiang"},"change_message_id":"f86df20766c049cec0800a65446cc2acb1c83908","unresolved":false,"context_lines":[{"line_number":438,"context_line":""},{"line_number":439,"context_line":"Option ``vnx_async_migrate`` is used to set the default value of async"},{"line_number":440,"context_line":"migration for the backend. Default value is `True`. If ``async_migrate`` is not"},{"line_number":441,"context_line":"set in metadata of volume, the value of this option will be used. Otherwise,"},{"line_number":442,"context_line":"``async_migrate`` value in metadata will override the value of this option."},{"line_number":443,"context_line":"For more detail, refer to `asynchronous migration support`_."},{"line_number":444,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5fc1f717_e8cfdc26","line":441,"range":{"start_line":441,"start_character":31,"end_line":441,"end_character":36},"in_reply_to":"5fc1f717_2ee3baa6","updated":"2019-03-21 02:29:22.000000000","message":"Thanks for the comments. The default value of option `vnx_async_migrate` is `True` if customers don\u0027t set it in cinder.conf. But customers could set it to `False`. If `async_migrate` is not set, VNX driver will use the value of option `vnx_async_migrate` which could be `True` or `False` (NOT the default value of the option). Otherwise, use the value of `async_migrate`.\n\nI\u0027ll reword this part if it leads misunderstanding.","commit_id":"6fca9c6584dd3ab0e7d33ad2ad513a9e719853c0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"79b1ed0f417c84a55f7f28558f77526bbe08109c","unresolved":false,"context_lines":[{"line_number":439,"context_line":"Option ``vnx_async_migrate`` is used to set the default value of async"},{"line_number":440,"context_line":"migration for the backend. Default value is `True`. If ``async_migrate`` is not"},{"line_number":441,"context_line":"set in metadata of volume, the value of this option will be used. Otherwise,"},{"line_number":442,"context_line":"``async_migrate`` value in metadata will override the value of this option."},{"line_number":443,"context_line":"For more detail, refer to `asynchronous migration support`_."},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"Extra spec options"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5fc1f717_0ef4be5a","line":442,"range":{"start_line":442,"start_character":54,"end_line":442,"end_character":59},"updated":"2019-03-20 15:49:02.000000000","message":"default value","commit_id":"6fca9c6584dd3ab0e7d33ad2ad513a9e719853c0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"79b1ed0f417c84a55f7f28558f77526bbe08109c","unresolved":false,"context_lines":[{"line_number":803,"context_line":"To disable this feature, user needs to do any one of below actions:"},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"- Configure ``vnx_async_migrate \u003d False`` for the backend in ``cinder.conf``,"},{"line_number":806,"context_line":"  then restart Cinder driver."},{"line_number":807,"context_line":"- Add ``--metadata async_migrate\u003dFalse`` when creating new volume from source."},{"line_number":808,"context_line":""},{"line_number":809,"context_line":"Be aware, ``async_migrate`` in metadata overrides the option"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5fc1f717_8e842eb3","line":806,"range":{"start_line":806,"start_character":15,"end_line":806,"end_character":28},"updated":"2019-03-20 15:49:02.000000000","message":"do you mean cinder services (c-vol to be precise) ?","commit_id":"6fca9c6584dd3ab0e7d33ad2ad513a9e719853c0"},{"author":{"_account_id":18742,"name":"Ryan Liang","email":"ryan.liang@emc.com","username":"RyanLiang"},"change_message_id":"f86df20766c049cec0800a65446cc2acb1c83908","unresolved":false,"context_lines":[{"line_number":803,"context_line":"To disable this feature, user needs to do any one of below actions:"},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"- Configure ``vnx_async_migrate \u003d False`` for the backend in ``cinder.conf``,"},{"line_number":806,"context_line":"  then restart Cinder driver."},{"line_number":807,"context_line":"- Add ``--metadata async_migrate\u003dFalse`` when creating new volume from source."},{"line_number":808,"context_line":""},{"line_number":809,"context_line":"Be aware, ``async_migrate`` in metadata overrides the option"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5fc1f717_a8d9d4f4","line":806,"range":{"start_line":806,"start_character":15,"end_line":806,"end_character":28},"in_reply_to":"5fc1f717_8e842eb3","updated":"2019-03-21 02:29:22.000000000","message":"Yes, change it to `Cinder services`.","commit_id":"6fca9c6584dd3ab0e7d33ad2ad513a9e719853c0"}]}
