)]}'
{"cinder/api/contrib/quota_classes.py":[{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"9938d14c526d6b3755707dff7e19ce1ccc73e6f1","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        quota_class \u003d id"},{"line_number":71,"context_line":"        if not self.is_valid_body(body, \u0027quota_class_set\u0027):"},{"line_number":72,"context_line":"            msg \u003d (_(\"Missing required element quota_class_set\""},{"line_number":73,"context_line":"                     \" in request body.\"))"},{"line_number":74,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        for key in body[\u0027quota_class_set\u0027].keys():"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAT3%2F%2F9VY%3D","line":73,"updated":"2013-12-26 10:02:16.000000000","message":"msg \u003d _(\"Missing required element quota_class_set \"\n\t\t\"in request body.\")\n\nWe always use above to split a long sentence, also no need to add () for msg","commit_id":"2231dfadb2f15e9f38792bca4ed3b1660829658a"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"64960f6d8d82c117171e15b9693b18cd6a18a31f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        quota_class \u003d id"},{"line_number":71,"context_line":"        if not self.is_valid_body(body, \u0027quota_class_set\u0027):"},{"line_number":72,"context_line":"            msg \u003d (_(\"Missing required element quota_class_set\""},{"line_number":73,"context_line":"                     \" in request body.\"))"},{"line_number":74,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        for key in body[\u0027quota_class_set\u0027].keys():"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2B%2Btw%3D","line":73,"in_reply_to":"AAAAT3%2F%2F6nI%3D","updated":"2014-01-20 06:28:00.000000000","message":"What next patch?  Why would you submit a follow up patch to fix something that somebody points out as being a problem with your current patched code?\n\nUnless I\u0027m misunderstanding the discussion here?","commit_id":"2231dfadb2f15e9f38792bca4ed3b1660829658a"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"64960f6d8d82c117171e15b9693b18cd6a18a31f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        quota_class \u003d id"},{"line_number":71,"context_line":"        if not self.is_valid_body(body, \u0027quota_class_set\u0027):"},{"line_number":72,"context_line":"            msg \u003d (_(\"Missing required element quota_class_set\""},{"line_number":73,"context_line":"                     \" in request body.\"))"},{"line_number":74,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        for key in body[\u0027quota_class_set\u0027].keys():"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2B%2Bt4%3D","line":73,"in_reply_to":"AAAAT3%2F%2F9VY%3D","updated":"2014-01-20 06:28:00.000000000","message":"Jay,\nSorry, not following what you\u0027re pointing to here?","commit_id":"2231dfadb2f15e9f38792bca4ed3b1660829658a"},{"author":{"_account_id":8874,"name":"ling-yun","email":"YunlingZeng@hotmail.com","username":"ling-yun"},"change_message_id":"4025010654c60fe695764bd03f3b5d5c2c271fd7","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        quota_class \u003d id"},{"line_number":71,"context_line":"        if not self.is_valid_body(body, \u0027quota_class_set\u0027):"},{"line_number":72,"context_line":"            msg \u003d (_(\"Missing required element quota_class_set\""},{"line_number":73,"context_line":"                     \" in request body.\"))"},{"line_number":74,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        for key in body[\u0027quota_class_set\u0027].keys():"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAT3%2F%2F6nI%3D","line":73,"in_reply_to":"AAAAT3%2F%2F9VY%3D","updated":"2013-12-27 07:45:25.000000000","message":"Modify it in next patch.","commit_id":"2231dfadb2f15e9f38792bca4ed3b1660829658a"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"71becdf843fd06c9d318871bb15d0a5a51a60013","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        quota_class \u003d id"},{"line_number":71,"context_line":"        if not self.is_valid_body(body, \u0027quota_class_set\u0027):"},{"line_number":72,"context_line":"            msg \u003d (_(\"Missing required element quota_class_set\""},{"line_number":73,"context_line":"                     \" in request body.\"))"},{"line_number":74,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        for key in body[\u0027quota_class_set\u0027].keys():"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BZHU%3D","line":73,"in_reply_to":"AAAAUH%2F%2B%2Bt4%3D","updated":"2014-01-27 12:40:52.000000000","message":"I think he meant next patch set, for the same patch :)\n\nWhat I understood from \u0027always use above to split long sentence\u0027 is keep the space character at the end of string while breaking it into parts, and not at the start of it.","commit_id":"2231dfadb2f15e9f38792bca4ed3b1660829658a"}],"cinder/api/contrib/quotas.py":[{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"9938d14c526d6b3755707dff7e19ce1ccc73e6f1","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        authorize_update(context)"},{"line_number":98,"context_line":"        project_id \u003d id"},{"line_number":99,"context_line":"        if not self.is_valid_body(body, \u0027quota_set\u0027):"},{"line_number":100,"context_line":"            msg \u003d (_(\"Missing required element quota_set in request body.\"))"},{"line_number":101,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        for key in body[\u0027quota_set\u0027].keys():"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAT3%2F%2F9VM%3D","line":100,"updated":"2013-12-26 10:02:16.000000000","message":"No need to add () around msg","commit_id":"2231dfadb2f15e9f38792bca4ed3b1660829658a"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"64960f6d8d82c117171e15b9693b18cd6a18a31f","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        authorize_update(context)"},{"line_number":98,"context_line":"        project_id \u003d id"},{"line_number":99,"context_line":"        if not self.is_valid_body(body, \u0027quota_set\u0027):"},{"line_number":100,"context_line":"            msg \u003d (_(\"Missing required element quota_set in request body.\"))"},{"line_number":101,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        for key in body[\u0027quota_set\u0027].keys():"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2B%2Btg%3D","line":100,"in_reply_to":"AAAAT3%2F%2F6nE%3D","updated":"2014-01-20 06:28:00.000000000","message":"Again, what next patch?  And again... if you submit a patch and a reviewer suggests something is not correct with the code you\u0027re modifying it\u0027s not appropriate to submit anyway and submit another patch to fix the issue that you just introduced.","commit_id":"2231dfadb2f15e9f38792bca4ed3b1660829658a"},{"author":{"_account_id":8874,"name":"ling-yun","email":"YunlingZeng@hotmail.com","username":"ling-yun"},"change_message_id":"4025010654c60fe695764bd03f3b5d5c2c271fd7","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        authorize_update(context)"},{"line_number":98,"context_line":"        project_id \u003d id"},{"line_number":99,"context_line":"        if not self.is_valid_body(body, \u0027quota_set\u0027):"},{"line_number":100,"context_line":"            msg \u003d (_(\"Missing required element quota_set in request body.\"))"},{"line_number":101,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        for key in body[\u0027quota_set\u0027].keys():"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAT3%2F%2F6nE%3D","line":100,"in_reply_to":"AAAAT3%2F%2F9VM%3D","updated":"2013-12-27 07:45:25.000000000","message":"Modify it in next patch.","commit_id":"2231dfadb2f15e9f38792bca4ed3b1660829658a"}]}