)]}'
{"cinder/tests/unit/volume/drivers/dell_emc/powermax/powermax_data.py":[{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"dd31804679b3d2e41c3b13a84984d2ffdae1bd65","unresolved":false,"context_lines":[{"line_number":999,"context_line":"    openstack_release \u003d \u002712.0.0.0b3.dev401\u0027"},{"line_number":1000,"context_line":"    openstack_version \u003d \u002712.0.0\u0027"},{"line_number":1001,"context_line":"    python_version \u003d \u00272.7.12\u0027"},{"line_number":1002,"context_line":"    vmax_driver_version \u003d \u00274.0\u0027"},{"line_number":1003,"context_line":"    vmax_firmware_version \u003d u\u00275977.1125.1125\u0027"},{"line_number":1004,"context_line":"    vmax_model \u003d u\u0027VMAX250F\u0027"},{"line_number":1005,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bfb3d3c7_de0605cf","line":1002,"range":{"start_line":1002,"start_character":29,"end_line":1002,"end_character":30},"updated":"2019-05-24 08:26:02.000000000","message":"This is a test file so has no effect on the driver, but the vmax driver version if reflecting the release should be 4.1","commit_id":"210fb8e23ee55b983028fa2ea7d15932165ee47b"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"0e017e21e713192d08a9c108d9ba80dc51ab5d7b","unresolved":false,"context_lines":[{"line_number":999,"context_line":"    openstack_release \u003d \u002712.0.0.0b3.dev401\u0027"},{"line_number":1000,"context_line":"    openstack_version \u003d \u002712.0.0\u0027"},{"line_number":1001,"context_line":"    python_version \u003d \u00272.7.12\u0027"},{"line_number":1002,"context_line":"    vmax_driver_version \u003d \u00274.0\u0027"},{"line_number":1003,"context_line":"    vmax_firmware_version \u003d u\u00275977.1125.1125\u0027"},{"line_number":1004,"context_line":"    vmax_model \u003d u\u0027VMAX250F\u0027"},{"line_number":1005,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bfb3d3c7_9ecd9086","line":1002,"range":{"start_line":1002,"start_character":29,"end_line":1002,"end_character":30},"in_reply_to":"bfb3d3c7_de0605cf","updated":"2019-05-30 15:54:09.000000000","message":"Sure, I\u0027ll update","commit_id":"210fb8e23ee55b983028fa2ea7d15932165ee47b"}],"cinder/tests/unit/volume/drivers/dell_emc/powermax/test_powermax_metadata.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"dd8992f859c587a9ff7e3ae5e39e583625e0eb71","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        super(PowerMaxVolumeMetadataNoDebugTest, self).setUp()"},{"line_number":33,"context_line":"        is_debug \u003d False"},{"line_number":34,"context_line":"        self.volume_metadata \u003d metadata.PowerMaxVolumeMetadata("},{"line_number":35,"context_line":"            rest.PowerMaxRest, \u00274.0\u0027, is_debug)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @mock.patch.object("},{"line_number":38,"context_line":"        metadata.PowerMaxVolumeMetadata, \u0027_fill_volume_trace_dict\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fb8cfa7_535fe771","line":35,"range":{"start_line":35,"start_character":32,"end_line":35,"end_character":35},"updated":"2019-06-17 13:23:34.000000000","message":"4.1?","commit_id":"e57c46042dbda4f43948e6672b047f22cc65276c"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"d91aec8bea71b16159f094cc674b65cce8d4ecf4","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        super(PowerMaxVolumeMetadataNoDebugTest, self).setUp()"},{"line_number":33,"context_line":"        is_debug \u003d False"},{"line_number":34,"context_line":"        self.volume_metadata \u003d metadata.PowerMaxVolumeMetadata("},{"line_number":35,"context_line":"            rest.PowerMaxRest, \u00274.0\u0027, is_debug)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @mock.patch.object("},{"line_number":38,"context_line":"        metadata.PowerMaxVolumeMetadata, \u0027_fill_volume_trace_dict\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fb8cfa7_c68c7781","line":35,"range":{"start_line":35,"start_character":32,"end_line":35,"end_character":35},"in_reply_to":"9fb8cfa7_535fe771","updated":"2019-06-17 13:33:30.000000000","message":"Sure.  I will make sure it gets added to https://review.opendev.org/#/c/664860/1","commit_id":"e57c46042dbda4f43948e6672b047f22cc65276c"}],"cinder/tests/unit/volume/drivers/dell_emc/powermax/test_powermax_replication.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"721ef497a64be754d173a52f66f39b365cfaa5c5","unresolved":false,"context_lines":[{"line_number":1014,"context_line":"        super(PowerMaxReplicationDebugTest, self).setUp()"},{"line_number":1015,"context_line":"        mock_logging \u003d self.mock_object(common, \u0027LOG\u0027)"},{"line_number":1016,"context_line":"        mock_log \u003d mock.Mock()"},{"line_number":1017,"context_line":"        mock_log.isEnabledFor \u003d lambda x: True"},{"line_number":1018,"context_line":"        mock_logging.getLogger \u003d mock.Mock(return_value\u003dmock_log)"},{"line_number":1019,"context_line":"        self.replication_device \u003d {"},{"line_number":1020,"context_line":"            \u0027target_device_id\u0027: self.data.remote_array,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bfb3d3c7_10bffdfb","line":1017,"updated":"2019-05-20 17:40:17.000000000","message":"This will fail w/ an update to hacking, would be better to not add new lambdas here.\n    https://review.opendev.org/#/c/652703/","commit_id":"210fb8e23ee55b983028fa2ea7d15932165ee47b"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"5f9666687f78c12af0f4c4708ea0b873733b933d","unresolved":false,"context_lines":[{"line_number":1014,"context_line":"        super(PowerMaxReplicationDebugTest, self).setUp()"},{"line_number":1015,"context_line":"        mock_logging \u003d self.mock_object(common, \u0027LOG\u0027)"},{"line_number":1016,"context_line":"        mock_log \u003d mock.Mock()"},{"line_number":1017,"context_line":"        mock_log.isEnabledFor \u003d lambda x: True"},{"line_number":1018,"context_line":"        mock_logging.getLogger \u003d mock.Mock(return_value\u003dmock_log)"},{"line_number":1019,"context_line":"        self.replication_device \u003d {"},{"line_number":1020,"context_line":"            \u0027target_device_id\u0027: self.data.remote_array,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bfb3d3c7_f0d7c922","line":1017,"in_reply_to":"bfb3d3c7_10bffdfb","updated":"2019-05-20 17:44:59.000000000","message":"Sure.  Thanks","commit_id":"210fb8e23ee55b983028fa2ea7d15932165ee47b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"52cace1a20ce6a80b98fe7f3be24ffbc871e577a","unresolved":false,"context_lines":[{"line_number":1014,"context_line":"        super(PowerMaxReplicationDebugTest, self).setUp()"},{"line_number":1015,"context_line":"        mock_logging \u003d self.mock_object(common, \u0027LOG\u0027)"},{"line_number":1016,"context_line":"        mock_log \u003d mock.Mock()"},{"line_number":1017,"context_line":"        mock_log.isEnabledFor \u003d lambda x: True"},{"line_number":1018,"context_line":"        mock_logging.getLogger \u003d mock.Mock(return_value\u003dmock_log)"},{"line_number":1019,"context_line":"        self.replication_device \u003d {"},{"line_number":1020,"context_line":"            \u0027target_device_id\u0027: self.data.remote_array,"}],"source_content_type":"text/x-python","patch_set":10,"id":"bfb3d3c7_620a6c20","line":1017,"updated":"2019-05-31 13:04:54.000000000","message":"Missed addressing Eric\u0027s comment from last patchset.","commit_id":"c41ad878896d2b9428fe6b1bb27937a437001a20"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"4a707b1f0d378b356d6ba9f679c4af6c5a7b4399","unresolved":false,"context_lines":[{"line_number":1014,"context_line":"        super(PowerMaxReplicationDebugTest, self).setUp()"},{"line_number":1015,"context_line":"        mock_logging \u003d self.mock_object(common, \u0027LOG\u0027)"},{"line_number":1016,"context_line":"        mock_log \u003d mock.Mock()"},{"line_number":1017,"context_line":"        mock_log.isEnabledFor \u003d lambda x: True"},{"line_number":1018,"context_line":"        mock_logging.getLogger \u003d mock.Mock(return_value\u003dmock_log)"},{"line_number":1019,"context_line":"        self.replication_device \u003d {"},{"line_number":1020,"context_line":"            \u0027target_device_id\u0027: self.data.remote_array,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fb8cfa7_2ca2009c","line":1017,"in_reply_to":"bfb3d3c7_620a6c20","updated":"2019-06-03 19:45:33.000000000","message":"Thanks Sean, I will address it","commit_id":"c41ad878896d2b9428fe6b1bb27937a437001a20"}],"cinder/volume/drivers/dell_emc/powermax/common.py":[{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"1f2ec5dbeb29eb3fc53d86289606d33d384aa2f2","unresolved":false,"context_lines":[{"line_number":3325,"context_line":"        :returns: replication_status -- str, replication_driver_data -- dict"},{"line_number":3326,"context_line":"                  rep_info_dict -- dict"},{"line_number":3327,"context_line":"        \"\"\""},{"line_number":3328,"context_line":"        rep_extra_specs \u003d {\u0027rep_mode\u0027: None, \u0027target_array_model\u0027: None}"},{"line_number":3329,"context_line":"        source_name \u003d volume.name"},{"line_number":3330,"context_line":"        LOG.debug(\u0027Starting replication setup \u0027"},{"line_number":3331,"context_line":"                  \u0027for volume: %s.\u0027, source_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fce034c_a0565b29","line":3328,"range":{"start_line":3328,"start_character":8,"end_line":3328,"end_character":72},"updated":"2019-04-19 13:16:56.000000000","message":"This dict is not necessary, rep_extra_specs are set on line 3343 and this dict is never used before that. \n\nOn line 3343 _get_replication_extra_specs will return a dict with more detailed info including \u0027target_array_model\u0027","commit_id":"1ec3af3f6227e979f9f2d442e82889b61622e64b"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"dd8992f859c587a9ff7e3ae5e39e583625e0eb71","unresolved":false,"context_lines":[{"line_number":3310,"context_line":""},{"line_number":3311,"context_line":"        return True, target_slo, target_workload"},{"line_number":3312,"context_line":""},{"line_number":3313,"context_line":"    def setup_volume_replication(self, array, volume, device_id,"},{"line_number":3314,"context_line":"                                 extra_specs, target_device_id\u003dNone):"},{"line_number":3315,"context_line":"        \"\"\"Setup replication for volume, if enabled."},{"line_number":3316,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9fb8cfa7_d34af7aa","line":3313,"range":{"start_line":3313,"start_character":8,"end_line":3313,"end_character":32},"updated":"2019-06-17 13:23:34.000000000","message":"This would be better as: _setup_volume_replication to differentiate from driver interfaces functions.","commit_id":"e57c46042dbda4f43948e6672b047f22cc65276c"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"d91aec8bea71b16159f094cc674b65cce8d4ecf4","unresolved":false,"context_lines":[{"line_number":3310,"context_line":""},{"line_number":3311,"context_line":"        return True, target_slo, target_workload"},{"line_number":3312,"context_line":""},{"line_number":3313,"context_line":"    def setup_volume_replication(self, array, volume, device_id,"},{"line_number":3314,"context_line":"                                 extra_specs, target_device_id\u003dNone):"},{"line_number":3315,"context_line":"        \"\"\"Setup replication for volume, if enabled."},{"line_number":3316,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9fb8cfa7_c64f9732","line":3313,"range":{"start_line":3313,"start_character":8,"end_line":3313,"end_character":32},"in_reply_to":"9fb8cfa7_d34af7aa","updated":"2019-06-17 13:33:30.000000000","message":"Agreed.  Will change it in https://review.opendev.org/#/c/664860.  Thank you for the feedback","commit_id":"e57c46042dbda4f43948e6672b047f22cc65276c"}],"cinder/volume/drivers/dell_emc/powermax/metadata.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"7b57bb256965c76291c58b90a174094333f94efe","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            else:"},{"line_number":42,"context_line":"                pass"},{"line_number":43,"context_line":"        except Exception:"},{"line_number":44,"context_line":"            LOG.warning(traceback.format_exc())"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    return func_wrapper"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_2bf4f586","line":44,"updated":"2019-03-21 13:17:05.000000000","message":"It might be good to keep the logging message you had and just add the traceback to that output for better context.","commit_id":"a38c5bedc9758fc820a62965417b12f6d96c2c03"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"6ced58c7ae2bfca9def1574520b9f46cf64344a6","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            else:"},{"line_number":42,"context_line":"                pass"},{"line_number":43,"context_line":"        except Exception:"},{"line_number":44,"context_line":"            LOG.warning(traceback.format_exc())"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    return func_wrapper"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_14035a44","line":44,"in_reply_to":"5fc1f717_2bf4f586","updated":"2019-03-21 14:59:33.000000000","message":"Sure, I will change it.  Thank you","commit_id":"a38c5bedc9758fc820a62965417b12f6d96c2c03"}]}