)]}'
{"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"991610839cbb9fb012a6e815868a4222b3e6d899","unresolved":false,"context_lines":[{"line_number":622,"context_line":""},{"line_number":623,"context_line":"    updated \u003d 0"},{"line_number":624,"context_line":"    query \u003d model_query(context,"},{"line_number":625,"context_line":"                        models.Volume).filter_by(service_uuid\u003dNone)"},{"line_number":626,"context_line":"    total \u003d query.count()"},{"line_number":627,"context_line":"    vol_refs \u003d query.limit(max_count).all()"},{"line_number":628,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_51fecf38","line":625,"range":{"start_line":625,"start_character":39,"end_line":625,"end_character":48},"updated":"2019-03-21 17:10:28.000000000","message":"Seem like it would be nice to just filter volumes with no host here, but I\u0027m not sure if that\u0027s possible.","commit_id":"9be9758c137de84f68c685dd9c85bd810e91da94"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ce87dc9572bdab7ba16f2e83c0b4d3eeb5228410","unresolved":false,"context_lines":[{"line_number":622,"context_line":""},{"line_number":623,"context_line":"    updated \u003d 0"},{"line_number":624,"context_line":"    query \u003d model_query(context,"},{"line_number":625,"context_line":"                        models.Volume).filter_by(service_uuid\u003dNone)"},{"line_number":626,"context_line":"    total \u003d query.count()"},{"line_number":627,"context_line":"    vol_refs \u003d query.limit(max_count).all()"},{"line_number":628,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_24409f35","line":625,"range":{"start_line":625,"start_character":39,"end_line":625,"end_character":48},"in_reply_to":"5fc1f717_51fecf38","updated":"2019-03-21 17:17:49.000000000","message":"I think you can do it with:\n\n\n  query \u003d query.filter(models.Volume.host.isnot(None))","commit_id":"9be9758c137de84f68c685dd9c85bd810e91da94"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"ad15d15eceaf08cb0afa70919f49d7ce40ff9816","unresolved":false,"context_lines":[{"line_number":622,"context_line":""},{"line_number":623,"context_line":"    updated \u003d 0"},{"line_number":624,"context_line":"    query \u003d model_query(context,"},{"line_number":625,"context_line":"                        models.Volume).filter_by(service_uuid\u003dNone)"},{"line_number":626,"context_line":"    total \u003d query.count()"},{"line_number":627,"context_line":"    vol_refs \u003d query.limit(max_count).all()"},{"line_number":628,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_b14b7385","line":625,"range":{"start_line":625,"start_character":39,"end_line":625,"end_character":48},"in_reply_to":"5fc1f717_51fecf38","updated":"2019-03-21 19:28:34.000000000","message":"If there is no host it could be because the volume is in ERROR state so maybe just filter the volumes not in ERROR state.","commit_id":"9be9758c137de84f68c685dd9c85bd810e91da94"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"37f7dd77e519d56a6e1d90818d7bc3e86b48023a","unresolved":false,"context_lines":[{"line_number":636,"context_line":""},{"line_number":637,"context_line":"    # update our volumes appropriately"},{"line_number":638,"context_line":"    for v in vol_refs:"},{"line_number":639,"context_line":"        if v.host is None:"},{"line_number":640,"context_line":"            continue"},{"line_number":641,"context_line":"        host \u003d v.host.split(\u0027#\u0027)"},{"line_number":642,"context_line":"        v[\u0027service_uuid\u0027] \u003d svc_map[host[0]]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_044fa334","line":639,"updated":"2019-03-21 17:24:59.000000000","message":"This needs to increment \"updated\" or it may never progress if max_count volumes had no host.  (Or adding the right filter to the volume query will do this.)","commit_id":"9be9758c137de84f68c685dd9c85bd810e91da94"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ee0e91f3ac372e1662e66b223feeea7466f3b6ae","unresolved":false,"context_lines":[{"line_number":623,"context_line":"    updated \u003d 0"},{"line_number":624,"context_line":"    query \u003d model_query(context,"},{"line_number":625,"context_line":"                        models.Volume).filter_by(service_uuid\u003dNone).\\"},{"line_number":626,"context_line":"        filter(models.Volume.host.isnot(None))"},{"line_number":627,"context_line":"    total \u003d query.count()"},{"line_number":628,"context_line":"    vol_refs \u003d query.limit(max_count).all()"},{"line_number":629,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_75f6eed9","line":626,"updated":"2019-03-26 11:38:20.000000000","message":"nit:  I would prefer we did like we do in other parts of the file\n\n  query \u003d query.filter(models.Volume.host.isnot(None))","commit_id":"47d2a98fa63fb1bdf122c8a40bd06ea9c1709855"}],"cinder/tests/unit/test_db_api.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e507e44538d23c83cca71b1b808c5fc79d71cdbe","unresolved":false,"context_lines":[{"line_number":515,"context_line":""},{"line_number":516,"context_line":"        # Now get the last one (intentionally setting max \u003e expected)"},{"line_number":517,"context_line":"        total, updated \u003d db.volume_service_uuids_online_data_migration("},{"line_number":518,"context_line":"            self.ctxt, 99)"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"        self.assertEqual(1, total)"},{"line_number":521,"context_line":"        self.assertEqual(1, updated)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_e6c36989","line":518,"range":{"start_line":518,"start_character":23,"end_line":518,"end_character":25},"updated":"2019-04-04 04:43:42.000000000","message":"much better","commit_id":"47d2a98fa63fb1bdf122c8a40bd06ea9c1709855"}]}