)]}'
{"cinder/cmd/status.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4d84d8068985b0b36cc326fcfd2a13011732dfd2","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                WARNING,"},{"line_number":69,"context_line":"                \u0027policy.json file is present. Make sure any changes from the \u0027"},{"line_number":70,"context_line":"                \u0027default policies are present in a policy.yaml file instead.\u0027)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"            return uc.Result(SUCCESS)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    _upgrade_checks \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_3bccc733","line":71,"updated":"2019-03-26 22:41:49.000000000","message":"Agree that this should be only a warning.  I imagine this message could really irritate someone who\u0027s got a heavily customized policy.json that they don\u0027t want to give up, though.  Maybe a bit more info in the message, something like:\n\n  \u0027policy.json file is present. Make sure any changes from the \u0027\n  \u0027default policies are present in a policy.yaml file instead. \u0027\n  \u0027If you really intend to use a policy.json file, make sure \u0027\n  \u0027that its absolute path is set as the value of the \u0027\n  \u0027\\\u0027policy_file\\\u0027 configuration option in the [oslo_policy] \u0027\n  \u0027section of your cinder.conf file.\u0027","commit_id":"da24b1a1c6418752108b18166161e22d6d1a3695"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"55589b5c77270f210a28aeb9e8c9bab4ef6f3467","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                WARNING,"},{"line_number":69,"context_line":"                \u0027policy.json file is present. Make sure any changes from the \u0027"},{"line_number":70,"context_line":"                \u0027default policies are present in a policy.yaml file instead.\u0027)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"            return uc.Result(SUCCESS)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    _upgrade_checks \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_48f21a72","line":71,"in_reply_to":"5fc1f717_3bccc733","updated":"2019-03-27 11:31:53.000000000","message":"Good idea.","commit_id":"da24b1a1c6418752108b18166161e22d6d1a3695"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c3eb42c96c24107502e2018e7cb9f6a6d312b29a","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                \u0027policy.json file is present. Make sure any changes from the \u0027"},{"line_number":70,"context_line":"                \u0027default policies are present in a policy.yaml file instead. \u0027"},{"line_number":71,"context_line":"                \u0027If you really intend to use  a policy.json file, make sure \u0027"},{"line_number":72,"context_line":"                \u0027that its absolute path is set as teh value of the \u0027"},{"line_number":73,"context_line":"                \"\u0027policy_file\u0027 configuration option in the [oslo_policy] \""},{"line_number":74,"context_line":"                \u0027section of your cinder.conf file.\u0027)"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_e932e70f","line":72,"range":{"start_line":72,"start_character":50,"end_line":72,"end_character":53},"updated":"2019-03-27 14:23:24.000000000","message":"typo!","commit_id":"c1c10fb2b6c9da499eadbd3e7a661d9c6535ebfd"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ac8f975a648064bd7a83f00c3e9458ed896b464c","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                \u0027policy.json file is present. Make sure any changes from the \u0027"},{"line_number":70,"context_line":"                \u0027default policies are present in a policy.yaml file instead. \u0027"},{"line_number":71,"context_line":"                \u0027If you really intend to use  a policy.json file, make sure \u0027"},{"line_number":72,"context_line":"                \u0027that its absolute path is set as teh value of the \u0027"},{"line_number":73,"context_line":"                \"\u0027policy_file\u0027 configuration option in the [oslo_policy] \""},{"line_number":74,"context_line":"                \u0027section of your cinder.conf file.\u0027)"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_0c52e113","line":72,"range":{"start_line":72,"start_character":50,"end_line":72,"end_character":53},"in_reply_to":"5fc1f717_e932e70f","updated":"2019-03-27 14:25:55.000000000","message":"Aaaaall the fails.","commit_id":"c1c10fb2b6c9da499eadbd3e7a661d9c6535ebfd"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6e40c6e18a849dcec25ceec73558f4baa0714be7","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                WARNING,"},{"line_number":69,"context_line":"                \u0027policy.json file is present. Make sure any changes from the \u0027"},{"line_number":70,"context_line":"                \u0027default policies are present in a policy.yaml file instead. \u0027"},{"line_number":71,"context_line":"                \u0027If you really intend to use  a policy.json file, make sure \u0027"},{"line_number":72,"context_line":"                \u0027that its absolute path is set as the value of the \u0027"},{"line_number":73,"context_line":"                \"\u0027policy_file\u0027 configuration option in the [oslo_policy] \""},{"line_number":74,"context_line":"                \u0027section of your cinder.conf file.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_ec2f553c","line":71,"range":{"start_line":71,"start_character":45,"end_line":71,"end_character":46},"updated":"2019-03-27 14:36:36.000000000","message":"extra space in here, too","commit_id":"7b4b4192a8e2342546bbc107597a9285ed0ccda6"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6e23e94c999ac452dc6a82c42449b7113eb4a4dc","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                WARNING,"},{"line_number":69,"context_line":"                \u0027policy.json file is present. Make sure any changes from the \u0027"},{"line_number":70,"context_line":"                \u0027default policies are present in a policy.yaml file instead. \u0027"},{"line_number":71,"context_line":"                \u0027If you really intend to use  a policy.json file, make sure \u0027"},{"line_number":72,"context_line":"                \u0027that its absolute path is set as the value of the \u0027"},{"line_number":73,"context_line":"                \"\u0027policy_file\u0027 configuration option in the [oslo_policy] \""},{"line_number":74,"context_line":"                \u0027section of your cinder.conf file.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_4cec69ba","line":71,"range":{"start_line":71,"start_character":45,"end_line":71,"end_character":46},"in_reply_to":"5fc1f717_ec2f553c","updated":"2019-03-27 14:48:19.000000000","message":"sonofa","commit_id":"7b4b4192a8e2342546bbc107597a9285ed0ccda6"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"61694f253d784b84e5f1dde1bbd98b8a7f85207f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        not being used."},{"line_number":64,"context_line":"        \"\"\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        if os.path.exists(\u0027/etc/cinder/policy.json\u0027):"},{"line_number":67,"context_line":"            return uc.Result("},{"line_number":68,"context_line":"                WARNING,"},{"line_number":69,"context_line":"                \u0027policy.json file is present. Make sure any changes from the \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"5fc1f717_4efbeb77","line":66,"range":{"start_line":66,"start_character":27,"end_line":66,"end_character":38},"updated":"2019-03-28 12:22:56.000000000","message":"Does this file path can be set by admins?","commit_id":"5c4d8b0cf23cba2f30d9a411145805efc7e8ce7c"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e26117bd1edb1be6b6f8b300bcf52bb1e2a88bb5","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        not being used."},{"line_number":64,"context_line":"        \"\"\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        if os.path.exists(\u0027/etc/cinder/policy.json\u0027):"},{"line_number":67,"context_line":"            return uc.Result("},{"line_number":68,"context_line":"                WARNING,"},{"line_number":69,"context_line":"                \u0027policy.json file is present. Make sure any changes from the \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"5fc1f717_e54515b5","line":66,"range":{"start_line":66,"start_character":27,"end_line":66,"end_character":38},"in_reply_to":"5fc1f717_4efbeb77","updated":"2019-03-28 13:51:53.000000000","message":"I was wondering about this as well -- I\u0027m not sure if this is always guaranteed to the be correct path.","commit_id":"5c4d8b0cf23cba2f30d9a411145805efc7e8ce7c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"369093c9dcb8d87bd074cf9326b2c1e859d7f54d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        not being used."},{"line_number":64,"context_line":"        \"\"\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        if os.path.exists(\u0027/etc/cinder/policy.json\u0027):"},{"line_number":67,"context_line":"            return uc.Result("},{"line_number":68,"context_line":"                WARNING,"},{"line_number":69,"context_line":"                \u0027policy.json file is present. Make sure any changes from the \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"5fc1f717_0775c063","line":66,"range":{"start_line":66,"start_character":27,"end_line":66,"end_character":38},"in_reply_to":"5fc1f717_c566d951","updated":"2019-03-28 17:47:03.000000000","message":"oslo.policy will use an absolute path to the file, otherwise it searches config directories [0].  The search uses oslo.config.cfg.find_file, which looks in a bunch of places described in [1].\n\n[0] https://opendev.org/openstack/oslo.policy/src/commit/5d2b7a8634c0a1b7c75a71953e37b671e996a9ca/oslo_policy/policy.py#L802-L805\n\n[1] https://opendev.org/openstack/oslo.config/src/commit/c6631d3825127f59a47e4986c735b1c4820eb750/oslo_config/cfg.py#L2518-L2523","commit_id":"5c4d8b0cf23cba2f30d9a411145805efc7e8ce7c"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"19b76ae12dc7e3c369840ef37185ce31d7b5d1c8","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        not being used."},{"line_number":64,"context_line":"        \"\"\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        if os.path.exists(\u0027/etc/cinder/policy.json\u0027):"},{"line_number":67,"context_line":"            return uc.Result("},{"line_number":68,"context_line":"                WARNING,"},{"line_number":69,"context_line":"                \u0027policy.json file is present. Make sure any changes from the \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"5fc1f717_c566d951","line":66,"range":{"start_line":66,"start_character":27,"end_line":66,"end_character":38},"in_reply_to":"5fc1f717_e54515b5","updated":"2019-03-28 13:53:13.000000000","message":"Yeah, I was concerned about that. I think I see a better way to determine that now. Let me try something quick and see.","commit_id":"5c4d8b0cf23cba2f30d9a411145805efc7e8ce7c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"57efc3f126cb1395547aeb3e26344a25cc6f2f28","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                    \"expected, but default policies will be used until any \""},{"line_number":78,"context_line":"                    \"desired overrides are added to this file.\" % policy_file)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        if \u0027yaml\u0027 in policy_file:"},{"line_number":81,"context_line":"            # Default is being used, check for old json file"},{"line_number":82,"context_line":"            config_dir \u003d CONF.find_file(\u0027cinder.conf\u0027)"},{"line_number":83,"context_line":"            json_file \u003d os.path.join(os.path.dirname(config_dir),"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_2a3be137","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":33},"updated":"2019-03-28 18:43:22.000000000","message":"i think this won\u0027t work when policy_file is something like, \u0027/etc/yaml/...\u0027,\npolicy_file[policy_file.rfind(\u0027.\u0027)+1:] \u003d\u003d \u0027yaml\u0027\nor\nif \u0027yaml\u0027 in policy_file[policy_file.rfind(\u0027.\u0027):]","commit_id":"6e158e249f1ca8b8218fa08a93708dcb67197092"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f92bd4bcffb21994edb384ef8ad636c9b670b6aa","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                    \"expected, but default policies will be used until any \""},{"line_number":78,"context_line":"                    \"desired overrides are added to this file.\" % policy_file)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        if \u0027yaml\u0027 in policy_file:"},{"line_number":81,"context_line":"            # Default is being used, check for old json file"},{"line_number":82,"context_line":"            config_dir \u003d CONF.find_file(\u0027cinder.conf\u0027)"},{"line_number":83,"context_line":"            json_file \u003d os.path.join(os.path.dirname(config_dir),"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_8d00ef02","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":33},"in_reply_to":"5fc1f717_2a3be137","updated":"2019-03-28 18:59:03.000000000","message":"I didn\u0027t consider that likely enough to care, but fair enough.","commit_id":"6e158e249f1ca8b8218fa08a93708dcb67197092"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a488b98201eabc85d752a75319b60696b3f59c47","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                    \"the \u0027policy_file\u0027 configuration option in the \""},{"line_number":94,"context_line":"                    \u0027[oslo_policy] section of your cinder.conf file.\u0027)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        return uc.Result(SUCCESS)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    _upgrade_checks \u003d ("},{"line_number":99,"context_line":"        (\u0027Backup Driver Path\u0027, _check_backup_module),"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_edb73320","line":96,"updated":"2019-03-28 19:20:23.000000000","message":"Thinking through the logic here.  The situation we want to detect is when an operator has a policy.json in the config directory but is using the default policy_file setting, which is \u0027policy.yaml\u0027.  (In that case, the code looks for policy.yaml, and not finding it, uses the defaults defined in code, which could be different from what the operator has configured in policy.json.)\n\nThe first \u0027if\u0027 checks if there\u0027s a path on the configured filename; if so, we know the operator has set it, and if the file exists, then that\u0027s cool, if it doesn\u0027t, we warn that the default policies in code are in effect and return.\n\nThe first check leaves out the case where the operator has set the value to \u0027cinder.yaml\u0027 but put the file in a place where oslo.config won\u0027t be able to find it.  The second check doesn\u0027t really handle that case either.  I\u0027d suggest changing the \u0027if\u0027 condition to\n\n  if policy_file \u003d\u003d \u0027policy.yaml\u0027:\n\nand then add an \u0027else\u0027 to catch the case where they\u0027ve changed the setting but the file isn\u0027t accessible.  I think finding the config_dir like you do in the \u0027if\u0027 and joining that to the configured filename is sufficient.  Same warning message as the first case.  (I think we don\u0027t care if there is a policy.json in this third case, because even if it\u0027s there, the operator has intentionally set a different filename.)\n\n(Also, if you don\u0027t want to hard-code \u0027policy.yaml\u0027 you can use cinder.policy.DEFAULT_POLICY_FILENAME)","commit_id":"6e158e249f1ca8b8218fa08a93708dcb67197092"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a488b98201eabc85d752a75319b60696b3f59c47","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                    \"the \u0027policy_file\u0027 configuration option in the \""},{"line_number":94,"context_line":"                    \u0027[oslo_policy] section of your cinder.conf file.\u0027)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        return uc.Result(SUCCESS)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    _upgrade_checks \u003d ("},{"line_number":99,"context_line":"        (\u0027Backup Driver Path\u0027, _check_backup_module),"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_4d25275b","line":96,"updated":"2019-03-28 19:20:23.000000000","message":"Thinking through the logic here.  The situation we want to detect is when an operator has a policy.json in the config directory but is using the default policy_file setting, which is \u0027policy.yaml\u0027.  (In that case, the code looks for policy.yaml, and not finding it, uses the defaults defined in code, which could be different from what the operator has configured in policy.json.)\n\nThe first \u0027if\u0027 checks if there\u0027s a path on the configured filename; if so, we know the operator has set it, and if the file exists, then that\u0027s cool, if it doesn\u0027t, we warn that the default policies in code are in effect and return.\n\nThe first check leaves out the case where the operator has set the value to \u0027cinder.yaml\u0027 but put the file in a place where oslo.config won\u0027t be able to find it.  The second check doesn\u0027t really handle that case either.  I\u0027d suggest changing the \u0027if\u0027 condition to\n\n  if policy_file \u003d\u003d \u0027policy.yaml\u0027:\n\n(because then we know for sure they\u0027re using the default) and then add an \u0027else\u0027 to catch the case where they\u0027ve changed the setting but the file isn\u0027t accessible.  I think finding the config_dir like you do in the \u0027if\u0027 and joining that to the configured filename is sufficient.  Same warning message as the first case.  (I think we don\u0027t care if there is a policy.json in this third case, because even if it\u0027s there, the operator has intentionally set a different filename.)\n\n(Also, if you don\u0027t want to hard-code \u0027policy.yaml\u0027 you can use cinder.policy.DEFAULT_POLICY_FILENAME)","commit_id":"a8e20c35fc70c9b3dc11509f13c4147d5a73c4aa"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"7f22c7b875b82cca3904e1fe4a3f6665f430afac","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"\"\"Upgrade checks to run.\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def _file_exists(self, path):"},{"line_number":38,"context_line":"        \"\"\"Helper for mocking check of os.path.exists.\"\"\""},{"line_number":39,"context_line":"        return os.path.exists(path)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _check_backup_module(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"5fc1f717_24bd84d7","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":57},"updated":"2019-04-09 19:06:56.000000000","message":":)","commit_id":"8c6355f3ccb64cb949a8280b6cd98a37e13bfaa7"}],"doc/source/cli/cinder-status.rst":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"7f22c7b875b82cca3904e1fe4a3f6665f430afac","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  * Check added to ensure the backup_driver setting is using the full driver"},{"line_number":89,"context_line":"    class path and not just the module path."},{"line_number":90,"context_line":"  * Checks for the presence of a **policy.json** file have been added to warn"},{"line_number":91,"context_line":"    if policy changes should be present in a **policy.yaml** file."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"See Also"}],"source_content_type":"text/x-rst","patch_set":12,"id":"5fc1f717_e4a77cbb","line":90,"updated":"2019-04-09 19:06:56.000000000","message":"Should we add this in Train section?","commit_id":"8c6355f3ccb64cb949a8280b6cd98a37e13bfaa7"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"bf7acf07407bc5d93d1aad27f58cb9af7736b8f3","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  * Check added to ensure the backup_driver setting is using the full driver"},{"line_number":89,"context_line":"    class path and not just the module path."},{"line_number":90,"context_line":"  * Checks for the presence of a **policy.json** file have been added to warn"},{"line_number":91,"context_line":"    if policy changes should be present in a **policy.yaml** file."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"See Also"}],"source_content_type":"text/x-rst","patch_set":12,"id":"5fc1f717_44669053","line":90,"in_reply_to":"5fc1f717_24dee410","updated":"2019-04-09 19:14:45.000000000","message":"I\u0027m not sure that it\u0027s OK to backport it because it\u0027s a feature, but I agree that it\u0027s good to have this in older releases to make upgrades easier. Anyway, it\u0027s not related to this patch and I\u0027m OK with it","commit_id":"8c6355f3ccb64cb949a8280b6cd98a37e13bfaa7"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6a09a5b2090544ff7eba7de7992c0516a5551754","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  * Check added to ensure the backup_driver setting is using the full driver"},{"line_number":89,"context_line":"    class path and not just the module path."},{"line_number":90,"context_line":"  * Checks for the presence of a **policy.json** file have been added to warn"},{"line_number":91,"context_line":"    if policy changes should be present in a **policy.yaml** file."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"See Also"}],"source_content_type":"text/x-rst","patch_set":12,"id":"5fc1f717_8451d832","line":90,"in_reply_to":"5fc1f717_44669053","updated":"2019-04-09 19:21:17.000000000","message":"We did discuss this with some folks as far as stable policy goes. This isn\u0027t a new feature really, it\u0027s something that we want to have to help our deployers as they upgrade, so the thought at the time was that it was acceptable to backport things like this to support that effort.","commit_id":"8c6355f3ccb64cb949a8280b6cd98a37e13bfaa7"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"317e6e41fb5e5e39073462b93bbe12595dfb821e","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  * Check added to ensure the backup_driver setting is using the full driver"},{"line_number":89,"context_line":"    class path and not just the module path."},{"line_number":90,"context_line":"  * Checks for the presence of a **policy.json** file have been added to warn"},{"line_number":91,"context_line":"    if policy changes should be present in a **policy.yaml** file."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"See Also"}],"source_content_type":"text/x-rst","patch_set":12,"id":"5fc1f717_24dee410","line":90,"in_reply_to":"5fc1f717_e4a77cbb","updated":"2019-04-09 19:10:46.000000000","message":"We should decide that. None of the checks actually made it into Stein even though I think all of the ones that are up there right now pertain to pre-Stein to Stein upgrades. So it is most applicable to Stein.\n\nI believe the plan still is that we get these merged, then backport them to stable/stein so they get picked up in a stable release there. If that is still the case, then we do want to have this listed under the Stein section.","commit_id":"8c6355f3ccb64cb949a8280b6cd98a37e13bfaa7"}]}