)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8717f1fcdb81622c518973764a1d90b7f69d5490","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sofia Enriquez \u003clsofia.enriquez@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-03-26 22:53:51 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check Volume Status on attahcment create/update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently the new Attachment calls in Cinder aren\u0027t checking the status"},{"line_number":10,"context_line":"of the volume when create or update is called.  This isn\u0027t good because"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_24743bfe","line":7,"range":{"start_line":7,"start_character":23,"end_line":7,"end_character":33},"updated":"2019-04-02 09:25:14.000000000","message":"NIT: attachment","commit_id":"37b710e73869311468bdafe3c1bf9c836161836f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3959abb4b55309af5109d6aa57e98a29c55094f8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sofia Enriquez \u003clsofia.enriquez@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-03-26 22:53:51 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check Volume Status on attahcment create/update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently the new Attachment calls in Cinder aren\u0027t checking the status"},{"line_number":10,"context_line":"of the volume when create or update is called.  This isn\u0027t good because"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_26fe516b","line":7,"range":{"start_line":7,"start_character":23,"end_line":7,"end_character":33},"in_reply_to":"5fc1f717_24743bfe","updated":"2019-04-04 05:09:25.000000000","message":"Done","commit_id":"37b710e73869311468bdafe3c1bf9c836161836f"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"9810d381be479ef9b478d8b46f375eb8f492389d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sofia Enriquez \u003clsofia.enriquez@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-03-26 22:53:51 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check Volume Status on attahcment create/update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently the new Attachment calls in Cinder aren\u0027t checking the status"},{"line_number":10,"context_line":"of the volume when create or update is called.  This isn\u0027t good because"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_bd3b0fe8","line":7,"range":{"start_line":7,"start_character":23,"end_line":7,"end_character":33},"in_reply_to":"5fc1f717_26fe516b","updated":"2019-04-05 14:31:48.000000000","message":"Fixing summary typos like this in backports is really not encouraged, it makes it harder to track the commit through other branches when doing archaeological research later.","commit_id":"37b710e73869311468bdafe3c1bf9c836161836f"}],"cinder/volume/api.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"17f4aaca343de6ae93290ba2ddebc8c856a9411f","unresolved":false,"context_lines":[{"line_number":2121,"context_line":"        if \"error\" in volume_ref.status:"},{"line_number":2122,"context_line":"            msg \u003d (\u0027Volume attachments can not be created if the volume \u0027"},{"line_number":2123,"context_line":"                   \u0027is in an error state. \u0027"},{"line_number":2124,"context_line":"                   \u0027The Volume %(volume_id)s currently has a status of: \u0027"},{"line_number":2125,"context_line":"                   \u0027%(volume_status)s \u0027) % {"},{"line_number":2126,"context_line":"                       \u0027volume_id\u0027: volume_ref.id,"},{"line_number":2127,"context_line":"                       \u0027volume_status\u0027: volume_ref.status}"},{"line_number":2128,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_f3783f90","line":2125,"range":{"start_line":2124,"start_character":19,"end_line":2125,"end_character":39},"updated":"2019-04-02 04:44:14.000000000","message":"isn\u0027t this redundant since we\u0027ve already mentioned the volume is in error state?","commit_id":"37b710e73869311468bdafe3c1bf9c836161836f"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"083e3683d6c45b2e7472cb746483ce508f523c7f","unresolved":false,"context_lines":[{"line_number":2121,"context_line":"        if \"error\" in volume_ref.status:"},{"line_number":2122,"context_line":"            msg \u003d (\u0027Volume attachments can not be created if the volume \u0027"},{"line_number":2123,"context_line":"                   \u0027is in an error state. \u0027"},{"line_number":2124,"context_line":"                   \u0027The Volume %(volume_id)s currently has a status of: \u0027"},{"line_number":2125,"context_line":"                   \u0027%(volume_status)s \u0027) % {"},{"line_number":2126,"context_line":"                       \u0027volume_id\u0027: volume_ref.id,"},{"line_number":2127,"context_line":"                       \u0027volume_status\u0027: volume_ref.status}"},{"line_number":2128,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_0e0cb539","line":2125,"range":{"start_line":2124,"start_character":19,"end_line":2125,"end_character":39},"in_reply_to":"5fc1f717_f3783f90","updated":"2019-04-02 13:42:36.000000000","message":"No, because the \"if\" will trigger on \"error_deleting\" etc., which is only logged here.","commit_id":"37b710e73869311468bdafe3c1bf9c836161836f"}]}