)]}'
{"cinder/cmd/status.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5a47af79b705f88e921643a3b5233abe75ef730c","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        * ITRI DISCO Storage Driver"},{"line_number":89,"context_line":"        * HGST Flash Storage Suite Driver"},{"line_number":90,"context_line":"        \"\"\""},{"line_number":91,"context_line":"        for volume_driver in _get_enabled_drivers():"},{"line_number":92,"context_line":"            for removed_driver in STEIN_REMOVED_DRVRS:"},{"line_number":93,"context_line":"                if removed_driver in volume_driver:"},{"line_number":94,"context_line":"                    return uc.Result("}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_8922e800","line":91,"range":{"start_line":91,"start_character":8,"end_line":91,"end_character":52},"updated":"2019-04-02 08:30:40.000000000","message":"i understand that vendors like coprhd has multiple drivers, iscsi, fc etc. therefore we check for substring inside the driver string, but if we could mention the full driver path in the removed driver list and compare it with the enabled driver list directly (eliminating this loop), that would be great.\ncorrect me if my understanding of this logic is wrong.","commit_id":"e9b04b7d001e66f74d211004912fbdf29c09f553"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"bc9fc093fb6917b5dadf850a2501b75237a7394c","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        * ITRI DISCO Storage Driver"},{"line_number":89,"context_line":"        * HGST Flash Storage Suite Driver"},{"line_number":90,"context_line":"        \"\"\""},{"line_number":91,"context_line":"        for volume_driver in _get_enabled_drivers():"},{"line_number":92,"context_line":"            for removed_driver in STEIN_REMOVED_DRVRS:"},{"line_number":93,"context_line":"                if removed_driver in volume_driver:"},{"line_number":94,"context_line":"                    return uc.Result("}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_9c6a1a19","line":91,"range":{"start_line":91,"start_character":8,"end_line":91,"end_character":52},"in_reply_to":"5fc1f717_8922e800","updated":"2019-04-02 18:51:43.000000000","message":"Rajat, I had thought about what you recommend here but it makes the code much more complicated and more error prone.  The volume_driver that will be reported in the error message has the full driver module path so I feel this approach is pretty unambiguous.","commit_id":"e9b04b7d001e66f74d211004912fbdf29c09f553"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ad259daed77cca896567bcae189687c7536223a6","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        * ITRI DISCO Storage Driver"},{"line_number":89,"context_line":"        * HGST Flash Storage Suite Driver"},{"line_number":90,"context_line":"        \"\"\""},{"line_number":91,"context_line":"        for volume_driver in _get_enabled_drivers():"},{"line_number":92,"context_line":"            for removed_driver in STEIN_REMOVED_DRVRS:"},{"line_number":93,"context_line":"                if removed_driver in volume_driver:"},{"line_number":94,"context_line":"                    return uc.Result("}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_5d4fbebd","line":91,"range":{"start_line":91,"start_character":8,"end_line":91,"end_character":52},"in_reply_to":"5fc1f717_9c6a1a19","updated":"2019-04-04 16:37:36.000000000","message":"Agreed, Just wanted to adding a few iterations to have a safe check would be more preferable.","commit_id":"e9b04b7d001e66f74d211004912fbdf29c09f553"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c5dff407184caf344de150acc8c7d9d29c04317b","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        for volume_driver in _get_enabled_drivers():"},{"line_number":114,"context_line":"            for removed_driver in STEIN_REMOVED_DRVRS:"},{"line_number":115,"context_line":"                if removed_driver in volume_driver:"},{"line_number":116,"context_line":"                    return uc.Result("},{"line_number":117,"context_line":"                        FAILURE,"},{"line_number":118,"context_line":"                        \u0027Found driver %s configured in cinder.conf \u0027"},{"line_number":119,"context_line":"                        \u0027This driver was removed in the Stein release \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_3c2ad47d","line":116,"updated":"2019-04-04 16:17:43.000000000","message":"What are the odds of some unlucky sucker having multiple backends that are all using removed drivers?  I\u0027m asking because this loop exits as soon as the first bad driver is found.  The operator will have to re-run the upgrade check to find out about the next bad driver.  Maybe that\u0027s ok.","commit_id":"b7fdd4213c6be6e9d1049fb40730522fede1d499"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"a0a693ed27d344a418f5c3e8e62277092adac7f3","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        for volume_driver in _get_enabled_drivers():"},{"line_number":114,"context_line":"            for removed_driver in STEIN_REMOVED_DRVRS:"},{"line_number":115,"context_line":"                if removed_driver in volume_driver:"},{"line_number":116,"context_line":"                    return uc.Result("},{"line_number":117,"context_line":"                        FAILURE,"},{"line_number":118,"context_line":"                        \u0027Found driver %s configured in cinder.conf \u0027"},{"line_number":119,"context_line":"                        \u0027This driver was removed in the Stein release \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_9c68a8ba","line":116,"in_reply_to":"5fc1f717_3c2ad47d","updated":"2019-04-04 17:31:23.000000000","message":"I had that thought.  I chose to do it this way to keep the check as simple as possible and the way the instructions are written for upgrade checks is to suggest that the check needs to be re-run.  So, I think this is the best approach.","commit_id":"b7fdd4213c6be6e9d1049fb40730522fede1d499"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ad259daed77cca896567bcae189687c7536223a6","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        for volume_driver in _get_enabled_drivers():"},{"line_number":114,"context_line":"            for removed_driver in STEIN_REMOVED_DRVRS:"},{"line_number":115,"context_line":"                if removed_driver in volume_driver:"},{"line_number":116,"context_line":"                    return uc.Result("},{"line_number":117,"context_line":"                        FAILURE,"},{"line_number":118,"context_line":"                        \u0027Found driver %s configured in cinder.conf \u0027"},{"line_number":119,"context_line":"                        \u0027This driver was removed in the Stein release \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_7c985c74","line":116,"in_reply_to":"5fc1f717_3c2ad47d","updated":"2019-04-04 16:37:36.000000000","message":"I think the odds can be high as one could be using all the drivers from same vendor.\nIt would be great to have all the \"bad drivers\" reported at the same time(similar to pep8 and py2/3 tests) but doesn\u0027t seem like a necessity for now.\nAn alternative could be to add a functionality(not now) where we can run a single check at a time like unit tests.","commit_id":"b7fdd4213c6be6e9d1049fb40730522fede1d499"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"829ca2ea8ede0120906a430ce5ac53f34efd064e","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        return uc.Result(SUCCESS)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def _check_stein_removed_drivers(self):"},{"line_number":104,"context_line":"        \"\"\"Checks to ensure that no removed drivers are configured."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        In Stein, this means checking for the following removed"}],"source_content_type":"text/x-python","patch_set":5,"id":"5fc1f717_c1c4d662","line":103,"updated":"2019-04-08 13:13:45.000000000","message":"See Sean\u0027s comment on https://review.openstack.org/649193 about making this more general.  Might be a good idea.","commit_id":"9a102d2bed56a7fdd2fc85bc392d6e88ba0d5f88"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"d4c087110c49001537a9242ff6bff816c8461eac","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        return uc.Result(SUCCESS)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def _check_stein_removed_drivers(self):"},{"line_number":104,"context_line":"        \"\"\"Checks to ensure that no removed drivers are configured."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        In Stein, this means checking for the following removed"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfbec78f_3b18a6d1","line":103,"in_reply_to":"5fc1f717_c1c4d662","updated":"2019-05-09 20:00:21.000000000","message":"Done","commit_id":"9a102d2bed56a7fdd2fc85bc392d6e88ba0d5f88"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"cc38a5d9ceb9b37f7afbaf0207a46377058065c9","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                if removed_driver in volume_driver:"},{"line_number":116,"context_line":"                    return uc.Result("},{"line_number":117,"context_line":"                        FAILURE,"},{"line_number":118,"context_line":"                        \u0027Found driver %s configured in cinder.conf \u0027"},{"line_number":119,"context_line":"                        \u0027This driver was removed in the Stein release \u0027"},{"line_number":120,"context_line":"                        \u0027and all data should be migrated off of this \u0027"},{"line_number":121,"context_line":"                        \u0027backend before upgrading Cinder.\u0027 %"}],"source_content_type":"text/x-python","patch_set":5,"id":"5fc1f717_3a3413de","line":118,"updated":"2019-04-04 18:29:38.000000000","message":"You can get this later (I think you will have merge conflicts with Sean\u0027s policy_json patch).  Right now the message looks like this:\n\n  +----------------------------------------------------------------------+\n  | Check: Stein Removed Drivers                                         |\n  | Result: Failure                                                      |\n  | Details: Found driver                                                |\n  |   cinder.volume.drivers.coprhd.fc.EMCCoprHDFCDriver                  |\n  |   configured in cinder.conf This driver was removed in the           |\n  |   Stein release and all data should be migrated off of this          |\n  |   backend before upgrading Cinder.                                   |\n  +----------------------------------------------------------------------+\n\nIf you don\u0027t want to put a period after \u0027cinder.conf\u0027, you could say \u0027in your cinder.conf file.\u0027  (I just hate seeing a user-facing typo after all the work you\u0027ve done on this!)","commit_id":"9a102d2bed56a7fdd2fc85bc392d6e88ba0d5f88"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"d4c087110c49001537a9242ff6bff816c8461eac","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                if removed_driver in volume_driver:"},{"line_number":116,"context_line":"                    return uc.Result("},{"line_number":117,"context_line":"                        FAILURE,"},{"line_number":118,"context_line":"                        \u0027Found driver %s configured in cinder.conf \u0027"},{"line_number":119,"context_line":"                        \u0027This driver was removed in the Stein release \u0027"},{"line_number":120,"context_line":"                        \u0027and all data should be migrated off of this \u0027"},{"line_number":121,"context_line":"                        \u0027backend before upgrading Cinder.\u0027 %"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfbec78f_db0e2a8c","line":118,"in_reply_to":"5fc1f717_3a3413de","updated":"2019-05-09 20:00:21.000000000","message":"Done","commit_id":"9a102d2bed56a7fdd2fc85bc392d6e88ba0d5f88"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"692d4630a0b8cd449fd693223be56da66c722764","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        Checks start with drivers removed in the Stein release."},{"line_number":165,"context_line":"        \"\"\""},{"line_number":166,"context_line":"        for volume_driver in _get_enabled_drivers():"},{"line_number":167,"context_line":"            for removed_driver in REMOVED_DRVRS:"},{"line_number":168,"context_line":"                if removed_driver in volume_driver:"},{"line_number":169,"context_line":"                    return uc.Result("},{"line_number":170,"context_line":"                        FAILURE,"}],"source_content_type":"text/x-python","patch_set":7,"id":"dfbec78f_d7a1daf9","line":167,"range":{"start_line":167,"start_character":34,"end_line":167,"end_character":47},"updated":"2019-05-14 13:54:20.000000000","message":"If this was made the full driver path we could get rid of the nested for looping and just loop through enabled drivers and test if the driver is in the list.\n\nfor volume_driver in _get_enabled_drivers():\n    if volume_driver in REMOVED_DRVRS:\n        return uc.Result(...","commit_id":"c602755ba399c8760405589fc7680e2f685f8277"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b1f1818f3ae9cd83039bbf89eabb7884dd36676c","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        Checks start with drivers removed in the Stein release."},{"line_number":165,"context_line":"        \"\"\""},{"line_number":166,"context_line":"        for volume_driver in _get_enabled_drivers():"},{"line_number":167,"context_line":"            for removed_driver in REMOVED_DRVRS:"},{"line_number":168,"context_line":"                if removed_driver in volume_driver:"},{"line_number":169,"context_line":"                    return uc.Result("},{"line_number":170,"context_line":"                        FAILURE,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bfb3d3c7_932e8641","line":167,"range":{"start_line":167,"start_character":34,"end_line":167,"end_character":47},"in_reply_to":"dfbec78f_d7a1daf9","updated":"2019-05-21 14:06:50.000000000","message":"I\u0027m OK with this approach, unless we are anticipating a situation where we might remove the coprhd FC driver but keep the coprhd ISCSI driver ... the current approach is all or nothing.","commit_id":"c602755ba399c8760405589fc7680e2f685f8277"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b1f1818f3ae9cd83039bbf89eabb7884dd36676c","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        for volume_driver in _get_enabled_drivers():"},{"line_number":167,"context_line":"            for removed_driver in REMOVED_DRVRS:"},{"line_number":168,"context_line":"                if removed_driver in volume_driver:"},{"line_number":169,"context_line":"                    return uc.Result("},{"line_number":170,"context_line":"                        FAILURE,"},{"line_number":171,"context_line":"                        \u0027Found driver %s configured in your cinder.conf file. \u0027"},{"line_number":172,"context_line":"                        \u0027This driver has been removed and all data should \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"bfb3d3c7_93bc46dd","line":169,"updated":"2019-05-21 14:06:50.000000000","message":"Since we\u0027re running late on this anyway, I\u0027d really like to see us check all the configured drivers so the operator doesn\u0027t have to keep re-running this thing to find out what needs to be fixed.  As Rajat pointed out on an earlier patch set, a consumer of brand X is likely to have X.iscsi and X.fc in use, so it would be nice to catch all those at once.","commit_id":"c602755ba399c8760405589fc7680e2f685f8277"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"7d47711c0afbf53c4a9bb1e71c2f94f07e349d87","unresolved":false,"context_lines":[{"line_number":207,"context_line":"        \"\"\""},{"line_number":208,"context_line":"        removed_drivers \u003d []"},{"line_number":209,"context_line":"        for volume_driver in _get_enabled_drivers():"},{"line_number":210,"context_line":"            for removed_driver in REMOVED_DRVRS:"},{"line_number":211,"context_line":"                if removed_driver in volume_driver:"},{"line_number":212,"context_line":"                    removed_drivers.append(volume_driver)"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bfb3d3c7_4df82948","line":210,"range":{"start_line":210,"start_character":34,"end_line":210,"end_character":47},"updated":"2019-05-24 13:43:19.000000000","message":"If you put the full driver path in REMOVED_DRVRS then you could get rid of the nested for loops and just have one check of \"if volume_driver in REMOVED_DRVRS:\"","commit_id":"e78e05c95dcb01336811a503c4292ac528959b8d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"7d47711c0afbf53c4a9bb1e71c2f94f07e349d87","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                    removed_drivers.append(volume_driver)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        if removed_drivers:"},{"line_number":215,"context_line":"            if len(removed_drivers) \u003e 1:"},{"line_number":216,"context_line":"                return uc.Result("},{"line_number":217,"context_line":"                    FAILURE,"},{"line_number":218,"context_line":"                    \u0027The following drivers, which no longer exist, were found \u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"bfb3d3c7_edc8fd22","line":215,"updated":"2019-05-24 13:43:19.000000000","message":"I think this whole if/else overcomplicates things and could be simplified with a general error message.","commit_id":"e78e05c95dcb01336811a503c4292ac528959b8d"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"4f338435dfb019e515563aa66f8e56d6a36d879f","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                    removed_drivers.append(volume_driver)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        if removed_drivers:"},{"line_number":215,"context_line":"            if len(removed_drivers) \u003e 1:"},{"line_number":216,"context_line":"                return uc.Result("},{"line_number":217,"context_line":"                    FAILURE,"},{"line_number":218,"context_line":"                    \u0027The following drivers, which no longer exist, were found \u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"bfb3d3c7_0dbf3cd1","line":215,"in_reply_to":"bfb3d3c7_edc8fd22","updated":"2019-05-30 14:02:34.000000000","message":"+1, we don\u0027t need \u0027else\u0027 here","commit_id":"e78e05c95dcb01336811a503c4292ac528959b8d"}],"cinder/tests/unit/cmd/test_status.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c5dff407184caf344de150acc8c7d9d29c04317b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def _set_backup_driver(self, driver_path):"},{"line_number":35,"context_line":"        CONF.set_override(\u0027backup_driver\u0027, driver_path)"},{"line_number":36,"context_line":"        self.addCleanup(CONF.clear_override, \u0027backup_driver\u0027)"},{"line_number":37,"context_line":"        "},{"line_number":38,"context_line":"    def _set_volume_driver(self, volume_driver, enabled_backend):"},{"line_number":39,"context_line":"        CONF.register_opts(volume_manager.volume_backend_opts,"},{"line_number":40,"context_line":"                           group\u003denabled_backend)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_9c118856","line":37,"updated":"2019-04-04 16:17:43.000000000","message":"pep8 doesn\u0027t like this","commit_id":"b7fdd4213c6be6e9d1049fb40730522fede1d499"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c5dff407184caf344de150acc8c7d9d29c04317b","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        self.assertEqual(uc.Code.FAILURE, result.code)"},{"line_number":72,"context_line":"        self.assertIn(\u0027Please update to use\u0027, result.details)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def test_check_stein_removed_drivers(self):"},{"line_number":75,"context_line":"        self._set_volume_driver("},{"line_number":76,"context_line":"            \u0027cinder.volume.drivers.lvm.LVMVolumeDriver\u0027,"},{"line_number":77,"context_line":"            \u0027winiscsi\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_bc0c8439","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":40},"updated":"2019-04-04 16:17:43.000000000","message":"there\u0027s something weird about the name of this test and the one at line 86","commit_id":"b7fdd4213c6be6e9d1049fb40730522fede1d499"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"a0a693ed27d344a418f5c3e8e62277092adac7f3","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        self.assertEqual(uc.Code.FAILURE, result.code)"},{"line_number":72,"context_line":"        self.assertIn(\u0027Please update to use\u0027, result.details)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def test_check_stein_removed_drivers(self):"},{"line_number":75,"context_line":"        self._set_volume_driver("},{"line_number":76,"context_line":"            \u0027cinder.volume.drivers.lvm.LVMVolumeDriver\u0027,"},{"line_number":77,"context_line":"            \u0027winiscsi\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_57753bf9","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":40},"in_reply_to":"5fc1f717_bc0c8439","updated":"2019-04-04 17:31:23.000000000","message":"Copy paste error.","commit_id":"b7fdd4213c6be6e9d1049fb40730522fede1d499"}],"doc/source/cli/cinder-status.rst":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5a47af79b705f88e921643a3b5233abe75ef730c","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  **14.0.0 (Stein)**"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  * Ensure that correct volume_driver path is used for Windows iSCSI driver."},{"line_number":89,"context_line":"  * Ensure that none of the volume drivers removed in Stein are configured."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"See Also"},{"line_number":92,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5fc1f717_297414fe","line":89,"range":{"start_line":89,"start_character":0,"end_line":89,"end_character":75},"updated":"2019-04-02 08:30:40.000000000","message":"probably this should come under Train section?","commit_id":"e9b04b7d001e66f74d211004912fbdf29c09f553"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"bc9fc093fb6917b5dadf850a2501b75237a7394c","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  **14.0.0 (Stein)**"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  * Ensure that correct volume_driver path is used for Windows iSCSI driver."},{"line_number":89,"context_line":"  * Ensure that none of the volume drivers removed in Stein are configured."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"See Also"},{"line_number":92,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5fc1f717_bc503660","line":89,"range":{"start_line":89,"start_character":0,"end_line":89,"end_character":75},"in_reply_to":"5fc1f717_297414fe","updated":"2019-04-02 18:51:43.000000000","message":"No, as these are the checks that will be run when upgrading to Stein.","commit_id":"e9b04b7d001e66f74d211004912fbdf29c09f553"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b1f1818f3ae9cd83039bbf89eabb7884dd36676c","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  * Checks for the presence of a **policy.json** file have been added to warn"},{"line_number":91,"context_line":"    if policy changes should be present in a **policy.yaml** file."},{"line_number":92,"context_line":"  * Ensure that correct volume_driver path is used for Windows iSCSI driver."},{"line_number":93,"context_line":"  * Ensure that none of the volume drivers removed in Stein are configured."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"See Also"},{"line_number":96,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bfb3d3c7_7344321c","line":93,"updated":"2019-05-21 14:06:50.000000000","message":"We\u0027re actually only checking the drivers whose backend group is listed in enabled_backends -- so if someone has a \"bad\" driver defined in a backend group that isn\u0027t currently being used (but is present) in the config file, that person could get a bad surprise later if they include the group in enabled_backends.  I think we need to mention that limitation here.  Or (because no one reads the documentation) ...\n\n... We could make the check more robust, but the only way I can think to do that would be to iterate through all the option groups in the file, checking each one that has a volume_driver option set.  We could get a false positive that way, but I don\u0027t know how else to distinguish a backend group from a \"regular\" oslo option-group.","commit_id":"c602755ba399c8760405589fc7680e2f685f8277"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1f5d93d5cd64803429c1dfea8fa06e4fe4855fc0","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    ``enabled_drivers`` config option this check will not catch the problem."},{"line_number":96,"context_line":"    If you have used the CoprHD, ITRI Disco or HGST drivers in the past you"},{"line_number":97,"context_line":"    should ensure that any data from these backends is transferred to a"},{"line_number":98,"context_line":"    supported storage array be upgrade."},{"line_number":99,"context_line":" "},{"line_number":100,"context_line":"  **15.0.0 (Train)**"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"bfb3d3c7_f88f6b20","line":98,"range":{"start_line":98,"start_character":28,"end_line":98,"end_character":30},"updated":"2019-05-23 17:33:24.000000000","message":"s/be/before/","commit_id":"37decd048d463138250e3c05966973360b8b37a1"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"79fabaee6de6eec5156f8312368470ae2ff137da","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    ``enabled_drivers`` config option this check will not catch the problem."},{"line_number":96,"context_line":"    If you have used the CoprHD, ITRI Disco or HGST drivers in the past you"},{"line_number":97,"context_line":"    should ensure that any data from these backends is transferred to a"},{"line_number":98,"context_line":"    supported storage array be upgrade."},{"line_number":99,"context_line":" "},{"line_number":100,"context_line":"  **15.0.0 (Train)**"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"bfb3d3c7_9823cf05","line":98,"range":{"start_line":98,"start_character":28,"end_line":98,"end_character":30},"in_reply_to":"bfb3d3c7_f88f6b20","updated":"2019-05-23 17:44:21.000000000","message":"Done","commit_id":"37decd048d463138250e3c05966973360b8b37a1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1f5d93d5cd64803429c1dfea8fa06e4fe4855fc0","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    If you have used the CoprHD, ITRI Disco or HGST drivers in the past you"},{"line_number":97,"context_line":"    should ensure that any data from these backends is transferred to a"},{"line_number":98,"context_line":"    supported storage array be upgrade."},{"line_number":99,"context_line":" "},{"line_number":100,"context_line":"  **15.0.0 (Train)**"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"  * Check added to make operators aware of new finer-grained configuration"}],"source_content_type":"text/x-rst","patch_set":11,"id":"bfb3d3c7_b899f36e","line":99,"range":{"start_line":99,"start_character":0,"end_line":99,"end_character":1},"updated":"2019-05-23 17:33:24.000000000","message":"(extra space)","commit_id":"37decd048d463138250e3c05966973360b8b37a1"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"79fabaee6de6eec5156f8312368470ae2ff137da","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    If you have used the CoprHD, ITRI Disco or HGST drivers in the past you"},{"line_number":97,"context_line":"    should ensure that any data from these backends is transferred to a"},{"line_number":98,"context_line":"    supported storage array be upgrade."},{"line_number":99,"context_line":" "},{"line_number":100,"context_line":"  **15.0.0 (Train)**"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"  * Check added to make operators aware of new finer-grained configuration"}],"source_content_type":"text/x-rst","patch_set":11,"id":"bfb3d3c7_581d57bb","line":99,"range":{"start_line":99,"start_character":0,"end_line":99,"end_character":1},"in_reply_to":"bfb3d3c7_b899f36e","updated":"2019-05-23 17:44:21.000000000","message":"Done","commit_id":"37decd048d463138250e3c05966973360b8b37a1"}]}