)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"688364fa027e48bed1dd587d8278d08f51cd6283","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Most of the numeric codes for HTTP respone (200, 202, ...)"},{"line_number":10,"context_line":"were replaced with OK, ACCEPTED ... constants."},{"line_number":11,"context_line":"It improves readability of code and maintains consistency."},{"line_number":12,"context_line":"This patch does the same change to the remaining places."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I7e404def8215b2266ee53583daff066cee35570c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_0897cd3c","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":31},"updated":"2019-04-02 13:00:42.000000000","message":"People keep saying this on changes that replace HTTP codes with constants, but I\u0027m skeptical.\n\nDoes everyone really know HTTP well enough to remember that \"NO_CONTENT\" is a successful operation more easily than parsing that \"204\" is successful because it\u0027s a 2xx code?","commit_id":"281685796fc00ca9811baa6f1cf289b7853f5795"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"54ee42bb68a473df7d55abbea1f5438f8aeed125","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Most of the numeric codes for HTTP respone (200, 202, ...)"},{"line_number":10,"context_line":"were replaced with OK, ACCEPTED ... constants."},{"line_number":11,"context_line":"It improves readability of code and maintains consistency."},{"line_number":12,"context_line":"This patch does the same change to the remaining places."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I7e404def8215b2266ee53583daff066cee35570c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_2edbb121","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":31},"in_reply_to":"5fc1f717_0897cd3c","updated":"2019-04-02 14:04:34.000000000","message":"Agree that on first glance, 2xx seems more appealing to be a success code than NO_CONTENT but since the change is inside the code and only visible to people that are atleast a little familiar with it, he/she may have a different(wide) perspective.\nFor instance, a GET request with a NO_CONTENT response might feel like an error (as GET expects a response) but the request for \u0027os-complete\u0027 action is POST type[1] which may or may not have a response so it is acceptable as a success.\n\n[1] https://developer.openstack.org/api-ref/block-storage/v3/index.html?expanded\u003dcomplete-attachment-detail#complete-attachment","commit_id":"281685796fc00ca9811baa6f1cf289b7853f5795"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"dce5843b5e9fc5050fac03966daaa12991b6806b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Most of the numeric codes for HTTP respone (200, 202, ...)"},{"line_number":10,"context_line":"were replaced with OK, ACCEPTED ... constants."},{"line_number":11,"context_line":"It improves readability of code and maintains consistency."},{"line_number":12,"context_line":"This patch does the same change to the remaining places."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I7e404def8215b2266ee53583daff066cee35570c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_1907051b","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":31},"in_reply_to":"5fc1f717_2edbb121","updated":"2019-04-03 16:34:34.000000000","message":"I\u0027ll buy the consistency argument.  (Although I guess we could replace all the constants with numerals instead! :P)","commit_id":"281685796fc00ca9811baa6f1cf289b7853f5795"}]}