)]}'
{"cinder/test.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"cc14c321b9fe3a2ac6d062b7744358a9472a54ff","unresolved":false,"context_lines":[{"line_number":489,"context_line":"                                   msg\u003dNone):"},{"line_number":490,"context_line":"        def obj_to_dict(o):"},{"line_number":491,"context_line":"            return self._dict_from_object(o, ignored_keys)"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"        objs1 \u003d map(obj_to_dict, objs1)"},{"line_number":494,"context_line":"        objs2 \u003d list(map(obj_to_dict, objs2))"},{"line_number":495,"context_line":"        # We don\u0027t care about the order of the lists, as long as they are in"}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_6972977d","line":492,"updated":"2019-05-28 15:42:59.000000000","message":"Nit: for most of the lambda replacements, you haven\u0027t been leaving a blank line between the def and its use (like at line 338).","commit_id":"799946da6512f26004d5c684cb4764cf95909034"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"7e798dfcdce5ce6a8da6395a65c6df5c01a2418a","unresolved":false,"context_lines":[{"line_number":489,"context_line":"                                   msg\u003dNone):"},{"line_number":490,"context_line":"        def obj_to_dict(o):"},{"line_number":491,"context_line":"            return self._dict_from_object(o, ignored_keys)"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"        objs1 \u003d map(obj_to_dict, objs1)"},{"line_number":494,"context_line":"        objs2 \u003d list(map(obj_to_dict, objs2))"},{"line_number":495,"context_line":"        # We don\u0027t care about the order of the lists, as long as they are in"}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_94ed8cb8","line":492,"in_reply_to":"bfb3d3c7_6972977d","updated":"2019-05-29 13:48:59.000000000","message":"Hmm, I\u0027m surprised pep8 doesn\u0027t have an opinion on this, I was mostly just stabbing at things until it was happy.","commit_id":"799946da6512f26004d5c684cb4764cf95909034"}],"cinder/tests/unit/test_cmd.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"cc14c321b9fe3a2ac6d062b7744358a9472a54ff","unresolved":false,"context_lines":[{"line_number":1261,"context_line":"        with mock.patch.object(rtslib_fb, \u0027NetworkPortal\u0027) as network_portal, \\"},{"line_number":1262,"context_line":"                mock.patch.object(rtslib_fb, \u0027LUN\u0027) as lun, \\"},{"line_number":1263,"context_line":"                mock.patch.object(rtslib_fb, \u0027TPG\u0027) as tpg, \\"},{"line_number":1264,"context_line":"                mock.patch.object(rtslib_fb, \u0027FabricModule\u0027) as fabric_mod, \\"},{"line_number":1265,"context_line":"                mock.patch.object(rtslib_fb, \u0027Target\u0027) as target, \\"},{"line_number":1266,"context_line":"                mock.patch.object(rtslib_fb, \u0027BlockStorageObject\u0027) as \\"},{"line_number":1267,"context_line":"                block_storage_object, \\"}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_e92e8790","line":1264,"range":{"start_line":1264,"start_character":64,"end_line":1264,"end_character":74},"updated":"2019-05-28 15:42:59.000000000","message":"You could call this \"fab_mod\" and then you\u0027d cover the Beatles as well as The Who.","commit_id":"799946da6512f26004d5c684cb4764cf95909034"}],"cinder/tests/unit/volume/drivers/test_zfssa.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"cc14c321b9fe3a2ac6d062b7744358a9472a54ff","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            \u0027iqn.1-0.org.deb:01:d7, iqn.1-0.org.deb:01:d9\u0027"},{"line_number":158,"context_line":"        self.configuration.zfssa_initiator_user \u003d \u0027\u0027"},{"line_number":159,"context_line":"        self.configuration.zfssa_initiator_password \u003d \u0027\u0027"},{"line_number":160,"context_line":"        self.configuration.zfssa_initiator_config \u003d \"{\u0027test-init-grp1\u0027:\"\\"},{"line_number":161,"context_line":"            \"[{\u0027iqn\u0027:\\"},{"line_number":162,"context_line":"            \u0027iqn.1-0.org.deb:01:d7\u0027,\u0027user\u0027:\u0027\u0027,\u0027password\u0027:\u0027\u0027}],\u0027test-init-grp\\"},{"line_number":163,"context_line":"            2\u0027:[{\u0027iqn\u0027:\u0027iqn.1-0.org.deb:01:d9\u0027,\u0027user\u0027:\u0027\u0027,\u0027password\u0027:\u0027\u0027}]}\""},{"line_number":164,"context_line":"        self.configuration.zfssa_target_group \u003d \u0027test-target-grp1\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_e60c74a6","line":161,"range":{"start_line":160,"start_character":71,"end_line":161,"end_character":13},"updated":"2019-05-28 15:42:59.000000000","message":"This has got to be the biggest nit ever nitted, but you\u0027re mixing two styles of string continuations in setting this value, one where you have complete quoted strings before and after each continuation, and one where the continuation happens within a single string.  The original style was the latter, should probably stick with that.  (Or completely ignore this, the end result is the same.)","commit_id":"799946da6512f26004d5c684cb4764cf95909034"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"7e798dfcdce5ce6a8da6395a65c6df5c01a2418a","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            \u0027iqn.1-0.org.deb:01:d7, iqn.1-0.org.deb:01:d9\u0027"},{"line_number":158,"context_line":"        self.configuration.zfssa_initiator_user \u003d \u0027\u0027"},{"line_number":159,"context_line":"        self.configuration.zfssa_initiator_password \u003d \u0027\u0027"},{"line_number":160,"context_line":"        self.configuration.zfssa_initiator_config \u003d \"{\u0027test-init-grp1\u0027:\"\\"},{"line_number":161,"context_line":"            \"[{\u0027iqn\u0027:\\"},{"line_number":162,"context_line":"            \u0027iqn.1-0.org.deb:01:d7\u0027,\u0027user\u0027:\u0027\u0027,\u0027password\u0027:\u0027\u0027}],\u0027test-init-grp\\"},{"line_number":163,"context_line":"            2\u0027:[{\u0027iqn\u0027:\u0027iqn.1-0.org.deb:01:d9\u0027,\u0027user\u0027:\u0027\u0027,\u0027password\u0027:\u0027\u0027}]}\""},{"line_number":164,"context_line":"        self.configuration.zfssa_target_group \u003d \u0027test-target-grp1\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_f433a860","line":161,"range":{"start_line":160,"start_character":71,"end_line":161,"end_character":13},"in_reply_to":"bfb3d3c7_e60c74a6","updated":"2019-05-29 13:48:59.000000000","message":"This whole thing is unreadable, so I\u0027m going to take the third option and just redo it with something totally different.  :)","commit_id":"799946da6512f26004d5c684cb4764cf95909034"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"251146b73c79de036d3de27df2f6daf944ee2bc2","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                                 \u0027password\u0027: \u0027\u0027}],"},{"line_number":164,"context_line":"             \u0027test-init-grp2\u0027: [{\u0027iqn\u0027: \u0027iqn.1-0.org.deb:01:d9\u0027,"},{"line_number":165,"context_line":"                                 \u0027user\u0027: \u0027\u0027,"},{"line_number":166,"context_line":"                                 \u0027password\u0027: \u0027\u0027}]})"},{"line_number":167,"context_line":"        self.configuration.zfssa_target_group \u003d \u0027test-target-grp1\u0027"},{"line_number":168,"context_line":"        self.configuration.zfssa_target_user \u003d \u0027\u0027"},{"line_number":169,"context_line":"        self.configuration.zfssa_target_password \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"bfb3d3c7_cf95b188","line":166,"updated":"2019-05-29 14:06:29.000000000","message":"I like what you did here, but it\u0027s going to generate legal JSON, whereas the original string was not.  Not sure if it matters.  (You could always add .replace(\u0027\"\u0027, \"\u0027\") on the end)","commit_id":"e1b501f27e845d170cb977833cb2efdaae66c55a"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"5b683cf74496b172bc189c49459dbdd064a6454f","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                                 \u0027password\u0027: \u0027\u0027}],"},{"line_number":164,"context_line":"             \u0027test-init-grp2\u0027: [{\u0027iqn\u0027: \u0027iqn.1-0.org.deb:01:d9\u0027,"},{"line_number":165,"context_line":"                                 \u0027user\u0027: \u0027\u0027,"},{"line_number":166,"context_line":"                                 \u0027password\u0027: \u0027\u0027}]})"},{"line_number":167,"context_line":"        self.configuration.zfssa_target_group \u003d \u0027test-target-grp1\u0027"},{"line_number":168,"context_line":"        self.configuration.zfssa_target_user \u003d \u0027\u0027"},{"line_number":169,"context_line":"        self.configuration.zfssa_target_password \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"bfb3d3c7_00407306","line":166,"in_reply_to":"bfb3d3c7_cf95b188","updated":"2019-05-29 17:49:21.000000000","message":"Eww... did not realize this was eval\u0027d python.","commit_id":"e1b501f27e845d170cb977833cb2efdaae66c55a"}],"test-requirements.txt":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2bc0846e1039d75e0550fd3d32127000e70e2dab","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Install bounded pep8/pyflakes first, then let flake8 install"},{"line_number":6,"context_line":"hacking\u003c1.2.0 # Apache-2.0"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"coverage!\u003d4.4,\u003e\u003d4.0 # Apache-2.0"},{"line_number":9,"context_line":"ddt\u003e\u003d1.2.1 # MIT"}],"source_content_type":"text/plain","patch_set":1,"id":"3fce034c_a49b2fc7","line":6,"updated":"2019-04-15 16:42:33.000000000","message":"I noticed the hacking\u003d\u003d1.1.0 in lower-constraints.txt.  I think that means you need\n\n    hacking\u003e\u003d1.1.0,\u003c1.2.0\n\nhere to actually get the enforcement you want.  (But I am not 100% sure about my police work there.)","commit_id":"1d65d6b278e4ab4cd29e692369aa6619cf24b049"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"cef45d9e3667ae19493ca2dfb8c0ae5631559917","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Install bounded pep8/pyflakes first, then let flake8 install"},{"line_number":6,"context_line":"hacking\u003c1.2.0 # Apache-2.0"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"coverage!\u003d4.4,\u003e\u003d4.0 # Apache-2.0"},{"line_number":9,"context_line":"ddt\u003e\u003d1.2.1 # MIT"}],"source_content_type":"text/plain","patch_set":1,"id":"3fce034c_67621741","line":6,"in_reply_to":"3fce034c_a49b2fc7","updated":"2019-04-16 13:45:08.000000000","message":"Sounds right to me.","commit_id":"1d65d6b278e4ab4cd29e692369aa6619cf24b049"}]}