)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c085ae29fab73a695518d162ad974f641a40812d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     yenai \u003cyenai@cmss.chinamobile.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-04-25 14:09:25 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix raise OSError when qemu-img is not installed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6af277e951dd46034033dcda6ab1d14f03638d71"},{"line_number":10,"context_line":"Closes-Bug: #1826317"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffb9cba7_b4b27493","line":7,"updated":"2019-04-25 13:48:48.000000000","message":"I don\u0027t understand the how this patch is related to this commit message.","commit_id":"11cb9da4c57e36ab7b59bec09aad53b86ba0cf52"}],"cinder/image/image_utils.py":[{"author":{"_account_id":25837,"name":"yenai","email":"yenai_yewu@cmss.chinamobile.com","username":"yenai2008"},"change_message_id":"ec5b9e8ace2a8964c83e4fcc010d18b61e6a465b","unresolved":false,"context_lines":[{"line_number":121,"context_line":"def get_qemu_img_version():"},{"line_number":122,"context_line":"    \"\"\"The qemu-img version will be cached until the process is restarted.\"\"\""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    global QEMU_IMG_VERSION"},{"line_number":125,"context_line":"    if QEMU_IMG_VERSION is not None:"},{"line_number":126,"context_line":"        return QEMU_IMG_VERSION"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_9bec462a","line":124,"range":{"start_line":124,"start_character":0,"end_line":124,"end_character":27},"updated":"2019-04-25 06:23:39.000000000","message":"@Eric Harney\nI find this global usage will cause other problems.\nDo these operations without restart cinder-volume:\n    [root@localhost ~]# rpm -qa | grep qemu-img\n    qemu-img-ev-2.12.0-18.el7_6.3.1.x86_64\n    [root@localhost ~]# rpm -e --nodeps qemu-img-ev-2.12.0-18.el7_6.3.1.x86_64\n    [root@localhost ~]# rpm -qa | grep qemu-img\n    [root@localhost ~]# qemu-img\n    -bash: qemu-img: command not found\n\nQEMU_IMG_VERSION is not None, but actually this is not right.","commit_id":"11cb9da4c57e36ab7b59bec09aad53b86ba0cf52"},{"author":{"_account_id":25837,"name":"yenai","email":"yenai_yewu@cmss.chinamobile.com","username":"yenai2008"},"change_message_id":"d800ae54b5941a388c0979a42d6ce154f597f15a","unresolved":false,"context_lines":[{"line_number":121,"context_line":"def get_qemu_img_version():"},{"line_number":122,"context_line":"    \"\"\"The qemu-img version will be cached until the process is restarted.\"\"\""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    global QEMU_IMG_VERSION"},{"line_number":125,"context_line":"    if QEMU_IMG_VERSION is not None:"},{"line_number":126,"context_line":"        return QEMU_IMG_VERSION"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_3bcc3abb","line":124,"range":{"start_line":124,"start_character":0,"end_line":124,"end_character":27},"in_reply_to":"ffb9cba7_9bec462a","updated":"2019-04-25 06:27:43.000000000","message":"@Eric Harney\nYou can see this error:\nhttps://bugs.launchpad.net/cinder/+bug/1826317 #2","commit_id":"11cb9da4c57e36ab7b59bec09aad53b86ba0cf52"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c085ae29fab73a695518d162ad974f641a40812d","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        return QEMU_IMG_VERSION"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    info \u003d utils.execute(\u0027qemu-img\u0027, \u0027--version\u0027,"},{"line_number":129,"context_line":"                         prlimit\u003dQEMU_IMG_LIMITS,"},{"line_number":130,"context_line":"                         check_exit_code\u003dFalse)[0]"},{"line_number":131,"context_line":"    pattern \u003d r\"qemu-img version ([0-9\\.]*)\""},{"line_number":132,"context_line":"    version \u003d re.match(pattern, info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_948e50ce","line":129,"range":{"start_line":129,"start_character":25,"end_line":129,"end_character":48},"updated":"2019-04-25 13:48:48.000000000","message":"There\u0027s no reason to add prlimit here, because this command doesn\u0027t actually do anything and will never hit this limit.","commit_id":"11cb9da4c57e36ab7b59bec09aad53b86ba0cf52"},{"author":{"_account_id":25837,"name":"yenai","email":"yenai_yewu@cmss.chinamobile.com","username":"yenai2008"},"change_message_id":"065135fcbc97605defbb1f33f82f2e8fb2461b41","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        return QEMU_IMG_VERSION"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    info \u003d utils.execute(\u0027qemu-img\u0027, \u0027--version\u0027,"},{"line_number":129,"context_line":"                         prlimit\u003dQEMU_IMG_LIMITS,"},{"line_number":130,"context_line":"                         check_exit_code\u003dFalse)[0]"},{"line_number":131,"context_line":"    pattern \u003d r\"qemu-img version ([0-9\\.]*)\""},{"line_number":132,"context_line":"    version \u003d re.match(pattern, info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_9a566e5c","line":129,"range":{"start_line":129,"start_character":25,"end_line":129,"end_character":48},"in_reply_to":"ffb9cba7_948e50ce","updated":"2019-04-26 02:00:01.000000000","message":"You can just test it yourself.\nrpm -e --nodeps qemu-img-ev-xxx\nI also feel confused T_T...","commit_id":"11cb9da4c57e36ab7b59bec09aad53b86ba0cf52"}]}