)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f1378ca4f81f797da65689fa54d82204d31eb03a","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The above \u0027service\u0027 is a proxy, it can be one of {\u0027swift\u0027, \u0027nfs\u0027,"},{"line_number":27,"context_line":"\u0027ceph\u0027, \u0027glusterfs\u0027, \u0027google\u0027, \u0027tsm\u0027, \u0027posix\u0027}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Closes-Bug: #1801316"},{"line_number":30,"context_line":"Change-Id: I1d7ee395c89beda0e50cbe26b4abb4fc7749e15e"},{"line_number":31,"context_line":"(cherry picked from commit b90a13d07dcf230a509cc93a4c864a20494cf5e7)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dfbec78f_fd2bd87e","line":28,"updated":"2019-05-10 09:45:41.000000000","message":"You should mention that part of this backport actually comes from Change-Id: If1e34ea112b0cff328a58ec2fc9c3f5a5005f1c6","commit_id":"e220aa06e8f6897a19f01c8aba140018421d7cd5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f1378ca4f81f797da65689fa54d82204d31eb03a","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Closes-Bug: #1801316"},{"line_number":30,"context_line":"Change-Id: I1d7ee395c89beda0e50cbe26b4abb4fc7749e15e"},{"line_number":31,"context_line":"(cherry picked from commit b90a13d07dcf230a509cc93a4c864a20494cf5e7)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dfbec78f_dd285487","line":31,"updated":"2019-05-10 09:45:41.000000000","message":"I don\u0027t think this was a clean cherry pick, most likely you got conflict in the files, please leave the conflicting files in the commit message.","commit_id":"e220aa06e8f6897a19f01c8aba140018421d7cd5"}],"cinder/backup/manager.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f1378ca4f81f797da65689fa54d82204d31eb03a","unresolved":false,"context_lines":[{"line_number":90,"context_line":"CONF.import_opt(\u0027use_multipath_for_image_xfer\u0027, \u0027cinder.volume.driver\u0027)"},{"line_number":91,"context_line":"CONF.import_opt(\u0027num_volume_device_scan_tries\u0027, \u0027cinder.volume.driver\u0027)"},{"line_number":92,"context_line":"QUOTAS \u003d quota.QUOTAS"},{"line_number":93,"context_line":"MAPPING \u003d {"},{"line_number":94,"context_line":"    # Module name \"google\" conflicts with google library namespace inside the"},{"line_number":95,"context_line":"    # driver when it imports google.auth"},{"line_number":96,"context_line":"    \u0027cinder.backup.drivers.google\u0027: \u0027cinder.backup.drivers.gcs\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_5a254ac1","line":93,"updated":"2019-05-10 09:45:41.000000000","message":"-1: The google driver didn\u0027t get renamed until the next release, here\u0027s making the mapping would actually break the Google backup driver.","commit_id":"e220aa06e8f6897a19f01c8aba140018421d7cd5"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"66b29ea2a1fa6b0059ca144f4baf42f3741cdd81","unresolved":false,"context_lines":[{"line_number":90,"context_line":"CONF.import_opt(\u0027use_multipath_for_image_xfer\u0027, \u0027cinder.volume.driver\u0027)"},{"line_number":91,"context_line":"CONF.import_opt(\u0027num_volume_device_scan_tries\u0027, \u0027cinder.volume.driver\u0027)"},{"line_number":92,"context_line":"QUOTAS \u003d quota.QUOTAS"},{"line_number":93,"context_line":"MAPPING \u003d {"},{"line_number":94,"context_line":"    # Module name \"google\" conflicts with google library namespace inside the"},{"line_number":95,"context_line":"    # driver when it imports google.auth"},{"line_number":96,"context_line":"    \u0027cinder.backup.drivers.google\u0027: \u0027cinder.backup.drivers.gcs\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_6c93815c","line":93,"in_reply_to":"dfbec78f_5a254ac1","updated":"2019-05-14 13:17:32.000000000","message":"Done","commit_id":"e220aa06e8f6897a19f01c8aba140018421d7cd5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f1378ca4f81f797da65689fa54d82204d31eb03a","unresolved":false,"context_lines":[{"line_number":522,"context_line":"                self.driver_name):"},{"line_number":523,"context_line":"            return True"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        # We support renaming of drivers, so check old names as well"},{"line_number":526,"context_line":"        for key, value in MAPPING.items():"},{"line_number":527,"context_line":"            if key.startswith(backup) and self.driver_name.startswith(value):"},{"line_number":528,"context_line":"                return True"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"        return False"},{"line_number":531,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_3a2ad68f","line":528,"range":{"start_line":525,"start_character":0,"end_line":528,"end_character":27},"updated":"2019-05-10 09:45:41.000000000","message":"-1: We don\u0027t have mappings here, we can remove this code.","commit_id":"e220aa06e8f6897a19f01c8aba140018421d7cd5"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"66b29ea2a1fa6b0059ca144f4baf42f3741cdd81","unresolved":false,"context_lines":[{"line_number":522,"context_line":"                self.driver_name):"},{"line_number":523,"context_line":"            return True"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        # We support renaming of drivers, so check old names as well"},{"line_number":526,"context_line":"        for key, value in MAPPING.items():"},{"line_number":527,"context_line":"            if key.startswith(backup) and self.driver_name.startswith(value):"},{"line_number":528,"context_line":"                return True"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"        return False"},{"line_number":531,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_0c9c4568","line":528,"range":{"start_line":525,"start_character":0,"end_line":528,"end_character":27},"in_reply_to":"dfbec78f_3a2ad68f","updated":"2019-05-14 13:17:32.000000000","message":"Done","commit_id":"e220aa06e8f6897a19f01c8aba140018421d7cd5"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"19d9eab5fc062530ee3478ab121f6322fa8f2ae2","unresolved":false,"context_lines":[{"line_number":91,"context_line":"CONF.import_opt(\u0027num_volume_device_scan_tries\u0027, \u0027cinder.volume.driver\u0027)"},{"line_number":92,"context_line":"QUOTAS \u003d quota.QUOTAS"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"# TODO(geguileo): Once Eventlet issue #432 gets fixed we can just tpool.execute"},{"line_number":96,"context_line":"# the whole call to the driver\u0027s backup and restore methods instead of proxy"},{"line_number":97,"context_line":"# wrapping the device_file and having the drivers also proxy wrap their"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfbec78f_0cfbe546","side":"PARENT","line":94,"updated":"2019-05-14 13:43:23.000000000","message":"nit: no reason to delete this line","commit_id":"b924a77bc2a3df559ff8ca88c9243f3014e95c4d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"19d9eab5fc062530ee3478ab121f6322fa8f2ae2","unresolved":false,"context_lines":[{"line_number":545,"context_line":"                      \u0027backup_id\u0027: backup[\u0027id\u0027],"},{"line_number":546,"context_line":"                      \u0027backup_size\u0027: backup[\u0027size\u0027]})"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"        backup_service \u003d self._map_service_to_driver(backup[\u0027service\u0027])"},{"line_number":549,"context_line":"        configured_service \u003d self.driver_name"},{"line_number":550,"context_line":"        # TODO(tommylikehu): We upgraded the \u0027driver_name\u0027 from module"},{"line_number":551,"context_line":"        # to class name, so we use \u0027in\u0027 here to match two namings,"},{"line_number":552,"context_line":"        # this can be replaced with equal sign during next"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfbec78f_ccf14d6d","side":"PARENT","line":549,"range":{"start_line":548,"start_character":0,"end_line":549,"end_character":45},"updated":"2019-05-14 13:43:23.000000000","message":"Should L548, 549 and 599 been left alone? I think the important change for this patch is limited to L554.","commit_id":"b924a77bc2a3df559ff8ca88c9243f3014e95c4d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"19d9eab5fc062530ee3478ab121f6322fa8f2ae2","unresolved":false,"context_lines":[{"line_number":683,"context_line":""},{"line_number":684,"context_line":"        backup_service \u003d self._map_service_to_driver(backup[\u0027service\u0027])"},{"line_number":685,"context_line":"        if backup_service is not None:"},{"line_number":686,"context_line":"            configured_service \u003d self.driver_name"},{"line_number":687,"context_line":"            # TODO(tommylikehu): We upgraded the \u0027driver_name\u0027 from module"},{"line_number":688,"context_line":"            # to class name, so we use \u0027in\u0027 here to match two namings,"},{"line_number":689,"context_line":"            # this can be replaced with equal sign during next"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfbec78f_6c8701b7","side":"PARENT","line":686,"updated":"2019-05-14 13:43:23.000000000","message":"See previous comment (not sure why L686 needs to change)","commit_id":"b924a77bc2a3df559ff8ca88c9243f3014e95c4d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"19d9eab5fc062530ee3478ab121f6322fa8f2ae2","unresolved":false,"context_lines":[{"line_number":697,"context_line":"                       \u0027backup_service\u0027: backup_service}"},{"line_number":698,"context_line":"                self._update_backup_error(backup, err)"},{"line_number":699,"context_line":"                raise exception.InvalidBackup(reason\u003derr)"},{"line_number":700,"context_line":""},{"line_number":701,"context_line":"            try:"},{"line_number":702,"context_line":"                backup_service \u003d self.get_backup_driver(context)"},{"line_number":703,"context_line":"                backup_service.delete_backup(backup)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfbec78f_acbad96a","side":"PARENT","line":700,"updated":"2019-05-14 13:43:23.000000000","message":"nit: see previous comment about unnecessary changes","commit_id":"b924a77bc2a3df559ff8ca88c9243f3014e95c4d"}]}