)]}'
{"cinder/tests/unit/test_ssh_utils.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"5311e87fe0edc696d5b97f35aa3f01c084db6401","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        with sshpool.item():"},{"line_number":376,"context_line":"            pass"},{"line_number":377,"context_line":"        self.assertEqual(4, sshpool.current_size)"},{"line_number":378,"context_line":"        fake_close.assert_called_once_with(mock.call())"},{"line_number":379,"context_line":"        fake_close.reset_mock()"},{"line_number":380,"context_line":"        sshpool.resize(3)"},{"line_number":381,"context_line":"        with sshpool.item():"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_02cf4cb0","line":378,"updated":"2019-04-29 08:57:53.000000000","message":"Nice catch :-) now we can see that the assertion is not right.\n\nIf I don\u0027t make a mistake we use mock.call() in a list with the function assert_has_called(). So we should remove it for those calls since we are not expecting args to be passed.","commit_id":"9602c8ca0ec1c3f2aee9b9bb1c9f2a12c0e5d0eb"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"f6cfeb8842eea64e367197dc0b4a35fc9b2a8a78","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        with sshpool.item():"},{"line_number":376,"context_line":"            pass"},{"line_number":377,"context_line":"        self.assertEqual(4, sshpool.current_size)"},{"line_number":378,"context_line":"        fake_close.assert_called_once_with(mock.call())"},{"line_number":379,"context_line":"        fake_close.reset_mock()"},{"line_number":380,"context_line":"        sshpool.resize(3)"},{"line_number":381,"context_line":"        with sshpool.item():"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_82725c48","line":378,"in_reply_to":"ffb9cba7_02cf4cb0","updated":"2019-04-29 09:22:40.000000000","message":"Thanks sahid, I don\u0027t know what\u0027s the purpose of this assert, so could you tell me how to modify?:)","commit_id":"9602c8ca0ec1c3f2aee9b9bb1c9f2a12c0e5d0eb"}]}
